Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Christoph Noack
Hi Josh, Regina, Astron! Josh, thanks for the patch and the screenshot - the latter makes evaluating things for less developers (tm) like myself very quick and easy. Am Donnerstag, den 11.08.2011, 12:29 +0930 schrieb Josh Heidenreich: Hi All, I have made some additional changes to the

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled... no longer! :)

2011-08-11 Thread julien2412
I noticed that cppcheck made its report on the old repositories too, is it possible to remove the cppcheck scan on these ? Julien. -- View this message in context: http://nabble.documentfoundation.org/http-libreoffice-boldandbusted-com-cppcheck-report-jobs-stalled-tp2745270p3244910.html Sent

[Libreoffice] Graphite 1.0.1

2011-08-11 Thread Martin Hosken
This is a library pull request. Please could someone upload http://sourceforge.net/projects/silgraphite/files/graphite2/graphite2-1.0.1.tgz/download to htp://download.go-oo.org/src I will then submit a patch to integrate the graphite2 release into libo (simplifying the existing patches, no

Re: [Libreoffice] [PATCH][PUSHED] Consistent paragraph border handling for HTML export

2011-08-11 Thread Cedric Bosdonnat
Hi Harri, On Wed, 2011-08-10 at 22:02 +0300, Harri Pitkänen wrote: My ultimate goal is to reach a point where we could drop all browser specific or legacy HTML formats and just have one HTML export format that works in all browsers (or at least in those that 99 % of people use). Or if it

Re: [Libreoffice] XML pretty printer (was: Where did Setup.xcu go?)

2011-08-11 Thread Miklos Vajna
On Wed, Aug 10, 2011 at 11:28:42PM +0200, Eike Rathke o...@erack.de wrote: For which I always recommend xmlpp, http://software.decisionsoft.com/tools.html Is this better in some aspect than xmllint --format, which cames with libxml and requires no manual installation? :) Thanks.

Re: [Libreoffice] Handling EasyHacks in general (was: Re: [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167)

2011-08-11 Thread Jan Holesovsky
Hi Christoph, Christoph Noack píše v Ne 07. 08. 2011 v 14:32 +0200: Very good questions ... it would be cool if some of us (QA, dev, UX) could chat about that (Hackfest in Munich, anyone?). At the end, Easy Hacks is only one way how an issue / wish is turned in something a new developer may

Re: [Libreoffice] XML pretty printer (was: Where did Setup.xcu go?)

2011-08-11 Thread Cedric Bosdonnat
On Thu, 2011-08-11 at 09:25 +0200, Miklos Vajna wrote: On Wed, Aug 10, 2011 at 11:28:42PM +0200, Eike Rathke o...@erack.de wrote: For which I always recommend xmlpp, http://software.decisionsoft.com/tools.html Many thanks Eike for that tool: I think I'll replace xmllint --format by this ;)

Re: [Libreoffice] Opengrok and onegit

2011-08-11 Thread Jan Holesovsky
Hi Jonathan, Jonathan Aquilina píše v St 10. 08. 2011 v 11:39 +0200: Kendy shouldnt opengrok still be indexing the old build system for those building 3.4.x ? [Stripped the unnecessary context that you've let in the mail...] No need to, all the 3.4 fixes have to be backports from master

Re: [Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

2011-08-11 Thread Thorsten Behrens
Lionel Elie Mamane wrote: [Postgresql connector] And the libreoffice pre-commit hooks complain about that. I was wondering if by any chance there is a general authorisation by Sun / Oracle that relicenses *all* OpenOffice-related code to LGPLv3 that would apply _also_ to this code? Hi

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled... no longer! :)

2011-08-11 Thread Thorsten Behrens
some...@boldandbusted.com wrote: I see the excellent Tinderbox work is going strong. If my report isn't really useful anymore due to work elsewhere, please let me know. Time moves on, and perhaps this kind of thing is no longer useful or wanted. Hi Jesse - nah, quite the opposite, your

Re: [Libreoffice] [PATCH] fix cosv build

2011-08-11 Thread Noel Power
On 10/08/11 17:54, Tom Tromey wrote: I tried building LibreOffice with svn trunk gcc; though in this case the bug seems to be a fairly generic include order problem. The build dies in cosv with: Compiling: cosv/source/strings/string.cxx In file included from ../../inc/cosv/string.hxx:33:0,

Re: [Libreoffice] [PUSHED] o3tl build -vs- svn gcc

2011-08-11 Thread Noel Power
On 10/08/11 18:14, Tom Tromey wrote: I tried building LibreOffice with svn trunk gcc. It dies in o3tl with: In file included from /home/tromey/Space/LibreOffice/bootstrap/o3tl/qa/test-vector_pool.cxx:8:0:

Re: [Libreoffice] Internal cairo and Postscript and PDF surface

2011-08-11 Thread Thorsten Behrens
Caolan McNamara wrote: We don't use these AFAIK. Wow, one month to get to this mail - anyway, if anyone has hints on how to keep especially the pdf backend working, that would be appreciated. Could be a nice start of adding a feature to have librsvg render natively to pdf ... Cheers, --

Re: [Libreoffice] [PUSHED] fix cosv build

2011-08-11 Thread Noel Power
On 11/08/11 09:36, Noel Power wrote: [...] pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=1a35f23a2ccb17c3e8e0cb218bb1cf886b4c7124 modified subject to PUSHED ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PUSHED] sax build -vs- svn gcc

2011-08-11 Thread Noel Power
On 10/08/11 18:49, Tom Tromey wrote: I tried building LibreOffice with svn trunk gcc. It dies in sax with: In file included from /home/tromey/Space/LibreOffice/bootstrap/sax/source/tools/fastserializer.cxx:33:0:

Re: [Libreoffice] [PUSHED] fix xml2cmp build with svn gcc

2011-08-11 Thread Noel Power
On 11/08/11 02:59, Norbert Thiebaud wrote: [...] 2/ I am not well equipped to apply in-lined patch like that (I use gmail as main mailbox for this dev-list... so it is cut-and-paste with horror stories about line wrapping and all) could you use git format-patch to generate patches and attach

Re: [Libreoffice] [PUSHED] [PATCH] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

2011-08-11 Thread Thorsten Behrens
Seeing this is pushed. Olivier Hallot wrote: License is LGPLV3 + MPL Hi Olivier, can you please confirm your patch is LGPLv3+ / MPL (to avoid any ambiguities)? Thanks, Cheers, -- Thorsten pgpvTID2joUA7.pgp Description: PGP signature ___

Re: [Libreoffice] [PATCH] Series of fixes and migration to One Git for contrib/dev-tools/ubuntu-jenkins

2011-08-11 Thread Noel Power
I guess Bjoern knows most about this, adding him to cc list, think he is on vacation now but surely will look when he gets back Noel On 10/08/11 22:56, Henrik Jensen wrote: Patches licensed under LGPLv3+/MPL 1.1 ( or what ever Bjoern Michaelsen prefers :-) ) A series of 7 suggested patches

Re: [Libreoffice] XML pretty printer (was: Where did Setup.xcu go?)

2011-08-11 Thread Stephan Bergmann
On Aug 10, 2011, at 11:28 PM, Eike Rathke wrote: On Wednesday, 2011-08-10 17:48:14 +0200, Stephan Bergmann wrote: For performance reasons, it (like all the other xcu files, too) got folded into a single large main.xcd. (Beware, very long lines. You may want to pipe it through an XML pretty

Re: [Libreoffice] odt-doc conversion (ODT support in Emacs/Orgmode)

2011-08-11 Thread Thorsten Behrens
Jambunathan K wrote: I am running in to an issue while converting from odt to Microsoft Word 97 format. The problem is that some sections of the odt file are differently formatted in word document. Please file a bug, with your sample files attached, here: http://bugs.freedesktop.org - use

Re: [Libreoffice] newbie developer - trying to learn

2011-08-11 Thread Cedric Bosdonnat
Hello Aaron Aaron Rasmussen aaron.rasmussen@... writes: When I run the program, everything builds and runs without any error messages, the LO application starts up, but no spreadsheet is ever created. I get the launch screen if I click on the LO icon in the dock. I'm wondering if there

Re: [Libreoffice] [PATCH] Bug 39168

2011-08-11 Thread Noel Power
On 10/08/11 18:44, Jenei Gábor wrote: Hello Noel, Well, I just like more if{ linefeedcodelinefeed } form even is code is just one line long, but you are right there are no rules about this, but it is the convention to at least follow the pattern already used in the source file otherwise

Re: [Libreoffice] Throwing exception in destructor

2011-08-11 Thread Stephan Bergmann
On Aug 10, 2011, at 11:22 PM, julien2412 wrote: cppcheck has detected 1 Throwing exception in destructor line 88 of core/bridges/test/java_uno/acquire/testacquire.cxx (sorry I mentionned 2 locations on IRC cause I forgot about the new git repo : it was in core and old ure repo) Could it be

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-11 Thread Lubos Lunak
On Wednesday 10 of August 2011, Stephan Bergmann wrote: On Aug 10, 2011, at 12:31 PM, Lubos Lunak wrote: On Tuesday 09 of August 2011, Stephan Bergmann wrote: Technically, lostd::list is no longer a container, as it violates the requirement that the return type of size() is size_type. (And

[Libreoffice] --enable-debug --enable-dbgutil smoketest green

2011-08-11 Thread Caolán McNamara
On Wed, 2011-08-10 at 21:30 +0200, Thomas Arnhold wrote: On 08/04/2011 01:56 PM, Caolán McNamara wrote: For this one at least, the assert itself was bogus for the empty paragraph case, fixed with

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Josh Heidenreich
Josh, thanks for the patch and the screenshot - the latter makes evaluating things for less developers (tm) like myself very quick and easy. No problem Hence, my question whether a semi-automatic extraction of short versions of the file type... I like this idea quite a bit Mmh, although it

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Regina Henschel
Hi Christoph, Christoph Noack schrieb: Hi Josh, Regina, Astron! [..] Another thing I've thought about is keep, use anyway, ... Only the visual marker on the button reveals the default choice in the dialog (grrr, different to LibreOffice ODF default - didn't notice that) - so my take is to

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Josh Heidenreich
Hi All, I think, that does not solve the keep problem. The document, the user is working on, _is_ in ODF Format. So saying Switch to ODK Format makes no sense to him. The user relates (or might relate) the button caption not to the target file format but to the source file format. So the

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled... no longer! :)

2011-08-11 Thread Christian Lohmaier
On Wed, Aug 10, 2011 at 7:38 PM, some...@boldandbusted.com wrote: After a long hiatus, this service is back on the air. I swapped out the bad RAM for some good RAM, and hooray, we've got a fresh cppcheck report at http://libreoffice.boldandbusted.com/ . gives a 403 forbidden error right

[Libreoffice] Class Time and its funny ideas about time

2011-08-11 Thread Lubos Lunak
[ Premise: If you think adding something to LO code is easy, you are still an inexperienced LO developer. ] #include tools/time.hxx ... printf( %d\n, Time( 25, 0, 0 ).GetHour()); printf( %d\n, ( Time( 1, 0, 10 ) - Time( 1, 0, 20 )).GetSec()); 25 10 As much as I don't like it, I can possibly

[Libreoffice] BANNED message from you (.exe, .exe-ms, .txt ... .exe)

2011-08-11 Thread Content-filter at mail.iqfarma.com
BANNED CONTENTS ALERT Our content checker found banned name: .exe,.exe-ms,.txt ... .exe in email presumably from you libreoffice@lists.freedesktop.org to the following recipient: - jbelt...@iqfarma.com Our internal reference code for your message is 22512-11/BHV4qPSr8+9R First upstream

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-11 Thread Nigel Hawkins
On Thu, 2011-08-11 at 14:43 +0200, Lubos Lunak wrote: Does somebody know why the Time class does either of these and how much would break if I fixed these two to be sane? I don't know, but I would guess that it is used for delta times as well as wall clock times. That would certainly explain

[Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-11 Thread Cedric Bosdonnat
Hi all, I fixed fdo#37403 a while ago, and Rainer asked if we could cherry-pick http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=21ec661d09ed9d7bbbec5e52ee2b382d8c465324 to 3.4.2. Can someone review, sign-off and cherry-pick it? Thanks, -- Cédric Bosdonnat LibreOffice hacker

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-11 Thread Caolán McNamara
On Thu, 2011-08-11 at 15:36 +0200, Cedric Bosdonnat wrote: Hi all, I fixed fdo#37403 a while ago, and Rainer asked if we could cherry-pick http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=21ec661d09ed9d7bbbec5e52ee2b382d8c465324 to 3.4.2. Forgot all about that one. Don't you

Re: [Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

2011-08-11 Thread Eike Rathke
Hi, On Thursday, 2011-08-11 10:15:02 +0200, Thorsten Behrens wrote: And the libreoffice pre-commit hooks complain about that. I was wondering if by any chance there is a general authorisation by Sun / Oracle that relicenses *all* OpenOffice-related code to LGPLv3 that would apply _also_

Re: [Libreoffice] [PUSHED] [PATCH] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

2011-08-11 Thread Olivier Hallot
Hello Thosrten I do confirm. Kind regards Olivier 2011/8/11 Thorsten Behrens t...@documentfoundation.org Seeing this is pushed. Olivier Hallot wrote: License is LGPLV3 + MPL Hi Olivier, can you please confirm your patch is LGPLv3+ / MPL (to avoid any ambiguities)? Thanks,

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

2011-08-11 Thread Olivier Hallot
Hello Kohei, Eike, Caolán Thank you guys for the coding advise and commit. I take note on the added value in optimizing code to squeeze CPU cycles. So far I was coding caring on legibility and understandability. Kind regards Olivier 2011/8/11 Kohei Yoshida kohei.yosh...@suse.com On Wed,

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-11 Thread Terrence Enger
Meta-reply: I am far from contributing a patch, so my thoughts are off-topic for this list. I am happy to take this conversation to private email or to the discussion list if that would better suit the list recipients. On Thu, 2011-08-11 at 14:43 +0200, Lubos Lunak wrote: [ Premise: If you

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-11 Thread Thorsten Behrens
Lubos Lunak wrote: As much as I don't like it, I can possibly see at least some reason for time having 25 hours, but 10 seconds without 20 seconds being 10 seconds (and there is actually explicit code to ensure that)? Does somebody know why the Time class does either of these and how

Re: [Libreoffice] [PATCH] fix xml2cmp build with svn gcc

2011-08-11 Thread Tom Tromey
Norbert == Norbert Thiebaud nthieb...@gmail.com writes: Norbert 1/ Are we sure that this behavior will be seen in a _released_ gcc ? Norbert (not a rhetorical question, I'm a bit weary of chasing gcc trunk that Norbert closely) I believe so; or at least, this is definitely a bug in LibreOffice.

Re: [Libreoffice] [PUSHED] fix xml2cmp build with svn gcc

2011-08-11 Thread Tom Tromey
Noel I rolled up this patch and the previous one here Noel http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2a634416ba8f385c25c16cc52aeae6f68cab9db I don't understand where these commits go. I re-pulled in 'ure' (actually everywhere using ./g pull) but I don't see that commit. I'm on

Re: [Libreoffice] [PUSHED] fix xml2cmp build with svn gcc

2011-08-11 Thread Miklos Vajna
On Thu, Aug 11, 2011 at 09:09:39AM -0600, Tom Tromey tro...@redhat.com wrote: Noel I rolled up this patch and the previous one here Noel http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2a634416ba8f385c25c16cc52aeae6f68cab9db I don't understand where these commits go. I re-pulled

Re: [Libreoffice] [PUSHED] fix xml2cmp build with svn gcc

2011-08-11 Thread Kohei Yoshida
Hello Tom, On Thu, 2011-08-11 at 09:09 -0600, Tom Tromey wrote: Noel I rolled up this patch and the previous one here Noel http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2a634416ba8f385c25c16cc52aeae6f68cab9db I don't understand where these commits go. I re-pulled in 'ure'

Re: [Libreoffice] [PUSHED] fix xml2cmp build with svn gcc

2011-08-11 Thread Tom Tromey
Miklos Yes, core.git. See Miklos http://wiki.documentfoundation.org/Development/Native_Build#Getting_the_sources Miklos Background: http://wiki.documentfoundation.org/Development/One_Git_Conversion Thanks. I must have read some stale document before starting; but unfortunately I don't recall

Re: [Libreoffice] [PUSHED] fix xml2cmp build with svn gcc

2011-08-11 Thread Noel Power
On 11/08/11 16:09, Tom Tromey wrote: Noel I rolled up this patch and the previous one here Noel http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2a634416ba8f385c25c16cc52aeae6f68cab9db I don't understand where these commits go. I re-pulled in 'ure' (actually everywhere using ./g

[Libreoffice] [PUSHED] patch for Confirmation of save format dialog

2011-08-11 Thread Caolán McNamara
On Thu, 2011-08-11 at 12:29 +0930, Josh Heidenreich wrote: I have attached a patch also. Looks a good start to me, overly-wide alright for some of the filter names, but when it appears it's obvious without reading war and peace which button I want, which makes it better I reckon. Pushed as a

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-11 Thread Eike Rathke
Hi Lubos, On Thursday, 2011-08-11 14:43:28 +0200, Lubos Lunak wrote: #include tools/time.hxx ... printf( %d\n, Time( 25, 0, 0 ).GetHour()); printf( %d\n, ( Time( 1, 0, 10 ) - Time( 1, 0, 20 )).GetSec()); 25 10 As much as I don't like it, I can possibly see at least some reason for

Re: [Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

2011-08-11 Thread drew
On Thu, 2011-08-11 at 10:15 +0200, Thorsten Behrens wrote: Lionel Elie Mamane wrote: [Postgresql connector] And the libreoffice pre-commit hooks complain about that. I was wondering if by any chance there is a general authorisation by Sun / Oracle that relicenses *all*

Re: [Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

2011-08-11 Thread Alexander Thurgood
Le 11/08/11 16:05, Eike Rathke a écrit : Hi Eike, The current state of affairs from what I know is that the list of files prepared contains all files of OOO340 plus all new files in all of the pending CWSs. Whether all of the files really will end up at AOOo is yet to be seen. But I'm fairly

Re: [Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use By property

2011-08-11 Thread Eike Rathke
Hi Olivier, On Thursday, 2011-08-11 11:26:28 -0300, Olivier Hallot wrote: I take note on the added value in optimizing code to squeeze CPU cycles. So far I was coding caring on legibility and understandability. Bear in mind that usually micro-optimizing code isn't worth the time as modern

Re: [Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

2011-08-11 Thread drew
On Thu, 2011-08-11 at 18:14 +0200, Alexander Thurgood wrote: Le 11/08/11 16:05, Eike Rathke a écrit : Hi Eike, The current state of affairs from what I know is that the list of files prepared contains all files of OOO340 plus all new files in all of the pending CWSs. Whether all of the

[Libreoffice] [PATCH] Make the help repo optional

2011-08-11 Thread Miklos Vajna
Hi, The attached patch allowed me to build and dev-install (wikihelp opens properly) master without cloning the help repo (saving 20MB of download of something I don't need during development in most cases). The Android/iOS part is because Tor already introduced a DESKTOP build type where

Re: [Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

2011-08-11 Thread Alexander Thurgood
Le 11/08/11 18:29, drew a écrit : Hi Drew, I'm not sure it ever was - you get the binary from the main OO.o webstie and not the extensions site (that never changed did it?) Yep, and it was only available for certain OSes (not Mac, which is my main platform). the only source I knew off was

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Astron
Hi. I have just found another (pretty big, I think) usability problem with the dialogue: it doesn't have a Cancel button that would abort the save. Pressing Esc currently selects the Save in ODF Format button. To keep the user in control (quote from Gnome HIG again) Josh, would you mind thinking

Re: [Libreoffice] Throwing exception in destructor

2011-08-11 Thread julien2412
Stephan Bergmann wrote: On Aug 10, 2011, at 11:22 PM, julien2412 wrote: ... Could it be replaced by just a log (which function should be used for this kind of case ?) or something since a throw in destructor should be avoided ? Given that assertNotNull() further down in that file uses

Re: [Libreoffice] [PATCH] Make the help repo optional

2011-08-11 Thread Miklos Vajna
On Thu, Aug 11, 2011 at 06:42:52PM +0200, Miklos Vajna vmik...@frugalware.org wrote: The attached patch allowed me to build and dev-install (wikihelp opens properly) master without cloning the help repo (saving 20MB of download of something I don't need during development in most cases).

Re: [Libreoffice] [PUSHED] [PATCH] SAL_ALLOW_LINKOO_SYMLINKS, libreoffice-3-4 sal module with dbglevel=2: init test fails

2011-08-11 Thread Lionel Elie Mamane
On Mon, Aug 08, 2011 at 01:11:43PM +0100, Caolán McNamara wrote: On Sun, 2011-08-07 at 11:32 +0200, Lionel Elie Mamane wrote: Ah, I found: solenv/bin/linkoo:export SAL_ALLOW_LINKOO_SYMLINKS=1 sc/source/ui/vba/testvba/runTests.pl: $ENV{SAL_ALLOW_LINKOO_SYMLINKS} = 1;

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Josh Heidenreich
Hi All, I have the third version of the patch. See also this screen: http://thejosh.info/libreoffice/export_format_v3.png Is it possible to get this into master? Commit message: Alien save dialog to include format name on save button Licenced under LGPLv3/MPL I'm going to do another one

Re: [Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

2011-08-11 Thread Lionel Elie Mamane
On Thu, Aug 11, 2011 at 11:55:02AM -0400, drew wrote: On Thu, 2011-08-11 at 10:15 +0200, Thorsten Behrens wrote: Lionel Elie Mamane wrote: [Postgresql connector] I was wondering if by any chance there is a general authorisation by Sun / Oracle that relicenses *all* OpenOffice-related code