Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-21 Thread G.H.M.Valkenhoef, van
Great to hear that it works & that it will make it into master :-). Any thoughts on this one:  3) When creating the CLucene FileReader (HelpIndexer.cxx), the path is converted to plain ASCII, that's probably dangerous. There is probably a way to work around this, but I haven't gotten around to

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-02-21 Thread Stephan Bergmann
On 02/20/2012 06:10 PM, Lionel Elie Mamane wrote: On Mon, Jan 23, 2012 at 03:21:30PM +0100, Stephan Bergmann wrote: changing the postgresql-sdbc functionality from a bundled extension into a proper (optional) part of LO. The attached 0001-Changed-postgresql-sdbc-from-bundled-oxt-to-proper-o.p

WaE prefix in git commit comment (was: WaE: add missing sal and cppunit dependencies causing tinderbox failure)

2012-02-21 Thread Tor Lillqvist
I thinki it was Caolán that started using the WaE: prefix in git commits, and when I asked him what it means indeed it is "Warnings are Errors". As I have understood it the intent is that commits that fix warnings (which are treated as errors if --enable-werror is used) use the WaE: prefix. --tml

Re: [Libreoffice-commits] .: "WaE: add missing sal and cppunit dependencies causing tinderbox failure"

2012-02-21 Thread Stephan Bergmann
On 02/21/2012 09:21 AM, Michael Meeks wrote: On Mon, 2012-02-20 at 21:24 +0100, Stephan Bergmann wrote: On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote: WaE: add missing sal and cppunit dependencies causing tinderbox failure ... Yes, as you say - it was for the unit te

Re: The new global -DHEADLESS should be "namespaced" surely?

2012-02-21 Thread Riccardo Magliocchetti
Hello, Il 21/02/2012 09:27, Tor Lillqvist ha scritto: Do we really want to use a generic and potentially clash-prone word like HEADLESS? Isn't the normal software engineering practise to use some package-specific prefix for global C-level identifiers like this? We already have -DLIBO_WERROR to i

The new global -DHEADLESS should be "namespaced" surely?

2012-02-21 Thread Tor Lillqvist
Do we really want to use a generic and potentially clash-prone word like HEADLESS? Isn't the normal software engineering practise to use some package-specific prefix for global C-level identifiers like this? We already have -DLIBO_WERROR to indicate when --enable-werror is in force, and -DLIBO_MERG

Re: [PUSHED] Remove unused methods from PDFI

2012-02-21 Thread Kate Goss
Hi, On 20 February 2012 11:00, Michael Meeks wrote: > > On Sat, 2012-02-18 at 21:18 +, Kate Goss wrote: > > Quick question - Can anyone point me to list of supported browsers for > > the bug submission assistant? > > I don't believe we have one :-) but I would say - whatever makes >

Re: [Libreoffice-commits] .: "WaE: add missing sal and cppunit dependencies causing tinderbox failure"

2012-02-21 Thread Michael Meeks
On Mon, 2012-02-20 at 21:24 +0100, Stephan Bergmann wrote: > > On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote: > >>> WaE: add missing sal and cppunit dependencies causing tinderbox > >>> failure > > ... > > Yes, as you say - it was for the unit test that was failing to compil

Has the time come to get rid of the "delivering" of public headers?

2012-02-21 Thread Tor Lillqvist
Has the time come to get rid of the "delivering" step for public headers? I.e. for a header , instead of having it in MODULE/inc/MODULE/BAR.hxx and then copying it to solver/INPATH/inc/MODULE/BAR.hxx as part of the "make" of MODULE, it could be directly in a new top-level "inc" directory, in inc/MO

<    1   2