[Libreoffice-commits] .: connectivity/source

2012-03-01 Thread Muthu Subramanian
connectivity/source/parse/sqliterator.cxx | 132 ++ connectivity/source/parse/sqlnode.cxx | 106 +++- 2 files changed, 117 insertions(+), 121 deletions(-) New commits: commit d1e5860bc001f092477421cb871636f3b0071e28 Author: Philipp

[Libreoffice-commits] .: 3 commits - sc/source sw/qa

2012-03-01 Thread Markus Mohrhard
sc/source/core/data/table2.cxx | 116 - sw/qa/core/filters-test.cxx| 51 -- 2 files changed, 82 insertions(+), 85 deletions(-) New commits: commit 58272b98319c5da2d433c0bc5e520a12ab73c71c Author: Markus Mohrhard

[Libreoffice-commits] .: sw/qa

2012-03-01 Thread Miklos Vajna
sw/qa/extras/rtftok/data/fdo46662.rtf | 46 ++ sw/qa/extras/rtftok/rtftok.cxx| 35 + 2 files changed, 81 insertions(+) New commits: commit 7029ccec25bc0b15f9cea463ea3713e802eafc08 Author: Miklos Vajna vmik...@suse.cz Date: Thu

[Libreoffice-commits] .: 4 commits - Makefile sal/osl sd/source sot/inc sot/source svx/inc svx/source test/inc test/source tools/inc tools/source unusedcode.easy

2012-03-01 Thread Caolán McNamara
Makefile |6 ++ sal/osl/unx/file.cxx |2 sd/source/filter/eppt/pptx-text.cxx | 12 - sd/source/filter/eppt/text.hxx |2 sot/inc/sot/stg.hxx |1 sot/source/sdstor/ucbstorage.cxx

[Libreoffice-commits] .: binfilter/bf_sc binfilter/bf_svtools binfilter/inc

2012-03-01 Thread Caolán McNamara
binfilter/bf_sc/source/core/inc/ddelink.hxx|3 - binfilter/bf_sc/source/core/tool/sc_rechead.cxx| 31 -- binfilter/bf_svtools/source/memtools/tl_unqidx.cxx | 62 - binfilter/bf_svtools/source/misc/tl_strimp.cxx | 23 ---

[Libreoffice-commits] .: writerfilter/source

2012-03-01 Thread Miklos Vajna
writerfilter/source/rtftok/rtfdocumentimpl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 456a59b24d4ba5ac341f76b4302e82b687e97f69 Author: Miklos Vajna vmik...@suse.cz Date: Thu Mar 1 11:56:08 2012 +0100 fix RTF import of drawing objects when there is no

[Libreoffice-commits] .: 2 commits - distro-configs/LibreOfficeMacOSX.conf redland/raptor

2012-03-01 Thread Petr Mladek
distro-configs/LibreOfficeMacOSX.conf |1 - redland/raptor/raptor-1.4.18.entities.patch | 13 - 2 files changed, 12 insertions(+), 2 deletions(-) New commits: commit 89f7da6d23eb348e4b16b529f95a40c635787807 Author: Petr Mladek pmla...@suse.cz Date: Thu Mar 1 11:55:50

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - distro-configs/LibreOfficeMacOSX.conf redland/raptor

2012-03-01 Thread Petr Mladek
distro-configs/LibreOfficeMacOSX.conf |1 - redland/raptor/raptor-1.4.18.entities.patch | 13 - 2 files changed, 12 insertions(+), 2 deletions(-) New commits: commit 0b252f4706a0d4e113fff9cfe0f55f64f5e74f1f Author: Petr Mladek pmla...@suse.cz Date: Thu Mar 1 11:55:50

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 3 commits - reportbuilder/util writerfilter/source

2012-03-01 Thread Michael Stahl
reportbuilder/util/makefile.mk |2 writerfilter/source/rtftok/rtfdocumentimpl.cxx | 59 + writerfilter/source/rtftok/rtfdocumentimpl.hxx | 13 + 3 files changed, 72 insertions(+), 2 deletions(-) New commits: commit

[Libreoffice-commits] .: Branch 'libreoffice-3-5-1' - 2 commits - distro-configs/LibreOfficeMacOSX.conf redland/raptor

2012-03-01 Thread Petr Mladek
distro-configs/LibreOfficeMacOSX.conf |1 - redland/raptor/raptor-1.4.18.entities.patch | 13 - 2 files changed, 12 insertions(+), 2 deletions(-) New commits: commit d3bdda0e404df6832e43d10e0aad6e276aeba3f3 Author: Petr Mladek pmla...@suse.cz Date: Thu Mar 1 11:55:50

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - 2 commits - redland/raptor

2012-03-01 Thread Petr Mladek
redland/raptor/makefile.mk |3 redland/raptor/raptor-1.4.18.entities.patch | 394 2 files changed, 396 insertions(+), 1 deletion(-) New commits: commit 514ded8d3dc5b924bc790ae19853b21e040062eb Author: Michael Stahl mst...@redhat.com Date: Thu

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - sw/source

2012-03-01 Thread Miklos Vajna
sw/source/core/inc/frame.hxx |2 ++ sw/source/core/inc/layfrm.hxx |4 +++- sw/source/core/inc/rootfrm.hxx|2 +- sw/source/core/inc/sectfrm.hxx|2 +- sw/source/core/layout/newfrm.cxx |9 - sw/source/core/layout/sectfrm.cxx | 13 +

[Libreoffice-commits] .: 2 commits - sc/source

2012-03-01 Thread Markus Mohrhard
sc/source/core/data/documen2.cxx | 81 --- 1 file changed, 1 insertion(+), 80 deletions(-) New commits: commit 1b93146d442bb8396126d6106f05a5bb0ee9fffa Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Mar 1 12:36:10 2012 +0100 don't

[Libreoffice-commits] .: sc/source

2012-03-01 Thread Markus Mohrhard
sc/source/core/data/cell.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f7fbeac4cbb764ccd153f9aea37a07e66e96b809 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Mar 1 12:59:14 2012 +0100 use the correct db range for the copy, fdo#46712

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - sw/source

2012-03-01 Thread Miklos Vajna
sw/source/core/inc/frame.hxx |2 ++ sw/source/core/inc/layfrm.hxx|4 +++- sw/source/core/inc/rootfrm.hxx |2 +- sw/source/core/layout/newfrm.cxx |9 - sw/source/core/layout/ssfrm.cxx | 21 +++-- 5 files changed, 33 insertions(+), 5 deletions(-)

[Libreoffice-commits] .: svx/source

2012-03-01 Thread Noel Power
svx/source/form/datanavi.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7b860d4970604f08ebd2e818bfd63891dd940804 Author: Noel Power noel.po...@novell.com Date: Thu Mar 1 12:10:56 2012 + fix crash using instances dialog of dataform navigator

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - svx/source

2012-03-01 Thread Michael Stahl
svx/source/form/datanavi.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 0aaa35c6d3b07a273af6a1be2d26add4a9d537cd Author: Noel Power noel.po...@novell.com Date: Thu Mar 1 12:10:56 2012 + fix crash using instances dialog of dataform navigator

[Libreoffice-commits] .: Branch 'libreoffice-3-5-1' - svx/source

2012-03-01 Thread Stephan Bergmann
svx/source/form/datanavi.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1f6625282d773ab798714c562589e380f90b6252 Author: Noel Power noel.po...@novell.com Date: Thu Mar 1 12:10:56 2012 + fix crash using instances dialog of dataform navigator

[Libreoffice-commits] .: 2 commits - svtools/source vcl/source

2012-03-01 Thread Caolán McNamara
svtools/source/dialogs/addresstemplate.cxx |4 ++-- svtools/source/dialogs/addresstemplate.hrc |2 +- svtools/source/dialogs/addresstemplate.src |2 +- vcl/source/gdi/outdev3.cxx |2 +- 4 files changed, 5 insertions(+), 5 deletions(-) New commits: commit

[Libreoffice-commits] .: sc/source svx/source sw/source

2012-03-01 Thread Tor Lillqvist
sc/source/ui/inc/tabvwsh.hxx |4 sc/source/ui/view/formatsh.cxx | 22 ++ sc/source/ui/view/tabvwsh4.cxx |1 - svx/source/tbxctrls/tbcontrl.cxx | 12 +--- svx/source/tbxctrls/tbxcolorupdate.cxx | 12 +++-

[Libreoffice-commits] .: editeng/source

2012-03-01 Thread Tor Lillqvist
editeng/source/editeng/editdoc.cxx | 26 -- editeng/source/editeng/impedit.hxx |5 ++--- editeng/source/editeng/impedit4.cxx | 24 3 files changed, 14 insertions(+), 41 deletions(-) New commits: commit

[Libreoffice-commits] .: svx/source

2012-03-01 Thread Stephan Bergmann
svx/source/tbxctrls/tbcontrl.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 5af303c0cd4d46c459c6b90712843967d716c866 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Mar 1 17:35:47 2012 +0100 -Werror=unused-variable diff --git a/svx/source/tbxctrls/tbcontrl.cxx

[Libreoffice-commits] .: oowintool

2012-03-01 Thread Caolán McNamara
oowintool |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 32781c2d268ed94eb46318a0398385baf31368c4 Author: Caolán McNamara caol...@redhat.com Date: Thu Mar 1 16:37:08 2012 + given that we can build with java7 now, allow it for windows too diff --git

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source

2012-03-01 Thread Kohei Yoshida
sc/source/core/data/documen2.cxx | 79 --- 1 file changed, 79 deletions(-) New commits: commit fcc9e377ad525a919ab13e7b0424a6c6d5673878 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Mar 1 12:36:10 2012 +0100 don't try to update the

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source

2012-03-01 Thread Kohei Yoshida
sc/source/core/data/documen2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 55b3c7430637d2b0005d7c0332e7221c69138a63 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Mar 1 11:50:13 2012 +0100 use correct source table

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source

2012-03-01 Thread Kohei Yoshida
sc/source/core/data/cell.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 94d4301ac51589f0f5ae39039c0f1f7379677b3a Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Mar 1 12:59:14 2012 +0100 use the correct db range for the copy, fdo#46712

[Libreoffice-commits] .: 2 commits - basegfx/inc basegfx/source redland/raptor sot/inc sot/source unusedcode.easy

2012-03-01 Thread Tor Lillqvist
basegfx/inc/basegfx/polygon/b2dpolygontools.hxx |6 -- basegfx/inc/basegfx/polygon/b3dpolygonclipper.hxx |7 -- basegfx/inc/basegfx/polygon/b3dpolygontools.hxx |3 - basegfx/source/polygon/b2dpolygontools.cxx| 27 -- basegfx/source/polygon/b3dpolygonclipper.cxx

[Libreoffice-commits] .: tools/inc vcl/inc vcl/source

2012-03-01 Thread Tor Lillqvist
tools/inc/tools/wintypes.hxx |1 + vcl/inc/svids.hrc|1 + vcl/inc/vcl/msgbox.hxx |4 vcl/source/src/btntext.src |5 + vcl/source/window/msgbox.cxx | 14 ++ 5 files changed, 25 insertions(+) New commits: commit

[Libreoffice-commits] .: embeddedobj/inc embeddedobj/Library_embobj.mk embeddedobj/Library_emboleobj.mk embeddedobj/Makefile embeddedobj/Module_embeddedobj.mk embeddedobj/prj embeddedobj/source embedd

2012-03-01 Thread Matus Kukan
Makefile |2 Repository.mk |2 RepositoryModule_ooo.mk|1 embeddedobj/Library_embobj.mk | 65 +++ embeddedobj/Library_emboleobj.mk | 89

[Libreoffice-commits] .: 3 commits - hwpfilter/source vcl/inc vcl/source

2012-03-01 Thread Tor Lillqvist
hwpfilter/source/hiodev.cxx |4 -- hwpfilter/source/hiodev.h |4 -- hwpfilter/source/htags.cxx|4 -- hwpfilter/source/htags.h |4 -- hwpfilter/source/lexer.cxx| 81 -- hwpfilter/source/mzstring.cxx |4 --

[Libreoffice-commits] .: src/xlsrecord.py src/xlsstream.py

2012-03-01 Thread Kohei Yoshida
src/xlsrecord.py | 35 +-- src/xlsstream.py |3 ++- 2 files changed, 35 insertions(+), 3 deletions(-) New commits: commit 980a33eb78ee294c7ec701343c7f07108ca70d9a Author: Kohei Yoshida kohei.yosh...@suse.com Date: Thu Mar 1 15:41:20 2012 -0500

[Libreoffice-commits] .: 5 commits - chart2/source svtools/inc svtools/source

2012-03-01 Thread Tor Lillqvist
chart2/source/tools/NameContainer.cxx |2 svtools/inc/svtools/addresstemplate.hxx|2 svtools/inc/svtools/brwbox.hxx |2 svtools/inc/svtools/calendar.hxx |2 svtools/inc/svtools/filechangedchecker.hxx |2 svtools/inc/svtools/filectrl.hxx

[Libreoffice-commits] .: Branch 'libreoffice-3-5-1' - sc/source

2012-03-01 Thread Michael Meeks
sc/source/core/data/cell.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 17322a611dd5add334f15539193dd0090e99ef01 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Mar 1 12:59:14 2012 +0100 use the correct db range for the copy, fdo#46712

[Libreoffice-commits] .: desktop/source

2012-03-01 Thread Stephan Bergmann
desktop/source/app/app.cxx |3 --- desktop/source/app/userinstall.cxx |5 - desktop/source/migration/migration.cxx | 17 - 3 files changed, 12 insertions(+), 13 deletions(-) New commits: commit 76e0d695a41326a5583dbc9702e0ce3b8219b514 Author: Stephan

[Libreoffice-commits] .: Branch 'libreoffice-3-5-1' - sc/source

2012-03-01 Thread Michael Meeks
sc/source/core/data/documen2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d69bb1d4535871b981df27f11bd4918ad3a41fe4 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Mar 1 11:50:13 2012 +0100 use correct source table

[Libreoffice-commits] .: editeng/inc formula/inc svtools/inc

2012-03-01 Thread Stephan Bergmann
editeng/inc/editeng/outliner.hxx|2 +- formula/inc/formula/formula.hxx |2 +- formula/inc/formula/funcutl.hxx |2 +- svtools/inc/svtools/QueryFolderName.hxx |4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) New commits: commit

[Libreoffice-commits] .: 2 commits - sc/inc sc/source

2012-03-01 Thread Markus Mohrhard
sc/inc/column.hxx |2 +- sc/inc/postit.hxx |4 ++-- sc/source/core/data/column.cxx |5 ++--- sc/source/core/data/postit.cxx | 11 +++ sc/source/core/data/table2.cxx |6 +++--- 5 files changed, 15 insertions(+), 13 deletions(-) New commits:

[Libreoffice-commits] .: 2 commits - sc/inc sc/source

2012-03-01 Thread Markus Mohrhard
sc/inc/document.hxx| 14 --- sc/source/core/data/column.cxx |4 +- sc/source/core/data/documen5.cxx |1 sc/source/core/data/table2.cxx |1 sc/source/filter/excel/excdoc.cxx |1 sc/source/ui/docshell/dbdocimp.cxx |1

[Libreoffice-commits] .: sc/source

2012-03-01 Thread Markus Mohrhard
sc/source/core/data/table3.cxx | 65 +++-- 1 file changed, 57 insertions(+), 8 deletions(-) New commits: commit d7db93f5f4972a94ab3157578e9c8795dc089caa Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Mar 2 04:49:27 2012 +0100

[Libreoffice-commits] .: Module_tail_build.mk postprocess/prj

2012-03-01 Thread David Tardon
Module_tail_build.mk |1 + postprocess/prj/build.lst |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 75a6e52bc8d3062859f626f7466f5af55841a7b7 Author: David Tardon dtar...@redhat.com Date: Fri Mar 2 08:15:50 2012 +0100 move embeddedobj to tail_build

[Libreoffice-commits] .: cui/source dbaccess/source

2012-03-01 Thread Stephan Bergmann
cui/source/options/optgdlg.hxx |2 +- dbaccess/source/ui/dlg/dsselect.hxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 906ca2e0e58556353a40670828e111986285315a Author: Stephan Bergmann sberg...@redhat.com Date: Fri Mar 2 08:55:49 2012 +0100

[PATCH] convert tools/table.hxx to std::vector in editeng module

2012-03-01 Thread Noel Grandin
Hi Convert tools/table.hxx usage in editeng/source/editdoc.cxx to std::vector Contributed under LGPLv3+ / MPL 1.1 or later. (And my license statement is on file in the wiki) Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html

Re: [REVIEW][3-5-1][3-4] nsplugin broken due to typo

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 06:21 AM, Michael Meeks wrote: Even better would be for a nice, checked, C++, in-line ( with direct shortcuts to the C++ factory method if it is in-process ;-) that could be compiled from the component files in a similar fashion to the configmgr changes - although, that'd

Re: [Pushed] [PATCH] Translate German comments

2012-03-01 Thread Muthu Subramanian K
Pushed. Looked ok to me - I don't know much of the german language, though. Thank you! On 03/01/2012 10:38 AM, Philipp Weissenbacher wrote: Hi all, I'd like to have a second set of eye-ball on these translations. Thanks, Philipp ___

Re: [REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-03-01 Thread Noel Power
On 01/03/12 05:09, Michael Meeks wrote: Looks a bit scary for 3.5.1 after RC1 surely ? or has this been well-tested elsewhere ? I guess if so a further +1 from me, coincidently I made the same change locally today whilst investigating a large import doc, definitely improved the import time

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||46687 --- Comment #210

Relicensing

2012-03-01 Thread David Fraser
Hi All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code Regards David -- David Fraser St James Software ___ LibreOffice mailing list

Re: [REVIEW -3-5] RTF import of drwaing objects regressions

2012-03-01 Thread Miklos Vajna
On Wed, Feb 29, 2012 at 05:05:01PM +0100, Miklos Vajna vmik...@suse.cz wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbef8b4 and As Michael Stahl pointed out on IRC, a null pointer check was missing in popState(), fixed with 456a59b in master, I'm attaching an amended patch,

A Desugn Suggestion

2012-03-01 Thread Arnold Bailson
I realize that this may not be the right place for this suggestion. If that is so, my apologies: please pass it on to the correct place. I now have macular degeneration in my second eye. I find it convenient when reading to use a hand-held lighted magnifier and this has brought very clearly

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Stephan Bergmann
On 02/29/2012 06:41 PM, Lionel Elie Mamane wrote: On Wed, Feb 29, 2012 at 02:57:09PM +0100, Stephan Bergmann wrote: Note that the stable sal interface historically stays clear of boost, because of differences in the various boost versions available in the various environments. OK, two prongs:

[REVIEW] fix crash in importSheets

2012-03-01 Thread Markus Mohrhard
Hey, could you please cherry-pick the attached patch to 3-5 and if still possible 3-5-1. Regards, Markus From 70dd1729ed0693ee670af0c27a304b4dbe01c5fe Mon Sep 17 00:00:00 2001 From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu, 1 Mar 2012 11:50:13 +0100 Subject: [PATCH] use correct

Re: [REVIEW-3-5][REVIEW-3-5-1] libxml2 on MacOSX

2012-03-01 Thread Stephan Bergmann
On 02/23/2012 09:48 PM, Stephan Bergmann wrote: shows that only a handful of executables and dynamic libraries use system libxml (/usr/lib/libxml2.2.dylib or /usr/local/lib/libxml2.2.dylib)---all of which are apparently only used during the build (if at all) and not included in the installation

Re: A Desugn Suggestion

2012-03-01 Thread Khaled Hosny
On Thu, Mar 01, 2012 at 11:06:41AM +, Arnold Bailson wrote: I realize that this may not be the right place for this suggestion. If that is so, my apologies: please pass it on to the correct place. I now have macular degeneration in my second eye. I find it convenient when reading to use

Re: Small note on static analyzer, includes and build times...

2012-03-01 Thread Albert Thuswaldner
Hi Stephan and Michael, On Tue, Feb 28, 2012 at 09:03, Stephan Bergmann sberg...@redhat.com wrote: Nice approach. :) One remark re Looking for .cxx files whose first include is not the header file...: I did not look into the articles you cite to see whether or why they advocate to include

[PUSHED] Re: [REVIEW -3-5] RTF import of drwaing objects regressions

2012-03-01 Thread Michael Stahl
On 01/03/12 12:06, Miklos Vajna wrote: On Wed, Feb 29, 2012 at 05:05:01PM +0100, Miklos Vajna vmik...@suse.cz wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbef8b4 and As Michael Stahl pointed out on IRC, a null pointer check was missing in popState(), fixed with 456a59b

SVG export

2012-03-01 Thread Chr. Rossmanith
Hi, I've observed the following strange behaviour when exporting a drawing to SVG. 1. select text tool and insert a letter 2. export drawing to SVG Expected: a text block in the exported svg file Observed: no text block and no font block If you export the drawing a second time the text and

License statement

2012-03-01 Thread Chr. Rossmanith
Hi, I declare that all my past and future contributions to LibreOffice are licensed under under MPL/LGPLv3+ . Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] Reduced duplicate code (simian) / vcl/generic/print/glyphset.cxx

2012-03-01 Thread Chr. Rossmanith
Hi, On Tue, 2012-02-28 at 11:07 +0100, Chr. Rossmanith wrote: here is the patch to reduce code which seems to be copypasted (cf. Duplicate code: GlyphSet::DrawGlyphs() and GlyphSet::ImplDrawText() / 27.2.2012) Thanks for that - a beautiful clean, pushed :-) [ how do you find

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Michael Stahl
On 01/03/12 12:14, Stephan Bergmann wrote: On 02/29/2012 06:41 PM, Lionel Elie Mamane wrote: On Wed, Feb 29, 2012 at 02:57:09PM +0100, Stephan Bergmann wrote: Note that the stable sal interface historically stays clear of boost, because of differences in the various boost versions available

[REVIEW] don't try to update range names twice in ScDocument::TransferTab

2012-03-01 Thread Markus Mohrhard
Hey, the attached patch prevents double updating of the index for copied range names. The new code updating range names is in cell.cxx adjustRangeName which does the job directly in the formula tokens. The removed code did something similar for global range names but was incomplete and contained

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-01 Thread Tor Lillqvist
I thought the problem would be related to the timestamps of the .o and .d files for the source file in question in some way that shows up when using clang. (With gcc I don't see this problem.) Although I don't understand how. Even if I add a ls -lT to show the full timestamp of the .o and .d

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Tor Lillqvist
If 4.4/4.5 are OK, but only 4.6.0-4.6.9 are to be blacklisted, I'd argue it is not a significant problem. What about the 4.0.1 used for Mac OS X builds? I *also* assume that Boost avoids breaking with MSVC :) Any assumptions about MSVC sound quite risky. --tml

[REVIEW] fix crash when deleting db range in formula

2012-03-01 Thread Markus Mohrhard
Hey, [1] fixes a crash if you try to delete a database range in a formula. IMHO this patch is extremely safe and it would be great if we could push it to 3-5 and maybe 3-5-1. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=f7fbeac4cbb764ccd153f9aea37a07e66e96b809

Re: [PUSHED][3-5][3-4] more problems in SwRootFrm dtor

2012-03-01 Thread Miklos Vajna
On Wed, Feb 29, 2012 at 11:00:09PM +0100, Michael Stahl mst...@redhat.com wrote: so refactor this a little to execute the base class dtors before SwRootFrm dtor returns: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ebb74441790a9852b1a1532d6e025c324666f6fc Pushed to -3-5 and -3-4,

[REVIEW 3-5][REVIEW 3-5-1 ?] fix crash using edit instance from xforms Data navigator dialog

2012-03-01 Thread Noel Power
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804 should fix the problem, it seems that commit f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a 'delete(pPage);' ( it seems from the comment to silence some cppcheck error ) but that delete

[PATCH]fdo45671 calc cell background color simplified code for split button action

2012-03-01 Thread Winfried Donkers
Hello all, Attached patch introduces simpler code to make the 'apply last used color'-part of the split button. This patch is for calc cell background color, the other split buttons are to follow. Becasue of that, some ifs have already been converted to switches. Winfried

Re: [REVIEW 3-5][REVIEW 3-5-1 ?] fix crash using edit instance from xforms Data navigator dialog

2012-03-01 Thread Michael Stahl
On 01/03/12 13:20, Noel Power wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804 should fix the problem, it seems that commit f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a 'delete(pPage);' ( it seems from the comment to silence

Re: [PUSHED:3-4,3-5][REVIEW:3-5-1] fix crash using edit instance from xforms Data navigator dialog

2012-03-01 Thread Petr Mladek
Michael Stahl píše v Čt 01. 03. 2012 v 13:52 +0100: On 01/03/12 13:20, Noel Power wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b860d4970604f08ebd2e818bfd63891dd940804 should fix the problem, it seems that commit f7f47366ea78a71853fcaca2fa402bef667d9cce introduced a

Re: SVG export

2012-03-01 Thread Thorsten Behrens
Chr. Rossmanith wrote: I've observed the following strange behaviour when exporting a drawing to SVG. Hi Christina, weird, don't see that here (for a -3-5 branch) - the only reason I could think of is that Draw somehow stays in text edit mode. Could you try to narrow down what contributes to

Re: [REVIEW] don't try to update range names twice in ScDocument::TransferTab

2012-03-01 Thread Markus Mohrhard
Missed the attachment, You can find the commit at http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b93146d442bb8396126d6106f05a5bb0ee9fffa 2012/3/1 Markus Mohrhard markus.mohrh...@googlemail.com: Hey, the attached patch prevents double updating of the index for copied range names.

Re: Small note on static analyzer, includes and build times...

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 12:28 PM, Albert Thuswaldner wrote: On Tue, Feb 28, 2012 at 09:03, Stephan Bergmannsberg...@redhat.com wrote: Nice approach. :) One remark re Looking for .cxx files whose first include is not the header file...: I did not look into the articles you cite to see whether or why

Re: [PUSHED:3-4,3-5][PUSHED:3-5-1] fix crash using edit instance from xforms Data navigator dialog

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 02:31 PM, Petr Mladek wrote: Looks fine to me. One more review needed for -3-5-1. pushed Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

how to change the default settings, like page setting to B5

2012-03-01 Thread huqitu du
Hi, I want to change the default settings like page from A4 to B5 or page layout from left right to top bottom, and I don't know where it is saving the default settings or which model handle it! thank you! best regard. huqitu, inner mongolia

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-03-01 Thread Alexander Thurgood
Le 29/02/12 20:13, Alex Thurgood a écrit : Sorry, by default setup, I meant the OSX server, not my LO build, I should've been more precise. I'm not in front of the box at the mo, but basically am building with virtually all of the extensions, the binfilters, mysql connector enabled, and

Re: libreoffice + clang == success

2012-03-01 Thread Tor Lillqvist
FYI, I also decided to start doing the iOS builds using clang. Whoa, compiling with Clang really reveals some interesting thinko-style bugs in the code. Bugs so old that it is hard to say whether it is riskier to fix them and better to let the code be as is (and work as it has worked all the

Re: how to change the default settings, like page setting to B5

2012-03-01 Thread Michael Meeks
Hi there, On Thu, 2012-03-01 at 22:12 +0800, huqitu du wrote: I want to change the default settings like page from A4 to B5 or page layout from left right to top bottom, and I don't know where it is saving the default settings or which model handle it! This really looks like a

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-03-01 Thread Lubos Lunak
On Wednesday 29 of February 2012, Caolán McNamara wrote: On Wed, 2012-02-29 at 17:11 +0100, Lubos Lunak wrote: Do we actually have code that tries to gracefully handle running out of memory? Because if not, and I doubt we realistically do[*] Its not O[U]String related, but FWIW

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 03:22 PM, Alexander Thurgood wrote: Just to add to my previous mail, the config switches I'm using : ./configure CC=ccache gcc-4.0 CXX=ccache g++-4.0 --with-max-jobs=4 --with-num-cpus=2 --with-vendor=The Document Foundation --enable-epm --enable-binfilter --without-system-libxml

Re: [PATCH][PUSHED] fdo45671 calc cell background color simplified code for split button action

2012-03-01 Thread Tor Lillqvist
Attached patch introduces simpler code to make the 'apply last used color'-part of the split button. Thanks! Pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PATCH] [PUSHED] convert tools/table.hxx to std::vector in editeng module

2012-03-01 Thread Tor Lillqvist
Convert tools/table.hxx usage in  editeng/source/editdoc.cxx to std::vector Thanks! Pushed to maser. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

MPL/LGPL blanket license

2012-03-01 Thread Sebastian Spaeth
Just in case some code actually ends up in LibO: All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Sebastian Spaeth ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Has the time come to get rid of the delivering of public headers?

2012-03-01 Thread Bjoern Michaelsen
On Thu, Feb 23, 2012 at 11:41:20AM +, Michael Meeks wrote: :-) Any chance of some more advanced 'easy hacks' on this ? and/or a Google Summer of Code idea: https://wiki.documentfoundation.org/Development/Gsoc/Ideas Done. Best, Bjoern

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Lionel Elie Mamane
On Thu, Mar 01, 2012 at 01:56:08PM +0200, Tor Lillqvist wrote: If 4.4/4.5 are OK, but only 4.6.0-4.6.9 are to be blacklisted, I'd argue it is not a significant problem. What about the 4.0.1 used for Mac OS X builds? What was being discussed above was a bug present in GCC 4.6.9, but not in

Re: [PATCH]fdo45671 calc cell background color simplified code for split button action

2012-03-01 Thread Tommy
On Thu, 01 Mar 2012 13:49:30 +0100, Winfried Donkers w.donk...@dci-electronics.nl wrote: Hello all, Attached patch introduces simpler code to make the 'apply last used color'-part of the split button. This patch is for calc cell background color, the other split buttons are to follow.

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Lionel Elie Mamane
On Thu, Mar 01, 2012 at 12:14:28PM +0100, Stephan Bergmann wrote: On 02/29/2012 06:41 PM, Lionel Elie Mamane wrote: On Wed, Feb 29, 2012 at 02:57:09PM +0100, Stephan Bergmann wrote: Note that the stable sal interface historically stays clear of boost, because of differences in the various

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-03-01 Thread Alexander Thurgood
Le 01/03/12 15:52, Stephan Bergmann a écrit : Hi Stephan, No idea why it uses -I/Developer/SDKs/MacOSX10.4u.sdk/usr/include/libxml2 while building libxslt for you, then. Anyway, just don't use --without-system-libxml. No idea either, but there must have been some more recent changes to

Re: Using a real parser generator to parse numbers (and dates)

2012-03-01 Thread Tor Lillqvist
According to Wikipedia, MSVC 7.1 is MSVC 2003. We use MSVC2005 or 2008 I believe? So it should be OK. Are you volunteering to do the necessary work then to make a newer boost then work for us with MSVC2008? --tml ___ LibreOffice mailing list

Re: Writer Unit tests

2012-03-01 Thread Vit
Hi, Michael! Do you have a build already ? if not, I'd recommend using a recent Linux distribution (I love openSUSE 12.1) and getting that going, it's really a pre-requisite. I'm using Arch linux at home but never build or installed daily builds of LO for now. But, I think, this can be

Re: [REVIEWED][3-5] don't try to update range names twice in ScDocument::TransferTab

2012-03-01 Thread Kohei Yoshida
On Thu, 2012-03-01 at 14:40 +0100, Markus Mohrhard wrote: Missed the attachment, You can find the commit at http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b93146d442bb8396126d6106f05a5bb0ee9fffa Pushed to the 3-5 branch with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker,

[PATCH] Remove unused code (21)

2012-03-01 Thread Elton Chung
Hi, This patch removes 5 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com

minutes of ESC call ...

2012-03-01 Thread Michael Meeks
* Present: + Norbert, Eike, Stephan, David, Bjoern, Caolan, Rainer Andras, Markus, Fridrich, Michael, Thorsten, Cedric, Petr, Michael S, Kohei * Completed Action Items + dig out more Windows 3.5.0 installation bugs (Rainer) + interacting /

Re: [REVIEW] [REVIEWED 3-5] fix crash in importSheets

2012-03-01 Thread Kohei Yoshida
On Thu, 2012-03-01 at 12:15 +0100, Markus Mohrhard wrote: Hey, could you please cherry-pick the attached patch to 3-5 and if still possible 3-5-1. Pushed to the 3-5 branch with my sign-off. I too recommend we push this to the 3-5-1 branch since it's just a simple silly mistake the fix is

Re: [REVIEW] [REVIEWED 3-5] fix crash when deleting db range in formula

2012-03-01 Thread Kohei Yoshida
On Thu, 2012-03-01 at 13:07 +0100, Markus Mohrhard wrote: Hey, [1] fixes a crash if you try to delete a database range in a formula. IMHO this patch is extremely safe and it would be great if we could push it to 3-5 and maybe 3-5-1. Regards, Markus [1]

Re: [PATCH] [PUSHED] Remove unused code (21)

2012-03-01 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#46193: Let the user copy error message from error dialog

2012-03-01 Thread Dézsi Szabolcs
Hi! I already made a patch for this bug, but this is a better solution ( at least i think :) ) I added a 'Copy to Clipboard' button to MessBox, so error messages are now copyable. Here's the bug (there's a screenshot of the patch as well): https://bugs.freedesktop.org/show_bug.cgi?id=46193

Re: [REVIEW] [REVIEWED 3-5] fix crash in importSheets

2012-03-01 Thread Michael Stahl
On 01/03/12 19:10, Kohei Yoshida wrote: On Thu, 2012-03-01 at 12:15 +0100, Markus Mohrhard wrote: Hey, could you please cherry-pick the attached patch to 3-5 and if still possible 3-5-1. Pushed to the 3-5 branch with my sign-off. I too recommend we push this to the 3-5-1 branch since

Re: [REVIEW] [REVIEWED 3-5] fix crash when deleting db range in formula

2012-03-01 Thread Michael Stahl
On 01/03/12 19:12, Kohei Yoshida wrote: On Thu, 2012-03-01 at 13:07 +0100, Markus Mohrhard wrote: Hey, [1] fixes a crash if you try to delete a database range in a formula. IMHO this patch is extremely safe and it would be great if we could push it to 3-5 and maybe 3-5-1. Regards, Markus

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

2012-03-01 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: minutes of ESC call ...

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 07:00 PM, Michael Meeks wrote: * un-realistic attitude wrt. exceptions and bloat ... (Sberg) I do not appreciate that tone. And I never brought this up for discussion in the ESC. Stephan ___ LibreOffice mailing list

Re: minutes of ESC call ...

2012-03-01 Thread Stephan Bergmann
On 03/01/2012 07:00 PM, Michael Meeks wrote: * GSOC update (Cedric) + drastic action / brainstorming on ideas required Add these tasks to the wiki AA: + l/strace-alike for UNO (Stephan) On a more constructive note ;) the above already exists, in the form of

  1   2   3   4   >