Please don't confuse dead code and commented-out code

2012-06-12 Thread Tor Lillqvist
Just a small thing, but still: Several cleanups recently have removed commented-out code. That is good. But the commit comments say that dead code was removed. That is misleading. Dead code is (according to Wikipedia) code in the source code of a program which is executed but whose result is

[Libreoffice-commits] .: sc/inc sc/source

2012-06-12 Thread Markus Mohrhard
sc/inc/colorscale.hxx |2 + sc/source/core/data/colorscale.cxx|9 + sc/source/ui/condformat/colorformat.cxx | 54 +++--- sc/source/ui/condformat/condformatdlg.cxx | 36 sc/source/ui/inc/colorformat.hrc

[Libreoffice-commits] .: sc/inc

2012-06-12 Thread Stephan Bergmann
sc/inc/conditio.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a61b43cbf9c798f553e5d81c60f59a29e47d240f Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jun 12 08:36:34 2012 +0200 -Werror,-Wmismatched-tags Change-Id:

libreoffice-3.5 release build on Mac failed

2012-06-12 Thread Norbert Thiebaud
Petr, the test build for 3.5.5 pn MacOSX failed see log below. the culprit seems to be http://cgit.freedesktop.org/libreoffice/core/commit/?id=89f45b9fef98650cc3166d9337c96e58f0c57c4f Norbert -=-=- [ build CXX ] sfx2/source/dialog/filedlghelper

Re: libreoffice-3.5 release build on Mac failed

2012-06-12 Thread Norbert Thiebaud
On Tue, Jun 12, 2012 at 1:50 AM, Norbert Thiebaud nthieb...@gmail.com wrote: Petr, the test build for 3.5.5 pn MacOSX failed see log below. the culprit seems to be http://cgit.freedesktop.org/libreoffice/core/commit/?id=89f45b9fef98650cc3166d9337c96e58f0c57c4f ahh, apparently that was

pyuno is broken on mingw on current master

2012-06-12 Thread David Ostrovsky
Hi, during my work on gbuild'ification of pyuno module i've seen mingw branches in some dmake makefiles. That why I have compiled mingw32 on OpenSUSE 12.1 with option --enable-python=internal and installed it on real Windows 7 machine and tested pyuno intergration without my gbuild'ification

Re: pyuno is broken on mingw on current master

2012-06-12 Thread Stephan Bergmann
On 06/12/2012 09:17 AM, David Ostrovsky wrote: What do you mean here? Personally, for an experimental platform like mingw, and as you have demonstrated that it does not work right now, I would not bother to make it work prior to gbuild'ification. Has pyuno on mingw ever been known to work?

Re: [ANN] LibreOffice 3.6.0 Beta1 available

2012-06-12 Thread Bjoern Michaelsen
On Tue, Jun 12, 2012 at 03:59:54AM +0200, Thorsten Behrens wrote: Dear Community, The Document Foundation is happy to announce the first beta release of LibreOffice 3.6.0. The upcoming 3.6.0 will be our fourth major release in two years, and comes with a nice set of new features. Please be

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - drawinglayer/source

2012-06-12 Thread Miklos Vajna
drawinglayer/source/primitive2d/borderlineprimitive2d.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 9ee04b49642b90d36aa51d5611d0def8f7c0516e Author: Michael Stahl mst...@redhat.com Date: Mon Jun 11 20:19:32 2012 +0200 fdo#38116, fdo#49438: fix

Re: [PUSHED][3-5] fdo#38116, fdo#49438 fix double hairline border drawing some more

2012-06-12 Thread Miklos Vajna
Hi Michael, On Mon, Jun 11, 2012 at 08:47:25PM +0200, Michael Stahl mst...@redhat.com wrote: so it turns out that the fixes for fdo#48647 and fdo#49438 interact in a bad way, and hence the border in the bugdoc on fdo#38116 is not displayed; this is a regression in libreoffice-3-5. let me

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - shell/source

2012-06-12 Thread Stephan Bergmann
shell/source/backends/wininetbe/wininetbackend.cxx | 66 ++--- 1 file changed, 44 insertions(+), 22 deletions(-) New commits: commit 4c07fd7f899b75edd61aa0d16c0f3dff0ebb94ad Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jun 8 16:54:18 2012 +0200 fdo#47044: Adapt

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Winfried Donkers o...@dci-electronics.nl changed: What|Removed |Added Depends on||50911 --

[Libreoffice-commits] .: sw/CppunitTest_sw_subsequent_ww8tok.mk

2012-06-12 Thread Stephan Bergmann
sw/CppunitTest_sw_subsequent_ww8tok.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 770e990dabcd4f0415da65ef3ace4fc5a3784278 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jun 12 10:31:35 2012 +0200 Missing dependency Change-Id:

finding unused translations / strings ...

2012-06-12 Thread Michael Meeks
On Mon, 2012-06-11 at 23:10 +0100, Caolán McNamara wrote: - STR_DOC_LOADING and STR_CHAIN_OK were unused. They are represented in many po files. Is there an easier way to remove them or only per regex/sed? Stuff in .po files I think basically take care of themselves, but maybe Andras can

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - shell/source

2012-06-12 Thread Michael Meeks
shell/source/backends/wininetbe/wininetbackend.cxx | 66 ++--- 1 file changed, 44 insertions(+), 22 deletions(-) New commits: commit a1555ee046fcf1fe9e49e8b6820316a66046698a Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jun 8 16:54:18 2012 +0200 fdo#47044: Adapt

[PUSHED-3-5] fdo#47044 LibreOffice crashed when accessing Options / Internet / Proxy or Browser Plug-in settings

2012-06-12 Thread Michael Meeks
On Tue, 2012-06-12 at 09:57 +0200, Stephan Bergmann wrote: I already cherry-picked it to libreoffice-3-6, and it would be great if somebody reviewed it for cherry-picking into libreoffice-3-5. (I have no Windows builds for 3-5 or 3-6 at hand right now where I could quickly verify the

Re: Please don't confuse dead code and commented-out code

2012-06-12 Thread Takeshi Abe
Hi Tor, On Tue, 12 Jun 2012 09:33:23 +0300, Tor Lillqvist t...@iki.fi wrote: Just a small thing, but still: Several cleanups recently have removed commented-out code. That is good. But the commit comments say that dead code was removed. That is misleading. Thank you for pointing it out.

Re: finding unused translations / strings ...

2012-06-12 Thread Thomas Arnhold
Hi Michael, Hi Caolán, yes, I will do this :) Starting next week. Thomas On 06/12/2012 10:56 AM, Michael Meeks wrote: On Mon, 2012-06-11 at 23:10 +0100, Caolán McNamara wrote: - STR_DOC_LOADING and STR_CHAIN_OK were unused. They are represented in many po files. Is there an easier way to

Re: [PUSHED][3-5] fdo#46112 Calc ODF import double border regression

2012-06-12 Thread Miklos Vajna
On Tue, Jun 05, 2012 at 02:46:42PM +0200, Michael Stahl mst...@redhat.com wrote: the Calc ODF import mangles double borders written by older versions and OOo, they have their width tripled and are beaten into a symmetric shape; the following patches fix that and should go into libreoffice-3-5:

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - editeng/source

2012-06-12 Thread Miklos Vajna
editeng/source/items/frmitems.cxx | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) New commits: commit c203a292ff523ae4e4d4d9ac70166f281a141fcc Author: Michael Stahl mst...@redhat.com Date: Mon Jun 4 18:54:34 2012 +0200 fdo#46112: tweak condition to prevent guessing

Re: [PUSHED:3-5] Fix for crash in fdo#50868

2012-06-12 Thread Petr Mladek
On Mon, 2012-06-11 at 10:28 +0100, Michael Meeks wrote: On Mon, 2012-06-11 at 11:14 +0200, Fridrich Strba wrote: Sorry, this one was held in the moderation queue for the whole weekend. Both the patches and upgrade look reasonable to me; it'd be great if you do the work merging them to

Re: Copyright

2012-06-12 Thread Matteo Casalin
On 06/08/2012 05:42 PM, Caolán McNamara wrote: On Fri, 2012-06-08 at 15:59 +0200, Matteo Casalin wrote: Hi all, a possibly silly question, but I'm wondering why new code files (e.g. sfx2/inc/sfx2/zoomitem.hxx) say: cause I just moved it from svx, its not a new file, just a moved old

Re: [Libreoffice-qa] New Bugzilla Version Picker items – 2

2012-06-12 Thread Petr Mladek
On Fri, 2012-06-08 at 17:13 +0200, Thomas Klausner wrote: On Fri, Jun 08, 2012 at 03:45:11PM +0200, Petr Mladek wrote: 4. Ubuntu/Debian: - + 3.X.Y~alphaZ - for alpha releases + 3.X.Y~betaZ- for beta releases + 3.X.Y.Z- for release candidates

Re: [Libreoffice-qa] New Bugzilla Version Picker items – 2

2012-06-12 Thread Petr Mladek
On Tue, 2012-06-12 at 09:53 +0200, Petr Mladek wrote: On Fri, 2012-06-08 at 17:13 +0200, Thomas Klausner wrote: On Fri, Jun 08, 2012 at 03:45:11PM +0200, Petr Mladek wrote: 4. Ubuntu/Debian: - + 3.X.Y~alphaZ - for alpha releases + 3.X.Y~betaZ- for beta

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 3 commits - oox/inc sc/source

2012-06-12 Thread Noel Power
oox/inc/oox/core/fragmenthandler2.hxx |3 +-- sc/source/filter/oox/worksheetfragment.cxx | 24 +++- sc/source/filter/oox/worksheethelper.cxx | 14 +++--- 3 files changed, 23 insertions(+), 18 deletions(-) New commits: commit

Re: extraordinary stoc/ thrash ...

2012-06-12 Thread Stephan Bergmann
On 04/05/2012 02:23 PM, Stephan Bergmann wrote: On 04/03/2012 02:27 PM, Stephan Bergmann wrote: I have a vague idea of placing yet another cppuhelper bootstrap mechanism next to the existing ones, which will internally use completely different (read: cheap) mechanisms to set up a component

[Libreoffice-commits] .: sal/inc

2012-06-12 Thread Jesús Corrius
sal/inc/systools/win32/qswin32.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 3a793f9558c61000dc00534df0820e06135c8c24 Author: Jesús Corrius je...@softcatala.org Date: Tue Jun 12 12:39:58 2012 +0200 rename Class Name, Window Name and Message of the

Re: [PATCH] fix proposed for fdo#49178

2012-06-12 Thread Miklos Vajna
Hi Julien, On Mon, Jun 11, 2012 at 01:44:25PM -0700, julien2412 serval2...@yahoo.fr wrote: I proposed a quite straightforward patch here for the bug fdo#49178 (CRASH when FILEOPEN particular RTF) here : https://bugs.freedesktop.org/attachment.cgi?id=62903 Is it ok to commit and push it ?

Updated spellchecking dict for pt-BR

2012-06-12 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I updated the Brazilian spell checking dictionary in master: http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=777d50ff87ea0ccc91fb2a38e3c4e86c5e4fba17 I would like it to go to 3.5 and 3.6 branches. Can it be done, please? Thank

[Libreoffice-commits] .: 7 commits - android/Bootstrap android/experimental sal/android sal/inc sal/Package_inc.mk toolkit/inc toolkit/source touch/idl touch/Library_libotouch.mk touch/source vcl/head

2012-06-12 Thread Tor Lillqvist
android/Bootstrap/src/org/libreoffice/android/Bootstrap.java | 10 android/experimental/DocumentLoader/Makefile |1

[Libreoffice-commits] .: 2 commits - dmake/dbug dmake/msdos dmake/unix dmake/win95 dmake/winnt embeddedobj/source embeddedobj/test extensions/source extensions/test framework/source l10ntools/source

2012-06-12 Thread Michael Meeks
dmake/dbug/malloc/testmlc.c|4 dmake/msdos/dstrlwr.c |2 -- dmake/unix/runargv.c |3 +-- dmake/win95/microsft/vpp40/runargv.c |1 - dmake/winnt/microsft/vpp40/runargv.c

[REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Muthu Subramanian K
Hi, Can somebody review and cherry-pick this one please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=25dd603fe2044f35341fe0c6d0b632c9295a824e Thanks! Muthu Subramanian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Muthu Subramanian K
Oops...seems like Korrawit already proposed this in a different mail thread...sorry for the troubles. On 06/12/2012 04:44 PM, Muthu Subramanian K wrote: Hi, Can somebody review and cherry-pick this one please?

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - unoxml/source

2012-06-12 Thread Michael Stahl
unoxml/source/dom/node.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit ab25d4c548408cfaeec8a61a0d17252d3085a6a1 Author: Muthu Subramanian sumu...@suse.com Date: Fri Jun 8 19:04:37 2012 +0530 n759982: Win/VC++ stl messes up the namespace vector.

Re: [PUSHED] Updated spellchecking dict for pt-BR

2012-06-12 Thread Andras Timar
2012/6/12 Olivier Hallot olivier.hal...@documentfoundation.org: Hi I updated the Brazilian spell checking dictionary in master: http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=777d50ff87ea0ccc91fb2a38e3c4e86c5e4fba17 I would like it to go to 3.5 and 3.6 branches. Can it be

[PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Michael Stahl
On 12.06.2012 13:14, Muthu Subramanian K wrote: Hi, Can somebody review and cherry-pick this one please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=25dd603fe2044f35341fe0c6d0b632c9295a824e hmm... that old code looks legit to me? well, if it helps MSVC, pushed.

[Libreoffice-commits] .: xmloff/source

2012-06-12 Thread Eike Rathke
xmloff/source/chart/SchXMLChartContext.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 0f79440a86dc788a38ef4b3be63bffd2cd396ddc Author: Eike Rathke er...@redhat.com Date: Tue Jun 12 11:51:55 2012 +0200 work around spurious signed overflow warnings

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - unoxml/source

2012-06-12 Thread Michael Stahl
unoxml/source/dom/node.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 422db2834c81d7a1d38b760209f7dec4a3cf43e0 Author: Muthu Subramanian sumu...@suse.com Date: Fri Jun 8 19:04:37 2012 +0530 n759982: Win/VC++ stl messes up the namespace vector.

Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Fridrich Strba
On 12/06/12 13:32, Michael Stahl wrote: Can somebody review and cherry-pick this one please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=25dd603fe2044f35341fe0c6d0b632c9295a824e hmm... that old code looks legit to me? well, if it helps MSVC, pushed. Why not to take a reference or a

[Libreoffice-commits] .: moz/extractfiles.mk moz/zipped nss/makefile.mk

2012-06-12 Thread Stephan Bergmann
moz/extractfiles.mk|7 ++- moz/zipped/makefile.mk | 12 nss/makefile.mk| 12 3 files changed, 26 insertions(+), 5 deletions(-) New commits: commit dc82cf021f76ea83ff7a4bcb2d7525f2e111f0cc Author: Stephan Bergmann sberg...@redhat.com Date: Tue

Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Stephan Bergmann
On 06/12/2012 01:32 PM, Michael Stahl wrote: On 12.06.2012 13:14, Muthu Subramanian K wrote: Can somebody review and cherry-pick this one please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=25dd603fe2044f35341fe0c6d0b632c9295a824e hmm... that old code looks legit to me? No,

[Libreoffice-commits] .: oox/inc

2012-06-12 Thread Miklos Vajna
oox/inc/oox/vml/vmltextbox.hxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 48da4027d0745deb3389885e903e9323b353c4d4 Author: Miklos Vajna vmik...@suse.cz Date: Tue Jun 12 14:06:06 2012 +0200 oox: fix TextFontModel doxygen comments

[Libreoffice-commits] .: Branch 'feature/cmclayout' - 2 commits - sw/source vcl/source

2012-06-12 Thread Caolán McNamara
sw/source/ui/misc/outline.hrc |4 ++-- vcl/source/window/builder.cxx |8 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 125cecd8fa6036986f1d442bc7d902b547c11e75 Author: Caolán McNamara caol...@redhat.com Date: Tue Jun 12 13:07:20 2012 +0100

Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Tor Lillqvist
No, growing a vector (which push_back can do) invalidates all references into the vector. Would building with --enable-dbgutil on Linux (thus defining _GLIBCXX_DEBUG) had caught this problem? If yes, they I certainly start agreeing with you (IIRC) that developers should use --enable-dbgutil.

[Libreoffice-commits] .: sdext/source xmloff/source

2012-06-12 Thread Michael Stahl
sdext/source/pdfimport/test/tests.cxx |3 ++- sdext/source/pdfimport/tree/pdfiprocessor.cxx |3 ++- xmloff/source/core/DomExport.cxx |3 ++- xmloff/source/text/txtlists.cxx |9 ++--- 4 files changed, 12 insertions(+), 6 deletions(-) New

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sdext/source xmloff/source

2012-06-12 Thread Michael Stahl
sdext/source/pdfimport/test/tests.cxx |3 ++- sdext/source/pdfimport/tree/pdfiprocessor.cxx |3 ++- xmloff/source/core/DomExport.cxx |3 ++- xmloff/source/text/txtlists.cxx |9 ++--- 4 files changed, 12 insertions(+), 6 deletions(-) New

[REVIEW-3-5] Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Michael Stahl
On 12.06.2012 13:54, Stephan Bergmann wrote: On 06/12/2012 01:32 PM, Michael Stahl wrote: On 12.06.2012 13:14, Muthu Subramanian K wrote: Can somebody review and cherry-pick this one please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=25dd603fe2044f35341fe0c6d0b632c9295a824e

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - oox/inc oox/source

2012-06-12 Thread Petr Mladek
oox/inc/oox/drawingml/shape.hxx |2 +- oox/inc/oox/ppt/pptshape.hxx |2 +- oox/source/drawingml/shape.cxx|4 ++-- oox/source/ppt/pptgraphicshapecontext.cxx |8 ++-- oox/source/ppt/pptshape.cxx |6 +++--- 5 files changed, 13

Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Michael Stahl
On 12.06.2012 14:12, Tor Lillqvist wrote: No, growing a vector (which push_back can do) invalidates all references into the vector. Would building with --enable-dbgutil on Linux (thus defining _GLIBCXX_DEBUG) had caught this problem? no, because there's no iterator involved: back() returns

Re: [PUSHED:3-5] Muthu's patches for pptx import fixes

2012-06-12 Thread Petr Mladek
On Mon, 2012-06-11 at 22:35 +0700, Korrawit Pruegsanusak wrote: Hello Muthu, all, I'd like to propose two Muthu's patches to include in stable branch as follow: * http://cgit.freedesktop.org/libreoffice/core/commit/?id=90352e5f1e50291960c944f9a1f44ab3e91d6503 This also fixed

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - libvisio/libvisio-0.0.17.patch

2012-06-12 Thread Fridrich Strba
libvisio/libvisio-0.0.17.patch | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) New commits: commit 2251e2185a6133904760fc34649ea72be170ef70 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Tue Jun 12 14:35:02 2012 +0200 Don't push_back(.back()), stupid

Re: [REVIEW] Muthu's patches for pptx import fixes

2012-06-12 Thread Petr Mladek
Hi Korrawit, I forgot to comment the last sentence ;-) On Mon, 2012-06-11 at 22:35 +0700, Korrawit Pruegsanusak wrote: If I shouldn't do this proposal in the future, please feel free to tell. :-) It is perfectly fine and welcome that you look for important fixes and propose them for review.

[Libreoffice-commits] .: 2 commits - basic/source comphelper/inc editeng/source svtools/source

2012-06-12 Thread Caolán McNamara
basic/source/comp/scanner.cxx|5 ++--- comphelper/inc/comphelper/string.hxx |3 ++- editeng/source/editeng/editdoc.cxx | 16 +++- svtools/source/edit/textdoc.cxx |2 +- 4 files changed, 12 insertions(+), 14 deletions(-) New commits: commit

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sdext/source xmloff/source

2012-06-12 Thread Lubos Lunak
sdext/source/pdfimport/test/tests.cxx |3 ++- sdext/source/pdfimport/tree/pdfiprocessor.cxx |3 ++- xmloff/source/core/DomExport.cxx |3 ++- xmloff/source/text/txtlists.cxx |9 ++--- 4 files changed, 12 insertions(+), 6 deletions(-) New

[Libreoffice-commits] .: sw/source

2012-06-12 Thread Caolán McNamara
sw/source/filter/ww8/ww8par3.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8bee7215898d8784eb20bc43af1df3ed815288a6 Author: Caolán McNamara caol...@redhat.com Date: Tue Jun 12 13:39:45 2012 +0100 misuse of null-terminating requiring string ctor

[PUSHED-3-5]Re: [REVIEW-3-5] Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Lubos Lunak
On Tuesday 12 of June 2012, Michael Stahl wrote: i've fixed the other ones, please review and push to libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd18b8e313b792f5fc4 2edb3314a95d202406899 Pushed. On Tuesday 12 of June 2012, Michael Stahl wrote: On 12.06.2012

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - libvisio/libvisio-0.0.17.patch

2012-06-12 Thread Petr Mladek
libvisio/libvisio-0.0.17.patch | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) New commits: commit b3e0232e08f49824c9884e33d579646748f7f5f6 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Tue Jun 12 14:35:02 2012 +0200 Don't push_back(.back()), stupid

MySQL Native Connector broken for LOdev 3.6

2012-06-12 Thread Fernand Vanrie
As the MySQL Native Connector Extension is not supported by this community, filling a issue is not the point. Sinds dev 3.6 the MySQL Native connector (for Windows) is broken , the Mysqlc.uno.dll can not been loaded during the extention installation , i suppose the extension code have to be

I cannot register at Gerrit

2012-06-12 Thread Lionel Elie Mamane
On Mon, Jun 04, 2012 at 10:20:14AM +0200, Lionel Elie Mamane wrote: On Mon, Jun 04, 2012 at 10:12:49AM +0200, Bjoern Michaelsen wrote: On Sun, Jun 03, 2012 at 09:10:15PM +0200, Lionel Elie Mamane wrote: On Thu, May 17, 2012 at 05:41:52PM +0200, Bjoern Michaelsen wrote: 1) login with OpenID(1)

Building and packaing OxygenOffice

2012-06-12 Thread KAMI911 KAMI911
Hi Folks, I haven't built OxygenOffice from LibreOffice branches for several months. Now I tried to do that (on 3-6) because I created two virtual machines for they. What is the best way to build package OxygenOffice product? I saw the PRODUCTNAME has set in configure.in:

Re: I cannot register at Gerrit

2012-06-12 Thread Bjoern Michaelsen
On Tue, Jun 12, 2012 at 02:52:34PM +0200, Lionel Elie Mamane wrote: As the gerrit switchover is looming closer, could we please solve that? After OpenID authentication, it says: Not Found The page you requested was not found. @Robert: May I ask you to have a look at the apache logs to

Re: [GERRIT] gbuild migration: pyuno module

2012-06-12 Thread Stephan Bergmann
On 06/11/2012 12:17 AM, David Ostrovsky wrote: Still have to test it on Windows and ask somebody to test it in MacosX. Quick update: Attached windows.patch allowed me to at least build https://gerrit.libreoffice.org/#/c/179/11 on Windows (on top of recent master). Tools - Macros - Organize

[Libreoffice-commits] .: 2 commits - sw/source

2012-06-12 Thread Philipp Weissenbacher
sw/source/core/tox/tox.cxx| 30 sw/source/core/tox/toxhlp.cxx | 12 +++--- sw/source/core/tox/txmsrt.cxx | 70 +- sw/source/filter/ascii/ascatr.cxx | 18 - sw/source/filter/ascii/parasc.cxx | 37

[Libreoffice-commits] .: sw/source

2012-06-12 Thread Norbert Thiebaud
sw/source/core/draw/dcontact.cxx | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) New commits: commit d10305bbcf98088ef3d72299e4a21de6e48f Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Jun 12 08:38:11 2012 -0500 fix null pointer dereference

[Libreoffice-commits] .: sw/source

2012-06-12 Thread Michael Stahl
sw/source/filter/ww8/ww8graf.cxx |4 1 file changed, 4 insertions(+) New commits: commit 36e43b52992735c622833e923faa63774b9e2f76 Author: Michael Stahl mst...@redhat.com Date: Tue Jun 12 15:40:45 2012 +0200 fdo#43249: WW8: fix double border import: The border widths are

[REVIEW][3-5] fdo#43249: WW8: fix double border import regression

2012-06-12 Thread Michael Stahl
yet another import filter where double border widths are tripled, fix proposed for libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=36e43b52992735c622833e923faa63774b9e2f76 i'm beginning to think this should really be solved in the SvxBorderLine class as opposed to in

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-06-12 Thread Michael Stahl
sw/source/filter/ww8/ww8graf.cxx |4 1 file changed, 4 insertions(+) New commits: commit 2930a1abf8ba74d9bba0be808c1172ea7cd8e149 Author: Michael Stahl mst...@redhat.com Date: Tue Jun 12 15:40:45 2012 +0200 fdo#43249: WW8: fix double border import: The border widths are

PATCH: Add support for gnome-mail to send documents from file menu.

2012-06-12 Thread Peter Tillemans
made available under the MPL/LGPLv3+ Hi, I originally posted this as a bug on launchpad, https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1011735. I was instructed to send the patch here instead. I also had to reassemble it a bit as part of the original was also to stuff which was

[Libreoffice-commits] .: 3 commits - canvas/source cppcanvas/source drawinglayer/source filter/source padmin/source reportdesign/source sc/source sd/source sw/source vcl/inc vcl/source vcl/win vcl/wor

2012-06-12 Thread Jan Holesovsky
canvas/source/cairo/cairo_canvashelper.cxx |4 cppcanvas/source/mtfrenderer/implrenderer.cxx | 14 - drawinglayer/source/primitive2d/metafileprimitive2d.cxx| 12 - drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx | 26 +-

probabilistic approach to tinderboxing

2012-06-12 Thread Bjoern Michaelsen
Hi all, this is a proposal to get as much focused tinderboxing as possible with limited resources and unreliable build clients. This also assumes patches under consideration to be independant (that is: without conflicts) and not dependant on a specific order. gerrit allow us to have patches

[Libreoffice-commits] .: writerfilter/source

2012-06-12 Thread Miklos Vajna
writerfilter/source/dmapper/FFDataHandler.cxx | 17 ++--- writerfilter/source/dmapper/FFDataHandler.hxx |5 +++-- 2 files changed, 17 insertions(+), 5 deletions(-) New commits: commit 9b0be41e96abb0a6547afad7de3a24f336bfdb5a Author: Miklos Vajna vmik...@suse.cz Date: Tue Jun

[LATE FEATURE] Windows UI improvements

2012-06-12 Thread Jan Holesovsky
Hi, Based on the Mirek's, Astron's and others designs / advice [thank you so much for all your help! :-)], I finally managed to get the Windows 7 look to this state: http://artax.karlin.mff.cuni.cz/~kendy/design-list/toolbar-gradient.png I'd like to cherry-pick the remaining changes (menubar,

Re: IsOfficeRunning() (was: [tdf-core] I'm sure this is an accident...)

2012-06-12 Thread Jesús Corrius
After some research I found that IsOfficeRunning() is completely useless. At least in main installer. It checks if (Libre)Office is running, and if it is, installer aborts. Originally it tried to rename a file in the installation folder with user privileges - instant fail on Vista and Windows

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sw/source

2012-06-12 Thread Caolán McNamara
sw/source/filter/ww8/ww8graf.cxx |4 1 file changed, 4 insertions(+) New commits: commit 56214e02055862f196900be9a7318cbe54a48f1c Author: Michael Stahl mst...@redhat.com Date: Tue Jun 12 15:40:45 2012 +0200 fdo#43249: WW8: fix double border import: The border widths are

Re: [REVIEW][PUSHED 3-5] fdo#43249: WW8: fix double border import regression

2012-06-12 Thread Caolán McNamara
On Tue, 2012-06-12 at 15:51 +0200, Michael Stahl wrote: yet another import filter where double border widths are tripled, fix proposed for libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=36e43b52992735c622833e923faa63774b9e2f76 pushed to 3-5. C.

[Libreoffice-commits] .: sw/source

2012-06-12 Thread Caolán McNamara
sw/source/ui/misc/outline.hrc |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 04f3f84eeda03c358133f1e68d8a1df8259cb61b Author: Caolán McNamara caol...@redhat.com Date: Tue Jun 12 13:07:20 2012 +0100 FT_CHARFMT and LB_CHARFMT shared the same resource id

[Libreoffice-commits] .: binfilter/bf_svx

2012-06-12 Thread Stephan Bergmann
binfilter/bf_svx/source/svdraw/svx_svdobj.cxx |2 +- binfilter/bf_svx/source/xoutdev/svx_xline.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 74c2636f88b46f5d17de76fd128e842386aa3217 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jun 12 17:22:24

Re: IsOfficeRunning() (was: [tdf-core] I'm sure this is an accident...)

2012-06-12 Thread Michael Meeks
On Tue, 2012-06-12 at 15:37 +0200, Andras Timar wrote: My proposal is to remove IsOfficeRunning custom action from installer, and delete it from source code. Does anybody know why it was developed in the first place? Sounds entirely sensible, it seems the original cure is worse than

Fwd: [LATE FEATURE] Windows UI improvements

2012-06-12 Thread Andras Timar
fwd to list... -- Forwarded message -- From: Andras Timar tima...@gmail.com Date: 2012/6/12 Subject: Re: [LATE FEATURE] Windows UI improvements To: Jan Holesovsky ke...@suse.cz 2012/6/12 Jan Holesovsky ke...@suse.cz: OK to go ahead?  Needs 3 cross-affiliation approvals -

[Libreoffice-commits] .: Branch 'feature/cmclayout' - 2 commits - vcl/inc vcl/source

2012-06-12 Thread Caolán McNamara
vcl/inc/vcl/builder.hxx|1 vcl/inc/vcl/tabctrl.hxx|3 + vcl/source/control/tabctrl.cxx | 30 ++--- vcl/source/window/builder.cxx | 90 +++-- 4 files changed, 98 insertions(+), 26 deletions(-) New commits: commit

[Libreoffice-commits] Changes to 'libreoffice-3-5-5'

2012-06-12 Thread Petr Mladek
New branch 'libreoffice-3-5-5' available with the following commits: commit 92ebfa3364996772dea3d2265c0cb04c97de4bb0 Author: Petr Mladek pmla...@suse.cz Date: Tue Jun 12 18:08:16 2012 +0200 Branch libreoffice-3-5-5 This is 'libreoffice-3-5-5' - the stable branch for the 3.5.5

[Libreoffice-commits] Changes to 'libreoffice-3-5-5'

2012-06-12 Thread Petr Mladek
New branch 'libreoffice-3-5-5' available with the following commits: commit 617a24897e10e309defebce7e1e2f814b783531f Author: Petr Mladek pmla...@suse.cz Date: Tue Jun 12 18:08:17 2012 +0200 Branch libreoffice-3-5-5 This is 'libreoffice-3-5-5' - the stable branch for the 3.5.5

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - instsetoo_native/util solenv/inc

2012-06-12 Thread Petr Mladek
instsetoo_native/util/openoffice.lst | 30 +++--- solenv/inc/minor.mk |2 +- 2 files changed, 16 insertions(+), 16 deletions(-) New commits: commit 66c88a48c34b3dc1382d4a2e0916dd06d578c101 Author: Petr Mladek pmla...@suse.cz Date: Tue Jun 12

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - ucb/source

2012-06-12 Thread Stephan Bergmann
ucb/source/ucp/webdav/DAVResourceAccess.cxx | 15 +++ 1 file changed, 15 insertions(+) New commits: commit d41f59ddbfafd3f9a2b26a7a9a2999b77095ae36 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jun 12 18:17:37 2012 +0200 rhbz#678440: Always include User-Agent to

[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.5.5.1'

2012-06-12 Thread Petr Mladek
Tag 'libreoffice-3.5.5.1' created by Petr Mladek pmla...@suse.cz at 2012-06-12 17:18 -0700 Tag 3.5.5.1 (3.5.5-rc1) -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJP12vkAAoJEPQ0oe+v7q6j7U0P/0P6l1WOmtjSKpfDgFHgf4FJ

[Libreoffice-commits] Changes to 'refs/tags/libreoffice-3.5.5.1'

2012-06-12 Thread Petr Mladek
Tag 'libreoffice-3.5.5.1' created by Petr Mladek pmla...@suse.cz at 2012-06-12 17:18 -0700 Tag 3.5.5.1 (3.5.5-rc1) -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJP12vkAAoJEPQ0oe+v7q6jDT8P/3X1IJ3PbND1NLhoD15L1TL/

[PATCH-3-5][PATCH-3-5-5] rhbz#678440: Always include User-Agent to avoid 403 from picky servers

2012-06-12 Thread Stephan Bergmann
It would be nice if http://cgit.freedesktop.org/libreoffice/core/commit/?id=4d0e3127ed2def7212bc05aa860cd06704bb1efe rhbz#678440: Always include User-Agent to avoid 403 from picky servers fixing https://bugzilla.redhat.com/show_bug.cgi?id=678440 opening urls fails with error 403 on picky

[ANNOUNCE] Branch libreoffice-3-5-5 created

2012-06-12 Thread Petr Mladek
Hi all, there have been created the libreoffice-3-5-5 branch. It will be used for fine tuning of the 3.5.5 release. The following rules apply: + preferably just translation or blocker fixes + only cherry-picking from libreoffice-3-5 branch + 2 additional reviews needed;

[ANNOUNCE] libreoffice-3.5.5.1 tag created (3.5.5-rc1)

2012-06-12 Thread Petr Mladek
Hi, there have been created the libreoffice-3.5.5.1 tag for 3.5.5-rc1 release. The corresponding official builds will be available within next few days. See the attached list of changes against 3.5.4-final[*]. Now, you might switch your current 3-5 source tree to it using: ./g fetch --tags

Re: [Libreoffice] [GSoC 2012][svg export filter] Weekly Report #3

2012-06-12 Thread Thorsten Behrens
Marco Cecchetti wrote: Report #3 - On this week I enabled support for clip-based slide and shape transitions. The following transitions are actually available: barnWipe, fourBoxWipe, ellipseWipe, pinWheelWipe. More clip-based transitions can be provided by simply fill in the

[Libreoffice-commits] .: 2 commits - bin/lo-commit-stat bin/lo-pack-sources

2012-06-12 Thread Petr Mladek
bin/lo-commit-stat |3 +++ bin/lo-pack-sources |2 +- 2 files changed, 4 insertions(+), 1 deletion(-) New commits: commit 2e353b8daadc588b02fe7c7df5b7f185187e9d58 Author: Petr Mladek pmla...@suse.cz Date: Tue Jun 12 19:46:42 2012 +0200 lo-commit-stat: avoid problems whit '%' in

[Libreoffice-commits] .: writerfilter/source

2012-06-12 Thread Julien Nabet
writerfilter/source/dmapper/DomainMapperTableManager.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 104badf31c8a39994cadc460561bfa01e428b67b Author: Julien Nabet serval2...@yahoo.fr Date: Tue Jun 12 19:50:23 2012 +0200 Resolves: fdo#49178 CRASH when

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 3 commits - bin/lo-commit-stat bin/lo-pack-sources

2012-06-12 Thread Petr Mladek
bin/lo-commit-stat | 38 -- bin/lo-pack-sources |2 +- 2 files changed, 33 insertions(+), 7 deletions(-) New commits: commit c7e744d669940acf87dc8e580236067ba4ba3743 Author: Petr Mladek pmla...@suse.cz Date: Tue Jun 12 19:46:42 2012 +0200

Re: [PATCH][PUSHED on master] fix proposed for fdo#49178

2012-06-12 Thread julien2412
Hi Miklos, I commited and pushed on master. I hope I haven't just hide a real bug with this fix. What about 3.6 and 3.5 branch, can it be pushed too ? Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-fix-proposed-for-fdo-49178-tp3989525p3989716.html Sent from

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - bin/lo-commit-stat

2012-06-12 Thread Petr Mladek
bin/lo-commit-stat | 38 -- 1 file changed, 32 insertions(+), 6 deletions(-) New commits: commit eeeffb9a9d8e1a84d2d85a13ea84e9d00aed3e58 Author: Petr Mladek pmla...@suse.cz Date: Tue Jun 12 19:46:42 2012 +0200 lo-commit-stat: avoid problems whit '%'

Re: probabilistic approach to tinderboxing

2012-06-12 Thread Bjoern Michaelsen
On Tue, Jun 12, 2012 at 04:45:06PM +0200, Bjoern Michaelsen wrote: After sending off the tinderbox with this patchset, do: p-innocent(patch) *= p-innocent(testcase) reducing the innocence of the patches without waiting for results. So we assume the patches of the set to be partially

Source for 3.3

2012-06-12 Thread Joel Madero
Hi All, Trying to tackle a bug reported by a user that they say was a regression from 3.3. I'm trying to get my hands on the source for 3.3 so I can do a comparison of the appropriate code. Can someone link me, thanks! Joel ___ LibreOffice mailing

[Libreoffice-commits] .: sc/source

2012-06-12 Thread Stephan Bergmann
sc/source/ui/condformat/condformatdlg.cxx | 30 -- 1 file changed, 30 deletions(-) New commits: commit 1c18604836ce8063b80cc8090445bf0c0094c5d8 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jun 12 22:00:40 2012 +0200 -Werror,-Wunused-function

IsOfficeRunning() (was: [tdf-core] I'm sure this is an accident...)

2012-06-12 Thread Andras Timar
2012.06.11. 12:13 keltezéssel, Jesús Corrius írta: That's right, first we shutdown our own Quickstarter, then we look for a running soffice.bin process, which can belong to AOO as well. So rather the IsOfficeRunning() should be amended, so we only check for running LibreOffice and ignore others

IsOfficeRunning() (was: [tdf-core] I'm sure this is an accident...)

2012-06-12 Thread Andras Timar
2012.06.11. 12:13 keltezéssel, Jesús Corrius írta: That's right, first we shutdown our own Quickstarter, then we look for a running soffice.bin process, which can belong to AOO as well. So rather the IsOfficeRunning() should be amended, so we only check for running LibreOffice and ignore others

  1   2   3   >