[PATCH] Replase GUIBASE checks with equivalent OS checks

2012-12-12 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1303 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/1303/1 Replase GUIBASE checks with equivalent OS checks The idea is to get rid of GUIBASE and GUI checks as much as

[PATCH] Get rid of (most uses of) GUI

2012-12-12 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1304 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1304/1 Get rid of (most uses of) GUI GUI only takes values UNX or WNT, so it is fairly pointless. One can check

[Libreoffice-commits] .: 2 commits - sfx2/inc sfx2/source

2012-12-12 Thread Libreoffice Gerrit user
sfx2/inc/sfx2/templateabstractview.hxx|4 sfx2/inc/sfx2/thumbnailview.hxx |4 sfx2/inc/sfx2/thumbnailviewitem.hxx |1 + sfx2/inc/templatedlg.hxx |2 +- sfx2/source/appl/appopen.cxx |2 +-

[Libreoffice-commits] .: Branch 'feature/improvexlsximport' - 2 commits - officecfg/registry svx/source

2012-12-12 Thread Libreoffice Gerrit user
officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 +- svx/source/svdraw/svdetc.cxx |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) New commits: commit dd86ce1814588d6bb8fdc4b1e0b165f013e223f5 Author: Noel Power noel.po...@suse.com Date:

templates.libreoffice.org CMIS/FTP/DAV support

2012-12-12 Thread Cedric Bosdonnat
Hi Andreas, The UX guys asked me to have the new templates manager out for 4.0 and I'm working hard these days to fix the usability issues around this one. It would be even better to have the templates.libreoffice.org repository set up as a default remote templates location accessible from the

[Libreoffice-commits] .: offapi/com

2012-12-12 Thread Libreoffice Gerrit user
offapi/com/sun/star/ui/GlobalAcceleratorConfiguration.idl |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) New commits: commit 1e40e188fa8c70022a48434582623c9255ffd2e8 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Dec 12 10:34:10 2012 +0100 Simplify documentation

Re: undefined reference to `__gcov_init' when using FLAGS+='-fprofile-arcs -ftest-coverage'

2012-12-12 Thread John Smith
On Wed, Dec 12, 2012 at 3:04 AM, Caolán McNamara caol...@redhat.com wrote: On Tue, 2012-12-11 at 21:50 +0100, John Smith wrote: But I still get this error message (in 'make setup_native') undefined reference to `__gcov_init' Does anyone have an idea of what might be going on here ? Does -

[PATCH] fdo#57422 - presenter console RTL support needs completion

2012-12-12 Thread Faisal al-otaibi (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1305 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1305/1 fdo#57422 - presenter console RTL support needs completion Fixing the number problem that on Title on standard

RFC: adding some IDL syntax sugar

2012-12-12 Thread Noel Grandin
Hi I'd like to add some IDL syntax sugar, so that instead of doing this: module com { module sun { module star { module formula { }; }; }; }; we can do this: module com::sun::star::formula { }; Which is consistent with how namespaces are used elsewhere, and much

[Libreoffice-commits] .: oox/inc

2012-12-12 Thread Libreoffice Gerrit user
oox/inc/oox/core/binarycodec.hxx | 14 +++--- oox/inc/oox/core/contexthandler.hxx |2 +- oox/inc/oox/core/contexthandler2.hxx |6 +++--- oox/inc/oox/core/fasttokenhandler.hxx |2 +- oox/inc/oox/core/fragmenthandler.hxx |4 ++-- 5 files changed, 14 insertions(+),

[Libreoffice-commits] .: Branch 'feature/improvexlsximport' - sc/qa

2012-12-12 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit fbb08fed6d36eb0f82fba45bbae08e4a4576081d Author: Noel Power noel.po...@suse.com Date: Wed Dec 12 10:04:58 2012 + counteract the addressing default for the test Change-Id:

Re: RFC: adding some IDL syntax sugar

2012-12-12 Thread Stephan Bergmann
On 12/12/2012 10:58 AM, Noel Grandin wrote: I'd like to add some IDL syntax sugar, so that instead of doing this: module com { module sun { module star { module formula { }; }; }; }; we can do this: module com::sun::star::formula { }; (Or even drop the module

Re: SDK examples (was: Using config_xxx.h instead of -DHAVE_XXX)

2012-12-12 Thread Michael Meeks
On Tue, 2012-12-11 at 19:40 +0100, Stephan Bergmann wrote: For the record, at least compiling all the SDK examples via ... works now again on master and libreoffice-4-0, at least on my Linux box. Thanks ! I'm sure I broke something :-) I wonder - is that a11y sample still there ?

Re: undefined reference to `__gcov_init' when using FLAGS+='-fprofile-arcs -ftest-coverage'

2012-12-12 Thread Michael Stahl
On 11/12/12 21:50, John Smith wrote: Hi, Im trying to build libreoffice for using gcov/loc, so Ive set: LDFLAGS+='-fprofile-arcs' CFLAGS+='-fprofile-arcs -ftest-coverage' CXXFLAGS+='-fprofile-arcs -ftest-coverage' \ CPPFLAGS+='-fprofile-arcs -ftest-coverage' But I still get this

Re: undefined reference to `__gcov_init' when using FLAGS+='-fprofile-arcs -ftest-coverage'

2012-12-12 Thread John Smith
On Wed, Dec 12, 2012 at 11:36 AM, Michael Stahl mst...@redhat.com wrote: setup_native still uses the old dmake based build system, most likely that does not support those *FLAGS variables. you can check with make setup_native VERBOSE=t if that stuff is actually used. Thanks. But I have no

[Libreoffice-commits] .: sdext/source

2012-12-12 Thread Libreoffice Gerrit user
sdext/source/presenter/PresenterHelpView.cxx | 106 ++- 1 file changed, 73 insertions(+), 33 deletions(-) New commits: commit a77fa7ee84424a5844d836e83978ab0197716bef Author: Faisal M. Al-Otaibi fmalota...@kacst.edu.sa Date: Wed Dec 12 10:34:19 2012 +0300

[PUSHED] fdo#57422 - presenter console RTL support needs completion

2012-12-12 Thread Michael Meeks (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1302 Approvals: Michael Meeks: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1302 To unsubscribe,

[Libreoffice-commits] .: sdext/source

2012-12-12 Thread Libreoffice Gerrit user
sdext/source/presenter/PresenterPaneBorderPainter.cxx | 204 +- 1 file changed, 64 insertions(+), 140 deletions(-) New commits: commit cfa0588e04ee3d132081212ac38fda7c83c45024 Author: Faisal M. Al-Otaibi fmalota...@kacst.edu.sa Date: Wed Dec 12 12:38:37 2012 +0300

[PATCH] Converted Spelling and grammar Widget

2012-12-12 Thread gokul s (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1306 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/1306/1 Converted Spelling and grammar Widget Change-Id: I10af600300fb90c31a0ada086b6f8d121d625afa --- A

[PUSHED] fdo#57422 - presenter console RTL support needs completion

2012-12-12 Thread Michael Meeks (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1305 Approvals: Michael Meeks: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1305 To unsubscribe,

[PATCH] Converted format-Character widget

2012-12-12 Thread gokul s (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1307 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/1307/1 Converted format-Character widget Change-Id: I9bee370ad888ef749ba45ad2238a6c3810e22350 --- A

Re: undefined reference to `__gcov_init' when using FLAGS+='-fprofile-arcs -ftest-coverage'

2012-12-12 Thread Michael Stahl
On 12/12/12 11:49, John Smith wrote: On Wed, Dec 12, 2012 at 11:36 AM, Michael Stahl mst...@redhat.com wrote: setup_native still uses the old dmake based build system, most likely that does not support those *FLAGS variables. you can check with make setup_native VERBOSE=t if that stuff is

[Libreoffice-commits] .: svx/source

2012-12-12 Thread Libreoffice Gerrit user
svx/source/sdr/overlay/overlaymanagerbuffered.cxx | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) New commits: commit 6c98ad71478cb72b51634b32d6e553ccaec30190 Author: Michael Meeks michael.me...@suse.com Date: Wed Dec 12 11:29:37 2012 + fdo#58029 -

[Libreoffice-commits] .: cppunit/ExternalProject_cppunit.mk

2012-12-12 Thread Libreoffice Gerrit user
cppunit/ExternalProject_cppunit.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 94a1b9c46fc76126296b298aa5447e5217a69ee3 Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Dec 12 13:37:09 2012 +0200 Fix VS2012 build at least for me diff --git

Re: undefined reference to `__gcov_init' when using FLAGS+='-fprofile-arcs -ftest-coverage'

2012-12-12 Thread John Smith
On Wed, Dec 12, 2012 at 12:28 PM, Michael Stahl mst...@redhat.com wrote: well obviously check that the flags you want to add are actually on the command line... Thank you so much for your time and patience. Yes, I could have checked if these options ended up on the command line. I was wrongly

[Libreoffice-commits] .: scripting/source

2012-12-12 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py| 24 scripting/source/pyprov/officehelper.py | 16 2 files changed, 20 insertions(+), 20 deletions(-) New commits: commit 37c6cfde4db921699a1b2660beeb581a9e963630 Author: Michael Stahl mst...@redhat.com Date:

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - scripting/source

2012-12-12 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py| 24 scripting/source/pyprov/officehelper.py | 16 2 files changed, 20 insertions(+), 20 deletions(-) New commits: commit 4f97f17d8a86546465ebdc0fa39b5c453ad60781 Author: Michael Stahl mst...@redhat.com Date:

Re: --headless broken with --enable-headless

2012-12-12 Thread Stephan Bergmann
On 10/01/2012 07:40 PM, Riccardo Magliocchetti wrote: Il 01/10/2012 18:11, Michael Meeks ha scritto: On Fri, 2012-09-28 at 20:26 +0200, Riccardo Magliocchetti wrote: Here you go, you'll find the valgrind output sans all the zlib / python related errors. Thanks a lot! update to git

Re: SDK examples

2012-12-12 Thread Stephan Bergmann
On 12/12/2012 11:16 AM, Michael Meeks wrote: For the record, at least compiling all the SDK examples via ... works now again on master and libreoffice-4-0, at least on my Linux box. Thanks ! I'm sure I broke something :-) I wonder - is that a11y sample still there ? Indeed it is,

Re: undefined reference to `__gcov_init' when using FLAGS+='-fprofile-arcs -ftest-coverage'

2012-12-12 Thread John Smith
On Wed, Dec 12, 2012 at 12:28 PM, Michael Stahl mst...@redhat.com wrote: but apparently LDFLAGS don't hmmm... you could try editing these and adding your options there: solenv/inc/unxgcc.mk:LINKFLAGSSHLGUI= -shared solenv/inc/unxgcc.mk:LINKFLAGSSHLCUI= -shared This works, by the way, for

[Libreoffice-commits] .: 4 commits - basctl/source cui/source editeng/source sc/source sfx2/source svtools/source svx/source sw/source unusedcode.easy vcl/inc vcl/source

2012-12-12 Thread Libreoffice Gerrit user
basctl/source/basicide/bastype2.cxx|2 cui/source/customize/selector.cxx |4 cui/source/dialogs/hyphen.cxx |2 cui/source/dialogs/scriptdlg.cxx |2 cui/source/dialogs/thesdlg.cxx |4 editeng/source/misc/svxacorr.cxx

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - basctl/source cui/source svtools/source svx/source sw/source vcl/inc vcl/source

2012-12-12 Thread Libreoffice Gerrit user
basctl/source/basicide/bastype2.cxx|2 +- cui/source/customize/selector.cxx |4 ++-- cui/source/dialogs/hyphen.cxx |2 +- cui/source/dialogs/scriptdlg.cxx |2 +- cui/source/dialogs/thesdlg.cxx |4 ++--

Re: [PATCH] fdo#38837: Timers must end eventually [Writer idle timer]

2012-12-12 Thread Caolán McNamara
On Sat, 2012-12-08 at 21:17 +0100, pkoroau pkoroau wrote: 2012/12/5 Caolán McNamara: 1. In e.g. SetNeedGrammarCheck and SetFieldsDirty shouldn't StartBackgroundJobs only be called for the true case and not the false case ? I planned to negate. That should be: if (

[Libreoffice-commits] .: vcl/source

2012-12-12 Thread Libreoffice Gerrit user
vcl/source/control/edit.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 0a9fd66e283566a26588c64f396fda6b32ab0415 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Dec 12 14:41:15 2012 +0100 Remove stray debug statement Change-Id:

[Libreoffice-commits] .: 2 commits - sw/source

2012-12-12 Thread Libreoffice Gerrit user
sw/source/core/txtnode/fmtatr2.cxx |2 - sw/source/core/txtnode/fntcache.cxx | 62 ++-- sw/source/core/txtnode/ndhints.cxx |4 +- sw/source/core/txtnode/ndtxt.cxx| 14 sw/source/core/txtnode/swfont.cxx |8 ++--

Re: undefined reference to `__gcov_init' when using FLAGS+='-fprofile-arcs -ftest-coverage'

2012-12-12 Thread Michael Stahl
On 12/12/12 13:53, John Smith wrote: On Wed, Dec 12, 2012 at 12:28 PM, Michael Stahl mst...@redhat.com wrote: but apparently LDFLAGS don't hmmm... you could try editing these and adding your options there: solenv/inc/unxgcc.mk:LINKFLAGSSHLGUI= -shared solenv/inc/unxgcc.mk:LINKFLAGSSHLCUI=

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - svx/source

2012-12-12 Thread Libreoffice Gerrit user
svx/source/sdr/overlay/overlaymanagerbuffered.cxx | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) New commits: commit b69b6eff232ac7e4897a28cc3422aa61171f4329 Author: Michael Meeks michael.me...@suse.com Date: Wed Dec 12 11:29:37 2012 + fdo#58029 -

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - vcl/source

2012-12-12 Thread Libreoffice Gerrit user
vcl/source/control/edit.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 56384876dfbc2d01436d6dba9d926dffd03a88b9 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Dec 12 14:41:15 2012 +0100 Remove stray debug statement Change-Id:

[Libreoffice-commits] .: vcl/source

2012-12-12 Thread Libreoffice Gerrit user
vcl/source/gdi/gdimtf.cxx |1 - vcl/source/gdi/pdfwriter_impl.cxx |9 ++--- 2 files changed, 6 insertions(+), 4 deletions(-) New commits: commit 0ec2577476fd6633a24d0daab4a7f8848f3fc217 Author: Caolán McNamara caol...@redhat.com Date: Wed Dec 12 14:00:25 2012 +

Re: --headless broken with --enable-headless

2012-12-12 Thread Michael Meeks
Hi Stephan, On Wed, 2012-12-12 at 13:12 +0100, Stephan Bergmann wrote: On 10/01/2012 07:40 PM, Riccardo Magliocchetti wrote: nAcquireCount is always 0 and the patch above let me run two unoconv testsuite runs in a row without valgrind logs. It indeed looks like Application::Yield shall be

Re: Drawbacks of using declarations/namespace aliases (was: [Libreoffice-commits] rtl:: prefix removal from configmgr)

2012-12-12 Thread Lubos Lunak
On Tuesday 11 of December 2012, Stephan Bergmann wrote: commit 3e64874e7cd234ff563ac11450cfb2b6e2db4bf6 Author: Radu Ioan ioan.rad...@gmail.com --- a/configmgr/source/access.hxx +++ b/configmgr/source/access.hxx @@ -82,7 +82,6 @@ namespace com { namespace sun { namespace star { }

[PATCH] Replace GUIBASE checks with equivalent OS checks

2012-12-12 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1308 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/1308/1 Replace GUIBASE checks with equivalent OS checks The idea is to get rid of GUIBASE and GUI checks as much as

[Libreoffice-commits] .: vcl/android vcl/headless

2012-12-12 Thread Libreoffice Gerrit user
vcl/android/androidinst.cxx |1 + vcl/headless/headlessinst.cxx |1 + 2 files changed, 2 insertions(+) New commits: commit 5613bcfc6dc0ea45f8baeef9a8469a77c31365f5 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Dec 12 15:38:17 2012 +0100 Consistently acquire solar mutex

Re: --headless broken with --enable-headless

2012-12-12 Thread Stephan Bergmann
On 12/12/2012 01:12 PM, Stephan Bergmann wrote: Now, the interesting thing is that the Linux-specific CreateSalInstance (called from ImplSVMain - InitVCL before calling the application's Main in ImplSVMain) explicitly locks the solar mutex thanks to

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sfx2/inc sfx2/source

2012-12-12 Thread Libreoffice Gerrit user
sfx2/inc/templatedlg.hxx| 15 + sfx2/source/doc/templatedlg.cxx | 103 +--- sfx2/source/doc/templatedlg.hrc | 12 ++-- sfx2/source/doc/templatedlg.src | 79 +- 4 files changed, 79 insertions(+), 130 deletions(-)

[Libreoffice-commits] .: sfx2/inc sfx2/source

2012-12-12 Thread Libreoffice Gerrit user
sfx2/inc/templatedlg.hxx| 15 + sfx2/source/doc/templatedlg.cxx | 103 +--- sfx2/source/doc/templatedlg.hrc | 12 ++-- sfx2/source/doc/templatedlg.src | 79 +- 4 files changed, 79 insertions(+), 130 deletions(-)

[Libreoffice-commits] .: libcdr/ExternalProject_libcdr.mk

2012-12-12 Thread Libreoffice Gerrit user
libcdr/ExternalProject_libcdr.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b7f2fc6696eba3d16e07a2c4881b6ed000bc9795 Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Dec 12 16:36:20 2012 +0200 One more MSBuild build fix for VS 2012 Don't know

[PATCH] String removal in filter

2012-12-12 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1309 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/1309/1 String removal in filter Change-Id: I170d132e9329dd58ed6dc9bbf4094c234d122592 --- M

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 6 commits - dbaccess/source

2012-12-12 Thread Libreoffice Gerrit user
dbaccess/source/ui/control/RelationControl.cxx | 71 ++--- dbaccess/source/ui/inc/RelationControl.hxx |2 dbaccess/source/ui/inc/TableConnectionData.hxx | 14 ++- dbaccess/source/ui/querydesign/TableConnectionData.cxx | 21 ++--- 4 files changed,

[Libreoffice-commits] .: 6 commits - dbaccess/source

2012-12-12 Thread Libreoffice Gerrit user
dbaccess/source/ui/control/RelationControl.cxx | 71 ++--- dbaccess/source/ui/inc/RelationControl.hxx |2 dbaccess/source/ui/inc/TableConnectionData.hxx | 14 ++- dbaccess/source/ui/querydesign/TableConnectionData.cxx | 21 ++--- 4 files changed,

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2012-12-12 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/DomainMapper_Impl.cxx |9 - 1 file changed, 8 insertions(+), 1 deletion(-) New commits: commit 8454a88e1818fa498c6860a2db434ad51591257c Author: Caolán McNamara caol...@redhat.com Date: Thu Jul 5 21:37:49 2012 +0100 Resolves: fdo#49587 apparent loop

Re: --headless broken with --enable-headless

2012-12-12 Thread Michael Meeks
On Wed, 2012-12-12 at 15:44 +0100, Stephan Bergmann wrote: Now, on yet closer inspection, it is only the versions of CreateSalInstance for Android and --enable-headless (vcl/android/androidinst.cxx, vcl/headless/headlessinst.cxx, both based on SvpSalInstance) that do not lock the solar

Crash in Base with empty database

2012-12-12 Thread Marcos Souza
Hi guys! Some days ago I was playing with the Base app. I never touched this before, so I was pressing some buttons after create a new database to see what it can do for me. And, I crashed LO :) But, I was trying to learn how to debug LO, but I'm almost without free time... so I'm sending this

Anti-aliasing via GPU

2012-12-12 Thread Kohei Yoshida
Hi there, I'm just wondering, whether our anti-aliasing is done strictly at software level, or via hardware, and if former, what it would take to do it via hardware so that we can take advantage of GPU to speed it up if it's there. I could look into it to find that out myself, but I'm not

Extension migration to LO 4 (was: minutes of ESC call ...)

2012-12-12 Thread Stephan Bergmann
On 11/14/2012 09:07 AM, Stephan Bergmann wrote: On 10/17/2012 01:14 PM, Michael Meeks wrote: * 4.0 plans / naming / ABI stability etc. (Kendy) + user-installs labelled with '4' + migration code to do a one-shot config / setup fix. + can loose old back-compat code. +

Re: --headless broken with --enable-headless

2012-12-12 Thread Stephan Bergmann
On 12/12/2012 04:50 PM, Michael Meeks wrote: On Wed, 2012-12-12 at 15:44 +0100, Stephan Bergmann wrote: Now, on yet closer inspection, it is only the versions of CreateSalInstance for Android and --enable-headless (vcl/android/androidinst.cxx, vcl/headless/headlessinst.cxx, both based on

[Libreoffice-commits] .: desktop/source

2012-12-12 Thread Libreoffice Gerrit user
desktop/source/app/app.cxx | 94 - 1 file changed, 35 insertions(+), 59 deletions(-) New commits: commit 3a14fa971f132b6d02cef5e97166972c7873a582 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Dec 12 17:34:48 2012 +0100 Clean up

when to backport

2012-12-12 Thread Luke Deller
Hi, Newbie developer question: what is the convention around here for backporting fixes to branches? I see that the 3.6 release plan in wiki says only important bug fixes, but what counts as important? If a fix seems moderately important to me do I just repost my patch to gerrit against

Re: Drawbacks of using declarations/namespace aliases

2012-12-12 Thread Stephan Bergmann
On 12/12/2012 03:22 PM, Lubos Lunak wrote: On Tuesday 11 of December 2012, Stephan Bergmann wrote: commit 3e64874e7cd234ff563ac11450cfb2b6e2db4bf6 Author: Radu Ioan ioan.rad...@gmail.com --- a/configmgr/source/access.hxx +++ b/configmgr/source/access.hxx @@ -82,7 +82,6 @@ namespace com {

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - vcl/android vcl/headless

2012-12-12 Thread Libreoffice Gerrit user
vcl/android/androidinst.cxx |1 + vcl/headless/headlessinst.cxx |1 + 2 files changed, 2 insertions(+) New commits: commit 8795bbb146f6061ba69bf5646a1af1c3749d302b Author: Stephan Bergmann sberg...@redhat.com Date: Wed Dec 12 15:38:17 2012 +0100 Consistently acquire solar mutex

[PATCH] office ipc: use timeout pipe feature when connecting to self

2012-12-12 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1311 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/1311/1 office ipc: use timeout pipe feature when connecting to self Prevent deadlock situation that may occur with

[PATCH] sal: add timeout option when using pipe in connect mode

2012-12-12 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1310 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/1310/1 sal: add timeout option when using pipe in connect mode Change-Id: I94b9edccf194e971f375853459d73c37bdb4c6a3

[Libreoffice-commits] .: offapi/README offapi/type_reference

2012-12-12 Thread Libreoffice Gerrit user
offapi/README |7 +++ offapi/type_reference/typelibrary_history.txt | 20 2 files changed, 7 insertions(+), 20 deletions(-) New commits: commit 6a10f561d9e9cde17534bad7bf0497c9f74ece9e Author: Stephan Bergmann sberg...@redhat.com

is 'make check' supposed to work on ~master ?

2012-12-12 Thread John Smith
Hi, Im trying to run 'make check' at toplevel on ~master. It fails for me at this point (soffice.bin crashes) : make /usr/local/src/libreoffice/workdir/unxlngi6.pro/JunitTest/comphelper_complex/done Is that 'supposed to work', or should I expect failure(s) ? - John Smith

Re: Anti-aliasing via GPU

2012-12-12 Thread Thorsten Behrens
Kohei Yoshida wrote: I'm just wondering, whether our anti-aliasing is done strictly at software level, or via hardware, and if former, what it would take to do it via hardware so that we can take advantage of GPU to speed it up if it's there. On Linux, we use cairo, and XRender directly in

Help with updating types.rdb

2012-12-12 Thread Kohei Yoshida
Hi, I'm trying to unpublish several UNO API as discussed in ESC meeting. I've done unpublishing but am struggling with updating the types.rdb. I'm running make cmd cmd='./types_reference/update-rdb.sh com/sun/star/sheet/DataPilotSource.idl com/sun/star/sheet/DataPilotSourceDimension.idl

Re: SDK examples

2012-12-12 Thread Thorsten Behrens
Stephan Bergmann wrote: Indeed it is, odk/examples/DevelopersGuide/Accessibility/. Looks like http://cgit.freedesktop.org/libreoffice/core/commit/?id=70626249cd247d9acdad417b8eaf252bae22c059 API CHANGE a11y unpublishing and add/removeListener rename. didn't address that. Sorry, after

Re: Gerrit - issue submitting a patch

2012-12-12 Thread Thorsten Behrens
Norbert Thiebaud wrote: and yes linked workdir is un-supported so no idea what the implication are... Then we should maybe properly kill it. Looks like it's currently causing more harm than benefits. -- Thorsten signature.asc Description: Digital signature

Re: Anti-aliasing via GPU

2012-12-12 Thread Jonathan Aquilina
What I know about Nvidia Gpu's, with CUDA all it is is a C library extension, so if it is not hardware based I dont think it would be a hard thing to offload to the GPU. I am not sure though what AMD does with their APU's On Wed, Dec 12, 2012 at 4:54 PM, Kohei Yoshida

Re: Help with updating types.rdb

2012-12-12 Thread Kohei Yoshida
On 12/12/2012 01:12 PM, Kohei Yoshida wrote: Help appreciated. Or, if someone with more clue than I is willing to do the change for me, I would be more than grateful. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list

Re: Documentation required

2012-12-12 Thread Thorsten Behrens
Michael Meeks wrote: If - having done that - you'd like to send some patches in to improve top-level module/README files with key concepts, and/or to add overview or doxygen comments to classes please do so ! :-) Speaking of doxygen, there's e.g.

Re: RFC: adding some IDL syntax sugar

2012-12-12 Thread Thorsten Behrens
I'd like to add some IDL syntax sugar, so that instead of doing this: module com { module sun { module star { module formula { }; }; }; }; we can do this: module com::sun::star::formula { }; Sounds lovely to me - and you intend to keep supporting the old

Re: Gerrit - issue submitting a patch

2012-12-12 Thread Norbert Thiebaud
On Wed, Dec 12, 2012 at 12:30 PM, Thorsten Behrens t...@documentfoundation.org wrote: Norbert Thiebaud wrote: and yes linked workdir is un-supported so no idea what the implication are... Then we should maybe properly kill it. Looks like it's currently causing more harm than benefits. I

Re: --headless broken with --enable-headless

2012-12-12 Thread Riccardo Magliocchetti
Hello Stephen, thanks a lot for debugging this issue Il 12/12/2012 15:44, Stephan Bergmann ha scritto: [snip] So http://cgit.freedesktop.org/libreoffice/core/commit/?id=5613bcfc6dc0ea45f8baeef9a8469a77c31365f5 Consistently acquire solar mutex in all CreateSalInstance variants appears to be

Re: templates.libreoffice.org CMIS/FTP/DAV support

2012-12-12 Thread Andreas Mantke
Hi Cedric, Am 12.12.2012 10:22, schrieb Cedric Bosdonnat: Hi Andreas, The UX guys asked me to have the new templates manager out for 4.0 and I'm working hard these days to fix the usability issues around this one. It would be even better to have the templates.libreoffice.org repository set

Re: Gerrit - issue submitting a patch

2012-12-12 Thread Thorsten Behrens
Norbert Thiebaud wrote: I never used it, never quite got the point of it... but clearly some other people found it useful... I used it, and so did Kohei - as a means to create cheap local clones. There were a few glitches though all the time, e.g. Cloph a few times complained about tinderbox

Re: Gerrit - issue submitting a patch

2012-12-12 Thread Norbert Thiebaud
On Wed, Dec 12, 2012 at 1:06 PM, Thorsten Behrens t...@documentfoundation.org wrote: Norbert Thiebaud wrote: I never used it, never quite got the point of it... but clearly some other people found it useful... I used it, and so did Kohei - as a means to create cheap local clones. There were

Re: --headless broken with --enable-headless

2012-12-12 Thread Tor Lillqvist
Now, on yet closer inspection, it is only the versions of CreateSalInstance for Android and --enable-headless (vcl/android/androidinst.cxx, vcl/headless/headlessinst.cxx, both based on SvpSalInstance) that do not lock the solar mutex -- while curiously enough both release it in

Re: Gerrit - issue submitting a patch

2012-12-12 Thread Kohei Yoshida
On 12/12/2012 02:06 PM, Thorsten Behrens wrote: Norbert Thiebaud wrote: I never used it, never quite got the point of it... but clearly some other people found it useful... I used it, and so did Kohei - as a means to create cheap local clones. There were a few glitches though all the time,

[Libreoffice-commits] .: offapi/com offapi/type_reference

2012-12-12 Thread Libreoffice Gerrit user
offapi/com/sun/star/sheet/DataPilotSource.idl|2 +- offapi/com/sun/star/sheet/DataPilotSourceDimension.idl |2 +- offapi/com/sun/star/sheet/DataPilotSourceDimensions.idl |2 +- offapi/com/sun/star/sheet/DataPilotSourceHierarchies.idl |2 +-

Re: RFC: adding some IDL syntax sugar

2012-12-12 Thread Noel Grandin
On Wednesday, 12 December 2012, Thorsten Behrens wrote: I'd like to add some IDL syntax sugar, so that instead of doing this: module com { module sun { module star { module formula { }; }; }; }; we can do this: module com::sun::star::formula { };

Re: Anti-aliasing via GPU

2012-12-12 Thread Kohei Yoshida
On 12/12/2012 12:53 PM, Thorsten Behrens wrote: Kohei Yoshida wrote: I'm just wondering, whether our anti-aliasing is done strictly at software level, or via hardware, and if former, what it would take to do it via hardware so that we can take advantage of GPU to speed it up if it's there. On

[Libreoffice-commits] .: bug/bug.xhtml

2012-12-12 Thread Rob Snelders
bug/bug.xhtml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 551bc848f3601c4fcd39ac9f2677bbd972de797d Author: Rob Snelders programm...@ertai.nl Date: Wed Dec 12 21:22:42 2012 +0100 other text at regression-combobox diff --git a/bug/bug.xhtml b/bug/bug.xhtml

[Libreoffice-commits] .: bug/bug.xhtml

2012-12-12 Thread Rob Snelders
bug/bug.xhtml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9a2e1d1c9410a1bf72e315e25cf5d2c3d4a6a202 Author: Rob Snelders programm...@ertai.nl Date: Wed Dec 12 21:29:48 2012 +0100 Changed Markup diff --git a/bug/bug.xhtml b/bug/bug.xhtml index

Re: templates.libreoffice.org CMIS/FTP/DAV support

2012-12-12 Thread Cedric Bosdonnat
Hi Andreas, On Wed, 2012-12-12 at 19:57 +0100, Andreas Mantke wrote: Could you help us on the plone side to get this ready? yes, I could do. There is currently a WebDAV available for the extensions- and the template-site: webdav://extensions.libreoffice.org

Re: templates.libreoffice.org CMIS/FTP/DAV support

2012-12-12 Thread Andreas Mantke
Hi Cedric, Am 12.12.2012 21:29, schrieb Cedric Bosdonnat: Hi Andreas, On Wed, 2012-12-12 at 19:57 +0100, Andreas Mantke wrote: Could you help us on the plone side to get this ready? yes, I could do. There is currently a WebDAV available for the extensions- and the template-site:

Re: when to backport

2012-12-12 Thread Michael Meeks
Hi Luke, On Wed, 2012-12-12 at 20:00 +1100, Luke Deller wrote: Newbie developer question: what is the convention around here for backporting fixes to branches? Good question :-) I see that the 3.6 release plan in wiki says only important bug fixes, but what counts as important ?

Re: templates.libreoffice.org CMIS/FTP/DAV support

2012-12-12 Thread Michael Meeks
On Wed, 2012-12-12 at 19:57 +0100, Andreas Mantke wrote: yes, I could do. There is currently a WebDAV available for the extensions- and the template-site: webdav://extensions.libreoffice.org webdav://templates.libreoffice.org If we're going to put this on a hot path that users use

Re: Anti-aliasing via GPU

2012-12-12 Thread Michael Meeks
Hi Kohei, On Wed, 2012-12-12 at 14:46 -0500, Kohei Yoshida wrote: My main concern was that, and the reason why I asked it was that when the anti-aliasing is enabled, the scrolling inside some quite complex Draw document becomes very very slow, and wondered if there was anything we could do

Re: templates.libreoffice.org CMIS/FTP/DAV support

2012-12-12 Thread Andreas Mantke
Hi Michael, Cedric, Am 12.12.2012 22:20, schrieb Michael Meeks: On Wed, 2012-12-12 at 19:57 +0100, Andreas Mantke wrote: yes, I could do. There is currently a WebDAV available for the extensions- and the template-site: webdav://extensions.libreoffice.org webdav://templates.libreoffice.org

Re: --headless broken with --enable-headless

2012-12-12 Thread Michael Meeks
On Wed, 2012-12-12 at 19:55 +0100, Riccardo Magliocchetti wrote: thanks a lot for debugging this issue Thanks for helping chase this down :-) With 6a10f561d9e9cde17534bad7bf0497c9f74ece9e , master still crashes for me when running unoconv test suite:

Re: --headless broken with --enable-headless

2012-12-12 Thread Michael Meeks
On Wed, 2012-12-12 at 21:19 +0200, Tor Lillqvist wrote: Well, firstly I am not sure if this SalInstance code gets involved at all currently in our Android app(s) (all GUI is done using Android Java code, no VCL event loop etc is running) Event loop or not - you don't want two threads

[Libreoffice-commits] .: 3 commits - sfx2/inc sfx2/source

2012-12-12 Thread Libreoffice Gerrit user
sfx2/inc/sfx2/templateabstractview.hxx |8 -- sfx2/inc/sfx2/templateproperties.hxx |1 sfx2/inc/sfx2/templateviewitem.hxx |5 --- sfx2/source/control/templateabstractview.cxx | 28 - sfx2/source/control/templatelocalview.cxx| 36

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 3 commits - sfx2/inc sfx2/source

2012-12-12 Thread Libreoffice Gerrit user
sfx2/inc/sfx2/templateabstractview.hxx |8 -- sfx2/inc/sfx2/templateproperties.hxx |1 sfx2/inc/sfx2/templateviewitem.hxx |5 --- sfx2/source/control/templateabstractview.cxx | 28 - sfx2/source/control/templatelocalview.cxx| 36

[PATCH] Base: fix incorrect field removal in criterion inside query design view

2012-12-12 Thread Olivier Ploton
Problem: you cannot type a field name inside a criterion if the field name is also the column name, even if it is qualified. For example (see attached file: pairs.odb), Query pairs_SQL can not be generated using query design view : Inside first column, named name, typing in something like

[Libreoffice-commits] .: sc/source

2012-12-12 Thread Libreoffice Gerrit user
sc/source/core/data/bcaslot.cxx | 183 +--- sc/source/core/inc/bcaslot.hxx | 53 +-- 2 files changed, 145 insertions(+), 91 deletions(-) New commits: commit a60b149eede0c79dc08f00fd76d648a9cce0e660 Author: Eike Rathke er...@redhat.com Date: Wed

[PATCH] migrate 'Caption options' dialog to .ui file

2012-12-12 Thread Jack Leigh (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1312 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1312/1 migrate 'Caption options' dialog to .ui file Change-Id: I58dbb70faf22c5958b65e5192664b7d12d62f04c --- M

Re: Anti-aliasing via GPU

2012-12-12 Thread Enrico Weigelt
On Windows, we use gdiplus, which is notoriously slow. Optionally using WPF there might speed things up a bit, haven't looked any closer yet, though. IIRC, Cairo also runs on win32, so why not using it instead of gdi+ ? cu -- Mit freundlichen Grüßen / Kind regards Enrico Weigelt VNC -

Re: Reworking the MSVC-related build options

2012-12-12 Thread Enrico Weigelt
Hi, Anyway, about killing the --directx-home option, even if that is done, that does not mean having and building against the DirectX SDK (June 2010, or some earlier version) would be mandatory. It would just mean that if the standard DXSDK_DIR environment variable does not exist, then

[Libreoffice-commits] .: editeng/source

2012-12-12 Thread Libreoffice Gerrit user
editeng/source/misc/svxacorr.cxx |4 1 file changed, 4 insertions(+) New commits: commit a61928d2f7512d573e598b23c7fd3cf341f97780 Author: Michael Meeks michael.me...@suse.com Date: Wed Dec 12 22:16:53 2012 + fdo#58060 - use empty-string for LANGUAGE_DONTKNOW ie. acorr_.dat

  1   2   3   4   >