[Libreoffice-commits] .: configure.ac .gitignore src/lib

2013-01-16 Thread Libreoffice Gerrit user
.gitignore |1 + configure.ac| 18 -- src/lib/Makefile.am |4 ++-- 3 files changed, 19 insertions(+), 4 deletions(-) New commits: commit 1f8d38e91ea3d7a90ba152560ae5c863d3cee72a Author: Fridrich Å trba Date: Wed Jan 16 10:37:01 2013 +0100 Check f

Re: replacing OUString::valueOf(static_cast) ??

2013-01-16 Thread Noel Grandin
On 2013-01-16 19:48, Lubos Lunak wrote: On Monday 14 of January 2013, Noel Grandin wrote: OK, so I tried modifying my patch so that we have number(sal_Int64) number(float) number(double) At which point my unit tests fail when passing a 32-bit value in because the compiler does not

[Libreoffice-commits] .: configure.ac

2013-01-16 Thread Libreoffice Gerrit user
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fcfe59ed3b0fe2d186ff44f2a3809b97ee116639 Author: Brennan T. Vincent Date: Wed Jan 16 18:44:47 2013 -0700 update to work with latest autotools diff --git a/configure.ac b/configure.ac index 6bfc167..

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58998, which changed state. Bug 58998 Summary: duplicated sections https://bugs.freedesktop.org/show_bug.cgi?id=58998 What|Removed |Added ---

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#58998 insert section applied twice

2013-01-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1729 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/1729/1 Resolves: fdo#58998 insert section applied twice regression since 0157f0b1ba364f7f9af2aacd1be9fbb5ddec2b4d my b

[Libreoffice-commits] .: 2 commits - sfx2/inc sfx2/source sw/source

2013-01-16 Thread Libreoffice Gerrit user
sfx2/inc/sfx2/tabdlg.hxx | 10 +++--- sfx2/source/dialog/tabdlg.cxx | 16 +--- sw/source/ui/dialog/swdlgfact.cxx |2 +- 3 files changed, 13 insertions(+), 15 deletions(-) New commits: commit b7aa16fe0da53001e056ad347ac5e10855376365 Author: Caolán McNamara Da

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 --- Comment #198 from ejectm...@me.com --- Nominate bug 33281, vertical text not exported properly in PDF. Filed in 2011. -- You are receiving this mail because: You are on the CC list for the bug. ___

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 ejectm...@me.com changed: What|Removed |Added Depends on||33281 -- You are receiving this mail

Re: Cppcheck reports

2013-01-16 Thread julien2412
Just for information, I updated the cppcheck reports (LO sources updated today + cppcheck updated today). I also created a first version to explain how to generate all this here: https://wiki.documentfoundation.org/Development/Cppcheck Julien -- View this message in context: http://nabble.docu

[PATCH] Change in core[libreoffice-4-0]: fdo#59321 un-escape quotes in Windows Installer's idt files

2013-01-16 Thread Andras Timar (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1728 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/1728/1 fdo#59321 un-escape quotes in Windows Installer's idt files Change-Id: Iecd39e00ed61449a720354f95cbb695447797bff

[PATCH] Add close findbar button also on other LO components

2013-01-16 Thread Joren De Cuyper (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1727 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/1727/1 Add close findbar button also on other LO components Change-Id: I8a18d0459d9584d00b8d7c747b0bb500e02988d9 --- M

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#59183 Copy 4 or more slides then crash

2013-01-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1726 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1726/1 Resolves: fdo#59183 Copy 4 or more slides then crash regression from 17afe4cea7e01aef1e5270cc09f438bc6fde3211 wh

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 59183, which changed state. Bug 59183 Summary: EDITING: Copy 4 or more slides then crash https://bugs.freedesktop.org/show_bug.cgi?id=59183 What|Removed |Added -

[Libreoffice-commits] .: dbaccess/source

2013-01-16 Thread Libreoffice Gerrit user
dbaccess/source/filter/xml/xmlDataSourceSetting.cxx | 35 1 file changed, 14 insertions(+), 21 deletions(-) New commits: commit 47d95d7591ec6218ad3c3ce75b232ee15d00c174 Author: Michael Stahl Date: Wed Jan 16 21:11:31 2013 +0100 OXMLDataSourceSetting::convertString:

[Libreoffice-commits] .: dbaccess/source

2013-01-16 Thread Libreoffice Gerrit user
dbaccess/source/filter/xml/xmlDataSourceSetting.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 92376b09e9c55b140dcd3241c9c881b8f1302527 Author: Luboš Luňák Date: Wed Jan 16 21:13:13 2013 +0100 fix build Change-Id: I1697e761061c21826f57d4b2

[Libreoffice-commits] .: svx/source

2013-01-16 Thread Libreoffice Gerrit user
svx/source/svdraw/svdmodel.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 63de2b8f1493f24669c78df3bc2d48d13528bd9f Author: Caolán McNamara Date: Wed Jan 16 20:09:37 2013 + Resolves: fdo#59183 Copy 4 or more slides then crash regression f

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 58893, which changed state. Bug 58893 Summary: [CRASH] FILEOPEN : master document with linked template modified https://bugs.freedesktop.org/show_bug.cgi?id=58893 What|Removed |Added -

[Libreoffice-commits] .: 3 commits - svx/inc svx/source

2013-01-16 Thread Libreoffice Gerrit user
svx/inc/svx/svdlayer.hxx | 46 +- svx/source/svdraw/svdlayer.cxx | 71 - 2 files changed, 65 insertions(+), 52 deletions(-) New commits: commit 2003d4ffbf9865bc87cbe081f48f98b287223820 Author: Kohei Yoshida Date: Wed Jan

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - oox/source

2013-01-16 Thread Libreoffice Gerrit user
oox/source/drawingml/table/tablecell.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 083b2c6dc32569930e1e5d35246e8f80701f8934 Author: Radek Doulik Date: Wed Jan 16 20:37:50 2013 +0100 fix cell border line properties n#793408 Change-Id: Id20fa233b7e7eb0f2f01f4c230

[Libreoffice-commits] .: oox/source

2013-01-16 Thread Libreoffice Gerrit user
oox/source/drawingml/table/tablecell.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit fd447c820f3f42cb16f5af28572fe7a9047b6481 Author: Radek Doulik Date: Wed Jan 16 20:37:50 2013 +0100 fix cell border line properties n#793408 Change-Id: Id20fa233b7e7eb0f2f01f4c230

Re: [PATCH] This also removes an English text in the Master page: "Click...

2013-01-16 Thread Samuel Mehrbrodt
Thanks Michael! :) I think I wrote #fdo59396, so it was treated as comment... Am 16.01.2013 20:14, schrieb Michael Stahl: On 16/01/13 18:57, Samuel Mehrbrodt wrote: The first line of my commit message was: fdo#59396 Remove duplicate footer placeholders Somehow it got lost. you can add it bac

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 John Kuang changed: What|Removed |Added Depends on||52159 --- Comment #197 from John Kuang ---

[Libreoffice-commits] .: Branch 'feature/androidapp' - android/experimental

2013-01-16 Thread Libreoffice Gerrit user
android/experimental/LibreOffice4Android/native-code.cxx | 35 +++ 1 file changed, 35 insertions(+) New commits: commit 91799f60b928e00b1ea2a86558d98d301bf82c4e Author: Michael Meeks Date: Wed Jan 16 22:18:51 2013 +0300 add missing components. Change-Id: I4d7993df86

Re: Pyuno ImportError

2013-01-16 Thread Xisco Faulí
Hello, I rebuilt master and it doesn't happen anymore. Probably I did something wrong because noone but me complained about it. Sorry for the inconvience. Regards 2013/1/16 Caolán McNamara > On Sat, 2013-01-05 at 02:51 +0100, Xisco Faulí wrote: > > Hello everybody, > > > > > > I've just built

Re: [PATCH] This also removes an English text in the Master page: "Click...

2013-01-16 Thread Michael Stahl
On 16/01/13 18:57, Samuel Mehrbrodt wrote: > The first line of my commit message was: > fdo#59396 Remove duplicate footer placeholders > > Somehow it got lost. you can add it back via git commit --amend, which opens the commit message in an editor (as specified by $EDITOR, often it's vi by defaul

[PUSHED] Change in core[libreoffice-4-0]: fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure

2013-01-16 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1719 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1719 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-3-6]: fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure

2013-01-16 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1720 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1720 To unsubscribe, visit

[PUSHED] Sanitize/simplify some parameters of functions in dbaccess

2013-01-16 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1707 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1707 To unsubscribe, visit

[PUSHED] fdo#57950: dbaccess: STRINGPARAM and more chained appends

2013-01-16 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1706 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1706 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sal/osl

2013-01-16 Thread Libreoffice Gerrit user
sal/osl/w32/file_dirvol.cxx | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) New commits: commit 1839f7be0a6720c11086df00a50443fe8ee3bd00 Author: Stephan Bergmann Date: Wed Jan 16 17:19:10 2013 +0100 fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sal/osl

2013-01-16 Thread Libreoffice Gerrit user
sal/osl/w32/file_dirvol.cxx | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) New commits: commit bcc204783bf5539570af2bbb49ac0b3f337ae70d Author: Stephan Bergmann Date: Wed Jan 16 17:19:10 2013 +0100 fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure

[Libreoffice-commits] .: dbaccess/source

2013-01-16 Thread Libreoffice Gerrit user
dbaccess/source/core/dataaccess/documentdefinition.cxx | 52 - 1 file changed, 25 insertions(+), 27 deletions(-) New commits: commit 8fcd3360f195736d636eb1f1ba58d51cf053beae Author: Marcos Paulo de Souza Date: Tue Jan 15 23:11:30 2013 -0200 Sanitize/simplify some paramet

[Libreoffice-commits] .: dbaccess/source

2013-01-16 Thread Libreoffice Gerrit user
dbaccess/source/core/api/CacheSet.cxx | 23 +--- dbaccess/source/core/api/OptimisticSet.cxx | 84 +--- dbaccess/source/core/api/View.cxx |2 dbaccess/source/core/api/query.cxx |4 dbaccess/source/co

Re: Modifying an Impress Template

2013-01-16 Thread Eike Rathke
Hi Samuel, On Wednesday, 2013-01-16 18:22:03 +0100, Samuel Mehrbrodt wrote: > >One thing one needs to do before committing is stripping language settings > >within the file with this script: solenv/bin/striplanguagetags.sh > I just tried to run that script on the updated template, and here's > wh

Fwd: LOGO Toolbar in front of New Document when closing and reopen LO

2013-01-16 Thread Marcos Souza
CCing the list =D -- Forwarded message -- From: Marcos Souza Date: 2013/1/16 Subject: Re: LOGO Toolbar in front of New Document when closing and reopen LO To: ten...@iseries-guru.com Hum... I believed that is could be so simple that we don't need to create a new bug... But, if

[Libreoffice-commits] .: solenv/gbuild

2013-01-16 Thread Libreoffice Gerrit user
solenv/gbuild/LinkTarget.mk | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) New commits: commit 41cc024a39d070911a5daa75ff8aa9340c71147e Author: Luboš Luňák Date: Wed Jan 16 19:25:50 2013 +0100 T_xxxFLAGS_APPEND fixups http://lists.freedesktop.org/archives

[Libreoffice-commits] .: solenv/bin

2013-01-16 Thread Libreoffice Gerrit user
solenv/bin/striplanguagetags.sh |6 ++ 1 file changed, 6 insertions(+) New commits: commit 02edfcaddf1a06775eab01ef742bb9eff640949b Author: Eike Rathke Date: Wed Jan 16 19:18:11 2013 +0100 check if $CALLXSLTPROC is defined and bail out if not Change-Id: I2cbaffc3569994231

Re: Change in core[master]: fdo#40465 solve regression when zooming with cursor not visi...

2013-01-16 Thread Eike Rathke
Hi Winfried, On Wednesday, 2013-01-16 08:42:07 +0100, Winfried Donkers wrote: > > the original commit contained a spurious "dictionaries" change, please don't > > use "git commit -a" > > I did notice that after submitting to gerrit. > "git diff" didn't show it. Hint: always do a git status if

Re: [PATCH] This also removes an English text in the Master page: "Click...

2013-01-16 Thread Samuel Mehrbrodt
The first line of my commit message was: fdo#59396 Remove duplicate footer placeholders Somehow it got lost. Here's the bug for that: https://bugs.freedesktop.org/show_bug.cgi?id=59396 Samuel Am 16.01.2013 18:51, schrieb Samuel Mehrbrodt (via Code Review): Hi, I have submitted a patch for re

[PATCH] This also removes an English text in the Master page: "Click...

2013-01-16 Thread Samuel Mehrbrodt (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1725 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1725/1 This also removes an English text in the Master page: "Click here to edit..." and replaces it with a placeholder

Re: Modifying an Impress Template

2013-01-16 Thread Samuel Mehrbrodt
Well, I just edited it manually and submitted the patch to Gerrit: https://gerrit.libreoffice.org/1725 Am 16.01.2013 18:22, schrieb Samuel Mehrbrodt: I just tried to run that script on the updated template, and here's what I got: http://pastie.org/5697585 _

Re: LOGO Toolbar in front of New Document when closing and reopen LO

2013-01-16 Thread Terrence Enger
On Tue, 2013-01-15 at 22:49 -0200, Marcos Souza wrote: > Hi guys! > > I believe this maybe be simple to solve, so I'm just sending this email to > tell you this issue. > > I was playing with the LOGO toolbar, and if we close and reopen Writer with > View->Toolbar->Logo set, the LOGO toolbar appea

Re: replacing OUString::valueOf(static_cast) ??

2013-01-16 Thread Lubos Lunak
On Monday 14 of January 2013, Noel Grandin wrote: > OK, so I tried modifying my patch so that we have >number(sal_Int64) >number(float) >number(double) > > At which point my unit tests fail when passing a 32-bit value in because > the compiler does not > know which overload to use - thi

Re: fdo#38838 - Removal/Replacement of the String/UniString with OUString once and for all.

2013-01-16 Thread Lubos Lunak
On Tuesday 15 of January 2013, Norbert Thiebaud wrote: > On Tue, Jan 15, 2013 at 12:26 PM, Eike Rathke wrote: > > For example, a > > > > if (String.Search(...) == STRING_NOTFOUND) > > > > replaced with > > > > if (OUString.indexOf(...) == STRING_NOTFOUND) > > > > will not work. > > A even

Re: REVIEW [4-0-0] [PUSHED 4.0 ] Late Feature: IFERROR and IFNA spreadsheet functions

2013-01-16 Thread Kohei Yoshida
On 01/16/2013 11:54 AM, Eike Rathke wrote: At some point we should get rid of that nonsense to use the internal opcode values there and use function names instead, Yup, that was my thinking as well when I discovered it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

[PATCH] Change in core[libreoffice-3-6]: rhbz#818557: fix it differently: SwDocShell::_LoadStyles():

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1724 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/1724/1 rhbz#818557: fix it differently: SwDocShell::_LoadStyles(): Try to prevent pushing of SfxShells from this functi

[PATCH] Change in core[libreoffice-3-6]: fdo#58893: Revert "Resolves: rhbz#818557 crash with NULL she...

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1723 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1723/1 fdo#58893: Revert "Resolves: rhbz#818557 crash with NULL shell..." This reverts commit a1d265be484f1c70f57ab3de9

Re: Modifying an Impress Template

2013-01-16 Thread Samuel Mehrbrodt
Hi Alexander, Am 16.01.2013 13:54, schrieb Alexander Wilms: Hi Samuel, Wouldn't the commit message suffice to explain the changes? One thing one needs to do before committing is stripping language settings within the file with this script: solenv/bin/striplanguagetags.sh I just tried to run th

[PATCH] Change in core[libreoffice-4-0]: fdo#58893: Revert "Resolves: rhbz#818557 crash with NULL she...

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1721 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/1721/1 fdo#58893: Revert "Resolves: rhbz#818557 crash with NULL shell..." This reverts commit a1d265be484f1c70f57ab3de9

[PATCH] Change in core[libreoffice-4-0]: rhbz#818557: fix it differently: SwDocShell::_LoadStyles():

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1722 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/1722/1 rhbz#818557: fix it differently: SwDocShell::_LoadStyles(): Try to prevent pushing of SfxShells from this functi

[Libreoffice-commits] .: solenv/bin

2013-01-16 Thread Libreoffice Gerrit user
solenv/bin/striplanguagetags.sh |6 ++ 1 file changed, 6 insertions(+) New commits: commit 83b729ebcf525d03ce4c0c85dd871c91968e78ac Author: Eike Rathke Date: Wed Jan 16 18:12:18 2013 +0100 also strip fo:script and *:rfc-language-tag For future reference, before this gets

Re: REVIEW [4-0-0] [PUSHED 4.0 ] Late Feature: IFERROR and IFNA spreadsheet functions

2013-01-16 Thread Eike Rathke
Hi Kohei, On Wednesday, 2013-01-16 09:20:42 -0500, Kohei Yoshida wrote: > The only thing I might suggest is that, since the commit shifts the > opcode values, check the last used function list which is defined in > the user configuration by a list of opcode values. That may be > affected, and mi

Re: Pyuno ImportError

2013-01-16 Thread Caolán McNamara
On Sat, 2013-01-05 at 02:51 +0100, Xisco Faulí wrote: > Hello everybody, > > > I've just built libreoffice after a couple of weeks and now pyuno > fails to import elements from the API, like from > com.sun.star.awt.VclWindowPeerAttribute import OK. > It worked well before Christmas. Any regressio

Re: fdo#38838 - Removal/Replacement of the String/UniString with OUString once and for all.

2013-01-16 Thread Caolán McNamara
On Wed, 2013-01-16 at 13:34 +0100, Jean-Noël Rouvignac wrote: > Thanks for all your relevant answers and wiki updates. > I understand the goal is to replace String and its variants by > OUString. > > My last remaining question is "what is the use of OString? Where/when > is it used in the applicat

[PATCH] Change in core[libreoffice-3-6]: fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure

2013-01-16 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1720 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1720/1 fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure ...in osl_getFileStatus et al, it would leave the r

[Libreoffice-commits] .: 2 commits - src/docrecord.py src/msodraw.py

2013-01-16 Thread Miklos Vajna
src/docrecord.py |4 +-- src/msodraw.py | 73 +-- 2 files changed, 47 insertions(+), 30 deletions(-) New commits: commit 318a8dc91b9fbd0ee3654049c70b8bd84a8fb14b Author: Miklos Vajna Date: Wed Jan 16 17:34:09 2013 +0100 msodraw:

[PATCH] Change in core[libreoffice-4-0]: fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure

2013-01-16 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1719 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1719/1 fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure ...in osl_getFileStatus et al, it would leave the r

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Caolán McNamara changed: What|Removed |Added Depends on|58815 |55974 -- You are receiving this mail

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58815, which changed state. Bug 58815 Summary: [CRASH] new document, add slide/page, close without saving crashes Impress, Draw https://bugs.freedesktop.org/show_bug.cgi?id=58815 What|Removed

Unit test failing on some machine

2013-01-16 Thread Pierre-Eric Pelloux-Prayer
Hi all, I recently added a new unit test to Writer docx test suite. It's quite simple: a single page document with one table filling all the page. The test then verifies that after import/export the document has indeed 1 page. (see sw/qa/extras/ooxmlexport/ooxmlexport.cxx and sw/qa/extras/ooxm

[Libreoffice-commits] .: 3 commits - cppuhelper/source sal/osl

2013-01-16 Thread Libreoffice Gerrit user
cppuhelper/source/defaultbootstrap.cxx | 17 --- cppuhelper/source/servicemanager.cxx | 78 + cppuhelper/source/servicemanager.hxx | 17 --- sal/osl/w32/file_dirvol.cxx| 20 ++-- 4 files changed, 76 insertions(+), 56 deletions(-)

[Libreoffice-commits] .: chart2/source sc/source sd/source svx/inc

2013-01-16 Thread Libreoffice Gerrit user
chart2/source/controller/main/ChartTransferable.cxx |2 +- sc/source/ui/app/seltrans.cxx |2 +- sc/source/ui/navipi/content.cxx |2 +- sc/source/ui/view/drawvie4.cxx |6 +++--- sd/source/core/drawdoc3.cxx

dropped unused function FontSelectPattern constructor

2013-01-16 Thread via Code Review
Caolán McNamara has abandoned this change. Change subject: dropped unused function FontSelectPattern constructor .. Patch Set 6: Abandoned this got resolved with the whitelist of stuff to ignore from unusedcode.easy -- To vie

fdo#44664: printer truncates Landscape orientation pages to ...

2013-01-16 Thread via Code Review
Caolán McNamara has abandoned this change. Change subject: fdo#44664: printer truncates Landscape orientation pages to Portrait dimensions .. Patch Set 1: Abandoned this got resolved with the new option to set the default prin

[Libreoffice-commits] .: solenv/bin

2013-01-16 Thread Libreoffice Gerrit user
solenv/bin/modules/installer/windows/idtglobal.pm |1 + 1 file changed, 1 insertion(+) New commits: commit 05923e058a6b90f05c90d5f9aef4de58233a51ac Author: Andras Timar Date: Wed Jan 16 17:16:03 2013 +0100 fdo#59321 un-escape quotes in Windows Installer's idt files Change-Id:

[Libreoffice-commits] .: 3 commits - sfx2/source sw/source

2013-01-16 Thread Libreoffice Gerrit user
sfx2/source/doc/objcont.cxx | 12 sfx2/source/doc/sfxbasemodel.cxx |3 --- sw/source/ui/app/docst.cxx |9 + 3 files changed, 17 insertions(+), 7 deletions(-) New commits: commit 7dc663ec764d569957e0e1758b701dfb8f399647 Author: Michael Stahl Date: Wed J

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#55974 segfault while closing an Impress file

2013-01-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1718 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/1718/1 Resolves: fdo#55974 segfault while closing an Impress file regression since aa1927dc257b52edf96de220cc3797e02c83

[Libreoffice-commits] .: sd/source

2013-01-16 Thread Libreoffice Gerrit user
sd/source/ui/framework/factories/ViewShellWrapper.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit a0d852b2ade42289af1e9b066a48c97aedeff3b1 Author: Caolán McNamara Date: Wed Jan 16 15:54:06 2013 + Resolves: fdo#55974 segfault while closing an Impress file

[Libreoffice-commits] .: sw/source

2013-01-16 Thread Libreoffice Gerrit user
sw/source/core/unocore/unoport.cxx | 21 ++--- sw/source/core/unocore/unoportenum.cxx |4 ++-- sw/source/core/unocore/unosett.cxx | 18 +++--- sw/source/core/unocore/unosrch.cxx |5 ++--- sw/source/core/unocore/unostyle.cxx| 23

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - instsetoo_native/util solenv/inc

2013-01-16 Thread Libreoffice Gerrit user
instsetoo_native/util/openoffice.lst |8 solenv/inc/minor.mk |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 0b2ff7cd759cc9ae3c577aafa06b98d7a3e86278 Author: Andras Timar Date: Wed Jan 16 16:11:57 2013 +0100 Bump for 3.6-6

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - 2 commits - instsetoo_native/inc_openoffice instsetoo_native/util setup_native/source solenv/bin solenv/inc

2013-01-16 Thread Libreoffice Gerrit user
instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt |1 + instsetoo_native/util/openoffice.lst |8 setup_native/source/packinfo/finals_instsetoo.txt |2 +- solenv/bin/make_installer.pl

[PATCH] Resolves fdo#55846 - Font Size list does not display with ve...

2013-01-16 Thread Rushi Shukla (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1717 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/1717/1 Resolves fdo#55846 - Font Size list does not display with vertical Formatting toolbar When the Formatting toolba

Re: REVIEW [4-0-0] [PUSHED 4.0 ] Late Feature: IFERROR and IFNA spreadsheet functions

2013-01-16 Thread Kohei Yoshida
On 01/15/2013 05:41 AM, Jan Holesovsky wrote: Having said that, it is now getting really late in the release cycle, so some more Calc experts approving this from the code point of view would be really appreciated - Noel already had a look, so Kohei, Markus, can you too? I'm stuck in a very har

[PUSHED] add close option to findbar in Writer

2013-01-16 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1557 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1557 To unsubscribe, vi

[Libreoffice-commits] .: icon-themes/galaxy officecfg/registry svx/inc svx/source svx/util sw/uiconfig

2013-01-16 Thread Libreoffice Gerrit user
icon-themes/galaxy/cmd/lc_exitsearch.png |binary officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu | 11 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |8 svx/inc/tbunosearchcontrollers.hxx

Contribution License

2013-01-16 Thread Tadele Assefa
All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. -- Regards,* ___ Tadele Assefa Managing Director* * Cell: +25-911-84-13-84* *Think Green – Please do not print this email unless you really need to* ___

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#59182 make the special character dialog behave

2013-01-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1716 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/1716/1 Resolves: fdo#59182 make the special character dialog behave squashed combo of four commits to fix fdo#59182 Re

[PATCH] Change in core[libreoffice-4-0]: Template Manager: show names on several lines

2013-01-16 Thread Bosdonnat Cedric (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1715 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1715/1 Template Manager: show names on several lines Change-Id: I6990bb6ac52889de36f3ec2cce33e4dc2f3da2ea --- M sfx2/in

[Libreoffice-commits] .: 2 commits - sfx2/inc sfx2/source

2013-01-16 Thread Libreoffice Gerrit user
sfx2/inc/sfx2/templatecontaineritem.hxx | 13 + sfx2/inc/sfx2/thumbnailviewitem.hxx |2 sfx2/source/control/templateabstractview.cxx | 16 ++ sfx2/source/control/templatecontaineritem.cxx | 172 ++ sfx2/source/control/templatelocalview.cxx |

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 David changed: What|Removed |Added Depends on||58730 --- Comment #81 from David --- I nominate

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - svtools/source

2013-01-16 Thread Libreoffice Gerrit user
svtools/source/graphic/grfmgr2.cxx | 317 ++--- 1 file changed, 123 insertions(+), 194 deletions(-) New commits: commit 4a34560c92c6bf9c9e3ab8c5740d3dc720d3be1a Author: Tomaž Vajngerl Date: Mon Jun 25 21:07:06 2012 +0200 n#797967 use only Bitmap scaling a

[PUSHED] Change in core[libreoffice-4-0]: make emailmerge work with python3 and python2 at the same ti...

2013-01-16 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1713 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1713 To unsubscribe, visi

fdo#58919 - Cursor is at Left when Table is converted to RTL...

2013-01-16 Thread gokul s (via Code Review)
gokul s has abandoned this change. Change subject: fdo#58919 - Cursor is at Left when Table is converted to RTL in Impress .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/1525 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - scripting/source

2013-01-16 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.README | 18 +++ scripting/source/pyprov/mailmerge.py | 154 ++- 2 files changed, 110 insertions(+), 62 deletions(-) New commits: commit f1396430d6b075a7ce2eade9629e69297b814ea2 Author: Caolán McNamara Date: Mon Jan 16 18:50

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 --- Comment #80 from Rainer Bielefeld --- Add "Bug 57444 - Wizards for Fax and Letter do not launch", very visible and might affect many users! -- You are receiving this mail because: You are on the CC list for the bug.

[PUSHED] Fixed Undo/Redo buttons icon orientation for RTL languages (...

2013-01-16 Thread Michael Meeks (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1712 Approvals: Michael Meeks: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1712 To unsubscribe, visi

[Libreoffice-commits] .: icon-themes/crystal icon-themes/galaxy icon-themes/hicontrast icon-themes/human icon-themes/industrial icon-themes/oxygen icon-themes/tango

2013-01-16 Thread Libreoffice Gerrit user
icon-themes/crystal/cmd/ar/lc_redo.png|binary icon-themes/crystal/cmd/ar/lc_undo.png|binary icon-themes/crystal/cmd/ar/sc_redo.png|binary icon-themes/crystal/cmd/ar/sc_undo.png|binary icon-themes/crystal/cmd/fa/lc_bold.png|binary ico

Re: Modifying an Impress Template

2013-01-16 Thread Alexander Wilms
Hi Samuel, Wouldn't the commit message suffice to explain the changes? One thing one needs to do before committing is stripping language settings within the file with this script: solenv/bin/striplanguagetags.sh Are you fixing that for the 4.0 branch? I made some improvements to several impress

[PATCH] allow a system python >= 2.6 with --enable-python=system

2013-01-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1714 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/1714/1 allow a system python >= 2.6 with --enable-python=system Change-Id: I861b1740e0cd5057570da91cbc0aca88333155b3 --

[Libreoffice-commits] .: vote/2013-confpoll

2013-01-16 Thread Libreoffice Gerrit user
vote/2013-confpoll/candidates.wml |4 ++-- vote/2013-confpoll/index.wml |2 +- vote/2013-confpoll/rules.wml |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) New commits: commit f732320431a55c9d2d3ca25030ddd86791a56356 Author: Thorsten Behrens Date: Wed Jan 16 13:45

[PATCH] Change in core[libreoffice-4-0]: make emailmerge work with python3 and python2 at the same ti...

2013-01-16 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1713 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1713/1 make emailmerge work with python3 and python2 at the same time squashed single 4-0 backport commit to sync 4-0 m

[PUSHED] fdo#58364 Change Align in View->Toolbar to Align Objects

2013-01-16 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1701 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1701 To unsubscribe, vi

Re: fdo#38838 - Removal/Replacement of the String/UniString with OUString once and for all.

2013-01-16 Thread Jean-Noël Rouvignac
Thanks for all your relevant answers and wiki updates. I understand the goal is to replace String and its variants by OUString. My last remaining question is "what is the use of OString? Where/when is it used in the application?" Thanks, Jean-Noël 2013/1/15 Norbert Thiebaud > On Tue, Jan 15,

[Libreoffice-commits] .: officecfg/registry

2013-01-16 Thread Libreoffice Gerrit user
officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu | 2 +- officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu | 2 +- officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu | 2 +- officecfg/registry/data/org/ope

[Libreoffice-commits] .: 4 commits - cui/source cui/uiconfig svx/inc svx/source

2013-01-16 Thread Libreoffice Gerrit user
cui/source/dialogs/cuicharmap.cxx| 33 ++- cui/source/inc/cuicharmap.hxx|4 + cui/uiconfig/ui/specialcharacters.ui | 27 + svx/inc/svx/charmap.hxx |5 + svx/source/dialog/charmap.cxx| 102 +-- 5 files cha

[Libreoffice-commits] .: Branch 'libreoffice-3-6-5' - instsetoo_native/util solenv/inc

2013-01-16 Thread Libreoffice Gerrit user
instsetoo_native/util/openoffice.lst | 40 +-- solenv/inc/minor.mk |4 +-- 2 files changed, 22 insertions(+), 22 deletions(-) New commits: commit 7ecff83bd228c5d50cba5dec764f2ec6b2a950bf Author: Fridrich Å trba Date: Wed Jan 16 13:01:12 20

[PUSHED] Re: PATCH: For Bug 55732 made available under the MPL/LGPLv3+

2013-01-16 Thread Michael Stahl
On 22/10/12 02:11, Lester Kakol wrote: > I've submitted a patch made available under the MPL/LGPLv3+ for bug > 55732 (https://bugs.freedesktop.org/show_bug.cgi?id=55732). apparently the patch was pushed as e89c99a8ce264173a9d9cbb6df09d7811d6b34cc ___ Li

Re: gb_COMPILERNOOPTFLAGS does not even obey the user passed CFLAGS

2013-01-16 Thread Michael Stahl
On 10/01/13 15:03, Lubos Lunak wrote: > On Thursday 10 of January 2013, Tomáš Chvátal wrote: >> Hi guys, >> >> As written in subject the variable is used on multiple targets and it >> ignores the user defined cflags/cxxflags. >> This should never happen and all our targets should take into effect t

[PUSHED] fdo#54165: Add key replacement names for Estonian (Patch by:...

2013-01-16 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1695 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1695 To unsubscribe, visit h

Change in core[libreoffice-4-0]: docx export: fix regression on table borders export

2013-01-16 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: docx export: fix regression on table borders export .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/1705 To unsubscribe, visit ht

  1   2   >