[PATCH] fdo#39999: Changing spelling preferences requires application restart

2012-04-21 Thread Dézsi Szabolcs
Hi! Bug's page After applying this patch, checking 'Check uppercase words' in options works without restarting LO. It's very simple, a single line, but it took me a while to find the right place to start... :) I hope that the patch is OK. Szabolcs

[PATCH] Removed RTL_CONSTASCII_USTRINGPARAM from UnoControls

2012-04-19 Thread Dézsi Szabolcs
Hi, title says it all. I replaced RTL_CONSTASCII_USTRINGPARAM macros with simple ... literals. Szabolcs From f1c3e6877ecb2471f44221c0c9b49d55d7c04bc5 Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi dezsisz...@hotmail.com Date: Thu, 19 Apr 2012 09:05:43

[PATCH] Removed RTL_CONSTASCII_USTRINGPARAM from animation

2012-04-19 Thread Dézsi Szabolcs
Hi Same for module animation. Szabolcs From be3148a6bfda58b6093b598a7ec17cc6f587b6c3 Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi dezsisz...@hotmail.com Date: Thu, 19 Apr 2012 09:58:41 +0200 Subject: [PATCH] Removed RTL_CONSTASCII_USTRINGPARAM from

[PATCH] Removed RTL_CONSTASCII_(U)STRINGPARAM from avmedia

2012-04-19 Thread Dézsi Szabolcs
Hi! Replaced a few RTL_CONSTASCII... macros in avmedia. Szabolcs From 116fc5e8f22f4234944dacc73b5b489ca27aa694 Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi dezsisz...@hotmail.com Date: Thu, 19 Apr 2012 10:22:50 +0200 Subject: [PATCH] Removed

RE: [PATCH] Removed RTL_CONSTASCII_USTRINGPARAM from animation

2012-04-19 Thread Dézsi Szabolcs
It'd prolly be more useful to work on other things until the re-licensing is done in a couple of months :-) Large scale string changes have the potential to create far more work for me than any win they provide :-) Thanks ! Ok, no problem. :) Szabolcs

Bug 48716: FILESAVE soffice.bin crashed with SIGABRT in os::abort()

2012-04-19 Thread Dézsi Szabolcs
Hi! Actually this gives me SIGSEGV (not SIGABRT) in sw/fmtcntnt.hxx line 60: return (const SwFmtCntnt)Get( RES_CNTNT,bInP); I print out '*this' and it's like this: {SfxItemSet = {_vptr.SfxItemSet = 0x18, _pPool = 0x10001, _pParent = 0x1757920, _aItems = 0x18, _pWhichRanges = 0x10001,

[PATCH] fdo#47436: FILEOPEN: Writer crashes when it opens an odt file produced by JasperReport

2012-04-19 Thread Dézsi Szabolcs
Hi! https://bugs.freedesktop.org/show_bug.cgi?id=47436 Hi! editeng/source/items/frmitems.cxx:1954 1951: for (int n(0); n != SAL_N_ELEMENTS(aBorders); ++n) 1952: { 1953: editeng::SvxBorderLine* pLine = const_cast editeng::SvxBorderLine* ( GetLine( aBorders[n] ) ); 1954:

RE: Question about Bug 33599

2012-04-17 Thread Dézsi Szabolcs
Hi, while working on this bug (33599) I found an issue which causes writer to crash. Here are the steps to reproduce it: 1. Open new writer document. 2. Insert new comment by pressing Ctrl+Alt+C or by selecting Insert/Comment 3. Write 'Test' into the comment. 4. Press Alt+Tab to switch

RE: Question about Bug 33599

2012-04-17 Thread Dézsi Szabolcs
It must be something in my build.. Libreoffice installed on OpenSuSe 12.1 x64 system is OK. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

RE: RTL_CONSTASCII_(U)STRINGPARAM officially obsolete

2012-04-05 Thread Dézsi Szabolcs
if (foo.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(X))) if (foo.equals(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(X can be written as if( foo == X ) This has to be the biggest improvement in OOo/LO codebase readability ever! Incredibly nice! Hi! Yesterday I started

RE: RTL_CONSTASCII_(U)STRINGPARAM officially obsolete

2012-04-05 Thread Dézsi Szabolcs
#if OSL_DEBUG_LEVEL 0 ScNoteCell::~ScNoteCell() { eCellType = CELLTYPE_DESTROYED; } #endif Deleting #if..., compiling, putting #if ... back solved it. Now it gives: http://pastebin.com/VR4cQAxK ___

Question about Bug 33599

2012-04-03 Thread Dézsi Szabolcs
Hi all! Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33599 I think I know where is the problem. In sw/source/ui/docvw/SidebarTxtControl.cxx function SidebarTxtControl::LoseFocus. There's a call for mrSidebarWin.UpdateData(); In this function it checks whether there was any modification

RE: Question about Bug 33599

2012-04-03 Thread Dézsi Szabolcs
I think I know where is the problem. I think I know where the problem is. - Sorry for the mistakes, i don't know why i make them :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Need help in UNO

2012-04-02 Thread Dézsi Szabolcs
Hi all! I'm working on Bug 34423 (more of a feature request). There's this extension called OpenOffice Toolbox on the bug's page. It implements image rotation. I want to port that to C++. I added a menu item to the right click menu of the image (Rotate... - will call a dialog), now it just

RE: Need help in UNO

2012-04-02 Thread Dézsi Szabolcs
Not sure if you noticed that the RotationDescriptor service is deprecated, just in case you plan to spend too much time on it. ;) Yes, I noticed it, I think I have to use Transformation (?). This is just a test to see if I can do it with RotateAngle (like in extension), after that I can use

[PATCH] fdo#84393: Title field displays wrongly in header/footer

2012-03-15 Thread Dézsi Szabolcs
Hi all! I made a patch for this (https://issues.apache.org/ooo/show_bug.cgi?id=84393). It was present in LO too. I hope I did everything right. Just let me know if something is incorrect. Szabolcs From 448af7eaa397bfe2f940c49798667fce99127a16 Mon Sep

RE: Issue with vcl Text Control

2012-03-12 Thread Dézsi Szabolcs
So basically my question is, is there a way to wrap text on a FixedText, or make the background on a MultiLinEdit transparent (or is there a better text control I can use?) Hi! Use SetPaintTransparent( sal_True ); If I remember correctly :) Szabolcs

Question about Bug 40686: Opening the attached file crashes LibreOffice - FILEOPEN

2012-03-08 Thread Dézsi Szabolcs
Hi! Here's the bug's page: https://bugs.freedesktop.org/show_bug.cgi?id=40686 It seems that a division by zero occurs on line 310 in ww8par6.cxx: aGrid.SetLines(writer_castsal_uInt16(nTextareaHeight/nLinePitch)); nLinePitch is 0 here. This causes some doc files to crash LO. Adding a simple if(

[PATCH] fdo#40686: Opening the attached file crashes LibreOffice - FILEOPEN

2012-03-08 Thread Dézsi Szabolcs
Hi! With this small modification files attached here loads correctly. I'm ignoring values which are outside the specification range (1-31680). Szabolcs From 4a17bf3d26fdf75cb504daa41364eeb7fe970e88 Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi

[PATCH] fdo#43424: LO Crashes while Comparing an Empty Document with Another Document

2012-03-08 Thread Dézsi Szabolcs
Hi! There was a call for GetLine( nInsPos-1 ); with nInsPos == 0 so it wanted to return aLines[ nLine ]; where nLine == -1. (vector CompareLine* aLines;) Files: sw/source/core/doc/doccomp.cxx (in SwCompareData::ShowDelete) Szabolcs From

Bug 45522: Crash when copying table between Writer and other LibreOffice programs

2012-03-08 Thread Dézsi Szabolcs
Hi! https://bugs.freedesktop.org/show_bug.cgi?id=45522 There's an attached odt file with a table in it. Copying the table to other LO programs (Calc, etc) causes LO to crash. After inspection I realized that the problem is in sw/source/core/table/swtable.cxx There is a struct definition in

[PATCH] fdo#46728: EDITING: soffice.bin crashed with SIGSEGV in Window::GetCursor()

2012-03-08 Thread Dézsi Szabolcs
Hi! Error is in svx/source/sdr/overlay/overlaymanagerbuffered.cxx 386: Window rWindow = static_cast Window (rmOutputDevice); 387: Cursor* pCursor = rWindow.GetCursor(); Maybe something is with the timing of instructions because there are two lines which are exactly the same, and there works

[PATCH] fdo#46939: Crash after trying to rename autotext entry

2012-03-06 Thread Dézsi Szabolcs
Hi! So... after a long debugging session, I managed to trace the crash all the way from glossary.cxx through gloshdl.cxx-swblock.cxx-shellio.cxx-SwXMLTextBlocks.cxx to storage.cxx. First of all, the crash only happens when I rename an AutoText but set the shortcut to something already existing.

[PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Dézsi Szabolcs
Hi! https://bugs.freedesktop.org/show_bug.cgi?id=33043 I added a new button to Start Center. It exits LibreOffice. I used the attached picture for testing, I'm not a designer :) For testing (or if someone makes a new image if this gets pushed) put the attached image (or the final image)

RE: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Dézsi Szabolcs
what's the purpose of such a button? once you are in the start center you already can close everything simply hitting the X button in the right upper corner. please, understand I'm not criticizing your patch, I'm just curious to know why users would need it. Well, i really don't know

RE: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Dézsi Szabolcs
PS: if the patch is needed, than let me know where to position the button. With the original patch it's positioned right next to the Get more information about LibreOffice button. Maybe it would be better on the right end of the window (between Templates...) Szabolcs

RE: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-04 Thread Dézsi Szabolcs
PS: if the patch is needed, than let me know where to position the button. With the original patch it's positioned right next to the Get more information about LibreOffice button. Maybe it would be better on the right end of the window (between Templates...) I mean under Templates... ;)

[PATCH] fdo#42396: Wizard dropdown does not sort alphabetically

2012-03-03 Thread Dézsi Szabolcs
Hi! Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42396 This is my first hack in Java, so let me know if something is wrong. I tested it, it worked for me. Szabolcs From 19f67b45799639db9549a9aa1f0beac3d4217ed8 Mon Sep 17 00:00:00 2001 From:

[PATCH] fdo#46501: EasyHack: cleanup SimpleResMgr ...

2012-03-02 Thread Dézsi Szabolcs
Hi! I deleted the constructor which uses OUString as suggested here: https://bugs.freedesktop.org/show_bug.cgi?id=46501 Szabolcs From f69fd5cb5e8cbe05a3b87b9b5adfd8494a9a4bab Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi dezsisz...@hotmail.com Date:

[PATCH] fdo#46193: Let the user copy error message from error dialog

2012-03-01 Thread Dézsi Szabolcs
Hi! I already made a patch for this bug, but this is a better solution ( at least i think :) ) I added a 'Copy to Clipboard' button to MessBox, so error messages are now copyable. Here's the bug (there's a screenshot of the patch as well): https://bugs.freedesktop.org/show_bug.cgi?id=46193

[PATCH] fdo#46193: Let the user copy error message from error dialog

2012-02-28 Thread Dézsi Szabolcs
Hello! I created a new class in cui/. : CopyableWarningBox (copywarnbox.hxx and copywarnbox.cxx). This class gets instantiated in cui/source/dialogs/scriptdlg.cxx (last method). I couldn't manage to do the sizing dynamically, so it creates a fix (500*300) dialog. To test the dialog run

RE: [PATCH] Reduced loadtime of autocorrect tables

2012-02-27 Thread Dézsi Szabolcs
great!!! I love you!!! the huge acor_ file you used is mine!!! I'm the one who opened this issue: https://issues.apache.org/ooo/show_bug.cgi?id=101726 Yes, I used that file, hope it's not a problem :) I know that i could generate an xml file with random entries (with a script), but

[PATCH] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-24 Thread Dézsi Szabolcs
Hi all! Started all over again, this patch removes the MSFilterTracer class, which is no longer used, and removes all references to it (in sc, sd and sw) The previous patch is obsolete now. https://bugs.freedesktop.org/show_bug.cgi?id=46166 Szabolcs

[PATCH] Removed unused code from drawinglayer

2012-02-17 Thread Dézsi Szabolcs
Hi, I removed unused function from module drawinglayer. (unusedcode.easy) removed functions: drawinglayer::attribute::FillBitmapAttribute::FillBitmapAttribute() drawinglayer::attribute::Sdr3DLightAttribute::Sdr3DLightAttribute()

[PATCH] Removed unused code from cppcanvas module

2012-02-17 Thread Dézsi Szabolcs
Hi, i removed unused code from cppcanvas module (unusedcode.easy) removed functions: cppcanvas::BaseGfxFactory::createPolyPolygon(boost::shared_ptrcppcanvas::Canvas const, basegfx::B2DPolyPolygon const) const cppcanvas::BaseGfxFactory::createText(boost::shared_ptrcppcanvas::Canvas const,

[PATCH] Removed unused code from MSFilterTracer

2012-02-16 Thread Dézsi Szabolcs
Hi! sry didn't attach file :$ This is my first patch, I hope everything's correct. Removed functions: (used unusedcode.easy) MSFilterTracer::SetProperty(rtl::OUString const, com::sun::star::uno::Any const) MSFilterTracer::StartElement(rtl::OUString const,

License statement

2012-02-16 Thread Dézsi Szabolcs
Hi, I confirm that all my past, present and future contributions to the LibreOffice project are licensed under the MPL / LGPLv3+. Regards Szabolcs Dezsi. ___ LibreOffice mailing list

[PATCH] Removed unused functions from MultiLineEdit in svtools module

2012-02-16 Thread Dézsi Szabolcs
Hi! I removed 4 unused functions from class MultiLineEdit. (based on unusedcode.easy) Functions removed: MultiLineEdit::GetHScrollBar() const MultiLineEdit::GetLeftMargin() const MultiLineEdit::GetTextLines() const MultiLineEdit::IsFocusSelectionHideEnabled() const Files modified:

[PATCH] Removed unused code from svl, svtools and sfx2

2012-02-16 Thread Dézsi Szabolcs
Hi! I removed some unused code from modules svl, svltools and sfx2 according to unusedcode.easy. Removed functions: SfxAppMenuControl_Impl::RegisterControl(unsigned short, SfxModule*) SfxApplication::Main() SfxBrushItemLink::Set(SfxBrushItemLink*) SfxHintPoster::RegisterEvent()

[PATCH] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-16 Thread Dézsi Szabolcs
Hi! I removed the MSFilterTracer class as suggested by Caolán McNamara. Hope it's ok. Szabolcs From 3f02b8043d86341572727b772c934ab7ccb496ec Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi dezsisz...@hotmail.com Date: Thu, 16 Feb 2012 16:11:52 +0100

[PATCH] Removed unused code from vcl module

2012-02-16 Thread Dézsi Szabolcs
Hi! I removed unused code from vcl module (used unusedcode.easy) Removed methods: vcl::LazyDeletorMenu::is_less(Menu*, Menu*) vcl::PDFExtOutDevData::EndGroup() vcl::PDFExtOutDevData::GetFormsFormat() const vcl::PDFExtOutDevData::SetAutoAdvanceTime(unsigned int, int)