Re: Patchtool

2012-03-18 Thread Josh Heidenreich
Hi, That is why I asked if the source was available. The code is now on GitHub. https://github.com/TheJosh/patchtool I'm going to keep working on it some more, and I'm wondering if it should have a more permanent home on an official domain, although I don't know who to talk to about that.

Re: Patchtool

2012-03-17 Thread Josh Heidenreich
Hi, Do you have the source somewhere public ? I was going to make a github project for it. The current codebase is fairly generic and can be used for any mailman mailing list, so I don't see any need for it to be libreoffice only. Of course for it to be truly useful we need LibO-specific

Patchtool

2012-03-16 Thread Josh Heidenreich
Hi everyone, For the last few days I have been working on a tool I call patchtool. Check it out here: http://thejosh.info/libreoffice/patchtool/ It scrapes the mailing-list archives, looking for messages with a subject of [PATCH] or [PUSHED]. Those messages go into a database, and get threaded

[Libreoffice-commits] .: autogen.sh

2012-03-12 Thread Josh Heidenreich
autogen.sh |8 1 file changed, 8 insertions(+) New commits: commit 6635337181c3c3530ceaa2fb49330c2b152107d7 Author: Josh Heidenreich josh.sickm...@gmail.com Date: Tue Mar 13 08:57:16 2012 +1030 Fix authgen.sh to not clobber autogen.lastrun when using --help Fix also

[Libreoffice-commits] .: sal/inc

2012-03-12 Thread Josh Heidenreich
sal/inc/osl/file.hxx | 16 1 file changed, 16 deletions(-) New commits: commit bde32dc95d33943e301bd165955655eb02e1e223 Author: Josh Heidenreich josh.sickm...@gmail.com Date: Tue Mar 13 16:02:18 2012 +1030 Removed FileStatus::isFile. Use ::isRegular instead

Re: Bugfix and improvement for autogen.sh

2012-03-09 Thread Josh Heidenreich
Hey,        I wonder if instead it would be better to special case '--help' in autogen.sh so that if it is detected we don't write it to autogen.lastrun. That is what the code does if I replace system (./help.sh . $ARGV[$pos+1]); in the above code with system (configure --help);

[Libreoffice-commits] .: 2 commits - sal/inc

2012-03-08 Thread Josh Heidenreich
sal/inc/osl/file.hxx | 58 +++ 1 file changed, 58 insertions(+) New commits: commit af5cc38cac0defcfc36796915e13ddd5969a7108 Author: Josh Heidenreich josh.sickm...@gmail.com Date: Thu Mar 8 14:29:23 2012 +1030 sal file.hxx documentation

Re: GSoC error during make

2012-03-08 Thread Josh Heidenreich
Hi, this is a known problem when using make 3.81 and is fixed on master now: http://cgit.freedesktop.org/libreoffice/core/commit/?id=294b86e3dbbdb9b136cb17a51687f4e2762711cf In the commit message for revision 294b86e3dbbd Michael Stahl wrote: This is all quite ugly and should be reverted once

Bugfix and improvement for autogen.sh

2012-03-08 Thread Josh Heidenreich
Hey, I was doing some compiling yesterday, and noticed that autogen.sh --help clobbers your autogen.lastrun. My original thought was to change the code to fix the bug, but then I had an idea - make --help more useful. Thus, my idea is to add this to autogen.sh: my $pos = 0; for my $arg (@ARGV)

Re: GSoC error during make

2012-03-07 Thread Josh Heidenreich
Hi, Just to piggyback this thread, because I am having build errors on master too. Okay, bad news... I still couldn't build LibreOffice :(. It fails in two modules: officecfg and sal. I tried building them separately, with a make clean before that, but I still get errors... I am having

[Libreoffice-commits] .: bin/find-german-comments

2012-03-06 Thread Josh Heidenreich
bin/find-german-comments | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) New commits: commit aedb86399dca3be9c636267104d0893ffc17aca3 Author: Philipp Weissenbacher p.weissenbac...@gmail.com Date: Tue Mar 6 21:48:52 2012 +0100 Add option to only list filenames

Re: [PUSHED][PATCH] Add option to find-german-comments to only list filenames

2012-03-06 Thread Josh Heidenreich
Here's a patch for find-german-comments: This adds the argument -f (--filenames-only), which only prints the filenames of files containing German comments. I personally scan the whole file for German strings anyway, as we do not find German strings with less than 4 chars. So there's not so

Re: [PUSHED 3.5][REVIEW 3.5.1] Fix crash on exit using KDE interface

2012-02-28 Thread Josh Heidenreich
Hi, Needs two more reviews for libreoffice-3-5-1. I don't know much about this code, nor if I have the authority to sign-off, but the patch looks sane to me. Just my 2c. Josh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Most elegant way to disable all BASIC functionality?

2012-02-26 Thread Josh Heidenreich
Tor, I can think of the following approaches now How is the Python/Java code disabled from the codebase? Wouldn't it be best if BASIC could be disabled in the same way (i.e. a autogen option). It might be useful to someone else down the track (not just the iOS project) to be able to disable

[Libreoffice-commits] .: sc/source

2012-02-22 Thread Josh Heidenreich
sc/source/filter/html/htmlexp2.cxx | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) New commits: commit e9d045f0f476c80060a350c08d8b253eaf41c41f Author: Josh Heidenreich josh.sickm...@gmail.com Date: Thu Feb 23 13:00:15 2012 +1030 Translation of German comments

[Libreoffice-commits] .: vcl/aqua vcl/source vcl/unx

2012-02-21 Thread Josh Heidenreich
(+), 39 deletions(-) New commits: commit 936ebcfa4b44a90bdc8789ce7556f1ba3599375c Author: Josh Heidenreich josh.sickm...@gmail.com Date: Tue Feb 21 13:06:11 2012 +1030 EasyHack fdo#46258 Removal of VCL testtool support (-enableautomation option) diff --git a/vcl/aqua/source/app/salinst.cxx b/vcl

[Libreoffice-commits] .: svx/source

2012-02-20 Thread Josh Heidenreich
svx/source/svdraw/svdotextpathdecomposition.cxx | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) New commits: commit 1248e2af6a70c44651b74d2950aeabb64c1c70e7 Author: Josh Heidenreich josh.sickm...@gmail.com Date: Tue Feb 21 09:27:38 2012 +1030 Fixed a possible NULL

Re: Building LibreOffice on Windows

2012-02-20 Thread Josh Heidenreich
Hi Jesus, Tor, *, It can be done, yes. But it requires several months of work from someone who knows what is doing and the result would probably be a nightmare to maintain. Did you go with cmake, a cmake-style solution (something which converted makefiles to VS projects) or manually

Working through cppcheck errors

2012-02-19 Thread Josh Heidenreich
Hi, I decided to begin some work looking through the cppcheck [1] errors. I found a nullPointer in svx/source/svdraw/svdotextpathdecomposition.cxx. Thought I would give the heads up first before commit + push, as Michael said so. Cheers, Josh [1] http://libreoffice.boldandbusted.com/

Re: Building LibreOffice on Windows

2012-02-19 Thread Josh Heidenreich
Hi, Okay so it might be nuts, but has anyone tried creating a native VS solution/projects, which ruins inside the ide? Could one be created cmake style perhaps? Josh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Josh Heidenreich
Thorsten, Stephan, List, nope, it's a manual process that I run every once in a while. Doxygen itself is rather heaviweight, so you really don't want to run that on a server, let alone for every commit. Can it be run standalone, without the rest of doxygen? Could it be run every commit in that

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Josh Heidenreich
hi, So no way to have a (license) comment at the head of a README? Do we need licence blocks in a README? Can we just write the licence in on all pages generated by the script? Also, if you do need a licence block, it can't be the first paragraph of the readme, that's for a summary. Maybe one

[Libreoffice-commits] .: libcdr/README libcmis/README libcroco/README libgsf/README libpng/README librsvg/README libvisio/README

2012-02-13 Thread Josh Heidenreich
b87e6be543b3daf73edb95012b87dbf95a918b95 Author: Josh Heidenreich josh.sickm...@gmail.com Date: Tue Feb 14 12:33:01 2012 +1030 Added READMEs for some library modules which didn't have them diff --git a/libcdr/README b/libcdr/README new file mode 100644 index 000..d3ba94d --- /dev/null +++ b/libcdr/README @@ -0,0 +1,3

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-13 Thread Josh Heidenreich
Thorsten, That stuff is currently generated by a little shell script - I'm not particularly attached to it, and wouldn't mind perl or python there, but php so far is not used throughout the build system, maybe we can avoid it here, too? At any rate, rather ugly conversion of your beautiful

[PATCH] Module READMEs for libs-extern-sys, extensions, extras, postprocess, sdk and testing

2012-02-09 Thread Josh Heidenreich
Hi, These patches are the last of the module READMEs in the copying over from the wiki. It covers the modules from libs-extern-sys, extensions, extras, postprocess, sdk and testing. After this, I'm going to look to see if there is any modules I missed, and fix them, then it should be all

[PATCH] fdo#45117 - Input window to ask if save in docx or odf format looks unequilibrated

2012-02-08 Thread Josh Heidenreich
Hi, This patch fixes the problem listed in the bug. It adjusts the width of the dialog to be wider, if required. This is one of the bugs listed in LibO most annoying bugs 3.5 (fdo#37361), so I guess this patch should go into 3.5 as well. Cheers, Josh

[PATCH] Module READMEs for libs-extern modules

2012-02-08 Thread Josh Heidenreich
Hi, Here is another patch containing READMEs for modules. This one contains all the modules from libs-extern. Cheers, Josh 0001-Added-and-improved-READMEs-for-modules-whihc-used-to.patch Description: Binary data ___ LibreOffice mailing list

[PATCH] Lots of module READMEs; libs-core, libs-gui, components, filter, base, calc

2012-02-07 Thread Josh Heidenreich
Hi, As per my module README porting from wiki and improving project, here are some more patches which add more READMEs. I sent an email yesterday, which seems to be missed, so I have included that patch again. I also did a heap more READMEs, thus why there is five patches instead of just one.

Re: [PATCH] Lots of module READMEs; libs-core, libs-gui, components, filter, base, calc

2012-02-07 Thread Josh Heidenreich
Update: David just pushed 0001-Added-READMEs-for-modules-which-used-to-be-in-libs-c.patch, so don't push it again! On Wed, Feb 8, 2012 at 12:30 PM, Josh Heidenreich josh.sickm...@gmail.com wrote: Hi, As per my module README porting from wiki and improving project, here are some more patches

Re: [PATCH] [PUSHED] Lots of module READMEs; libs-core, libs-gui, components, filter, base, calc

2012-02-07 Thread Josh Heidenreich
David, And I just pushed the whole lot of it. Sweeet. Cool so I'm re-running the tool again at the moment, but it will be done in a couple of minutes. You can see the result here: http://thejosh.info/libreoffice/module_readmes/ Cheers, Josh ___

[PATCH] More READMEs for modules!

2012-02-06 Thread Josh Heidenreich
Hi everyone who cares, Here is a patch for more READMEs for the modules (yay). I'm about 1/3 done with this project now. You can see my progress here: http://thejosh.info/libreoffice/module_readmes/ Cheers, Josh 0001-Added-READMEs-for-modules-which-used-to-be-in-libs-c.patch Description:

Fix for a compile issue I was having in l10ntools (GCC 4.4.3, Ubuntu)

2012-02-05 Thread Josh Heidenreich
Hi, I had some trouble compiling LibO the other day, a syntax error. I found someone had had a similar problem in the list archvies, so I did a fix in the same way they did theirs. Cheers, Josh 0001-Single-line-bugfix-in-l10n-tools-to-fix-compile-on-G.patch Description: Binary data

[PATCH] Some more READMEs

2012-02-05 Thread Josh Heidenreich
Hi all, Here are some more READMEs for the modules. This covers mostly just URE stuff, copied from: http://wiki.documentfoundation.org/Development/Code_Overview It introduces a little bit of syntax (for linking to cgit and urls). Cheers, Josh

My contributions - licence

2012-02-05 Thread Josh Heidenreich
Hi All, So it's clear, I am willing to dual-license all of my past, present and future contributions to LibreOffice under the MPL/LGPLv3+. Cheers, Josh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PUSHED] Some more READMEs

2012-02-05 Thread Josh Heidenreich
Hi,        Nice work, pushed :-) Cool so I've regenerated the docs again: http://thejosh.info/libreoffice/module_readmes/ I guess this should go onto a cron - I'm waiting until cgit is back before setting this up. Cheers, Josh ___ LibreOffice

[PATCH] The first of the READMEs for the modules

2012-02-04 Thread Josh Heidenreich
Hi, This is the first of the READMEs for the modules. They are only short at the moment - copied from the wiki mainly. I've tweaked the syntax a little, although I haven't reflected that in the tool yet. The syntax is going to allow for some basic linking, so will use something wiki-like, and I

Re: [PATCH] The first of the READMEs for the modules

2012-02-04 Thread Josh Heidenreich
Hi Norbert, Thanks for that. Can you please fit you cit config so that your commit are attributed properly ? the attached patch says: From: unknown Josh@George.(none) Sorry I am not on my usual development computer. and finally, try to get a more descriptive/precise commit messages. I

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-03 Thread Josh Heidenreich
Mike, *,        What would be really sexy (apart from getting your script running on a TDF server and linked from the wiki etc. etc.) - would be if we could transfer what little information we have from the Code_Overview into README files. Any chance you could clone the git repo from

New tool for better understanding the codebase, to complement the wiki.

2012-02-02 Thread Josh Heidenreich
Hi, I was bored while waiting for LibO to compile, and I was taking a look at the wiki docs for development. I found a page Code Overview, but it looks really out of date. (http://wiki.documentfoundation.org/Development/Code_Overview). Then I thought maybe I should update it, and then I thought

[Libreoffice] LibreOffice website - maintainer required?

2011-09-07 Thread Josh Heidenreich
Hi All, As some people may have noticed, I have done a little bit of work in LibO recently, and submitted a few patches. Just a quick question. Is there currently a maintainer of the LibO website? I ask because while I do C/C++ programming as a hobby, my occupation involves wbesite programming

Re: [Libreoffice] [PATCH] Bug 34431 - More symbols (crosses, circles) needed for data points in charts

2011-08-30 Thread Josh Heidenreich
Hi Regina, I had the same problem with a patch recently. Did you find a solution? Josh On Wed, Aug 31, 2011 at 7:01 AM, Regina Henschel rb.hensc...@t-online.de wrote: Hi, I have attached a patch to issue https://bugs.freedesktop.org/show_bug.cgi?id=34431, so that you can have a look at

Re: [Libreoffice] Need help to generate patch with git

2011-08-30 Thread Josh Heidenreich
Hi Regina, I'm still learning to use git and need some help. I have made a patch for issue 34431. But after I used the 'commit' command I noticed, that I had to change a file, which needs another 'commit'. Now the command 'format-patch' has produced two files, one for each commit. Is there a

Re: [Libreoffice] [PATCH] Improve the alien save dialog (part one)

2011-08-16 Thread Josh Heidenreich
       By which (I hope) you mean: LGPLv3+/MPL ? :-) Yes, my bad. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-15 Thread Josh Heidenreich
Hi all, @Josh: Just saw the export_format_v3.png -- great! It's in master now - Thanks Caolán! I see this different - although the internal representation of the data model might match (closely) the ODF formath, it is different from the user's point-of-view:      * the document might be

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-12 Thread Josh Heidenreich
I have the third version of the patch. Oops, forgot to attach From 8cea17536d1be944db3e74711e2e0d92594a2d43 Mon Sep 17 00:00:00 2001 From: Josh Heidenreich josh.sickm...@gmail.com Date: Thu, 11 Aug 2011 12:25:48 +0930 Subject: [PATCH] Changes to the alien save dialog This is part one. Part two

Re: [Libreoffice] [PATCH] Improve the alien save dialog (part one)

2011-08-12 Thread Josh Heidenreich
Fantastic, thanks mate. I'll have another one next week with more complicated changes to make it even better so that should be good. Josh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Josh Heidenreich
Josh, thanks for the patch and the screenshot - the latter makes evaluating things for less developers (tm) like myself very quick and easy. No problem Hence, my question whether a semi-automatic extraction of short versions of the file type... I like this idea quite a bit Mmh, although it

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Josh Heidenreich
Hi All, I think, that does not solve the keep problem. The document, the user is working on, _is_ in ODF Format. So saying Switch to ODK Format makes no sense to him. The user relates (or might relate) the button caption not to the target file format but to the source file format. So the

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-11 Thread Josh Heidenreich
Hi All, I have the third version of the patch. See also this screen: http://thejosh.info/libreoffice/export_format_v3.png Is it possible to get this into master? Commit message: Alien save dialog to include format name on save button Licenced under LGPLv3/MPL I'm going to do another one

Re: [Libreoffice] [Libreoffice-ux-advise] Suggestion and patch for Confirmation of save format dialog

2011-08-10 Thread Josh Heidenreich
: Josh Heidenreich josh.sickm...@gmail.com Date: Thu, 11 Aug 2011 12:25:48 +0930 Subject: [PATCH] Changed the alien save dialog to contain the format name on the button This is stage one of a number of changes to improve this dialog. --- sfx2/source/dialog/alienwarn.cxx |7 ++- sfx2/source

Re: [Libreoffice] Suggestion and patch for Confirmation of save format dialog

2011-08-09 Thread Josh Heidenreich
Forwarding this to the ux-advise list, a better forum I think for discussion about such changes I can get a few of the UI designers at work (who are also LO users) to take a look as well. I like Caolán's suggested wording though. Attach the patch anyway :-). Also, what is the easiest way to

[Libreoffice] Suggestion and patch for Confirmation of save format dialog

2011-08-08 Thread Josh Heidenreich
HI, For a long time I have been annoyed at the Are you sure you want to save as a .DOC message, as I find the buttons confusing. I have made some changes, with the button to show the format name. Screenshots: http://thejosh.info/libreoffice/export_format1.png

Re: [Libreoffice] [PATCH] Splash screen fix for multi-head on Linux (bug 33214)

2011-07-20 Thread Josh Heidenreich
Yes that licence is fine ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Splash screen fix for multi-head on Linux (bug 33214)

2011-07-20 Thread Josh Heidenreich
Any specific reason for this construct? +        int i = 0; +        for( ; i n_xinerama_screens; i++ ) Like, why not for( int i = 0; i n_xinerama_screens; i++ ) ?  The splash is in C, not C++, so this wouldn't work there (unless C99 mode is used I think). Yeah it gives the following

[Libreoffice] [PATCH] Splash screen fix for multi-head on Linux (bug 33214)

2011-07-19 Thread Josh Heidenreich
Uses xinerama to get the size of the primary screen 0001-Splash-screen-fix-for-multi-head-on-Linux-bug-33214.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org