Re: Tinderbox failure, W2008R2@16-minimal_build, MASTER, last success: 2012-07-22 13:36:59

2012-07-23 Thread Lubos Lunak
failing again, but I think it's just a side effect. Looks like scp2 needs to be modified too to make this file really only optional. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 in LibreOffice

2012-07-23 Thread Lubos Lunak
with MSVC. It would be quite worth trying that one out with LO. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: C++11 in LibreOffice

2012-07-23 Thread Lubos Lunak
making (well, that also includes one year of just > thinking about it idly with no code), I'm glad I've finally got this one > off my shoulder. :-) > > But no doubt more work is ahead to further optimize this structure. Where's the ben

[Libreoffice-commits] .: Makefile.top

2012-07-22 Thread Lubos Lunak
Makefile.top |1 + 1 file changed, 1 insertion(+) New commits: commit 1ca7d3432c288f86710fff53674a021ef5e8e8ed Author: Luboš Luňák Date: Sun Jul 22 16:48:23 2012 +0200 install-tb target has meanwhile started using the .zip archive too diff --git a/Makefile.top b/Makefile.top index

Tinderbox nightlies broken (was Re: No Win builds?)

2012-07-22 Thread Lubos Lunak
dev-install, but this whole 'build' target looks broken to me. What's the point of building a .msi archive there? Especially now with dev-install that looks completely pointless and it should have its own target. Does somebody understand this perl install cruft? -- Lubos Lunak l

[Libreoffice-commits] .: Makefile.top

2012-07-22 Thread Lubos Lunak
Makefile.top |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1bdb0801eb9315a3f844aa0200f001e667953483 Author: Luboš Luňák Date: Sun Jul 22 16:26:29 2012 +0200 'make build' again generates .msi on windows This is a partial revert of 0ec45dc41dd4

[Libreoffice-commits] .: 2 commits - solenv/gbuild sw/source

2012-07-22 Thread Lubos Lunak
solenv/gbuild/platform/unxgcc.mk |2 ++ sw/source/filter/ww8/docxattributeoutput.cxx |5 - sw/source/filter/ww8/docxexport.cxx |3 --- sw/source/filter/ww8/docxexportfilter.cxx|1 - sw/source/filter/ww8/rtfattributeoutput.cxx |6 -- sw/source/f

Re: [Libreoffice-commits] .: 3 commits - sc/source tubes/inc tubes/Library_tubes.mk tubes/source

2012-07-20 Thread Lubos Lunak
loadComponentFromURL( rStr, "_blank", 0, args ), > +css::uno::UNO_QUERY_THROW ); > +} > +catch ( css::uno::Exception& e ) > +{ > +fprintf( stderr, "exception when loading '%s' !\n", > + rt

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
On Friday 20 of July 2012, Lubos Lunak wrote: > And after all this is done, it should be easier to actually talk about > LO4, because we'll know what the talk is actually about. As for the > technical details (i.e. c) ), we'll need to decide how to handle the > bre

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
On Friday 20 of July 2012, Thorsten Behrens wrote: > Lubos Lunak wrote: > > Hmm. That makes it something we should take into consideration then, but > > that consideration may be quickly over with saying that it's internal API > > and as such we don't care about p

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
On Friday 20 of July 2012, Lubos Lunak wrote: > On Friday 20 of July 2012, Michael Meeks wrote: > > On Fri, 2012-07-20 at 17:20 +0200, Lubos Lunak wrote: > > > Now, if you look at > > > http://wiki.documentfoundation.org/Development/LibreOffice4 , a lot of > > >

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
On Friday 20 of July 2012, Michael Meeks wrote: > On Fri, 2012-07-20 at 17:20 +0200, Lubos Lunak wrote: > > Now, if you look at > > http://wiki.documentfoundation.org/Development/LibreOffice4 , a lot of > > the stuff there does not belong to the page at all, as it has absolut

Re: Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
u ages to get anywhere near to what LibreOffice is now. I didn't mention it explicitly, but since this is a development list, I expect discussion about what _realistically_ can be done. If you want just to post some random unfounded ideas on which you are not going to actually work, ple

Changes needed for "LibreOffice 4"

2012-07-20 Thread Lubos Lunak
what we expect from "LibreOffice4" (how much we are actually going to change, how much we care about extensions, etc.). So for that, we should first decide on what "LibreOffice4" will mean. Summary: - it needs to be said what we expect from "LibreOffice4" - the wiki p

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 3 commits - sw/source writerfilter/source

2012-07-19 Thread Lubos Lunak
sw/source/filter/ww8/rtfattributeoutput.cxx | 10 -- sw/source/filter/ww8/rtfattributeoutput.hxx |5 + sw/source/filter/ww8/rtfexport.cxx|4 +++- writerfilter/source/dmapper/DomainMapper_Impl.cxx |3 ++- writerfilter/source/rtftok/rtfdocumentim

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2012-07-19 Thread Lubos Lunak
writerfilter/source/rtftok/rtfdocumentimpl.cxx |4 +++- writerfilter/source/rtftok/rtfdocumentimpl.hxx |2 +- writerfilter/source/rtftok/rtfsdrimport.cxx| 10 ++ 3 files changed, 10 insertions(+), 6 deletions(-) New commits: commit 0c1de6d3d6320f91770967d1b23c8dd57d168fe7 Au

Re: [REVIEW: 3-6 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread Lubos Lunak
On Thursday 19 of July 2012, David Tardon wrote: > On Thu, Jul 19, 2012 at 02:36:48PM +0200, Lubos Lunak wrote: > > On Thursday 19 of July 2012, David Tardon wrote: > > > Hi all, > > > > > > commit 859018061956b1937c7be3809a9858cbd610fa9c fixes yet another

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-07-19 Thread Lubos Lunak
sw/source/core/fields/authfld.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 48d61f4ad1eb4f8a031e65c3fcbebc5023d600e9 Author: David Tardon Date: Thu Jul 19 14:00:55 2012 +0200 fdo#52241 remove just one entry Change-Id: Ida7920c3196105f7f8aab

Re: [REVIEW: 3-6-0] fdo#55241 updating of indexes is broken

2012-07-19 Thread Lubos Lunak
n't done anything more than this +1. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: sorted_vector, constness, pointers, and structs

2012-07-19 Thread Lubos Lunak
On Thursday 19 of July 2012, Stephan Bergmann wrote: > On 07/18/2012 08:09 PM, Lubos Lunak wrote: > > What you want is broken. It is definitely broken from the theoretical > > point of view, since modifying the items may change the sort order. > > While one can argue

Re: sorted_vector, constness, pointers, and structs

2012-07-19 Thread Lubos Lunak
On Wednesday 18 of July 2012, Noel Grandin wrote: > On Wed, Jul 18, 2012 at 8:09 PM, Lubos Lunak wrote: > > You didn't read further than that part above, did you? > > > > What you want is broken. It is definitely broken from the theoretical > > point of vie

Re: sorted_vector, constness, pointers, and structs

2012-07-18 Thread Lubos Lunak
On Wednesday 18 of July 2012, Noel Grandin wrote: > On Wed, Jul 18, 2012 at 7:23 PM, Lubos Lunak wrote: > > But it is correct that you get an error in the second case and you > > ideally should be getting one in the first case as well. You cannot > > modify the elements

Re: sorted_vector, constness, pointers, and structs

2012-07-18 Thread Lubos Lunak
se with a pointer is flagged as an error as well, I think a template specialization should be able to handle it (I think I can do that if it's too much of voodoo magic for you). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] .: 3 commits - basctl/source chart2/source cppcanvas/source cui/source dbaccess/source editeng/source filter/source framework/source package/source reportdesign/source scp2/s

2012-07-18 Thread Lubos Lunak
of the data Isn't sal_uLong deprecated? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

FYI: Using the Clang compiler

2012-07-17 Thread Lubos Lunak
y a big part are political reasons (BSD-like license). PS: In case you'll ever feel like posting a patch to the Clang mailing list, be warned that they can be really anal about details and may have no problem with holding your patch just because of silly details like temporary

[PUSHED 3-6] Re: [REVIEW 3-6] fdo#51957 opentype emdash exported to pdf as endash

2012-07-17 Thread Lubos Lunak
0d2778397 >b6b08583149e39022e692 > > proposing for 3-6 as payback for the qa-volunteering time the reporter > puts in :-) Looks ok, pushed to 3-6. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/source

2012-07-17 Thread Lubos Lunak
vcl/source/fontsubset/cff.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 733d07a79a46a551e1eba443a81f3cc851d4cb25 Author: Caolán McNamara Date: Tue Jul 17 16:20:43 2012 +0100 Resolves: fdo#51957 typo, endash entered twice, 2nd should be emdash A

Re: Code documentation - doxygen

2012-07-17 Thread Lubos Lunak
that > > which would be great to change to > > int m_nSomething; //< this counts this and that That is actually not doxygen markup either, it should be ///< . See http://wiki.documentfoundation.org/Development/Doxyg

Re: C++11 in LibreOffice

2012-07-17 Thread Lubos Lunak
gating ctors, are not there at all. So, as long as we require to build LO with MSVC, we can revisit the question of hard-depending on C++11 in, uhm, let's be optimistic and say 3 years. IOW, we can probably get there faster by ditching backwards ABI compatibility with LO4 and switching

[Libreoffice-commits] .: RepositoryExternal.mk

2012-07-16 Thread Lubos Lunak
RepositoryExternal.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e13cda114264670413fe9f799491266b99601df3 Author: Luboš Luňák Date: Mon Jul 16 21:50:59 2012 +0200 fix --with-system-openldap Change-Id: Ifb70bf8277659b942ef05f55f483e1407814958f

[Libreoffice-commits] .: configmgr/source framework/inc framework/source sd/source vcl/unx xmloff/inc xmloff/source

2012-07-16 Thread Lubos Lunak
configmgr/source/components.cxx |2 +- framework/inc/services/frameloaderfactory.hxx|2 +- framework/source/inc/loadenv/targethelper.hxx|4 ++-- framework/source/services/substitutepathvars.cxx |2 +- sd/source/filter/ppt/pptinanimations.cxx |4

[Libreoffice-commits] .: cppuhelper/CppunitTest_cppuhelper_checkapi.mk cppuhelper/CustomTarget_cppuhelper_allheaders.mk

2012-07-16 Thread Lubos Lunak
cppuhelper/CppunitTest_cppuhelper_checkapi.mk| 24 +++ cppuhelper/CustomTarget_cppuhelper_allheaders.mk | 22 ++--- 2 files changed, 23 insertions(+), 23 deletions(-) New commits: commit 437dc5384985c97d6b59e91ab5280a840a387731 Author: Luboš Luňák D

Re: Automatic using ::rtl::OUString etc.

2012-07-16 Thread Lubos Lunak
On Thursday 12 of April 2012, Lubos Lunak wrote: > Hello, > > would somebody see a problem with this? > > sal/inc/rtl/ustring.hxx : > +#ifdef RTL_AUTOMATIC_USING > +using ::rtl::OUString; > +using ::rtl::OStringToOUString; > +using ::rtl::OUStringToOString; > +#endi

[Libreoffice-commits] .: 2 commits - cppu/CppunitTest_cppu_checkapi.mk cppu/CustomTarget_cppu_allheaders.mk cppuhelper/CppunitTest_cppuhelper_checkapi.mk cppuhelper/CustomTarget_cppuhelper_allheaders.

2012-07-16 Thread Lubos Lunak
cppu/CppunitTest_cppu_checkapi.mk| 55 +++ cppu/CustomTarget_cppu_allheaders.mk | 49 cppu/Module_cppu.mk |2 cppu/qa/checkapi/strings.cxx | 30 cppuhelper/

Re: Code documentation

2012-07-16 Thread Lubos Lunak
ce is headers. See also https://wiki.documentfoundation.org/Development/Doxygen . -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Question about OUString::compareToAscii

2012-07-13 Thread Lubos Lunak
> - more meaningful > - doing some ! on sal_Int32 is not as clean as using sal_Bool directly Yes, except again, just == will do. > Do you think that such a clean-up is interesting ? Yes, if it's interesting to you to do it :). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 2 commits - sw/qa

2012-07-13 Thread Lubos Lunak
sw/qa/extras/README | 19 +++ sw/qa/extras/ooxmlexport/ooxmlexport.cxx |4 - sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 75 +-- sw/qa/extras/swmodeltestbase.hxx | 35 ++ sw/qa/extras/ww8export/ww8export.cxx |

[Libreoffice-commits] .: sw/qa

2012-07-13 Thread Lubos Lunak
sw/qa/extras/ooxmlexport/data/empty.odt |binary sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 15 +++ 2 files changed, 15 insertions(+) New commits: commit d74b14892486a401682a2b33cd12812354220e59 Author: Luboš Luňák Date: Fri Jul 13 19:20:06 2012 +0200 testcase for the re

[REVIEW 3-6] Use paragraph's numbering if explicitly specified (.docx)

2012-07-13 Thread Lubos Lunak
PROP_NUMBERING_RULES is set for the paragraph. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW 3-6] Do not write default tab stop as custom in .docx

2012-07-13 Thread Lubos Lunak
Hello, can somebody please backport http://cgit.freedesktop.org/libreoffice/core/commit/?id=15af925c25 to 3-6? It's consistent with what the RTF export does and otherwise the default style ends up with a custom tab stop. -- Lubos Lunak l.lu...@su

[Libreoffice-commits] .: 2 commits - sw/source

2012-07-13 Thread Lubos Lunak
sw/source/filter/ww8/docxattributeoutput.cxx |7 ++- sw/source/filter/ww8/docxexport.cxx |6 ++ sw/source/filter/ww8/docxexport.hxx |5 +++-- sw/source/filter/ww8/wrtww8.hxx |2 +- sw/source/filter/ww8/ww8atr.cxx |2 +- 5 file

[Libreoffice-commits] .: sw/qa

2012-07-13 Thread Lubos Lunak
sw/qa/extras/odftok/data/empty-svg-family-name.odt |binary sw/qa/extras/odftok/odftok.cxx |8 2 files changed, 8 insertions(+) New commits: commit f7f4e9a823adc20cb4136d7ff6f83b943f23b3b6 Author: Luboš Luňák Date: Fri Jul 13 16:06:56 2012 +0200 add tes

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - xmloff/source

2012-07-13 Thread Lubos Lunak
xmloff/source/style/fonthdl.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit 0054c76b0f3d5bdbaef73a696ce3cf930be9c16b Author: Luboš Luňák Date: Fri Jul 13 15:15:57 2012 +0200 fix a crash with empty string If it's named nLast, then it's sup

[Libreoffice-commits] .: xmloff/source

2012-07-13 Thread Lubos Lunak
xmloff/source/style/fonthdl.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit fc508908f55cc1fe5a22adcba710cebb75fc979c Author: Luboš Luňák Date: Fri Jul 13 15:15:57 2012 +0200 fix a crash with empty string If it's named nLast, then it's sup

[Libreoffice-commits] .: 3 commits - sw/qa writerfilter/source

2012-07-11 Thread Lubos Lunak
sw/qa/extras/ooxmltok/data/numbering1.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx | 58 +++ writerfilter/source/dmapper/DomainMapper.cxx | 29 +++-- 3 files changed, 74 insertions(+), 13 deletions(-) New commits: commit 794caa58a7208921ad8f911d

Re: [HELP] fdo#51239 how to debug "it is slow"

2012-07-11 Thread Lubos Lunak
st does it and reports > findings in the bug? I have no idea how Callgrind handles Java. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: issue with HelpLinker (Bus Error, core dumped)

2012-07-10 Thread Lubos Lunak
gt; #11 0x000801d44040 in ?? () > #12 0x7fff0005 in ?? () > #13 0x000f in ?? () > #14 0x in ?? () Try running it in valgrind in gdb manually. Other than that, you use a development snapshot of gcc, so this is not very likely a LibreOffice

Re: [PATCH] Build problem.

2012-07-09 Thread Lubos Lunak
#include > #include > +#include > > #include "oox/helper/propertyset.hxx" > #include "oox/core/xmlfilterbase.hxx" > > Regards. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Question about calling a method with a default parameter

2012-07-09 Thread Lubos Lunak
ot; which is not what it is. The first case is also not exactly intuitive, but at least the 0 there is a hint. IMO the proper fix would be to remove the default value (which we can't do until 4.0 because that'd break backwards compatibility) and introduce OUString::startsWith() (which

Re: Bogus call to OUString::matchAsciiL in /framework/source/lomenubar/MenuItemStatusListener.cxx ?

2012-07-09 Thread Lubos Lunak
ant ? > > Yes, it is. No, not anymore. The AsciiL variants and RTL_CONSTASCII_(U)STRINGPARAM macros are obsolete, with string literals it is now possible to use the "normal" version of the function. IOW, oULabel.matchAsciiL ("private:", 8, 0) is now best written simply as oULabel.match("private:", 0) . -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: connectivity/source

2012-07-04 Thread Lubos Lunak
connectivity/source/drivers/postgresql/pq_allocator.hxx |6 -- connectivity/source/drivers/postgresql/pq_common.hxx| 41 2 files changed, 2 insertions(+), 45 deletions(-) New commits: commit bd493f15a5d9478739368e48f598d2cd7ed4ea30 Author: Luboš Luňák Date: Wed Ju

[Libreoffice-commits] .: solenv/gbuild

2012-07-04 Thread Lubos Lunak
solenv/gbuild/platform/WNT_INTEL_MSC.mk |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit c42a8d41afbd8c49b68046eeb8480e04d4f072c4 Author: Luboš Luňák Date: Wed Jul 4 18:22:36 2012 +0200 use -nologo with other MSVC build tools too Except for no

[Libreoffice-commits] .: canvas/source cui/source filter/source framework/source sd/source sfx2/source svtools/source svx/source toolkit/source vcl/inc vcl/source

2012-06-22 Thread Lubos Lunak
canvas/source/vcl/canvasbitmaphelper.cxx |2 +- canvas/source/vcl/canvashelper.cxx |2 +- cui/source/dialogs/cuigrfflt.cxx |2 +- filter/source/graphicfilter/eps/eps.cxx|2 +- fr

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - canvas/source cui/source filter/source framework/source sd/source sfx2/source svx/source toolkit/source vcl/inc vcl/source

2012-06-22 Thread Lubos Lunak
canvas/source/vcl/canvasbitmaphelper.cxx |2 +- canvas/source/vcl/canvashelper.cxx |2 +- cui/source/dialogs/cuigrfflt.cxx |2 +- filter/source/graphicfilter/eps/eps.cxx|2 +- fr

[Libreoffice-commits] .: 9 commits - svtools/inc svtools/source

2012-06-22 Thread Lubos Lunak
svtools/inc/svtools/grfmgr.hxx |4 svtools/source/filter/wmf/enhwmf.cxx |8 svtools/source/filter/wmf/winwmf.cxx |2 svtools/source/graphic/grfcache.cxx | 312 +-- svtools/source/graphic/grfmgr2.cxx | 271 +++--- 5 f

Re: Precompiled headers?

2012-06-20 Thread Lubos Lunak
On Wednesday 20 of June 2012, Norbert Thiebaud wrote: > On Tue, Jun 19, 2012 at 7:32 AM, Lubos Lunak wrote: > >[...] PCH with > > MSVC avoid the performance hit of using many -I options (adding -I for > > each /inc adds 25% time for whatever reason, but only without > &g

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-06-20 Thread Lubos Lunak
On Wednesday 20 of June 2012, Bjoern Michaelsen wrote: > On Wed, Jun 20, 2012 at 02:55:53PM +0200, Lubos Lunak wrote: > > If you don't want people to miss important information, you need to > > announce it properly and not as some offhand remark. > > A mail with "

Re: Precompiled headers?

2012-06-20 Thread Lubos Lunak
On Tuesday 19 of June 2012, Bjoern Michaelsen wrote: > On Tue, Jun 19, 2012 at 02:32:23PM +0200, Lubos Lunak wrote: > > does somebody know why support for precompiled headers has been removed > > from LibreOffice? > > So back in the days: > - lack of an insanely fast wi

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-06-20 Thread Lubos Lunak
On Tuesday 19 of June 2012, Bjoern Michaelsen wrote: > On Tue, Jun 19, 2012 at 05:04:58PM +0200, Lubos Lunak wrote: > > Which is the problem. Besides asking just to do that it should have also > > said why one should do that. I'm one of the people who haven't done that, &

Re: [Libreoffice-commits] .: sw/source

2012-06-20 Thread Lubos Lunak
"Wrong TxtFlyCnt-Hint." ); > -const_cast(pHnt->GetFlyCnt()).SetFlyFmt(); > +if (pHnt) > +const_cast(pHnt->GetFlyCnt()).SetFlyFmt(); I think this is a sign of internal inconsiste

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-06-19 Thread Lubos Lunak
urprised people who actually had a look at what is coming before. Sorry, but I think you got this backwards. If we run out of smart unsurprised people to look at what's coming, it's not coming. Simple as that. Tools are there for people, not people for tools. > So I guess the lesson is

[REVIEW-3-5-5] Use after delete in oox

2012-06-19 Thread Lubos Lunak
x27;t feel confident enough about the rewrite for a backport at this point, so the patch is just a band-aid. The current 3-5 code has a use-after-delete problem caused by the fact that it's not possible to take out a pointer out of a shared_ptr based container. -- Lubos Lunak l.lu...@su

Precompiled headers?

2012-06-19 Thread Lubos Lunak
reason, but only without PCH). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: vcl/source

2012-06-19 Thread Lubos Lunak
vcl/source/gdi/outdev2.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit ad08216f8f489ad36c8def71ae4f27a64d89 Author: Luboš Luňák Date: Tue Jun 19 13:47:42 2012 +0200 match properly the type in the extern declaration Change-Id: Iaad

[Libreoffice-commits] .: sw/qa

2012-06-19 Thread Lubos Lunak
sw/qa/extras/ooxmltok/ooxmltok.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1eb52e99b1bb20616d91142e71f6e535bb8eb13f Author: Luboš Luňák Date: Tue Jun 19 12:12:23 2012 +0200 treat for tinderbox with obsolete gcc and -Werror *sigh* diff --git a/sw/qa

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 3 commits - oox/inc oox/source

2012-06-19 Thread Lubos Lunak
oox/inc/oox/vml/vmlshapecontainer.hxx| 31 --- oox/source/shape/ShapeContextHandler.cxx | 13 - oox/source/vml/vmlshapecontainer.cxx | 22 +- 3 files changed, 53 insertions(+), 13 deletions(-) New commits: commit a8d062de88

[Libreoffice-commits] .: 6 commits - oox/inc oox/source svtools/source sw/qa vcl/source writerfilter/source

2012-06-19 Thread Lubos Lunak
oox/inc/oox/vml/vmlshapecontainer.hxx | 21 ++-- oox/source/shape/ShapeContextHandler.cxx | 13 +++- oox/source/vml/vmlshapecontainer.cxx | 22 - svtools/source/graphic/grfmgr2.cxx|7 ++ sw/

Re: probabilistic approach to tinderboxing

2012-06-14 Thread Lubos Lunak
ich are needed anyway (for direct commits, some other seemingly unrelated commit breaking the patch meanwhile, etc.). [*] Speaking of which, when will we get told about this gerrit thing, besides random remarks, or have I missed it? -- Lubos Lunak l.lu...@suse.cz _

[PUSHED-3-5]Re: [REVIEW-3-5] Re: [PUSHED][3-5] Re: [REVIEW-3-5] MSVC stl usage.

2012-06-12 Thread Lubos Lunak
blem? > > no, because there's no iterator involved: back() returns a reference to > the value_type. It technically could, by checking in every method that can invalidate references that the passed argument is not such a reference (to one of the elements). -- Lubos Lunak l.lu...@suse.

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sdext/source xmloff/source

2012-06-12 Thread Lubos Lunak
sdext/source/pdfimport/test/tests.cxx |3 ++- sdext/source/pdfimport/tree/pdfiprocessor.cxx |3 ++- xmloff/source/core/DomExport.cxx |3 ++- xmloff/source/text/txtlists.cxx |9 ++--- 4 files changed, 12 insertions(+), 6 deletions(-) New commi

[Libreoffice-commits] .: 2 commits - oox/source sw/qa

2012-06-11 Thread Lubos Lunak
oox/source/vml/vmlshape.cxx| 15 --- sw/qa/extras/ooxmltok/ooxmltok.cxx |5 + 2 files changed, 17 insertions(+), 3 deletions(-) New commits: commit 0016757efef898205452a586ba5927e5d11fdabe Author: Luboš Luňák Date: Fri Jun 8 19:31:32 2012 +0200 attempt to

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - oox/inc oox/source

2012-06-08 Thread Lubos Lunak
oox/inc/oox/vml/vmlformatting.hxx |5 +++-- oox/source/vml/vmlformatting.cxx |3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) New commits: commit 069bf1bd90142c6cde41e5fefdb99a275bf798a1 Author: Luboš Luňák Date: Thu Jun 7 18:10:20 2012 +0200 handle f suffix (1/65536th

[Libreoffice-commits] .: 2 commits - configure.in oox/inc oox/source

2012-06-08 Thread Lubos Lunak
configure.in |6 ++ oox/inc/oox/vml/vmlformatting.hxx |5 +++-- oox/source/vml/vmlformatting.cxx |3 +++ 3 files changed, 8 insertions(+), 6 deletions(-) New commits: commit 106d638e6cd4dceffc0aa98a7772d69488ae0a39 Author: Luboš Luňák Date: Fri Jun 8 16

[Libreoffice-commits] .: 3 commits - oox/source sw/qa sw/source

2012-06-07 Thread Lubos Lunak
oox/source/vml/vmlshape.cxx |4 ++ sw/qa/extras/ooxmltok/data/n764745-alignment.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx| 19 + sw/source/core/unocore/unodraw.cxx| 31 ++ 4 files changed, 44 inser

Incorrect OSL_ENSURE -> SAL_WARN_IF conversions (Re: [Libreoffice-commits] .: sw/source)

2012-06-06 Thread Lubos Lunak
to be false and warns on true. On Wednesday 06 of June 2012, Lubos Lunak wrote: > sw/source/core/unocore/unodraw.cxx | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > New commits: > commit dfc4832049c140b7442c085062599aef1953e8fd > Author: L

[Libreoffice-commits] .: sw/source

2012-06-06 Thread Lubos Lunak
sw/source/core/unocore/unodraw.cxx | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) New commits: commit dfc4832049c140b7442c085062599aef1953e8fd Author: Luboš Luňák Date: Wed Jun 6 18:17:50 2012 +0200 fix incorrect OSL_ENSURE -> SAL_WARN_IF conversion (conditi

[Libreoffice-commits] .: embedserv/Library_emser.mk

2012-06-06 Thread Lubos Lunak
embedserv/Library_emser.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 34dfde55762e48e174f04895d40b9f08918efc4a Author: Luboš Luňák Date: Wed Jun 6 12:42:06 2012 +0200 fix linking after 0fcd1a73f0e1ec564f3c6da1ccd890183d3c18db diff --git a/embedserv/Library_emser.mk b

[Libreoffice-commits] .: glib/makefile.mk

2012-06-05 Thread Lubos Lunak
glib/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4cf7551c24f5dad694fecbb2b80b2b52173ffdb7 Author: Luboš Luňák Date: Tue Jun 5 12:02:39 2012 +0200 correct path to dirent.h for win32 glib build diff --git a/glib/makefile.mk b/glib/makefile.mk

Re: [PUSHED][REVIEW-3.5] Various .doc/.docx fixes

2012-06-04 Thread Lubos Lunak
On Thursday 31 of May 2012, Caolán McNamara wrote: > On Wed, 2012-05-30 at 18:38 +0200, Lubos Lunak wrote: > > > - http://cgit.freedesktop.org/libreoffice/core/commit/?id=04d600d4be7c > > > - http://cgit.freedesktop.org/libreoffice/core/commit/?id=5935a6db6483 > > >

[Libreoffice-commits] .: config_host.mk.in solenv/gbuild

2012-06-04 Thread Lubos Lunak
config_host.mk.in |1 - solenv/gbuild/platform/WNT_INTEL_MSC.mk |3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit b6526cfa9070c5b9734c92ca20f16b16807b1031 Author: Luboš Luňák Date: Mon Jun 4 16:40:51 2012 +0200 do not export INCLU

Re: 1.6Gb of workdir/.../Dep - thoughts ...

2012-06-04 Thread Lubos Lunak
50% or possibly even more) - a significant part of .d content is the depend-on-nothing deps created by -MP , if those would be merged into one dedicated .d file that'd save a lot of space as well; not sure if this is easily doable though -- Lubos Lunak l.lu...@suse.cz __

Re: [REVIEW-3.5] Various .doc/.docx fixes

2012-05-30 Thread Lubos Lunak
On Wednesday 30 of May 2012, Lubos Lunak wrote: > Hello, > > could somebody please review and pick for 3-5 the following changes from > master? They all have nice descriptive commit messages and testcases in > sw/qa/extras :) . > > - http://cgit.freedesktop.org/libreo

[REVIEW-3.5] Various .doc/.docx fixes

2012-05-30 Thread Lubos Lunak
) - the attached 0001-fix-UNO-ZOrder.patch, which is commits http://cgit.freedesktop.org/libreoffice/core/commit/?id=e05e77f4b737 and http://cgit.freedesktop.org/libreoffice/core/commit/?id=9365a3255875 merged Thanks. -- Lubos Lunak l.lu...@suse.cz From 9b909c372cd1e214a723aaae42bc3a0597ca5f86

Re: potentially dead code in "sw/source/core/undo/undel.cxx"?

2012-05-30 Thread Lubos Lunak
ached to anything, it is there just to limit the scope and lifetime of the aPos variable. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: feature/gbuild_merge needs testing

2012-05-30 Thread Lubos Lunak
On Wednesday 30 of May 2012, Noel Grandin wrote: > Hi > > I'm still having issues building on Windows with cygwin. Build error log > attached. The "invalid argument 'long -I list'" error is probably again the annoying command line argument length limitatio

[Libreoffice-commits] .: oox/source

2012-05-29 Thread Lubos Lunak
oox/source/shape/ShapeContextHandler.cxx | 26 -- oox/source/shape/ShapeContextHandler.hxx |2 -- 2 files changed, 28 deletions(-) New commits: commit 099198a4224778fe6e43f5dc13b5b9b1b4dc828c Author: Luboš Luňák Date: Tue May 29 17:49:17 2012 +0200 Revert

[Libreoffice-commits] .: i18npool/source

2012-05-29 Thread Lubos Lunak
i18npool/source/isolang/mslangid.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 8979193090f085d5d171a6daa6f8fa4a188b3130 Author: Luboš Luňák Date: Tue May 29 16:24:14 2012 +0200 Revert "fdo#45830: Indicate correct default locale setting" T

Re: Advice needed about some cppcheck reports

2012-05-29 Thread Lubos Lunak
} > > 271 nRetValue /= 65536; > > also makes sense This is not the same, it looks more to me like it should be 'nRetValue = -nRetValue;' to negate the value, especially given the abs() above. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [PUSHED] disable unit tests wich depend on xmlsec was: sc filter test failures

2012-05-29 Thread Lubos Lunak
perimental) option that leads to breakage is still broken even if it's documented. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 4 commits - filter/inc filter/source oox/source sw/qa sw/source

2012-05-28 Thread Lubos Lunak
filter/inc/filter/msfilter/msdffimp.hxx |2 + filter/source/msfilter/msdffimp.cxx | 20 +-- oox/source/vml/vmlshape.cxx |6 ++--- oox/source/vml/vmlshapecontext.cxx |9 sw/qa/extras/ww8tok/data/n757118.doc|binary sw/qa/extras/ww8tok/

Re: Question about filter/source/msfilter/msdffimp.cxx

2012-05-28 Thread Lubos Lunak
und statement (i.e. block), just like any other. The only difference is that this one is not attached to anything but it's standalone. Its purpose seems to be to limit the scope for the xObjStg variable. And yes, it should be a cppcheck bug. -- Lubos Lunak l.lu...@suse.cz __

[Libreoffice-commits] .: 4 commits - sw/qa sw/source writerfilter/source

2012-05-24 Thread Lubos Lunak
sw/qa/extras/ooxmltok/data/n652364.docx |binary sw/qa/extras/ooxmltok/data/n750255.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx | 88 +++- sw/qa/extras/ww8tok/data/n652364.doc|binary sw/qa/extras/ww8tok/data/n750255.doc|binary sw/qa

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-24 Thread Lubos Lunak
p; a concrete proposal for the ESC call on Thursday ? I don't see the point, at least now. The thread is going on (and it's far from endless), because there is something to talk about, and it's mostly about the smaller things which wouldn't be reasonably handled within few m

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-24 Thread Lubos Lunak
On Tuesday 22 of May 2012, Stephan Bergmann wrote: > On 05/22/2012 04:02 PM, Lubos Lunak wrote: > > On Tuesday 22 of May 2012, Stephan Bergmann wrote: > >> On 05/22/2012 03:19 PM, Lubos Lunak wrote: > >>>But --enable-debug also enables asserts, logging and si

Re: build time optimization

2012-05-24 Thread Lubos Lunak
-system-foo hassle Implementing your suggestion is possibly more work than any of these. [1] http://lists.freedesktop.org/archives/libreoffice/2012-April/030645.html [2] http://lists.freedesktop.org/archives/libreoffice/2012-April/030897.html -- Lubos Lunak l.lu...@suse.cz ___

[Libreoffice-commits] .: 3 commits - sw/qa sw/source

2012-05-23 Thread Lubos Lunak
sw/qa/extras/ooxmltok/data/n747461.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx | 36 +++ sw/source/core/unocore/unoframe.cxx |4 ++- sw/source/filter/ww8/docxattributeoutput.cxx | 24 -- 4 files changed, 50 insertions(+),

[Libreoffice-commits] .: sw/qa

2012-05-22 Thread Lubos Lunak
sw/qa/extras/ooxmltok/ooxmltok.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7e656661684669b6d34d3f813d53fad9d9ffd047 Author: Luboš Luňák Date: Tue May 22 22:32:28 2012 +0200 ++I_hate_sal_Int32 Change-Id: Id6943713ade8a77f3f72aabf2e746358

[Libreoffice-commits] .: 3 commits - oox/inc oox/source sw/qa writerfilter/inc writerfilter/source

2012-05-22 Thread Lubos Lunak
oox/inc/oox/vml/vmlshapecontainer.hxx |6 +-- oox/source/shape/ShapeContextHandler.cxx |5 --- oox/source/vml/vmlshapecontainer.cxx | 11 --- sw/qa/extras/ooxmltok/data/n705956-2.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cx

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-22 Thread Lubos Lunak
On Tuesday 22 of May 2012, Stephan Bergmann wrote: > On 05/22/2012 03:19 PM, Lubos Lunak wrote: > > On Monday 21 of May 2012, Stephan Bergmann wrote: > >> On 05/21/2012 05:10 PM, Lubos Lunak wrote: > >>> On Friday 18 of May 2012, Stephan Bergmann wrote: > >&g

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-22 Thread Lubos Lunak
On Friday 18 of May 2012, Michael Stahl wrote: > On 16/05/12 15:09, Lubos Lunak wrote: > > these switches are actually supposed to do. As far as I can > > tell, --enable-symbols enables -g, --enable-debug does --enable-symbols > > and turns on logging+assertions and disabl

<    1   2   3   4   5   6   7   8   >