Re: Counter-productive UNUSED macro in connectivity/source/drivers/postgresql

2012-02-09 Thread Lubos Lunak
ust plain 1-byte -> 2-bytes extension. > Anyhow - on this topic: > > Any chance of SAL_UNUSED ? ;-) At worse, SAL_UNUSED_PARAM. SAL_UNUSED_PARAM? And that's how the Writer codebase came around ... . Unlike RTL_CONSTASCII_USTRINGPARAM(), this one is unlikely to be

Re: OK to merge the fw? libraries in framework?

2012-02-08 Thread Lubos Lunak
rom performance point of view. I can't comment on other reasons why this might have been split though. [*] Seriously, I can't find a thing. Is there actually something using the library? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: SfxItemSet::HasItem method

2012-02-07 Thread Lubos Lunak
temState(), but also to make it more visible that it is an out argument. The intuitive reading of "if( set.HasItem( which, item ))" to me is "does 'set' have an item of type 'which' that is 'item'?". -- Lubos Lunak l.lu...@suse.c

Re: [Libreoffice] Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-02 Thread Lubos Lunak
On Thursday 02 of February 2012, Stephan Bergmann wrote: > On 02/02/2012 11:26 AM, Lubos Lunak wrote: > > I agree with all the points, but in Julien's defense, I remember > > exactly this same approach was pushed in recently as a fix to the same > > issue elsewhere. >

Re: [Libreoffice] Question about iterator management in sw/source/core/fields/cellfml.cxx

2012-02-02 Thread Lubos Lunak
should agree on what the recommended way is? I personally think the simplest and most elegant solution is to go with 'it = container.erase( it );" and move the "++it" out of for()'s parentheses to an else block of the if() condition (oh well, ease of use

Re: [Libreoffice] default build verbosity

2012-02-01 Thread Lubos Lunak
avoid most of the unneeded output and still, I assume, would do and be an optimal default. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW 3-5, 3-5-0] fdo#42543: Empty wizard page in reportdesign

2012-01-31 Thread Lubos Lunak
hat, and is the least intrusive change. > > Can you please review for -3-5 and -3-5-0? Pushed to 3-5. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Simplified C++ configuration access

2012-01-31 Thread Lubos Lunak
rocessComponentContext in code that does not thread the > component context more locally). How usual is the case that one does not want to pass comphelper::getProcessComponentContext() to all these functions? Or in other words, why not simply make it the default argument value? -- Lub

[Libreoffice] [REVIEW] Fix reading .doc comments (fdo#45255)

2012-01-30 Thread Lubos Lunak
ormat enough to be certain about the fix, but I expect it is quite clear from the logic of the thing, so I've committed as b5a73d4b2b283d3d1a57ac0f66b608998960a873 . Please review and backport. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice ma

Re: [Libreoffice] Database of areas for SAL_INFO etc.

2012-01-27 Thread Lubos Lunak
On Tuesday 24 of January 2012, Stephan Bergmann wrote: > On 01/24/2012 04:40 PM, Lubos Lunak wrote: > > I intend to put just a short note to the documentation in sal/log.hxx > > pointing to this file (so that additions wouldn't trigger rebuilds), but > > I'm not su

Re: [Libreoffice] LibreOffice Code Cleanup Patch

2012-01-27 Thread Lubos Lunak
od with scripts, he'd be more than welcome to e.g. use them to change writer's cryptic indentifiers to something that does not need decyphering. Which would affect git blame as well, but in this case the huge increase in readability of the code would be more than worth it. Tasks for

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source "fix rendering of metafiles embedded in emf+"

2012-01-26 Thread Lubos Lunak
han's problem, but your changes (both the commit and the attached patch) break the document from bnc#743331 (picture in the upper-right corner). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://l

Re: [Libreoffice] [PATCH] Code cleanup: ( () ) replaced by (())

2012-01-26 Thread Lubos Lunak
irely a matter of taste and IMO it's not worth to affect git blame by things like this. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fdo#43869 use the old rtf importer for paste

2012-01-26 Thread Lubos Lunak
ebody sign-off and push to -3-5, please? > > I cherry-picked it to -3-5, but it would be good to have 2 more reviews > to push it to -3-5-0 as well. One. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.free

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Lubos Lunak
On Wednesday 25 of January 2012, Thorsten Behrens wrote: > Lubos Lunak wrote: > > (and the filter-it-out suggestion is ridiculous, what if somebody really > > explicitly also CC-ed me e.g. because it's urgent?). > > http://help.cselabs.umn.edu/email/procmail ;) Cool! S

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Lubos Lunak
On Wednesday 25 of January 2012, Fridrich Strba wrote: > On 24/01/12 16:26, Lubos Lunak wrote: > > - it leaves less room for the actually important part of the subject when > > browsing mail > > - which gets expecially insane when forwarding mails futher or between > >

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Lubos Lunak
On Wednesday 25 of January 2012, Stephan Bergmann wrote: > On 01/25/2012 12:04 PM, Lubos Lunak wrote: > > if I wanted to get all those useless duplicates of replies to my > > mails, I would have said so. > > This might be a controversial issue. While I too feel I don

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Lubos Lunak
On Wednesday 25 of January 2012, Regina Henschel wrote: > Hi, > > Lubos Lunak schrieb: > > On Tuesday 24 of January 2012, khagaroth wrote: > >> While at it, it would be nice to also set Reply-To: > >> libreoffice@lists.freedesktop.org. > > > > Oh

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Lubos Lunak
ke, last decade) to have 'reply-to-mailing-list' and that solves the problem. And that was a plural you, if I wanted to get all those useless duplicates of replies to my mails, I would have said so. -- Lubos Lunak l.lu...@suse.cz __

[Libreoffice] Database of areas for SAL_INFO etc.

2012-01-24 Thread Lubos Lunak
hat doesn't look very good to me. Does somebody know where a good place for such a file would be? Thanks. PS: A good place meaning that people would actually be able to find it and use it, which rules out the option of burying it in some random wiki page. -- Lubos Lunak l.lu...@suse.cz __

[Libreoffice] Changing list setup to not add to subject

2012-01-24 Thread Lubos Lunak
iling lists - it makes adding tags like [PUSHED] more cumbersome - one would hope that by 2012 everybody interested in filtering mail can actually do it based on the List-Id header, which has the additional benefit of really filtering mails from the mailing list -- Lubos Lunak l.lu...@su

Re: [Libreoffice] [REVIEW-3.5] Handling ordering problem when properties are set one by one

2012-01-24 Thread Lubos Lunak
On Tuesday 24 of January 2012, Michael Stahl wrote: > On 23/01/12 21:31, Lubos Lunak wrote: > > Technically, I get in SwXDocumentSettings::_setSingleValue() first a > > call with HANDLE_CURRENT_DATABASE_DATA_SOURCE and then with > > HANDLE_CURRENT_DATABASE_COMMAND. They

[Libreoffice] Handling ordering problem when properties are set one by one

2012-01-23 Thread Lubos Lunak
-push-all-the-data-as-properties-one-by-one approach, so I wonder what the common way of avoiding this problem is? Preferably something that's not an ugly hack, excuse the naivety. Thanks -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing li

Re: [Libreoffice] [PATCH][PUSHED] Add import of docvariable fields from word documents

2012-01-16 Thread Lubos Lunak
t; custom document information. > > Please consider this patch for inclusion. Pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Writer table layout fix

2012-01-16 Thread Lubos Lunak
broken to me to unconditionally move a table forward just depending on whether there is something before it. Git blame shows a CWS merge, so it is unhelpful. -- Lubos Lunak l.lu...@suse.cz From 63e7d5a92a9580b1e04026657eb99bfef3480fde Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=

Re: [Libreoffice] unnecessary building basegfx twice ?

2012-01-06 Thread Lubos Lunak
On Friday 06 of January 2012, Michael Stahl wrote: > On 06/01/12 17:35, Lubos Lunak wrote: > > On Friday 06 of January 2012, Michael Stahl wrote: > >> in the case of pdfimport, isn't there a potential licensing problem > >> because it uses GPL-licensed xpdf/pop

Re: [Libreoffice] unnecessary building basegfx twice ?

2012-01-06 Thread Lubos Lunak
g out we have this filter that can handle it or by finding out we have this extension that can handle it. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH 1/2][PUSHED] Added missing includes.

2012-01-05 Thread Lubos Lunak
On Tuesday 03 of January 2012, Marcel Metz wrote: > --- > binfilter/inc/bf_starmath/smmod.hxx |2 ++ > binfilter/inc/bf_sw/shellres.hxx|2 +- > 2 files changed, 3 insertions(+), 1 deletions(-) Pushed all patches. -- Lubos Lunak l.l

Re: [Libreoffice] [PATCH 1/5][PUSHED] Removed unnecessary tools includes.

2012-01-05 Thread Lubos Lunak
but the > patch also touches some of the mac specific code like > fpicker/source/aqua/SalAquaFilePicker.mm so it would be maybe a good > idea to test this patch. Compiled for me too, so let's say the only way to check for problems is by running into them :). Pus

Re: [Libreoffice] [PATCH][PUSHED] Fix for fdo43460 Part XXII getLength() to isEmpty()

2012-01-05 Thread Lubos Lunak
On Wednesday 04 of January 2012, Gustavo Pacheco wrote: > Hi! > > Partial fix for Easy Hack FDO43460 (part XXII) for review. > > Part XXII > modules > jvmfwk, l10ntools, lingucomponent Pushed, thanks. -- Lubos L

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-04 Thread Lubos Lunak
On Wednesday 04 of January 2012, Stephan Bergmann wrote: > On 01/04/2012 04:15 PM, Lubos Lunak wrote: > > On Wednesday 04 of January 2012, Stephan Bergmann wrote: > >> (One downside of doxygen appears to be that > >> it does not generate an overview of all the non-class

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-04 Thread Lubos Lunak
not sure what you mean here - the overviews do include also global non-namespaced objects, search http://api.libreoffice.org/docs/cpp/ref/names/index.html for e.g. 'typereg_writer_destroy'. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffi

Re: [Libreoffice] [PATCH][PUSHED] Easyhack fdo#38831 remove SvStrings

2012-01-04 Thread Lubos Lunak
hanks (and all the notes were correct). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Fix for fdo43460 Part XXVIII getLength() to isEmpty()

2012-01-04 Thread Lubos Lunak
;isEmpty() patches I've reviewed are correct, I expect the rest will be as well, and by now you are the expert in this field anyway :). You can still post for review other patches where you won't be sure. -- Lubos Lunak l.lu...@suse.cz

Re: [Libreoffice] [PATCH 3/8][PUSHED] Easyhack fdo#38831 remove SvStrings

2012-01-03 Thread Lubos Lunak
.begin()); it != aFldNames.end(); ++it) { -pArray[i] = *aFldNames.GetObject(i); +pArray[i] = **it; ^^^ +delete *it; } Fixed, pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH 2/8][PUSHED] Easyhack fdo#38831 remove SvStrings

2012-01-03 Thread Lubos Lunak
The same like before. Pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH 1/8][PUSHED] Easyhack fdo#38831 remove SvStrings

2012-01-03 Thread Lubos Lunak
(i.e. addresses remain the same), which does not seem to be the case, this is just an optimization. The 16 looks a bit like a magic number anyway. You also removed the check for m_pGlosArr being NULL in the code below: SwGlossaries::~SwGlossaries() { - sal_uInt16 nCount = m_pGlosArr? m_

Re: [Libreoffice] [PATCH][PUSHED] Remove unused tools function.

2012-01-03 Thread Lubos Lunak
On Tuesday 03 of January 2012, Marcel Metz wrote: > Hello lo-devs, > > this patch removes the unused (according to OpenGrok) GetIsoFallback > function from the tools module. Looks ok, pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOf

Re: [Libreoffice] [PATCH] fixing some errors when building with clang on linux

2012-01-03 Thread Lubos Lunak
lows a ctor to directly call another ctor, but otherwise init() seems to be the only correct option. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Fix for fdo43460 Part XXVII getLength() to isEmpty()

2012-01-02 Thread Lubos Lunak
On Monday 02 of January 2012, Olivier Hallot wrote: > Please find attached a partial fix for Easy Hack FDO43460 > > Part XXVII > Modules > padmin, pyuno, rdbmaker, regexp, registry, rsc, sal Pushed as well. -- Lubos Lunak

Re: [Libreoffice] [PATCH][PUSHED] Fix for fdo43460 Part XXVI getLength() to isEmpty()

2012-01-02 Thread Lubos Lunak
On Sunday 01 of January 2012, Olivier Hallot wrote: > Please find attached a partial fix for Easy Hack FDO43460 > > Part XXVI > Module > package Pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.

Re: [Libreoffice] [PATCH] Fix for fdo43460 Part XXV getLength() to isEmpty()

2012-01-02 Thread Lubos Lunak
On Sunday 01 of January 2012, Olivier Hallot wrote: > Please find attached a partial fix for Easy Hack FDO43460 > > Part XXI > Module > oox Pushed, thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing l

Re: [Libreoffice] [REVIEW:3-4-5] crash in LO 3.4.5 rc1 : fdo40253

2012-01-02 Thread Lubos Lunak
bs-core/commit/?h=libreoffice-3-4 >&id=395c05c288116683ffb3bceb658f61694c042b28 > > We need 2 more approvals for the 3-4-5 branch. Makes sense. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW-3-4-5] bug#36874 to be patched in 3.4.5 as well?

2012-01-02 Thread Lubos Lunak
assumption. Your patch makes sense > and I have pushed it to the 3-4 branch, see > http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4&id >=502ef71db74c3cdb1433c3402a0d93971dc47f1b > > We need two more approvals for the 3-4-5 branch. Looks ok. -- Lubos L

Re: [Libreoffice] [REVIEW 3-4] Related: fdo#33463 (writerfilter)

2012-01-02 Thread Lubos Lunak
cgit.freedesktop.org/libreoffice/filters/commit/?h=libreoffice-3-4&i >d=9dcc765e88bf23418ffbf66345e4eaa4c36005e4 Yes, it's correct. > We need two more approvals for the 3-4-5 branch. One. -- Lubos Lunak l.lu...@suse.cz __

Re: [Libreoffice] [PATCH][PUSHED] Remove unused code

2012-01-02 Thread Lubos Lunak
On Wednesday 28 of December 2011, Marcel Metz wrote: > Hello lo-devs, > > There is never an instance of mpDateTable allocated and a lot of > code is never executed because of that. This patch removes the > unused code. Pushed, thanks. -- Lubos Lunak

Re: [Libreoffice] [REVIEW][PUSHED] invalid ODF fdo#37390 fdo#44073 fdo#44082

2012-01-02 Thread Lubos Lunak
it to the libreoffice-3-4 branch, see > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4 >&id=005f59ac32ce48397fa7df3b4f6586467c7f9bda > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4 >&id=09b32d79015b9e4fd933492b495b99ab1

Re: [Libreoffice] [PATCH] removing mpNotes field from ScBaseCell

2011-12-19 Thread Lubos Lunak
ces, set the tab size correctly or whatever it is your editor needs. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] building with gcc-trunk

2011-12-16 Thread Lubos Lunak
alue mpGraphic, so that suggests it is possible to re-initialize the class using this call. But then using this init() call first and later one of the ones inherited from GraphicDescript will leave mpGraphic inconsistent. Presumably the proper fix is to get rid of the init() calls and use directly

Re: [Libreoffice] Make gbuild output [build CXX] filename also with the .cxx extension

2011-12-15 Thread Lubos Lunak
On Wednesday 14 of December 2011, Bjoern Michaelsen wrote: > Hi Lubos, > > On Wed, Dec 14, 2011 at 04:45:29PM +0100, Lubos Lunak wrote: > > I find it mildly annoying that gbuild outputs "[ build CXX ] > > starmath/source/types", without the .cxx extension, i.e. a no

Re: [Libreoffice] [PATCH] Use -gdwarf-4 by default if possible (was Re: Even more debugging info)

2011-12-15 Thread Lubos Lunak
On Thursday 08 of December 2011, Lubos Lunak wrote: > On Wednesday 07 of December 2011, Michael Meeks wrote: > > On Thu, 2011-12-01 at 17:35 +0100, Lubos Lunak wrote: > > > > So -gdwarf-4 looks like a sensible default to me. Even if not, I'm > > > > going

Re: [Libreoffice] Simpler logging using a string format function

2011-12-15 Thread Lubos Lunak
On Thursday 15 of December 2011, Stephan Bergmann wrote: > On 12/15/2011 02:57 PM, Lubos Lunak wrote: > > The "bar"<< "baz", which, at first glance, is nonsense. Code is not > > only written, it is also read, and many more times. > > Still do

Re: [Libreoffice] Simpler logging using a string format function

2011-12-15 Thread Lubos Lunak
On Thursday 15 of December 2011, Stephan Bergmann wrote: > On 12/13/2011 07:56 PM, Lubos Lunak wrote: > > But it might the moment you realize you're trading away things like > > > > SAL_INFO( "foo", 1<< 2 ) or SAL_INFO( "foo", &quo

Re: [Libreoffice] getting debug symbols when running build unit tests under gdb?

2011-12-14 Thread Lubos Lunak
27;, the app then will crash as soon as it reaches the limit. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Make gbuild output [build CXX] filename also with the .cxx extension

2011-12-14 Thread Lubos Lunak
Hello, I find it mildly annoying that gbuild outputs "[ build CXX ] starmath/source/types", without the .cxx extension, i.e. a non-existent file. Especially since other target types like LNK do output "[ build LNK ] Library/libsmlo.so". Any objections to the attache

Re: [Libreoffice] Simpler logging using a string format function

2011-12-13 Thread Lubos Lunak
On Monday 12 of December 2011, Michael Meeks wrote: > On Mon, 2011-12-12 at 16:30 +0100, Lubos Lunak wrote: > > The format-based usage uses a printf-like function that, unlike printf, > > is typesafe and extensible. If people would be interested, the function > > itself cou

Re: [Libreoffice] Simpler logging using a string format function

2011-12-13 Thread Lubos Lunak
On Monday 12 of December 2011, Stephan Bergmann wrote: > On 12/12/2011 04:30 PM, Lubos Lunak wrote: > > I'd like to propose changes to the SAL_INFO etc. family of the new > > logging functions that would replace the somewhat strange usage > > > > SAL_INFO(&quo

Re: [Libreoffice] Simpler logging using a string format function

2011-12-12 Thread Lubos Lunak
On Monday 12 of December 2011, Lubos Lunak wrote: > Attached source code has a testing implementation of the format function and > a simple logging macro. In case somebody actually tries to build it :), the easiest way seems to be: g++ -Wall -O2 -save-temps a.cxx -DUNX -DLINUX -I$LODIR/

[Libreoffice] Simpler logging using a string format function

2011-12-12 Thread Lubos Lunak
a: Did you know that despite being seemingly highly optimized, with stuff like OUStringBuffer::makeStringAndClear() or the obnoxious RTL_CONSTASCII_USTRINGPARAM macro, O(U)String* actually does some rather pathetic things like ctors first checking if there's any memory to free or allocat

Re: [Libreoffice] odd ND_FOONODE bits was fdo#42147: fix crash

2011-12-09 Thread Lubos Lunak
ore/docnode/nodes.cxx does instantiate SwNode, so I really don't know. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Use -gdwarf-4 by default if possible (was Re: Even more debugging info)

2011-12-08 Thread Lubos Lunak
On Wednesday 07 of December 2011, Michael Meeks wrote: > On Thu, 2011-12-01 at 17:35 +0100, Lubos Lunak wrote: > > > So -gdwarf-4 looks like a sensible default to me. Even if not, I'm > > > going to use it (quick hack: modify your LO make script to add it to > >

[Libreoffice] StarMath test documents - where to add?

2011-12-02 Thread Lubos Lunak
em? I don't know if/where we have a suitable place. The documents would be also usable for automated tests, but seeing the discussion about subsequenttests right now it's probably not the right time to try to figure it out. -- Lubos Lunak

[Libreoffice] Verbose build (was Re: [Libreoffice-commits] .: solenv/gbuild)

2011-12-01 Thread Lubos Lunak
s, also errors. Tinderbox mails are already pretty difficult to read as they are and anything that makes people less motivated to do more than just glance at them is bad. Thanks for switching tinderbox to -s. -- Lubos Lunak l.lu...@suse.cz ___ Li

[Libreoffice] [PATCH] Use -gdwarf-4 by default if possible (was Re: Even more debugging info)

2011-12-01 Thread Lubos Lunak
On Thursday 01 of December 2011, Lubos Lunak wrote: > On Wednesday 30 of November 2011, Tom Tromey wrote: > > These options cause debuginfo for > > most big types to be shared across compilation units, a huge size win. > > This also makes gdb use less memory. > > I&

Re: [Libreoffice] Even more debugging info

2011-12-01 Thread Lubos Lunak
On Thursday 01 of December 2011, Lionel Elie Mamane wrote: > On Thu, Dec 01, 2011 at 12:14:32PM +0100, Lubos Lunak wrote: > > On Wednesday 30 of November 2011, Tom Tromey wrote: > >> First, one must consider the tradeoffs. I always use -g3 when building > >> gdb, bec

Re: [Libreoffice] Even more debugging info

2011-12-01 Thread Lubos Lunak
ce any problems with -gdwarf-4. So -gdwarf-4 looks like a sensible default to me. Even if not, I'm going to use it (quick hack: modify your LO make script to add it to $CXXFLAGS). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Even more debugging info

2011-11-30 Thread Lubos Lunak
increase object size compared to -ggdb2? http://lists.freedesktop.org/archives/libreoffice/2011-April/010408.html Short answer: yes. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.fr

Re: [Libreoffice] [Libreoffice-commits] .: solenv/gbuild

2011-11-30 Thread Lubos Lunak
$(filter s,$(MAKEFLAGS)),,VERBOSE=T) -P$(BUILD_NCPUS) $(2) > -P$(GMAKE_PARALLELISM) gb_MAKETARGET=$(gb_MAKETARGET) $(eval > gb_BuildplTarget_COMPLETEDTARGETS+=$(1)) > endef -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list

2011-11-29 Thread Lubos Lunak
On Tuesday 29 of November 2011, Michael Meeks wrote: > Ah - but this is what I added: > > Window* Window::GetParentDialog() const One 'const' missing (or one too much). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice maili

Re: [Libreoffice] WaE on vcl because of qt4 module

2011-11-28 Thread Lubos Lunak
it uses?). Moreover, in Qt-based land -Whadow is (AFAICT) usually considered a nuisance rather than help (and this shows why), so I expect nobody will even seriously look at it anyway, for a reason. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] MSVC class-in-class visibility (Re: Tinderbox failure, last success: 2011-11-24 15:00:56)

2011-11-25 Thread Lubos Lunak
call > SmOoxmlImport::handleBorderBox(void)" > (?handleBorderBox@SmOoxmlImport@@AAE?AVOUString@rtl@@XZ) > c:/libreoffice/workdir/wntmsci12.pro/LinkTarget/Library/smlo.dll : fatal > error LNK1120: 3 unresolved externals make[1]: *** -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] message construction bloat ...

2011-11-25 Thread Lubos Lunak
al data is split, then the concatenation has to happen at some level. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] message construction bloat ...

2011-11-24 Thread Lubos Lunak
On Wednesday 23 of November 2011, Lubos Lunak wrote: > I expect it would be even possible to achieve such single in-place call > even for the LOG( "P is " << p << " and b is " << b ) case, or even do this > for string+string operation, which would tu

Re: [Libreoffice] message construction bloat ...

2011-11-23 Thread Lubos Lunak
On Wednesday 23 of November 2011, Michael Meeks wrote: > On Wed, 2011-11-23 at 14:56 +0100, Lubos Lunak wrote: > > And some of the arguments are rather weak as well, I can get you easy to > > use and read, better to translate and similarly space efficient without > >

Re: [Libreoffice] Solving an introduced runtime dependency on unreleased Qt version (KDE4 vcl backend)

2011-11-23 Thread Lubos Lunak
On Tuesday 22 of November 2011, Michael Meeks wrote: > On Tue, 2011-11-22 at 18:26 +0100, Lubos Lunak wrote: > > Since 3.4 at least, when run with KDE4 integration, LO kind of happens > > to have a runtime dependency on a yet unreleased Qt version, otherwise LO > > w

Re: [Libreoffice] sw: serial numbers

2011-11-23 Thread Lubos Lunak
e does not have SwNode as its first base class (and trying to change that goes horribly wrong). But I myself wouldn't consider that a good reason for keeping the serials. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing li

Re: [Libreoffice] message construction bloat ...

2011-11-23 Thread Lubos Lunak
lso, string usage in LO is rather cumbersome as it is and in general it'd be probably a good trade-off to waste a couple of bytes on each string operation that doesn't need a whole line of code to express a trivial operation. -- Lubos Lunak l.lu...@suse.cz _

Re: [Libreoffice] Assertions and Logging

2011-11-22 Thread Lubos Lunak
On Tuesday 22 of November 2011, Stephan Bergmann wrote: > On 11/22/2011 05:17 PM, Lubos Lunak wrote: ... > I did not commit it in order to stop any discussion. Sorry if it looked > that way. Rather, as I did not get any totally disagreeing reactions, I > thought it would be easier to

[Libreoffice] Solving an introduced runtime dependency on unreleased Qt version (KDE4 vcl backend)

2011-11-22 Thread Lubos Lunak
that is supposed to work. What do you suggest to do about it? PS: I've attached a backport of the Qt change to https://bugs.freedesktop.org/show_bug.cgi?id=40298 . -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Assertions and Logging

2011-11-22 Thread Lubos Lunak
iant, perhaps they should be simply rather fixed/improved - WTH should we intentionally have two sets of one functionality again? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Importing StarMath component in an import filter

2011-11-09 Thread Lubos Lunak
me to the right places in the code? Thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Remove obsolete IsWin95A function

2011-11-07 Thread Lubos Lunak
d I don't really dare to just guess, as the 'return TRUE' part is a clear evidence the function was written by somebody brain-damaged. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http:/

[Libreoffice] Using Doxygen for API documentation

2011-11-03 Thread Lubos Lunak
minute and write something short. The same applies whenever you write something new of course. Now that you know how, there's no real excuse. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Kubuntu Oneiric "Qt4 Libraries"

2011-11-02 Thread Lubos Lunak
27;t say I understand the actual problem, but if you want to configure on a system with unusual locations, there's $QT4INC and $QT4LIB. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Trinity Desktop Environment (TDE) desktop integraton for LibreOffice

2011-11-01 Thread Lubos Lunak
backwards compatibility with KDE3 or not. The configure checks in the patch search for KDE3/Qt3 names, so I would assume the answer is yes. If not, then at least that part of the patch is definitely wrong. -- Lubos Lunak l.lu...@suse.cz --- /home/llunak/build/src/libo/vcl/unx/kde/salnativewid

Re: [Libreoffice] gravity of raised assertions?

2011-11-01 Thread Lubos Lunak
ch OSL_ASSERT is really meant to assert and which is just a warning. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Trinity Desktop Environment (TDE) desktop integraton for LibreOffice

2011-10-31 Thread Lubos Lunak
ease (freeze is Dec 5th) quite > easily. The original mail rings a bell ... http://lists.freedesktop.org/archives/libreoffice/2011-September/017515.html . And I don't remember any reply to my questions, and I don't see anything changing since then,

Re: [Libreoffice] make experts: progress information?

2011-10-20 Thread Lubos Lunak
wants this would need to examine the makefiles it generates. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] gdb: catching exceptions...

2011-10-18 Thread Lubos Lunak
his :) Possibly 'help catch' and 'help commands' could make this easier/faster, but I have not actually tried it. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-commits] .: 3 commits - cui/source sfx2/source svx/inc svx/source sw/inc sw/source ucb/source vcl/unx

2011-10-17 Thread Lubos Lunak
living Child(s) destroyed: 21SfxEmptySplitWin_Impl (window text: '')') -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

2011-10-05 Thread Lubos Lunak
he pO->GetData() to something like > po->data(), instead of &(*pO)[0] (and similar) used on many places... That same would be allowed by class bytes : public std::vector { public: const sal_uInt8* data() const { return &front(); } ... -- Lubos Lunak l.lu...@suse.cz ___

Re: [Libreoffice] [EASY HACKS] machine translation of remaining german comments acceptable?

2011-10-05 Thread Lubos Lunak
t. It's going to take ages for it all to be translated manually and IMO the translations can be occassionally useful, even if of questionable quality. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop

Re: [Libreoffice] Proposal: slowcheck -- some numbers for sc

2011-09-23 Thread Lubos Lunak
heck. Even if ods does not officially store it, presumably you can have an LO-specific field where LO could cache the value for faster reading anyway, no? -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.o

Re: [Libreoffice] [PATCH] libstdc++ STL debug

2011-09-21 Thread Lubos Lunak
On Wednesday 21 of September 2011, Bjoern Michaelsen wrote: > On Wed, 21 Sep 2011 12:55:44 +0200 > > Lubos Lunak wrote: > > You forgot Qt4/KDE4. LO does not use STL with it, so this is just to > > show that it's not so trivial to check if there's a potential >

Re: [Libreoffice] Proposal: slowcheck -- some numbers for sc

2011-09-21 Thread Lubos Lunak
bstractions, especially in a non-optimized build. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] libstdc++ STL debug

2011-09-21 Thread Lubos Lunak
check for this automatically, so the only way to find such a problem would presumably be getting a strange crash. But I'm not against, if not having STL debug enabled on Linux makes building on Windows even more of a nightmare, then I guess we could live with that. -- Lubos Lunak l.lu..

Re: [Libreoffice] [PATCH] libstdc++ STL debug (was: Re: Usefulness of --enable-dbgutil)

2011-09-15 Thread Lubos Lunak
good. > i don't think it's a good idea that the Linux developers introduce such > regressions Agreed, but Linux developers getting mysterious crashes is not a very good idea either, so it is a question if STL debug mode is worth it. -- Lubos Lunak l.lu...@suse.cz __

Re: [Libreoffice] From sal/cppunit.h to sal/precppunit.hxx

2011-09-13 Thread Lubos Lunak
i.documentfoundation.org/Development/Unit_Tests to match the current status. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ccache support

2011-09-12 Thread Lubos Lunak
On Saturday 10 of September 2011, Norbert Thiebaud wrote: > On Fri, Sep 9, 2011 at 1:22 PM, Lubos Lunak wrote: > >  Since there (AFAIR) haven't been any actual data presented in the > > discussion > > here are some number for my linux buildbot. Ccache hit statistics f

Re: [Libreoffice] ccache support

2011-09-09 Thread Lubos Lunak
doubt ccache warrants being enabled by default just like that. > I don't do that in configure for the same reason we don't change > CCACHE_DIR or the cache dir size. > Using ccache if available is one thing... but trying to > 'auto-magically' optimize ccache is

<    1   2   3   4   5   6   7   8   >