Re: [Libreoffice] configure.in monstrosity

2011-09-09 Thread Lubos Lunak
> > improve the readability. > > autoconf stuff isn't readable anyway, so.. ;-) But that doesn't mean we intentionally have to make it even worse :). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] New desktop integration modules

2011-09-01 Thread Lubos Lunak
as, given it was based on KDE3, so even then it'd be probably better to have one common base and build two different versions from it (note that in this case also Trinity should not use KDE3 library and header names). -- Lubos Lunak l.lu...@suse.cz __

Re: [Libreoffice] Template for copyright headers is cumbersome (was Re: How to call from one component to another (sw->starmath))

2011-08-18 Thread Lubos Lunak
On Thursday 18 of August 2011, Bjoern Michaelsen wrote: > Hi all, > > On Thu, 18 Aug 2011 10:21:54 +0200 > > Lubos Lunak wrote: > > It does, but does it really need to be so chatty to repeat the > > obvious facts that each contributor's copyright relates only

Re: [Libreoffice] Template for copyright headers is cumbersome (was Re: How to call from one component to another (sw->starmath))

2011-08-18 Thread Lubos Lunak
On Thursday 18 of August 2011, Thorsten Behrens wrote: > Lubos Lunak wrote: > > However, I can't help noticing that the template layout is ... er, not > > suitable for easy use: > > How about attached patch? Does that address your points? It does, but does it real

Re: [Libreoffice] How to call from one component to another (sw->starmath)

2011-08-18 Thread Lubos Lunak
On Thursday 18 of August 2011, Bjoern Michaelsen wrote: > On Thu, 18 Aug 2011 08:31:55 +0200 > > Lubos Lunak wrote: > > On Thursday 18 of August 2011, Lubos Lunak wrote: > > > Is that true in practice? Sw and writerfilter have a hard > > > depedency on > >

Re: [Libreoffice] How to call from one component to another (sw->starmath)

2011-08-17 Thread Lubos Lunak
On Thursday 18 of August 2011, Lubos Lunak wrote: > Is that true in practice? Sw and writerfilter have a hard depedency on Correction: Writerfilter does not. It doesn't change anything though. > filter already. I only added few more dependencies to starmath that sw > al

Re: [Libreoffice] How to call from one component to another (sw->starmath)

2011-08-17 Thread Lubos Lunak
On Thursday 18 of August 2011, Bjoern Michaelsen wrote: > Hi Lubos, > > On Tue, 16 Aug 2011 12:09:19 +0200 > > Lubos Lunak wrote: > > No, starmath doesn't need to call back to writer. The problem is > > that this is still needlessly complicated. How about the

Re: [Libreoffice] XML pretty printer (was: Where did Setup.xcu go?)

2011-08-17 Thread Lubos Lunak
ng it and explicitly marking problems in the XML structure with an easily visible comment. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Template for copyright headers is cumbersome (was Re: How to call from one component to another (sw->starmath))

2011-08-16 Thread Lubos Lunak
On Tuesday 16 of August 2011, Michael Meeks wrote: > Hi Lubos, > > On Tue, 2011-08-16 at 12:09 +0200, Lubos Lunak wrote: > > No, starmath doesn't need to call back to writer. The problem is that > > this is still needlessly complicated. How about the attached pa

Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?

2011-08-16 Thread Lubos Lunak
ent. You need to handle the else case as well. If this is fixed, you have my ACK. > + > +return *this; > +} > > All is now working fine, and that later commit could be applied to 3.4 > safely. -- Lubos Lunak l.lu...@suse.cz __

Re: [Libreoffice] How to call from one component to another (sw->starmath)

2011-08-16 Thread Lubos Lunak
On Tuesday 16 of August 2011, Caolán McNamara wrote: > On Mon, 2011-08-15 at 17:16 +0200, Lubos Lunak wrote: > > I already have a pointer to SmModel and SmDocShell (I can get it the same > > way the .doc code does) and just need to call their method, passing the > > XML se

Re: [Libreoffice] How to call from one component to another (sw->starmath)

2011-08-15 Thread Lubos Lunak
On Monday 15 of August 2011, Miklos Vajna wrote: > On Mon, Aug 15, 2011 at 05:16:17PM +0200, Lubos Lunak wrote: > > I'm implementing .docx OOXML support for writing math formulas. As this > > is something that could be used not only by Writer but also by other >

[Libreoffice] How to call from one component to another (sw->starmath)

2011-08-15 Thread Lubos Lunak
fff66ec7330, rOLENode=...) at /home/llunak/build/src/l2/sw/source/filter/ww8/wrtww8gr.cxx:280 -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-12 Thread Lubos Lunak
On Thursday 11 of August 2011, Thorsten Behrens wrote: > Lubos Lunak wrote: > > As much as I don't like it, I can possibly see at least some reason for > > time having 25 hours, but 10 seconds without 20 seconds being 10 seconds > > (and there is actually ex

Re: [Libreoffice] Class Time and its funny ideas about time

2011-08-12 Thread Lubos Lunak
e of something (no compilation errors) by marking it as deprecated, building with that and grepping the output for deprecation warnings. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Class Time and its funny ideas about time

2011-08-11 Thread Lubos Lunak
it, I can possibly see at least some reason for time having 25 hours, but 10 seconds without 20 seconds being 10 seconds (and there is actually explicit code to ensure that)? Does somebody know why the Time class does either of these and how much would break if I fixed these two to be sane

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-11 Thread Lubos Lunak
On Wednesday 10 of August 2011, Stephan Bergmann wrote: > On Aug 10, 2011, at 12:31 PM, Lubos Lunak wrote: > > On Tuesday 09 of August 2011, Stephan Bergmann wrote: > >> Technically, lostd::list is no longer a container, as it violates the > >> requirement that t

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-10 Thread Lubos Lunak
On Tuesday 09 of August 2011, Stephan Bergmann wrote: > On Aug 9, 2011, at 5:15 PM, Lubos Lunak wrote: > > namespace lostd // or just no namespace at all, any other 'list' class is > > unlikely > > { > > template< ... > > > class list : public ::st

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-09 Thread Lubos Lunak
On Tuesday 09 of August 2011, Stephan Bergmann wrote: > On Aug 9, 2011, at 3:02 PM, Lubos Lunak wrote: > > Too bad usage of STL drags in these problems, but that's not a problem > > that couldn't be solved. > > How? namespace lostd // or just no namespace at

Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1)

2011-08-09 Thread Lubos Lunak
usage of STL drags in these problems, but that's not a problem that couldn't be solved. Certainly much easier than having code cluttered with checks and casts that serve no real purpose. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ccache support

2011-08-08 Thread Lubos Lunak
On Monday 08 of August 2011, Christian Lohmaier wrote: > On Mon, Aug 8, 2011 at 11:33 AM, Lubos Lunak wrote: > > On Monday 08 of August 2011, Norbert Thiebaud wrote: > >> I've pushed > >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=57cf026739a3d7

Re: [Libreoffice] ccache support

2011-08-08 Thread Lubos Lunak
who have already done their setup will need to adjust for this. People who only have ccache installed but haven't done anything will get slower builds, as the default ccache cache size is vastly unsufficient for LO builds, so ccache will only create cache contents that will be eventually thrown

Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-04 Thread Lubos Lunak
On Wednesday 03 of August 2011, Caolán McNamara wrote: > On Tue, 2011-08-02 at 14:58 +0200, Lubos Lunak wrote: > > - osl_loadModule*() functions are plain C functions from stable API, so > > no overloading to add the extra argument for the error message, the best > > I've

Re: [Libreoffice] Reporting an error when loading of a component fails

2011-08-04 Thread Lubos Lunak
ached if you think it might be useful, feel free to > use/disregard/change totally etc. I agree that ideally the code should be changed to make the error dialog actually show what the problem was, but there are the problems you mention, that's why I wanted to at least push the patch I

[Libreoffice] [PUSHED] Re: [PATCH] Add missing libdir path for qt4 detection

2011-08-04 Thread Lubos Lunak
On Wednesday 03 of August 2011, Tomáš Chvátal wrote: > 0001-Add-one-more-libdir-path-for-detection-with-qt4-on-3.patch Pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.

[Libreoffice] Reporting an error when loading of a component fails

2011-08-02 Thread Lubos Lunak
or the error message, the best I've come up with was simply a wrapper around dlerror(), which I admit is not very nice API either, would there be any better approach? -- Lubos Lunak l.lu...@suse.cz diff --git a/cppuhelper/source/shlib.cxx b/cppuhelper/source/shlib.cxx index a979454..1beed1f

[Libreoffice] [PUSHED] Re: [PATCH] Import of xrefs to numbered paragraphs from docx

2011-08-01 Thread Lubos Lunak
of the patches much simpler. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Fix parent level count in numbering from docx

2011-08-01 Thread Lubos Lunak
On Monday 01 of August 2011, Lubos Lunak wrote: > On Friday 22 of July 2011, Troy Rollo wrote: > > Before this patch, when importing from docx, if there were no parent > > numbering levels in the number formats for outline numbered paragraphs, > > the import would include all

Re: [Libreoffice] [PATCH] Fix parent level count in numbering from docx

2011-08-01 Thread Lubos Lunak
he third and subsequent numbering levels. Checked and pushed, thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fdo#37693 macros creating random table borders

2011-08-01 Thread Lubos Lunak
On Thursday 28 of July 2011, Caolán McNamara wrote: > proposing this fix for 3-4 > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=a7058d28e5d36778b >9f16308632ffb4c9608479c > Reviewed, pushed. -- Lubos Lunak l.l

Re: [Libreoffice] [PATCH] Fix field values in export to docx

2011-07-29 Thread Lubos Lunak
On Friday 29 of July 2011, Caolán McNamara wrote: > On Thu, 2011-07-28 at 17:14 +0200, Lubos Lunak wrote: > > > -// Find another way for hyperlinks > > > -RunText( rInfos.pField->GetFieldName() ); > > > +String sExpand(

[Libreoffice] [PUSHED] Re: [PATCH] Fix fdo#36868 - doc import list numbering error

2011-07-28 Thread Lubos Lunak
evel 0 style), just an sprmPIlvl and an sprmPIlfo. Therefore there > was no call to SwWW8ImplReader::Read_POutLvl to set nOutlineLevel. Pushed, bug closed, thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freed

Re: [Libreoffice] [PATCH] Fix field values in export to docx

2011-07-28 Thread Lubos Lunak
hyperlinks > -RunText( rInfos.pField->GetFieldName() ); > +String sExpand( rInfos.pField->ExpandField( true ) ); > +sExpand.SearchAndReplaceAll( 0x0A, 0x0B ); This line looks strange. What is the reason for this? > +RunText( sExpand ); > + > m_pSer

[Libreoffice] [REVIEW] Fix wrapping around objects in headers (fdo#39155)

2011-07-19 Thread Lubos Lunak
around objects in the header (and not in the main text), so I see no regression in the behavior. -- Lubos Lunak l.lu...@suse.cz diff --git a/sw/source/core/text/txtfly.cxx b/sw/source/core/text/txtfly.cxx index 513c2d5..a900867 100644 --- a/sw/source/core/text/txtfly.cxx +++ b/sw/source/core

Re: [Libreoffice] How to add a unit test?

2011-07-15 Thread Lubos Lunak
On Monday 11 of July 2011, Caolán McNamara wrote: > On Mon, 2011-07-11 at 15:32 +0200, Lubos Lunak wrote: > > Hello, > > > > who knows how to add a unit test? > > > > http://wiki.documentfoundation.org/Development/Unit_Tests is incomplete > > (what if th

Re: [Libreoffice] Unit tests - cppunit crashing with debug build

2011-07-14 Thread Lubos Lunak
On Wednesday 13 of July 2011, Caolán McNamara wrote: > On Tue, 2011-07-12 at 10:35 +0200, Lubos Lunak wrote: > > On Monday 11 of July 2011, Caolán McNamara wrote: > > > I reckon we probably have to bite the bullet and drop -D_GLIBCXX_DEBUG > > > from solenv ? > > &

Re: [Libreoffice] Unit tests - cppunit crashing with debug build

2011-07-12 Thread Lubos Lunak
How would that work? The non-debug 3rd-party lib will always use non-debug version of list and that means we'd have to manually somehow use non-debug version of list as well when interfacing with the library. That sounds pretty unfeas

[Libreoffice] Unit tests - cppunit crashing with debug build

2011-07-11 Thread Lubos Lunak
memory not allocated by the ctor (located in the cppunit library). Thanks PS: The real question is of course "WTH does it not crash for others with debug build?", but I guess that'll remain a mystery. -- Lubos Lunak l.lu...@suse.cz diff --git a/configure.in b/configure.i

[Libreoffice] How to add a unit test?

2011-07-11 Thread Lubos Lunak
Hello, who knows how to add a unit test? http://wiki.documentfoundation.org/Development/Unit_Tests is incomplete (what if there is no qa/makefile.mk?) and obsolete (it assumes that this qa/makefile.mk is dmake-based). -- Lubos Lunak l.lu...@suse.cz

Re: [Libreoffice] rtl::O[U]StringBuffer now has a "remove" method

2011-07-04 Thread Lubos Lunak
On Saturday 02 of July 2011, Caolán McNamara wrote: > On Fri, 2011-07-01 at 17:53 +0200, Lubos Lunak wrote: > > On Thursday 30 of June 2011, Caolán McNamara wrote: > > > Do we have a preference ?, I'm easy either way. > > > > Since nobody seems to have a pre

Re: [Libreoffice] rtl::O[U]StringBuffer now has a "remove" method

2011-07-01 Thread Lubos Lunak
On Thursday 30 of June 2011, Caolán McNamara wrote: > On Thu, 2011-06-30 at 13:46 +0200, Lubos Lunak wrote: > > O[U]StringBuffer don't have any other range > > function, but O[U]String uses start+len for such cases (copy, replaceAt), > > so this seems inconsistent. > &

Re: [Libreoffice] rtl::O[U]StringBuffer now has a "remove" method

2011-06-30 Thread Lubos Lunak
,y) style, > not start position and length though this is clearly the same for an x > of 0 Usual style in what way? O[U]StringBuffer don't have any other range function, but O[U]String uses start+len for such cases (copy, replaceAt), so this seems inconsistent. -- Lubos Lunak

Re: [Libreoffice] patch for make to help in gbuild debugging

2011-06-29 Thread Lubos Lunak
On Wednesday 29 of June 2011, Bjoern Michaelsen wrote: > On Wed, 29 Jun 2011 17:56:42 +0200 > > Lubos Lunak wrote: > > Correct me if I'm wrong, but I haven't seen proposals for any other > > kinds of extensions to the gmake copy. > > yet. So what? Are we

Re: [Libreoffice] patch for make to help in gbuild debugging

2011-06-29 Thread Lubos Lunak
On Wednesday 29 of June 2011, Thorsten Behrens wrote: > Lubos Lunak wrote: > > It is not another dmake, as I understand it, as you cannot simply nuke > > our dmake copy now and expect things to still work, whereas that would > > work with a gnumake copy as long as that one&#

Re: [Libreoffice] patch for make to help in gbuild debugging

2011-06-29 Thread Lubos Lunak
.. don't ask) that supported a subset of automake+make functionality and while people could still build using automake+make if they wished so for whatever strange reason, using unsermake was just so much better. -- Lubos Lunak l.lu...@suse.cz __

Re: [Libreoffice] [REVIEW] fix for screen resizing problems

2011-06-29 Thread Lubos Lunak
tone age of window management handling, but there I'd simply wait for somebody to complain first if that's the case. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] problem with SAL_NO_MOUSEGRAPS during drag and drop

2011-06-28 Thread Lubos Lunak
n work at all without grabbing the mouse - you'll need to try and find out. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Tarball fetching broken with --with-system-libs

2011-06-25 Thread Lubos Lunak
On Friday 24 of June 2011, Jan Holesovsky wrote: > Hi Lubos, > > Lubos Lunak píše v Pá 24. 06. 2011 v 16:40 +0200: > > could somebody who understands tarball fetching review the attached > > patch? I did make clean, pulled, configured with --with-systems-libs and

[Libreoffice] Tarball fetching broken with --with-system-libs

2011-06-24 Thread Lubos Lunak
't be made This seems to be a result of b246ad5ff409a7a51091c0b3c1fe50e0eb468fc4 in bootstrap and libvisio version update since my last build. The attached patch fixes the problem for me, but since I have no idea why those checks were there, I'm just checking. -- Lubos Lunak l.lu.

Re: [Libreoffice] Master fails to build in vcl with --enable-kde4 flag

2011-06-06 Thread Lubos Lunak
related to the > recent move from dmake to gmake? > > I've tried to poke around a bit but, but I can't really make much > sense of this. Any ideas? Yes. It would help if you posted the actual errors, there are none in the output you've pr

Re: [Libreoffice] Proposal to join Apache OpenOffice

2011-06-06 Thread Lubos Lunak
think we should continue working on LO and not get involved at this time at all. The situation seems to be the best realistic outcome and it seems we can't improve it, so let's be happy about it, but we should not drown our resources in something that has unsure future and value

Re: [Libreoffice] Patch to fix compile with Bison 2.5 and Gcc 4.5.3 on LibO 3.4 RC2

2011-05-31 Thread Lubos Lunak
so that it's easier to see - attach the patch instead of posting it inline (it failed to apply, apparently the mailer changed the formatting) -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://list

Re: [Libreoffice] [PATCH] change default fall-back font lists for Thai locale in vcl.xcu

2011-05-26 Thread Lubos Lunak
g wrong or need to be > improved before committing. Committed to master and 3-4, thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] __cdecl -> SAL_CALL (libs-gui)

2011-05-26 Thread Lubos Lunak
On Monday 23 of May 2011, Chr. Rossmanith wrote: > Hi, > > the attached patch removes __cdecl and uses SAL_CALL instead. Pushed, thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop

Re: [Libreoffice] [REVIEW] fix for fdo#37390

2011-05-24 Thread Lubos Lunak
eview and push it to 3.4 and 3.4.0? > > Looks fine => pushed into libreoffice-3-4 branch, see > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4 >&id=97c995a22c1602679a3e386f994a20b23d07f429 > > We need two more reviews for 3-4-0 branch. +1 --

Re: [Libreoffice] [REVIEW][PUSHED] fdo#37433 German hyph dictionary failure

2011-05-23 Thread Lubos Lunak
On Monday 23 of May 2011, Tor Lillqvist wrote: > > We need 2 more reviews for the libreoffice-3-4-0 branch. > > +1 from me +1, pushed to 3-4-0. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesk

Re: [Libreoffice] [Review] [PUSHED] Patch for fdo#37429: crash when copy/paste table from writer to calc

2011-05-23 Thread Lubos Lunak
On Monday 23 of May 2011, Markus Mohrhard wrote: > Pushed to master. > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=d30c66cb1954103a159 >da2ef82dba4bf9685844f > > Would be nice if we could get 2 additional reviews for 3-4-0. +1, pushed to 3-4-0. -- Lubos Lunak

Re: [Libreoffice] [REVIEW] Compatibility option for old size of small caps text effect

2011-05-23 Thread Lubos Lunak
d by that one, as I cannot say for sure either way whether it matters for sw or not. However as the result with the patch looks ok to me I decided not to change that one, as I have no idea how I'd propagate the option to editeng from sw anyway. -- Lubos Lunak l.lu...@suse.cz _

Re: [Libreoffice] 3-4 build problem: sw module: ‘class SwDrawView’ has no member named ‘UpdateDrawLayersRegion’

2011-05-20 Thread Lubos Lunak
check if my repos are > up-to-date? I used status for it. I will try with LibreOfficeLinux > distro. Is it problem if I build with Ubuntu/8.04 on 32 and 64 bit? It is not enough to rebuild just sw, you also need to rebuild the module where the change triggering this h

[Libreoffice] [REVIEW] Compatibility option for old size of small caps text effect

2011-05-20 Thread Lubos Lunak
been changed again. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] bison 2.5 breaks build process

2011-05-19 Thread Lubos Lunak
ar*)' > [-fpermissive] > > Afaik this can be fixed with adding -fpermissive to the CXXFLAGS. > But is this the proper fix? No. Presumably the new bison version finally realized it's 21st century and started using const char* instead of plain char* when referring const stri

[Libreoffice] LO with clean configuration unusable

2011-05-17 Thread Lubos Lunak
about plugins). The commit responsible for this problem is f9496177a4c942f2acc39a978a3cd65689f14d8d in libs-gui. I don't understand the code, but apparently the new constraints introduced by the commit are not met by code using the class. -- Lubos Lunak l.lu...@su

Re: [Libreoffice] [REVIEW] Fix for 35805 to cherry-pick in 3.4

2011-05-11 Thread Lubos Lunak
t least fdo#37013 too. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Bug in main function libs-core/desktop/source/app/app.cxx ?

2011-04-28 Thread Lubos Lunak
ems to be pointless, as ReleaseSolarMutex() would just return 0 otherwise. The -1 is to compensate for this one additional acquire. Just confused and pointless, as far as I can say. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Introduce HideDisabledMenuItems style setting

2011-04-28 Thread Lubos Lunak
p the same switch in a very misleading way. > > Thanks for the nice patches, which I just pushed. > > So sorry it took a week to get this, IMHO helpful and sensible cleanup > pushed. I've reverted the KDE parts of the patch as they do not match K

Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-28 Thread Lubos Lunak
indows 8 decides that all icons should be pink on green, then probably LO on W8 should paint icons that way too. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

2011-04-28 Thread Lubos Lunak
KDE hidding any disabled menu items anywhere, AFAIK they always get just greyed out. I don't have any access to OS X, so I don't know there, but a google query turned up [*], which also seems to just do that instead of hiding. [*] http://macintopics.com/media/2010/06/context-menu-text-s

[Libreoffice] [PUSHED] Re: [PATCH] Error dialog when a component is missing

2011-04-26 Thread Lubos Lunak
On Friday 22 of April 2011, Kohei Yoshida wrote: > Hi Lubos, > > On Fri, 2011-04-22 at 15:36 +0200, Lubos Lunak wrote: > > Hello, > > > > could somebody review the attached patch for bnc#689116? When e.g. > > Writer is not installed (which can happen with split

Re: [Libreoffice] OSL_ASSERT - remove backtrace or make abort

2011-04-22 Thread Lubos Lunak
On Friday 22 of April 2011, Jan Holesovsky wrote: > Hi Lubos, > > On 2011-04-21 at 17:12 +0200, Lubos Lunak wrote: > > > Then, there's sal-disable-backtrace.diff, > > > which I can happily merge - just set DISABLE_SAL_BACKTRACE then. > > > > Again, it

[Libreoffice] [PATCH] Error dialog when a component is missing

2011-04-22 Thread Lubos Lunak
r it to be checked as I have no clue about LO UI string handling or error handling (and I bow to the creativitity of whoever has created this complex error handling system). -- Lubos Lunak l.lu...@suse.cz diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx index 868dfc1..b4186d3 100644 --- a/

Re: [Libreoffice] OSL_ASSERT - remove backtrace or make abort

2011-04-21 Thread Lubos Lunak
'Generic input/output error' :(. But I don't know a good universal solution to this, it probably required fixing code that does things like this. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] OSL_ASSERT - remove backtrace or make abort

2011-04-21 Thread Lubos Lunak
On Wednesday 20 of April 2011, Thorsten Behrens wrote: > Lubos Lunak wrote: > > I'd like to remove the backtrace printing from OSL_ASSERT and friends, > > or, even better and if possible, make these functions work properly, i.e. > > abort on failure (I'm not really

Re: [Libreoffice] consistent namespaces & future breakage ...

2011-04-20 Thread Lubos Lunak
it be said more specifically what we cannot fix currently? As I understand it we cannot break backwards compatibility only for things related to extensions (UNO, what else?), but even there I'm not sure what that all means code-wise. -- Lubos L

Re: [Libreoffice] Mouse with horizontal wheel

2011-04-19 Thread Lubos Lunak
fy this bug, let alone fix this behavior. The attached small app fakes a single scroll to the left (change the 6's to 7's for right). Compile and link with something like 'g++ a.cpp -lXtst -lX11'. -- Lubos Lunak l.lu...@suse.cz #include #include int main( int argc, char*

[Libreoffice] OSL_ASSERT - remove backtrace or make abort

2011-04-19 Thread Lubos Lunak
would be able to successfully run LO for some time :), so that'd require a transitional period, e.g. similar to how compile warnings are fixed to make compilation with -Werror possible. No idea how much effort this would be, it's the technically right way, but I don't

Re: [Libreoffice] Proposing a new Easy Hack - project consistent namespaces

2011-04-19 Thread Lubos Lunak
d as such it needs to be kept for backwards compatibility for extensions. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused chunk of toolbar menu code

2011-04-19 Thread Lubos Lunak
On Tuesday 19 of April 2011, Christian Dywan wrote: > I stumbled upon a big chunk of code that's commented out in > ToolbarMenu::implPaint not touched since November 2005. Pushed, thanks. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice m

Re: [Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE

2011-04-19 Thread Lubos Lunak
On Tuesday 19 of April 2011, Christian Dywan wrote: > > Am 19.04.2011 13:35:54 schrieb Lubos Lunak: > > I think it makes more sense to have it as a style setting rather than > > hardcoding a bunch of if's > > I don't think it makes sense as a setting, and no platf

Re: [Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE

2011-04-18 Thread Lubos Lunak
lineedit popups only, or generic? In the latter case it should just go to SetAccelKey(). > and I saw get_desktop_session() but > that isn't public API and I'm not sure how it's meant to be used. If > there's a better approach, pointers welcome. &g

Re: [Libreoffice] -Wl,-O1 (was Reducing -ggdb3 to -ggdb2)

2011-04-13 Thread Lubos Lunak
On Tuesday 12 of April 2011, Bjoern Michaelsen wrote: > Hi Lubos, > > On Tue, 12 Apr 2011 16:25:58 +0200 > > Lubos Lunak wrote: > > > solenv/inc/unxgcc.mk:LINKFLAGSOPTIMIZE*=-Wl,-O1 > > > > No, I forgot to mention, that's not the one: > > [...]

[Libreoffice] -Wl,-O1 (was Reducing -ggdb3 to -ggdb2)

2011-04-12 Thread Lubos Lunak
On Tuesday 12 of April 2011, Caolán McNamara wrote: > On Tue, 2011-04-12 at 16:01 +0200, Lubos Lunak wrote: > > it. Almost five times the size of data is really a lot more data for I/O > > to shuffle back and forth. > > I noticed recently that my linux --eanble-symbols solver

[Libreoffice] Reducing -ggdb3 to -ggdb2

2011-04-12 Thread Lubos Lunak
. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] a faster gnumake ? ...

2011-04-05 Thread Lubos Lunak
n up to all but the last > few chars > iow a likely poor performing sort. If this really would be significant in practice, then the sort could first compare lengths of the strings and then go backwards (or even have a hash) - if only uniqueness is needed, then it doesn't matter what t

Re: [Libreoffice] component_writeInfo bits ...

2011-04-04 Thread Lubos Lunak
e looks as something LO-related rather than KDE-related. Maybe Kendy knows. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] if (foo == sal_True)

2011-04-01 Thread Lubos Lunak
as converting to bool converts any non-zero to true (which has the value of 1 with gcc, although I'm not quite sure the spec mandates this). So if in those examples above the return type and the type of the variable were bool, this just works (unlike sal_Bool). With bool it can break only if

Re: [Libreoffice] Purpose of easy task 'Get rid of sal_uLong' ?

2011-03-31 Thread Lubos Lunak
On Wednesday 30 of March 2011, Bjoern Michaelsen wrote: > Lubos Lunak wrote: > > If it's used for marshalling, then it can't be changed. Or, if it > > can, then it doesn't matter if the data would be simply marshalled as > > int. > > Some sal_* =&g

Re: [Libreoffice] Purpose of easy task 'Get rid of sal_uLong' ?

2011-03-30 Thread Lubos Lunak
On Tuesday 29 of March 2011, Bjoern Michaelsen wrote: > Hi Lubos, > > On Tue, 29 Mar 2011 15:11:44 +0200 > > Lubos Lunak wrote: > > Why not? I generally just need a number and int fits that perfectly. > > I really don't care how many bits it has as long as it wo

Re: [Libreoffice] Purpose of easy task 'Get rid of sal_uLong' ?

2011-03-29 Thread Lubos Lunak
On Monday 28 of March 2011, Bjoern Michaelsen wrote: > Hi Lubos, > On Mon, 28 Mar 2011 12:45:11 +0200 > > Lubos Lunak wrote: > > Specifically, the simple and logical type for numbers happens to be > > 'int'. Some kind of intptr type is usually only for ugly ha

[Libreoffice] Purpose of easy task 'Get rid of sal_uLong' ?

2011-03-28 Thread Lubos Lunak
'? And, looking at this description, is there any plan to get rid of these superfluous sal_xxx types eventually? [*] http://wiki.documentfoundation.org/Development/Easy_Hacks#Get_rid_of_sal_uLong -- Lubos Lunak l.lu...@suse.cz ___ LibreOff

Re: [Libreoffice] -Woverloaded-virtual

2011-03-28 Thread Lubos Lunak
On Friday 25 of March 2011, Pierre-André Jacquod wrote: > Hello, > > On 03/25/2011 02:13 PM, Lubos Lunak wrote: > > On Friday 25 of March 2011, Caolán McNamara wrote: > >> argh!, I meant to say "then things are *not* too bad", not "*too* bad". > >

Re: [Libreoffice] [PATCH] fdo#34908

2011-03-28 Thread Lubos Lunak
no-)exceptions should be completely unrelated to RTTI. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] fdo#34908

2011-03-25 Thread Lubos Lunak
ypeid( *pFieldmark ).name(), pCheckboxFm, dynamic_cast< void* >( pCheckboxFm ), typeid( *pCheckboxFm ).name()); (where 'ptr' is what you get from the pMarksAccess->makeNoTextFieldBookmark() call before casting to anything). -- Lubos Lunak l.lu...@suse.cz ___

Re: [Libreoffice] -Woverloaded-virtual

2011-03-25 Thread Lubos Lunak
On Friday 25 of March 2011, Caolán McNamara wrote: > On Fri, 2011-03-25 at 13:55 +0100, Lubos Lunak wrote: > > It should be the current full list, with duplicates removed (i.e. once > > per every source of the problem, not once per every time it's reported). > >

Re: [Libreoffice] -Woverloaded-virtual

2011-03-25 Thread Lubos Lunak
On Thursday 24 of March 2011, Caolán McNamara wrote: > On Thu, 2011-03-24 at 17:29 +0100, Lubos Lunak wrote: > > a list of warnings (duplicates removed). > > I don't want to enable the warning right now, since although I've > > already reduced the number of warnin

Re: [Libreoffice] -Woverloaded-virtual

2011-03-24 Thread Lubos Lunak
em. There were tons of them initially (it's header files that trigger them), but my patch for fixing SdrObject::operator=() has cleaned up most of them. It's probably good enough to go now. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice

Re: [Libreoffice] -Woverloaded-virtual

2011-03-24 Thread Lubos Lunak
On Thursday 24 of March 2011, Lubos Lunak wrote: > Attached is a patch for introducing the warning (quite obvious) and a list > of warnings (duplicates removed). I don't want to enable the warning right > now, since although I've already reduced the number of warnings, I don

[Libreoffice] Disabling unit tests building?

2011-03-21 Thread Lubos Lunak
). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] nullptr, was: Suggestion: Let's switch to using MSVC2010 on Windows for master

2011-03-16 Thread Lubos Lunak
lers we care about, then we could switch to nullptr and #define it ourselves when not provided by the compiler automatically. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Using LibreOffice Editor as a widget in a third-party application

2011-03-09 Thread Lubos Lunak
quite easy, but making it reasonably right gets increasingly painful, especially if the embedded app has no support for it (client side of XEmbed, etc.). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lis

Re: [Libreoffice] [PATCH] Remove useless comments.

2011-03-04 Thread Lubos Lunak
On Friday 04 of March 2011, Guillaume Poussel wrote: > And again new patches attached (2/2) > > 2011/3/3 Guillaume Poussel : > > Attached patches for components and filters. Pushed (all 7 patches in the 3 mails), thanks. -- Lubos Lunak

<    2   3   4   5   6   7   8   >