[PATCH libreoffice-4-0] the print range can start in row 0, fdo#62938

2013-06-02 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4138 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/4138/1 the print range can start in row 0, fdo#62938 Change-Id: I8569e4e120a6fd2b626db0bdaadf5d9234d09a36 --- M

[PATCH libreoffice-4-0] r is an optional attribute in c and r, fdo#65059

2013-05-29 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4088 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/4088/1 r is an optional attribute in c and r, fdo#65059 Change-Id: Ic954cc5692ddc899f8a6fa99466bc0c8a83da352 --- M

[PATCH libreoffice-4-0] range names need to be checked upper case, fdo#64031

2013-05-27 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4050 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/4050/1 range names need to be checked upper case, fdo#64031 Change-Id: I540821fd7058bf0da27d955c9d966a10dd21ec94 --- M

[PATCH libreoffice-4-0] we need a reference to the DifParser.aData, fdo#64920

2013-05-27 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4054 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/4054/1 we need a reference to the DifParser.aData, fdo#64920 regression from 6191fa0847ac5b27083efe1a8c6cd84d080a638c

[PUSHED libreoffice-4-1] Typo in optsecuritypage.ui

2013-05-27 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4057 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4057 To unsubscribe,

[PUSHED] Typo in optsecuritypage.ui

2013-05-27 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4056 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4056 To unsubscribe,

[PATCH libreoffice-4-0] restore old behavior for external references, fdo#64229

2013-05-27 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4062 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/4062/1 restore old behavior for external references, fdo#64229 Change-Id: Iae160607447ff6e1133f9e1e6f9c6a9f1e7bd7ab

[PATCH libreoffice-4-0] correctly delete note captions, fdo#64068

2013-05-27 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4066 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/4066/1 correctly delete note captions, fdo#64068 This fixes fdo#64068 and correctly without reintroducing the crash

[PUSHED] Delete double whitespace in optsecuritypage.ui

2013-05-26 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4040 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4040 To unsubscribe,

[PUSHED libreoffice-4-1] Delete double whitespace in optsecuritypage.ui

2013-05-26 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4041 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4041 To unsubscribe,

[PATCH libreoffice-4-0] remove chart listener when chart is deleted, fdo#64639

2013-05-26 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4045 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/4045/1 remove chart listener when chart is deleted, fdo#64639 Change-Id: I7ebf75f49c89edcb0bba3a597ba24ac1c0a655ef ---

[PATCH libreoffice-3-6] remove chart listener when chart is deleted, fdo#64639

2013-05-26 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4046 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/4046/1 remove chart listener when chart is deleted, fdo#64639 Change-Id: I7ebf75f49c89edcb0bba3a597ba24ac1c0a655ef ---

[PUSHED libreoffice-4-0] resolved fdo#64384 check subtotal row filtered also for sing...

2013-05-11 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3847 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3847 To unsubscribe,

[PUSHED] Calc sort: Use method GetSortKeyCount from SortParam

2013-05-07 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3816 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3816 To unsubscribe,

[PUSHED] fdo#51828 - UI: Sort: can use more than 3 criteria once only...

2013-05-06 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3772 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3772 To unsubscribe,

[PATCH libreoffice-4-0] map full transparent solid fill to no fill, fdo#64224

2013-05-05 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3792 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/3792/1 map full transparent solid fill to no fill, fdo#64224 Change-Id: I9ec33b347647bfcd6c1411c4db7af51ca597dc8e

[PATCH libreoffice-4-0] let us be explicit about default values

2013-05-05 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3793 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/3793/1 let us be explicit about default values Different MSO versions behave differently in respect to the default

[ABANDONED] export zoom factor correctly to OOXML

2013-05-03 Thread Markus Mohrhard (via Code Review)
Markus Mohrhard has abandoned this change. Change subject: export zoom factor correctly to OOXML .. Patch Set 1: Abandoned Noel fixed it already -- To view, visit https://gerrit.libreoffice.org/3691 To unsubscribe, visit

[PATCH libreoffice-4-0] change order to allow validation of chart part

2013-04-29 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3657 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/3657/1 change order to allow validation of chart part My simple test file is finally valid but is still now shown in

[PUSHED libreoffice-4-0] Resolves: fdo#51556 allow tab traversing into the conditiona...

2013-04-29 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3656 Approvals: Markus Mohrhard: Verified; Looks good to me, approved Tor Lillqvist: Looks good to me, but someone else must approve -- To

[PATCH] c:varyColor is true by default in Excel

2013-04-29 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3683 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/3683/1 c:varyColor is true by default in Excel And another step closer to opening my test file correctly in Excel.

[PATCH] c:delete is true by default in Excel

2013-04-29 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3684 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/3684/1 c:delete is true by default in Excel One step closer to opening my simple test file correctly in Excel.

[ABANDONED] c:varyColor is true by default in Excel

2013-04-29 Thread Markus Mohrhard (via Code Review)
Markus Mohrhard has abandoned this change. Change subject: c:varyColor is true by default in Excel .. Patch Set 1: Abandoned should have gone to libreoffice-4-0 -- To view, visit https://gerrit.libreoffice.org/3683 To

[ABANDONED] c:delete is true by default in Excel

2013-04-29 Thread Markus Mohrhard (via Code Review)
Markus Mohrhard has abandoned this change. Change subject: c:delete is true by default in Excel .. Patch Set 1: Abandoned should have gone to libreoffice-4-0 -- To view, visit https://gerrit.libreoffice.org/3684 To

[PATCH libreoffice-4-0] c:delete is true by default in Excel

2013-04-29 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3685 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3685/1 c:delete is true by default in Excel One step closer to opening my simple test file correctly in Excel.

[PATCH libreoffice-4-0] c:varyColor is true by default in Excel

2013-04-29 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3686 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/3686/1 c:varyColor is true by default in Excel And another step closer to opening my test file correctly in Excel.

[PATCH] export zoom factor correctly to OOXML

2013-04-29 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3691 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/3691/1 export zoom factor correctly to OOXML Change-Id: I6ab21e46e63a4d1597eb79de91533448fef0cfbc --- M

[PATCH] show formula results of new formulas even if auto calc is di...

2013-04-26 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3625 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/3625/1 show formula results of new formulas even if auto calc is disabled This change might cost us a bit of

[PATCH] enable symbols and disable optimization in openssl for a dbg...

2013-04-19 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3489 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/3489/1 enable symbols and disable optimization in openssl for a dbgutil build Change-Id:

[PATCH] Fix https://-related crashes.

2013-04-19 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3488 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3488/1 Fix https://-related crashes. The internal openssl on 64bit linux was built as linux-generic32, instead of

[ABANDONED] Fix https://-related crashes.

2013-04-19 Thread Markus Mohrhard (via Code Review)
Markus Mohrhard has abandoned this change. Change subject: Fix https://-related crashes. .. Patch Set 1: Abandoned already merged, was just cherry-picked into that build -- To view, visit https://gerrit.libreoffice.org/3488

[PUSHED] fdo#61135: adding help button to stepped lines dialog.

2013-04-18 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3445 -- To view, visit https://gerrit.libreoffice.org/3445 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED libreoffice-3-6] resolved rhbz#918544 do not attempt to access non-existing f...

2013-04-18 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3460 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3460 To unsubscribe,

[PUSHED] Adding the dialog for setting stepped lines.

2013-04-12 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3345 -- To view, visit https://gerrit.libreoffice.org/3345 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED libreoffice-4-0] fdo#51828 - UI: Sort: can use more than 3 criteria once only

2013-04-11 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3350 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3350 To unsubscribe,

[PATCH libreoffice-4-0] disable cached value import for ODS for now, fdo#60215

2013-04-09 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3290 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/3290/1 disable cached value import for ODS for now, fdo#60215 Change-Id: I714e75112727f5ebcd8cc55cf4f70dd15eb9b810 ---

[ABANDONED] fdo#51656 Mean value line starts in wrong place

2013-04-01 Thread Markus Mohrhard (via Code Review)
Markus Mohrhard has abandoned this change. Change subject: fdo#51656 Mean value line starts in wrong place .. Patch Set 1: Abandoned See https://gerrit.libreoffice.org/#/c/3122/ for the original review request. Please note

[PUSHED] fdo#51656 : Mean value line starts in wrong place in column ...

2013-04-01 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3122 -- To view, visit https://gerrit.libreoffice.org/3122 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Use local utility functions instead of SbxSimpleCharClass

2013-03-31 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3132 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3132 To unsubscribe,

[PUSHED] Converting spline dialog box to glade.

2013-03-28 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3102 -- To view, visit https://gerrit.libreoffice.org/3102 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED libreoffice-4-0-2] resolved fdo#44286 some historical dates were decremented

2013-03-26 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3037 Approvals: Markus Mohrhard: Verified; Looks good to me, approved Petr Mladek: Verified; Looks good to me, but someone else must approve

[PATCH libreoffice-4-0-2] use the right range representation, fdo#52159

2013-03-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2982 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/2982/1 use the right range representation, fdo#52159 Change-Id: I36ede89ccb8836708a4f87c4815bbe2fb6d6f3cf (cherry

[PATCH libreoffice-4-0-2] for internal data providers this makes no sense

2013-03-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2983 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/2983/1 for internal data providers this makes no sense Change-Id: Ic2651defd0ec8846dc0b0a81faee5dd6743310fb (cherry

[PATCH libreoffice-4-0-2] error bar range is also part of chart range, related fdo#521...

2013-03-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2984 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/2984/1 error bar range is also part of chart range, related fdo#52159 Change-Id:

[PATCH libreoffice-4-0-2] we need to register data sequences during import, fdo#52159

2013-03-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2985 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/2985/1 we need to register data sequences during import, fdo#52159 Change-Id:

[PATCH libreoffice-4-0] URM_INSDEL we need to update the src position, fdo#62206

2013-03-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2986 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/2986/1 URM_INSDEL we need to update the src position, fdo#62206 See ScFormulaCell::UpdateReference for a similar

[PUSHED libreoffice-4-0] Fix build

2013-03-15 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2767 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2767 To unsubscribe,

[PUSHED] coverity#989730 and coverity#989729: Uninitialized scalar fi...

2013-03-09 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2607 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2607 To unsubscribe,

[PUSHED] coverity#989728: uninitialized scalar

2013-03-09 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2609 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2609 To unsubscribe,

[PATCH libreoffice-4-0] use direct calls to set row height, fdo#61721

2013-03-09 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2615 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/2615/1 use direct calls to set row height, fdo#61721 Change-Id: I3c19e00b8ad2bc649b8e499cc869e3a4c488c343 (cherry

[PUSHED] group undo action when hiding/showing sheets

2013-03-09 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2579 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2579 To unsubscribe,

[PATCH libreoffice-4-0] respect nDelFlags, fdo#57661

2013-03-09 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2616 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/2616/1 respect nDelFlags, fdo#57661 Change-Id: I77d3e1f537b59504125d66f66f691d01f8f23894 (cherry picked from commit

[PATCH libreoffice-4-0] handle note export correctly, fdo#61165

2013-03-09 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2629 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2629/1 handle note export correctly, fdo#61165 This code was horribly over-optimized and that actually with an error.

[PUSHED libreoffice-4-0] fdo#54651: Only pick non-default number format for pivot fie...

2013-03-07 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2585 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2585 To unsubscribe,

[PATCH libreoffice-4-0] make all chart ranges explicitly 3D refs during import/expor...

2013-03-06 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2561 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/2561/1 make all chart ranges explicitly 3D refs during import/export, fdo#61781 Change-Id:

[PATCH libreoffice-4-0] prevent non-3D refs from being accepted in chart2, related f...

2013-03-06 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2562 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/2562/1 prevent non-3D refs from being accepted in chart2, related fdo#61781 Change-Id:

[PUSHED] Translate German comments to English in svmain.cxx

2013-03-06 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2529 -- To view, visit https://gerrit.libreoffice.org/2529 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH libreoffice-4-0] and one more fix for error bar import, related fdo#60083

2013-03-05 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2559 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/2559/1 and one more fix for error bar import, related fdo#60083 Change-Id: I76ff4849137aaad175b3c95dce6644d612871201

[PATCH libreoffice-4-0] another fix for error bar import, related fdo#60083

2013-03-05 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2560 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/2560/1 another fix for error bar import, related fdo#60083 Change-Id: I843a597702cb0cb66d8696c277666e1605091c09 --- M

[PATCH libreoffice-4-0] we need to use GetParentDialog nowadays, fdo#60253

2013-03-04 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2537 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/2537/1 we need to use GetParentDialog nowadays, fdo#60253 Change-Id: I6317ce1f99af58439f7009cac5a4bc133e404dbf (cherry

[PUSHED] Translated German comment, other comments updated for clarit...

2013-03-03 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2525 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2525 To unsubscribe,

[PUSHED] Comment translation german-english sw/source/ui/uno/

2013-03-03 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2530 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2530 To unsubscribe,

[ABANDONED] No need for commented out code.

2013-03-03 Thread Markus Mohrhard (via Code Review)
Markus Mohrhard has abandoned this change. Change subject: No need for commented out code. .. Patch Set 1: Abandoned Has been committed manually without the dictionaries and helpcontent2 change as

[PATCH] coverity#988423: fix memory leak

2013-02-27 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2458 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/2458/1 coverity#988423: fix memory leak Change-Id: I3ac2cca7e24e6cc1b47b42c2d42bc7caee91b559 --- M

[PATCH libreoffice-4-0] one more fix for error bar import, fdo#60083

2013-02-26 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2434 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/2434/1 one more fix for error bar import, fdo#60083 This makes it finally possible to import the original test

[PATCH libreoffice-4-0] remove the copied cond format cell attr entries, fdo#60306

2013-02-26 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2435 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/2435/1 remove the copied cond format cell attr entries, fdo#60306 The old exisiting conditional format entries in the

[PUSHED] Comment translation german - english - redo of writer.cxx

2013-02-15 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2140 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2140 To unsubscribe,

[PATCH libreoffice-3-6] support new attribute also in 3.6, fdo#60760

2013-02-15 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2159 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/2159/1 support new attribute also in 3.6, fdo#60760 Change-Id: I8beab492a3b9b42b323d7d6d9cebfbda1eae0ce1 --- M

[PUSHED] Comment translation german - english - redo of 5 files

2013-02-15 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2143 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2143 To unsubscribe,

[PUSHED libreoffice-4-0] bnc#802350: Cell validation is not a special (cell) content.

2013-02-15 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2128 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2128 To unsubscribe,

[PUSHED] Comment translation - german-english - 3 files

2013-02-15 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2157 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2157 To unsubscribe,

[PUSHED libreoffice-4-0] CELL needs to be recalculated during import as well, fdo#606...

2013-02-15 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2168 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2168 To unsubscribe,

[PUSHED libreoffice-3-6] fdo#39135: Prevent integer overflow update the character d...

2013-02-11 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2008 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2008 To unsubscribe,

[PUSHED libreoffice-4-0] bnc#801152: Scan all columns to determine the first data row...

2013-02-02 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1959 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1959 To unsubscribe,

[PUSHED libreoffice-3-6] resolved fdo#60078 correctly calculate IMCSCH and IMSECH

2013-02-02 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1927 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1927 To unsubscribe,

Change in core[libreoffice-4-0]: make it possible to update DDE links after loading, fdo#5903...

2013-01-31 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1940 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/1940/1 make it possible to update DDE links after loading, fdo#59032 Change-Id:

Change in core[libreoffice-4-0]: Hyperlink is an optional property, fdo#58858

2013-01-31 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1941 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/1941/1 Hyperlink is an optional property, fdo#58858 Change-Id: I30f2b0cdb72951a47cfd8d0091b5418fd59efe83 Reviewed-on:

Change in core[libreoffice-4-0]: if no cond format is valid use the existing protection, fdo#...

2013-01-31 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1942 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1942/1 if no cond format is valid use the existing protection, fdo#58826 Change-Id:

Change in core[libreoffice-4-0]: show style when dialog is created with existing cond format, ...

2013-01-31 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1943 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/1943/1 show style when dialog is created with existing cond format, fdo#59778 Change-Id:

Change in core[libreoffice-4-0]: we need to parse the cell address after import, fdo#59843

2013-01-31 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1944 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/1944/1 we need to parse the cell address after import, fdo#59843 Otherwise we may have problems with sheet names from

Change in core[libreoffice-4-0]: we need to use SCROW for row numbers, fdo#59894

2013-01-31 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1945 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/1945/1 we need to use SCROW for row numbers, fdo#59894 This caused an overflow and resulted in adding endless number

Change in core[libreoffice-4-0]: ODFF: write RRI as RRI, not ZGZ, fdo#60077

2013-01-30 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1922 -- To view, visit https://gerrit.libreoffice.org/1922 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

Change in core[master]: Hyperlink is an optional property, fdo#58858

2013-01-30 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1930 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/1930/1 Hyperlink is an optional property, fdo#58858 Change-Id: I30f2b0cdb72951a47cfd8d0091b5418fd59efe83 --- M

Change in core[libreoffice-4-0]: bnc#615357: Recompile cells with #NAME! for English function...

2013-01-30 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1931 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1931 To unsubscribe,

Change in core[master]: Use a method from UnoApitest instead of implement a new one ...

2013-01-30 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1923 -- To view, visit https://gerrit.libreoffice.org/1923 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Change in core[libreoffice-4-0]: reset automatic row height flag after import, fdo#59193

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1831 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/1831/1 reset automatic row height flag after import, fdo#59193 Change-Id: Ied9cb4a2b6a17d8c7b65f4fec3cb17219a5afa5b

[PATCH] Change in core[libreoffice-4-0-0]: reset automatic row height flag after import, fdo#59193

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1832 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/1832/1 reset automatic row height flag after import, fdo#59193 Change-Id: Ied9cb4a2b6a17d8c7b65f4fec3cb17219a5afa5b

[PUSHED] Change in core[libreoffice-4-0]: don't use ScDrawLayer::GetObjDataTab to get Anchor fix for f...

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1828 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1828 To unsubscribe,

[PUSHED] Change in core[libreoffice-4-0-0]: bnc#798271: Don't delete the PropertyMapEntry instance prema...

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1860 Approvals: Markus Mohrhard: Verified; Looks good to me, approved Miklos Vajna: Looks good to me, but someone else must approve -- To

[PATCH] Change in core[libreoffice-4-0]: import inherited number formats with cached values, fdo#5972...

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1866 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/1866/1 import inherited number formats with cached values, fdo#59724 Change-Id:

[PUSHED] Change in core[libreoffice-3-6]: bnc#798271: Don't delete the PropertyMapEntry instance prema...

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1859 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1859 To unsubscribe,

[PATCH] Change in core[libreoffice-4-0-0]: import inherited number formats with cached values, fdo#5972...

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1870 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/1870/1 import inherited number formats with cached values, fdo#59724 Change-Id:

[PUSHED] Change in core[libreoffice-4-0]: bnc#590020: Sort data points stably.

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1871 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1871 To unsubscribe,

[PUSHED] Change in core[libreoffice-3-6]: bnc#590020: Sort data points stably.

2013-01-25 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1872 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1872 To unsubscribe,

[PUSHED] Remove fprintf usage from vcl/builder

2013-01-22 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1813 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1813 To unsubscribe,

[PUSHED] Change in core[libreoffice-4-0]: resolved fdo#59583 prevent inappropriate column/row label de...

2013-01-21 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1796 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1796 To unsubscribe,

[PUSHED] Change in core[libreoffice-3-6]: resolved fdo#59583 prevent inappropriate column/row label de...

2013-01-21 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1797 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1797 To unsubscribe,

[PATCH] Change in core[libreoffice-4-0]: don't create multiple dialogs in the loop, fdo#59314

2013-01-20 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1778 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/1778/1 don't create multiple dialogs in the loop, fdo#59314 Change-Id: Ia48262cdf8b07caf6622f2d4a48f366f3f26c0fd --- M

[PATCH] Change in core[libreoffice-4-0]: prevent to create cond formats with empty range, fdo#58778

2013-01-20 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1780 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/1780/1 prevent to create cond formats with empty range, fdo#58778 Change-Id: I54bac843dc60c419c23c6d3f22c8d2f4b5805327

[PATCH] Change in core[libreoffice-4-0]: add missing data bar axis import, fdo#59578

2013-01-20 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1781 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/1781/1 add missing data bar axis import, fdo#59578 Change-Id: Id035741b2372c76f9afe54f59f2203c5edfbb0ae --- M

  1   2   >