Re: Crash test update

2019-07-22 Thread Tamas Zolnai
Hi Caolan, Péntek, Július 19, 2019 16:13 BST dátummal, Caolán McNamara ezt írta: > On Tue, 2019-07-16 at 18:07 +, Crashtest VM wrote: > > New crashtest update available at > > http://dev-builds.libreoffice.org/crashtest/f926de93c455f7cede505ad8cf849fe81eb514cf/ > > FWIW three or four

Re: sw_uiwriter hangs in testDateFormFieldCurrentDateInvalidation

2019-07-14 Thread Tamas Zolnai
Thanks for the note! I disabled the test for now, let's see if it fix tinderboxes. I'll check the test on Windows locally and fix it or remove it if this ProcessEventsToIdle() does not work correctly. I force pushed it because every second Windows build fails on gerrit, which is not very useful

Re: Crash test update

2018-02-19 Thread Tamas Zolnai
On Monday, February 19, 2018 12:25 GMT, "Tamas Zolnai" <tamas.zol...@collabora.co.uk> wrote: > Hi Caolan, > > Hétfő, Február 19, 2018 11:49 GMT dátummal, Caolán McNamara > <caol...@redhat.com> ezt írta: > > > On Sun, 2018-02-18 at 23:55 +00

Re: Crash test update

2018-02-19 Thread Tamas Zolnai
Hi Caolan, Hétfő, Február 19, 2018 11:49 GMT dátummal, Caolán McNamara ezt írta: > On Sun, 2018-02-18 at 23:55 +, Crashtest VM wrote: > > New crashtest update available at http://dev-builds.libreoffice.org/c > > rashtest/cf9e55538375e5c5dea173151f1d0386bd29ad4e/ > >

git-hook: Catch tab indentation also for makefiles

2017-09-04 Thread Tamas Zolnai
Hi there, I just noticed that for makefiles (*.mk) git does not check whether the commit contains tab indentation. As I know we use spaces also for makefiles for indentation, right? So I added a patch changing pre-commit hook to check tab also for makfiles:

Re: Backward compatibility or valid input

2017-05-16 Thread Tamas Zolnai
Hi Caolan, On Monday, May 15, 2017 12:33 BST, Caolán McNamara <caol...@redhat.com> wrote: > On Fri, 2017-05-12 at 18:20 +0100, Tamas Zolnai wrote: > > Caolan, I don't see a bug number in the commit message. So I don't > > know what was the actual test case there. Do y

Backward compatibility or valid input

2017-05-12 Thread Tamas Zolnai
Hi there, We've got an issue from an LO user about that LO does not import some tool generated Writer documents. I found that it's the same issue which was already reported here: https://bugs.documentfoundation.org/show_bug.cgi?id=100033 and was closed as won't fix. I'm not sure this was the

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-06 Thread Tamas Zolnai
://gerrit.libreoffice.org/#/c/34933/ Thanks, Tamás On Monday, March 06, 2017 18:40 GMT, "Tamas Zolnai" <tamas.zol...@collabora.co.uk> wrote: > Hi Stephan, > > I saw you reverted my change about config manager. Can you help me > understanding your comments

Re: Revert "tdf#106283: Registry settings are not read properly on Windows"

2017-03-06 Thread Tamas Zolnai
Hi Stephan, I saw you reverted my change about config manager. Can you help me understanding your comments, please. It's not all clear. Your commit message was: "Revert "tdf#106283: Registry settings are not read properly on Windows" This reverts commit 8cfda7206139b3017346c435591c77c9741ba8ee.

Re: Chart test failures on mac: text size differences

2017-03-06 Thread Tamas Zolnai
On Tuesday, February 28, 2017 23:42 GMT, Khaled Hosny <khaledho...@eglug.org> wrote: > On Tue, Feb 28, 2017 at 11:02:30PM +0000, Tamas Zolnai wrote: > > Hi Khaled, > > > > > I don’t think text width or height are that interesting, but they are > > &

Re: Chart test failures on mac: text size differences

2017-02-28 Thread Tamas Zolnai
Hi Khaled, > I don’t think text width or height are that interesting, but they are > probably a good approximation, so I repurposed one of the existing VCL > tests to test this[1]. I tried testing also the text bounding rectangle > but it showed a 1 pixel difference on Mac, this should be fixed

Re: Chart test failures on mac: text size differences

2017-02-27 Thread Tamas Zolnai
Hi Khaled, On Sunday, February 26, 2017 23:30 GMT, Khaled Hosny <khaledho...@eglug.org> wrote: > On Sat, Feb 25, 2017 at 09:58:58PM +0000, Tamas Zolnai wrote: > > Hi Khaled, > > > > > > However I think it would be better to debug this problem with a unit

Re: Chart test failures on mac: text size differences

2017-02-25 Thread Tamas Zolnai
Hi Khaled, > > However I think it would be better to debug this problem with a unit > > test in vcl module which tests directly the text rendering. I would > > suggest that if you are working making text rendering consitent. The > > vcldemo does something similar, but it's just doing the

Re: Chart test failures on mac: text size differences

2017-02-25 Thread Tamas Zolnai
Hi Khaled, On Friday, February 24, 2017 19:40 GMT, Khaled Hosny <khaledho...@eglug.org> wrote: > On Fri, Feb 24, 2017 at 05:41:25PM +0000, Tamas Zolnai wrote: > > Hi Khaled, > > > > I see you're working on text rendering, so I thought that my findings > >

Chart test failures on mac: text size differences

2017-02-24 Thread Tamas Zolnai
Hi Khaled, I see you're working on text rendering, so I thought that my findings might be usefull for you. I had a look at chart test failures on Mac and found that it is because of text size differences. (I checked your latest change [1], but the differences are still there.) Both text width

Re: Failing ChartDumpTest

2017-02-17 Thread Tamas Zolnai
Hi Telesto, Thanks for the message. I added a bigger delta for mac which will fix this building issue: https://gerrit.libreoffice.org/#/c/34362/ It seems on mac chart layouting works very differently, so can't test it using reference files created on Windows. Can you send a screenshot of one of

Re: validation issues with .pptx files

2016-12-20 Thread Tamas Zolnai
Hi Thorsten, On Tuesday, December 20, 2016 07:41 GMT, Thorsten Behrens <t...@libreoffice.org> wrote: > Tamas Zolnai wrote: > > On Monday, December 19, 2016 20:35 GMT, Xisco Fauli > > <xiscofa...@libreoffice.or> > > Testing the office-interoperability-tools

Re: imgcell not working on Master

2014-12-03 Thread Tamas Zolnai
On Wednesday, December 3, 2014 13:01 GMT, Stephan Bergmann sberg...@redhat.com wrote: On 12/02/2014 04:35 AM, TANAKA Hidemune wrote: For the following extensions, I suffer from the problem of LibreOffice Calc. http://extensions.libreoffice.org/extension-center/imgcell-1 I am

Refactor image handling

2014-10-27 Thread Tamas Zolnai
Hi there, Just a short note about that currently I'm working on refactoring of image handling (Graphic / GraphicObject). Mainly working on swapping mechanisms which cause a lot's of headache as I see. LO's bad swapping mechanism leads both to image loss and to ineffective behavior. So it's time

Re: build failure, clock_gettime undefined, linking libavmedialo.so

2014-05-16 Thread Tamas Zolnai
On Friday, May 16, 2014 15:00 BST, Terrence Enger ten...@iseries-guru.com wrote: Zolnai, My build of commit 48eccfb, fetched around 2014-05-16 00:57 UTC, is failing with messages: [build LNK] Library/libavmedialo.so

Re: [solved] build failure, clock_gettime undefined, linking libavmedialo.so

2014-05-16 Thread Tamas Zolnai
On Friday, May 16, 2014 20:38 BST, Terrence Enger ten...@iseries-guru.com wrote: On Fri, 2014-05-16 at 15:19 +0100, Tamas Zolnai wrote: On Friday, May 16, 2014 15:00 BST, Terrence Enger ten...@iseries-guru.com wrote: [snip] /home/terry/lo_hacking/git/libo2/workdir

Re: [Libreoffice-commits] core.git: 3 commits - sd/source slideshow/source

2014-04-16 Thread Tamas Zolnai
On Tuesday, April 15, 2014 23:15 BST, Thorsten Behrens t...@documentfoundation.org wrote: Zolnai Tamás wrote: --- a/slideshow/source/engine/shapes/appletshape.cxx +++ b/slideshow/source/engine/shapes/appletshape.cxx @@ -96,11 +96,11 @@ namespace slideshow virtual bool

Re: [Libreoffice-ux-advise] Vertical text alignment for frames

2014-03-06 Thread Tamas Zolnai
On Friday, February 28, 2014 06:15 GMT, Adolfo Jayme Barrientos f...@libreoffice.org wrote: On 2/27/14, Tamas Zolnai tamas.zol...@collabora.co.uk wrote: I think we can use the same combo box which we use for table (Table context menu - Table - Text flow - Alignment). I see two places

[Libreoffice-ux-advise] Vertical text alignment for frames

2014-02-27 Thread Tamas Zolnai
Hi there, I'm working on a new feature and I'd like to ask for some advise about the UI part. The feature I'm speaking about is text vertical alignment for frames (Insert - Frame). This text alignment works for drawing elements (shapes, text boxes) and for table cells, but not for frames. I

Vertical text alignment for frames

2014-02-26 Thread Tamas Zolnai
Hi there, I'm working on a new feature and I'd like to ask for some advise about the UI part. The feature I'm speaking about is text vertical alignment for frames (Insert - Frame). This text alignment works for drawing elements (shapes, text boxes) and for table cells, but not for frames. I

Re: Grouping UI elements

2014-01-16 Thread Tamas Zolnai
2014 Január 16, Csütörtök 14:43 GMT dátummal, Caolán McNamara caol...@redhat.com ezt írta: On Wed, 2014-01-15 at 14:25 +, Tamas Zolnai wrote: Main problem is that the 'Help' and the 'Extensions' buttons on the Start Center are in different GtkBoxes and so arrow key traversal

Re: Grouping UI elements

2014-01-16 Thread Tamas Zolnai
Hi Stuart, I think the problem is not with the used container (GtkBox or GtkGrid), but there is no a simple way to specify border to a container widget or to a custom PushButton and so people who implemented that two buttons were forced to use workarounds (GtkBox in GtkBox) to add the

Grouping UI elements

2014-01-15 Thread Tamas Zolnai
Hi Caolán, I'm working on part of this bug: https://bugs.freedesktop.org/show_bug.cgi?id=71764. Main problem is that the 'Help' and the 'Extensions' buttons on the Start Center are in different GtkBoxes and so arrow key traversal doesn't work between them. Nested GtkBoxes are necessary

Re: [Libreoffice-commits] core.git: 2 commits - include/sfx2 sfx2/source sfx2/uiconfig

2014-01-10 Thread Tamas Zolnai
2014 Január 10, Péntek 15:24 GMT dátummal, Stephan Bergmann sberg...@redhat.com ezt írta: On 01/10/2014 02:13 PM, Zolnai Tamás wrote: commit 60c7ed80643a6c397feebdd1492d6c3ef4d810be Author: Zolnai Tamás tamas.zol...@collabora.com Date: Fri Jan 10 03:31:46 2014 +0100 fdo#72947