[Libreoffice-commits] core.git: basctl/source bin/moveglobalheaders.sh cui/source dbaccess/inc dbaccess/source desktop/source editeng/source extensions/source filter/source framework/source include/to

2013-06-28 Thread Thomas Arnhold
(+), 93 deletions(-) New commits: commit 5cb2e3104b11e538b946e2b7228e74365cb38648 Author: Thomas Arnhold Date: Fri Jun 28 04:38:06 2013 +0200 remove toolkit/unohlp.hxx hack Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913 Reviewed-on: https://gerrit.libreoffice.org/4601

[Libreoffice-commits] core.git: 2 commits - connectivity/source include/vcl rsc/inc rsc/source

2013-06-28 Thread Thomas Arnhold
/rscibas.cxx| 13 ++ rsc/source/parser/rscicpx.cxx|4 +-- rsc/source/parser/rscinit.cxx|4 --- 7 files changed, 14 insertions(+), 75 deletions(-) New commits: commit 61fd1d2e7803516e88a18017ee5d6a34d6ca14fa Author: Thomas Arnhold Date: Fri

[Libreoffice-commits] core.git: scripting/source

2013-06-28 Thread Thomas Arnhold
|1 scripting/source/provider/ScriptImpl.cxx |1 scripting/source/provider/ScriptingContext.cxx|1 11 files changed, 38 deletions(-) New commits: commit 349d3b2bb5b771b9e6d42693c64ba7fa29379322 Author: Thomas Arnhold Date: Thu Jun 27 13:21

[PUSHED] fdo#43460 shell,vcl,xmlreader: use isEmpty()

2013-06-24 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/ Approvals: LibreOffice gerrit bot: Verified Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - 3 commits - editeng/source oox/source sd/source sw/source unotools/inc unotools/source vcl/generic vcl/source

2013-06-07 Thread Thomas Arnhold
files changed, 53 insertions(+), 53 deletions(-) New commits: commit d04ef1f208d6a32ffa3bdb56b951f85854bca897 Author: Thomas Arnhold Date: Tue May 28 10:53:03 2013 +0200 Make use of IsStarSymbol() Reviewed-on: https://gerrit.libreoffice.org/4077 Reviewed-by: Luboš Luňák

[PUSHED] Replace invalid doxygen commands: thrown -> throws

2013-06-03 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4136 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4136 To unsubscribe

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/uno

2013-06-02 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4129 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4129 To unsubscribe

[Libreoffice-commits] core.git: editeng/source include/unotools oox/source sd/source sw/source unotools/source vcl/generic vcl/source

2013-05-30 Thread Thomas Arnhold
8079f40743f86c4f7e6c9af8393ff699378a0797 Author: Thomas Arnhold Date: Tue May 28 10:53:03 2013 +0200 Make use of IsStarSymbol() Change-Id: I7a2e3a6f11bbaaaff50e8163e4ce3e2583b1d03c Reviewed-on: https://gerrit.libreoffice.org/4077 Reviewed-by: LuboÅ¡ Luňák Tested-by: LuboÅ

[Libreoffice-commits] core.git: starmath/sdi starmath/source starmath/uiconfig

2013-05-30 Thread Thomas Arnhold
/statusbar.xml |5 ++-- 5 files changed, 37 insertions(+), 2 deletions(-) New commits: commit 20824c118f21c1aad2672630f1c2ed7eecf5d2dd Author: Thomas Arnhold Date: Mon May 27 04:49:29 2013 +0200 fdo#63351 make use of ZoomSlider in StarMath In collaboration with Marcos Souza

Re: Dropping support for Visual Studio 2008 in master branch

2013-05-30 Thread Thomas Arnhold
On 29.05.2013 23:26, Mat M wrote: Or, as mentioned on the wiki [1], you can download the Driver Development Kit [2], which still includes ATL & MFC headers, at least in v7.1. And the EULA does not mark them as unusable or not distributable. 1: https://wiki.documentfoundation.org/Development/Buil

Re: Dropping support for Visual Studio 2008 in master branch

2013-05-29 Thread Thomas Arnhold
Hi Regina, On 29.05.2013 16:28, Regina Henschel wrote: Is a build possible with the Express version, on Windows 7, so that it includes ATL? No, the Express version doesn't include ATL. "The only legal way to do this is to purchase a retail version of Visual Studio C++ and install it on the s

Re: [PATCH] fdo#39468 - translate German comments

2013-05-29 Thread Thomas Arnhold
Hi Guillermo, because English is spoken and understood by more people than German. You have to look which language is most-spoken: http://en.wikipedia.org/wiki/List_of_languages_by_total_number_of_speakers So the better choice above English would only be Standard Chinese... Thomas On 29.05.2

[PATCH] fdo#39468 - translate German comments

2013-05-28 Thread Thomas Arnhold (via Code Review)
e.GetValue( eUnit ) ) ); } -- To view, visit https://gerrit.libreoffice.org/4079 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1324c2682873112fa7702b94fcaceab6de0b94d1 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60724 change spelling error REMOVEABLE -> REMOVABLE II

2013-05-28 Thread Thomas Arnhold (via Code Review)
_ACCESS_REMOVEABLE) != 0) { +if ((acc & RT_ACCESS_REMOVABLE) != 0) { attrs |= AccumulationBasedServiceEntity::Property:: ATTRIBUTE_REMOVABLE; } -- To view, visit https://gerrit.libreoffice.org/4078 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0057b9174af6a83f3fde0e27c3a91a4aeca95873 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Make use of IsStarSymbol()

2013-05-28 Thread Thomas Arnhold (via Code Review)
c 100644 --- a/vcl/source/gdi/outdev3.cxx +++ b/vcl/source/gdi/outdev3.cxx @@ -695,8 +695,7 @@ { // StarSymbol is a unicode font, but it still deserves the symbol flag if( !IsSymbolFont() ) -if( GetFamilyName().startsWithIgnoreAsciiCase( "starsymbol" ) -|| GetFamilyName

[Libreoffice-commits] core.git: editeng/source oox/source sd/source unotools/source vcl/generic

2013-05-27 Thread Thomas Arnhold
changed, 9 insertions(+), 7 deletions(-) New commits: commit a0f85534a71e5b04a8ca21c12ab3f04335f34344 Author: Thomas Arnhold Date: Thu May 23 19:49:08 2013 +0200 be case-insensitive for open/starsymbol comparison Change-Id: I7a342c809a723f5f9c03271c6145d9c367cea6de Reviewed-on

[PATCH] fdo#63351 make use of ZoomSlider in StarMath

2013-05-27 Thread Thomas Arnhold (via Code Review)
xmlns:xlink="http://www.w3.org/1999/xlink";> - - + + + -- To view, visit https://gerrit.libreoffice.org/4053 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibfb1eab1abef7b026eeb7fd7c0a778c433c9e208 Gerrit-PatchSet: 1 Gerrit-Pr

Re: Help on meanings of SDI fields

2013-05-27 Thread Thomas Arnhold
Hi Rodolfo, here's a list of attributes with a short description: http://wiki.openoffice.org/wiki/Framework/Article/Implementation_of_the_Dispatch_API_In_SFX2 Thomas On 27.05.2013 01:10, Rodolfo wrote: I need some help with .SDI definition syntax. Could anyone clarify me for these fields? Sp

[Libreoffice-commits] core.git: vcl/source

2013-05-25 Thread Thomas Arnhold
vcl/source/gdi/outdev3.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 5ccdfd28bf05703f2d4b3c0e2040dd6d500eb8d0 Author: Thomas Arnhold Date: Sun May 26 08:20:09 2013 +0200 fix OUString conversion no idea why hgminchob and hgpminchob are

[PUSHED] fix OUString conversion

2013-05-25 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4035 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4035 To unsubscribe

[PATCH] be case-insensitive for open/starsymbol comparison

2013-05-23 Thread Thomas Arnhold (via Code Review)
ot;StarSymbol" ) + (rTo.GetFamilyName().equalsIgnoreAsciiCase("OpenSymbol")) || + (rTo.GetFamilyName().equalsIgnoreAsciiCase("StarSymbol")) ) { rTo.SetSymbolFlag( true ); -- To view, visit https://gerrit.libreoffice.org/40

Re: Font family case-sensitiveness

2013-05-23 Thread Thomas Arnhold
Thanks, Stephan. Here are some more, now compared case-insensitive: https://gerrit.libreoffice.org/#/c/4015/ Thomas On 22.05.2013 11:09, Stephan Bergmann wrote: On 05/20/2013 03:35 PM, Caolán McNamara wrote: On Sun, 2013-05-19 at 18:24 +0200, Thomas Arnhold wrote: And maybe there is more

[PUSHED] fdo#39468 Comment translation GER-ENG

2013-05-20 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3965 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3965 To unsubscribe

[Libreoffice-commits] core.git: sw/source

2013-05-20 Thread Thomas Arnhold
sw/source/ui/vba/vbafield.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 869b787deeda5b45d5b0732d1bf777c26abce51e Author: Thomas Arnhold Date: Mon May 20 10:26:34 2013 +0200 add a copy and paste note Change-Id: I8dcb9c71f5c72bda24d55a6f550208f30e42cb4f diff

Font family case-sensitiveness

2013-05-19 Thread Thomas Arnhold
Hi, A quick grep on the source reveals that there case-sensitive and case-insensitive comparisons for the font family name. This looks pretty suspicious. git grep -i \"starsymbol\" -- *.cxx Should we always check case-insensitive or convert all lower-case ones to "StarSymbol" (most/all? def

[Libreoffice-commits] core.git: 2 commits - vcl/generic vcl/source

2013-05-19 Thread Thomas Arnhold
vcl/generic/fontmanager/fontsubst.cxx |8 vcl/source/gdi/outdev3.cxx|8 2 files changed, 8 insertions(+), 8 deletions(-) New commits: commit 43c234b0481fe63b8c4823affad066c6362f5068 Author: Thomas Arnhold Date: Sun May 19 18:00:39 2013 +0200 fix

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/ribbar...

2013-05-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3924 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3924 To unsubscribe

[PUSHED] fdo#39468 Translate German comments - graphicfilter

2013-05-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3955 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3955 To unsubscribe

[PUSHED] Changed compareTo to startsWith

2013-05-19 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3956 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3956 To unsubscribe

[Libreoffice-commits] core.git: vcl/source

2013-05-19 Thread Thomas Arnhold
vcl/source/gdi/outdev3.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 754fee5d1b6adcc04b58a834c84568585afd728a Author: Thomas Arnhold Date: Sun May 19 09:08:07 2013 +0200 don't check the same twice Chan

Re: Euro Converter Wizard

2013-05-15 Thread Thomas Arnhold
That sounds great :) Thomas On 15.05.2013 13:24, Xisco Faulí wrote: Hello, In that case we should add those currencies to the wizard because they aren't present right now. What about creating an extension of this wizard and dropping it from core so libreoffice wouldn't ship it by default to a

Re: Euro Converter Wizard

2013-05-15 Thread Thomas Arnhold
I'm for the removal, too. Thomas On 14.05.2013 12:54, Xisco Faulí wrote: Hello all, Euro Converter Wizard has become a bit outdated nowadays and I'm wondering if it'd convenient to get rid of it. Personally I'd do so, but I'd like to hear from you, especially from the libreoffice expect to de

[PUSHED] Update pch

2013-05-09 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3831 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3831 To unsubscribe

Re: Killing the gerrit to dev-list spam ...

2013-05-02 Thread Thomas Arnhold
On 02.05.2013 17:39, Thorsten Behrens wrote: If we remove all the [PATCH] from the ML, what is left ? a dev-discuss list ? It is already now the case that there is a disconnect between discussing code, or a concrete problem, and the subsequent gerrit patch submission (case in point: https://ger

Re: Killing the gerrit to dev-list spam ...

2013-05-02 Thread Thomas Arnhold
On 01.05.2013 21:33, Bjoern Michaelsen wrote: So, is there anyone who is _not_ a sponsored developer opposing to kill the mail spammage? If so: - could this be mitigated by a separate gerrit-patches mailing list? - could this be mitigated by a daily digest of "gerrit news"? - could this be mitig

[Libreoffice-commits] core.git: desktop/inc desktop/source desktop/unx sw/source

2013-04-28 Thread Thomas Arnhold
| 68 +++ 10 files changed, 93 insertions(+), 110 deletions(-) New commits: commit 2094610175140023cf8f904f8506c189e36dec06 Author: Thomas Arnhold Date: Sun Apr 28 10:36:40 2013 +0200 namespacing cleanup Change-Id

[Libreoffice-commits] core.git: cui/source starmath/source svtools/source svx/source sw/source uui/source

2013-04-27 Thread Thomas Arnhold
f8231a9765b63ef57d4e099936b94357267ac9b3 Author: Thomas Arnhold Date: Sat Apr 27 23:04:15 2013 +0200 some eco-activism Change-Id: Ib447cd8633c3102ee78c919cfbeabcc88018b130 diff --git a/cui/source/dialogs/hyphen.cxx b/cui/source/dialogs/hyphen.cxx index 26326647..e7bfc03 100644 --- a/cui/source/dialogs

[Libreoffice-commits] core.git: toolkit/source

2013-04-27 Thread Thomas Arnhold
toolkit/source/awt/vclxaccessiblecomponent.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 43937af87eaac37be5153abea9f8d83681bbf904 Author: Thomas Arnhold Date: Sat Apr 27 17:14:12 2013 +0200 this is stupid anyhow vclevent.hxx was indirectly

[PUSHED] Remove useless commented out code.

2013-04-27 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3631 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3631 To unsubscribe

[Libreoffice-commits] core.git: forms/source fpicker/source

2013-04-27 Thread Thomas Arnhold
forms/source/richtext/richtextmodel.cxx |3 --- fpicker/source/win32/filepicker/dialogcustomcontrols.cxx |3 --- 2 files changed, 6 deletions(-) New commits: commit 7b4d85901bf525d10e6155fb5682d0bbdf5607e2 Author: Thomas Arnhold Date: Sat Apr 27 12:04:20 2013 +0200

[Libreoffice-commits] core.git: basic/source

2013-04-26 Thread Thomas Arnhold
basic/source/runtime/dllmgr-x64.cxx |3 +++ basic/source/runtime/dllmgr-x86.cxx |3 +++ 2 files changed, 6 insertions(+) New commits: commit 52b71a2b5ecd60200fdc0868261154673ba96f35 Author: Thomas Arnhold Date: Fri Apr 26 18:45:27 2013 +0200 fix windows build Change-Id

[Libreoffice-commits] core.git: sc/qa

2013-04-26 Thread Thomas Arnhold
|3 +++ sc/qa/extras/sctablesheetobj.cxx |3 +++ sc/qa/extras/sctablesheetsobj.cxx |3 +++ 14 files changed, 41 insertions(+) New commits: commit 934a179b75de2385f1235847a3cbbf8c92480ec3 Author: Thomas Arnhold Date: Fri Apr 26 18:17:53 2013 +0200 forgot those

[Libreoffice-commits] core.git: sc/qa

2013-04-26 Thread Thomas Arnhold
sc/qa/extras/scdatapilottableobj.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 50600ee5c18ca60c91b5690287133b3ffdc308af Author: Thomas Arnhold Date: Fri Apr 26 18:09:50 2013 +0200 fix Change-Id: I0b6634e15034fbe9cd77c4149494839152823783 diff --git a/sc/qa

[Libreoffice-commits] core.git: accessibility/inc basic/source chart2/source xmloff/source xmlsecurity/source

2013-04-26 Thread Thomas Arnhold
/registerservices.cxx |2 16 files changed, 59 insertions(+), 90 deletions(-) New commits: commit 1e83da9aedda51aaef7e105187ae9a6a385f15d3 Author: Thomas Arnhold Date: Fri Apr 26 17:14:48 2013 +0200 some more namespace cleanup Change-Id

[Libreoffice-commits] core.git: include/test test/source

2013-04-26 Thread Thomas Arnhold
|3 ++- test/source/util/xsearchable.cxx |3 ++- 60 files changed, 128 insertions(+), 182 deletions(-) New commits: commit add638b725bb9e5c94b33f6802483bc7101e3681 Author: Thomas Arnhold Date: Fri Apr 26 14:38:52 2013 +0200 test: clean up namespacing Change

[Libreoffice-commits] core.git: include/test include/toolkit test/source toolkit/source

2013-04-25 Thread Thomas Arnhold
|5 + 5 files changed, 52 insertions(+), 62 deletions(-) New commits: commit e35f2f0631784c1f58dbef5cb819a48b3a4703f4 Author: Thomas Arnhold Date: Thu Apr 25 17:02:30 2013 +0200 don't pollute global namespace Change-Id: Iffeeffb015c59ea787838c737c6a11f6fbef2794 diff --

[Libreoffice-commits] core.git: dbaccess/inc oox/inc sal/inc sc/inc sd/inc starmath/inc svtools/inc svx/inc sw/inc vcl/inc xmloff/inc

2013-04-25 Thread Thomas Arnhold
|2 - 12 files changed, 96 insertions(+), 12 deletions(-) New commits: commit 360d6bf4fd1241af47f55648b7597fda3120390a Author: Thomas Arnhold Date: Thu Apr 25 12:11:25 2013 +0200 update pch Change-Id: I67e73438312f2a672e71762ee6707ec5d425bb47 diff --git a/dbaccess/inc/pch

Re: Compilation fails with --enable-pch after global header move

2013-04-25 Thread Thomas Arnhold
On 25.04.2013 09:35, Stephan Bergmann wrote: git grep -Fw using include/ | grep -Fw beans reveals that some headers dare pollute the global namespace with inappropriate using directives. /All/ those using directives (not just the ones injecting com::sun::star::uno::beans) apparently need to be

Re: Empty Advanced options page on Windows

2013-04-24 Thread Thomas Arnhold
On 24.04.2013 17:12, Stephan Bergmann wrote: On Linux with no JRE installed it works. The list is just empty. But maybe Kohei's Windows build was configure --without-java, and that would make the difference? (Seeing that SOLAR_JAVA does get mentioned in the relevant parts of module cui.) Ind

Re: Empty Advanced options page on Windows

2013-04-24 Thread Thomas Arnhold
On 23.04.2013 16:40, Caolán McNamara wrote: On Wed, 2013-04-17 at 08:49 -0400, Kohei Yoshida wrote: Hi there, I just completed my Windows build of the master branch and noticed that, the Advanced options page is for some reason totally blank. If my attachment goes through, you can see it in t

[Libreoffice-commits] core.git: 2 commits - editeng/inc svx/inc

2013-04-22 Thread Thomas Arnhold
editeng/inc/editeng/editids.hrc |6 +++--- svx/inc/svx/svxids.hrc |1 - 2 files changed, 3 insertions(+), 4 deletions(-) New commits: commit 5639cb44547b01443b772d02cb131342ec49ae20 Author: Thomas Arnhold Date: Mon Apr 22 15:17:14 2013 +0200 editeng: move two double used

[Libreoffice-commits] core.git: sfx2/inc

2013-04-22 Thread Thomas Arnhold
sfx2/inc/sfx2/sfxsids.hrc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9d6a0fe7f0ae636079782a48a9b33b5e50ca2c1d Author: Thomas Arnhold Date: Mon Apr 22 15:02:34 2013 +0200 SID_ATTR_TEXT_FITTOSIZE is already using this slot Change-Id

Re: Empty Advanced options page on Windows

2013-04-20 Thread Thomas Arnhold
Hi Kohei, I tried it with the latest daily build but can't confirm your problem. Version: 4.1.0.0.alpha0+ Build ID: fa72fc3eddbfabb82193452a4ba993b11d1584d TinderBox: Win-x86@6, Branch:master, Time: 2013-04-18_23:11:53 Thomas On 17.04.2013 15:19, Thomas Arnhold wrote: Hi Kohei, seems

[PATCH] fdo#63749: #118845# corrected missing ressource for gallery ...

2013-04-20 Thread Thomas Arnhold (via Code Review)
, please !!! -- To view, visit https://gerrit.libreoffice.org/3507 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I263bc8bcd4232d8e9b4a971fd611b451840618a3 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-O

[Libreoffice-commits] core.git: svx/inc

2013-04-20 Thread Thomas Arnhold
svx/inc/galtheme.hrc|4 svx/inc/svx/gallery.hxx |1 + 2 files changed, 5 insertions(+) New commits: commit be3bf9c62d9928fc67a5eb8609c06087d5c1fd22 Author: Thomas Arnhold Date: Sat Apr 20 13:12:50 2013 +0200 gallery: add some hints Change-Id

[Libreoffice-commits] core.git: scp2/macros

2013-04-18 Thread Thomas Arnhold
scp2/macros/macro.pl | 36 1 file changed, 36 deletions(-) New commits: commit bb59404622c7198ff539cc58fc26d0371a6c5cd3 Author: Thomas Arnhold Date: Thu Apr 18 17:53:32 2013 +0200 remove unused macros from macro.pl Change-Id

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3423 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3423 To unsubscribe

Re: officecfg: reformat using xmllint

2013-04-17 Thread Thomas Arnhold
? :) Thomas On 17.04.2013 13:13, Stephan Bergmann wrote: On 04/17/2013 03:20 AM, Thomas Arnhold wrote: does anyone have objections against running xmllint on officecfg like fe4260c53e7df91a4d2dad06104d7979a212de29 did? Isn't xmllint --fromat, without access to a DTD, fundamentally flawed, in th

Re: Empty Advanced options page on Windows

2013-04-17 Thread Thomas Arnhold
t I'm compiling it during the weekend for myself. Thomas On 17.04.2013 15:19, Thomas Arnhold wrote: Hi Kohei, seems to be my fault (7c48a2a83f4a92200c7f2b0f259bf1684d253436). I'll investigate it. Thomas On 17.04.2013 14:49, Kohei Yoshida wrote: Hi there, I just completed my Windo

Re: Empty Advanced options page on Windows

2013-04-17 Thread Thomas Arnhold
Hi Kohei, seems to be my fault (7c48a2a83f4a92200c7f2b0f259bf1684d253436). I'll investigate it. Thomas On 17.04.2013 14:49, Kohei Yoshida wrote: Hi there, I just completed my Windows build of the master branch and noticed that, the Advanced options page is for some reason totally blank. If

[PUSHED] update dictionaries

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3429 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3429 To unsubscribe

[Libreoffice-commits] core.git: dictionaries

2013-04-17 Thread Thomas Arnhold
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f4b7fa5cdb670359ee967f38bd71fa9a8e5eb8d4 Author: Thomas Arnhold Date: Wed Apr 17 12:21:42 2013 +0200 update dictionaries Change-Id: I0f693266b7c3621f885acbe450f4faead3d8284f Reviewed-on

[PATCH] update dictionaries

2013-04-17 Thread Thomas Arnhold (via Code Review)
://gerrit.libreoffice.org/3429 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f693266b7c3621f885acbe450f4faead3d8284f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold

[ABANDONED] fix Serbian dictionary makefile

2013-04-17 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: fix Serbian dictionary makefile .. Patch Set 1: Abandoned hrm... -- To view, visit https://gerrit.libreoffice.org/3428 To unsubscribe, visit https

[PATCH] fix Serbian dictionary makefile

2013-04-17 Thread Thomas Arnhold (via Code Review)
Gerrit-PatchSet: 1 Gerrit-Project: dictionaries Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold Gerrit-Reviewer: Andras Timar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] core.git: dbaccess/inc dictionaries oox/inc sal/inc sc/inc sd/inc svtools/inc sw/inc vcl/inc writerfilter/inc

2013-04-17 Thread Thomas Arnhold
ommit c75eeddfb892918c13a19f7c534b73e423ff8d89 Author: Aurimas Fišeras Date: Tue Apr 16 17:26:06 2013 +0300 Update pch Change-Id: Ice80350184f7a514d5beab0a5e1da5b98d5733e4 Reviewed-on: https://gerrit.libreoffice.org/3427 Reviewed-by: Thomas Arnhold Tested-by: Thomas Ar

[PUSHED] fdo#62096 - replace some O(U)String compareTo with ==

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3422 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3422 To unsubscribe

[PUSHED] Update pch

2013-04-17 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3427 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3427 To unsubscribe

[Libreoffice-commits] core.git: scp2/macros scp2/source

2013-04-17 Thread Thomas Arnhold
scp2/macros/macro.pl | 11 - scp2/source/ooo/directory_ooo.scp | 303 -- 2 files changed, 314 deletions(-) New commits: commit e70ea92b3632c376975dd85dbcb26e7ca6b95498 Author: Thomas Arnhold Date: Mon Apr 15 03:53:39 2013 +0200 scp

officecfg: reformat using xmllint

2013-04-16 Thread Thomas Arnhold
Hi, does anyone have objections against running xmllint on officecfg like fe4260c53e7df91a4d2dad06104d7979a212de29 did? Those xml files are such messed up that this would be a pretty good improvement in my eyes. Thomas ___ LibreOffice mailing list

[Libreoffice-commits] core.git: officecfg/registry

2013-04-16 Thread Thomas Arnhold
officecfg/registry/schema/org/openoffice/LDAP.xcs | 96 ++ 1 file changed, 63 insertions(+), 33 deletions(-) New commits: commit fe4260c53e7df91a4d2dad06104d7979a212de29 Author: Thomas Arnhold Date: Wed Apr 17 03:13:23 2013 +0200 reformat xml file with xmllint

[Libreoffice-commits] core.git: officecfg/registry

2013-04-16 Thread Thomas Arnhold
-- officecfg/registry/schema/org/openoffice/ucb/Hierarchy.xcs | 14 -- officecfg/registry/schema/org/openoffice/ucb/Store.xcs | 16 --- 17 files changed, 253 deletions(-) New commits: commit 3ca9820f14cfc1b579fe8196c225b0f099312f6d Author: Thomas Arnhold Date: Wed Apr 17 02:44

[PUSHED] General cleanup of OfficeBeans

2013-04-16 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3413 Approvals: Noel Grandin: Looks good to me, but someone else must approve Thomas Arnhold: Verified; Looks good to me, approved -- To

[PUSHED] fdo#39468 Translate German comments V2 - vcl/source/edit/{te...

2013-04-16 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3162 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3162 To unsubscribe

[PATCH] scp: remove unused macros

2013-04-16 Thread Thomas Arnhold (via Code Review)
End @@ -880,18 +589,6 @@ Directory gid_Dir_Samples_Language ParentID = gid_Dir_Samples; DIR_ISOLANGUAGE_ALL_LANG_2; -End - -/* Samples - Documentations */ -Directory gid_Dir_Samples_Documentations -ParentID = gid_Dir_Samples_Language; -DosName = "Documentations"; -End - -/* Samples - Advertisement */ -Directory gid_Dir_Samples_Advertisement -ParentID = gid_Dir_Samples_Language; -DosName = "Advertisement"; End /* Elements */ -- To view, visit https://gerrit.libreoffice.org/3410 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I48ac97bd6ac8cbd534e50c617f3d54ff10bd2908 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

2013-04-15 Thread Thomas Arnhold
0d3a130511fcd28d3d24d5b56275de73d8fbfc1a Author: Thomas Arnhold Date: Mon Apr 15 22:41:17 2013 +0200 Revert "Calc Sort: Introducing new method AddKeyItem to avoid code duplication" This reverts commit 42726853bb90eab11bf4fde8b0358ca3c3354529. In tpsort.cxx this is used in anothe

[PUSHED] Simple string cleanup in backingwindow.cxx

2013-04-15 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3377 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3377 To unsubscribe

[PUSHED] Removal of Dead code

2013-04-15 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3392 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3392 To unsubscribe

[PUSHED] remove dead class SfxResourceManager

2013-04-15 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3393 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3393 To unsubscribe

[Libreoffice-commits] core.git: scp2/inc

2013-04-14 Thread Thomas Arnhold
scp2/inc/macros.inc | 12 1 file changed, 12 deletions(-) New commits: commit 6fb3c3872c626efe740c850d9e89447a1d7ca053 Author: Thomas Arnhold Date: Sat Apr 13 15:01:14 2013 +0200 remove unused macros Change-Id: I0b0a73e8c9d6c5fb760c2278e58b87f08e881ce4 diff --git

Re: running soffice fails due to missing libjvmfwk.so.3 on master

2013-04-13 Thread Thomas Arnhold
Thanks, Ngo. That did the trick ;) Thomas On 12.04.2013 20:28, Cao Cuong Ngo wrote: Hi, I did 'make clean' and that did the trick ;) Cheers, CC Ngo. On 04/12/2013 07:36 PM, Thomas Arnhold wrote: Hi, with the latest master I can't run soffice: [thomas@localhost libo]$ /h

running soffice fails due to missing libjvmfwk.so.3 on master

2013-04-12 Thread Thomas Arnhold
Hi, with the latest master I can't run soffice: [thomas@localhost libo]$ /home/thomas/libo/install/program/soffice /home/thomas/libo/solver/unxlngi6/installation/opt/program/../ure-link/bin/javaldx: error while loading shared libraries: libjvmfwk.so.3: cannot open shared object file: No such f

[PUSHED] remove dead code

2013-04-12 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3361 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3361 To unsubscribe

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - officecfg/registry

2013-04-10 Thread Thomas Arnhold
officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 032f8845d2242e0e03bf1a4b47898dee51493f56 Author: Thomas Arnhold Date: Wed Apr 10 04:48:01 2013 +0200 fdo#63350 math: move stardard toolbar to

[PATCH libreoffice-4-0] fdo#63350 math: move stardard toolbar to the left

2013-04-10 Thread Thomas Arnhold (via Code Review)
: libreoffice-4-0 Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#63350 math: move stardard toolbar to the left

2013-04-10 Thread Thomas Arnhold (via Code Review)
Thomas Arnhold has abandoned this change. Change subject: fdo#63350 math: move stardard toolbar to the left .. Patch Set 1: Abandoned hrm this should be libreoffice-4-0 -- To view, visit https://gerrit.libreoffice.org/3323

[PATCH] fdo#63350 math: move stardard toolbar to the left

2013-04-10 Thread Thomas Arnhold (via Code Review)
Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: officecfg/registry

2013-04-10 Thread Thomas Arnhold
officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a7e61eab07832a55427a8b532d9e2bf27929e446 Author: Thomas Arnhold Date: Wed Apr 10 04:48:01 2013 +0200 fdo#63350 math: move stardard toolbar to

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/wrtsh/...

2013-04-10 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3319 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3319 To unsubscribe

[Libreoffice-commits] core.git: sc/uiconfig

2013-04-09 Thread Thomas Arnhold
sc/uiconfig/scalc/statusbar/statusbar.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bcf7efd9f09a11756333beaca2c64a3fff315fcc Author: Thomas Arnhold Date: Wed Apr 10 04:30:45 2013 +0200 calc: set ZoomSlider size to 130 like all other components do

[Libreoffice-commits] core.git: 5 commits - officecfg/registry starmath/source stoc/source

2013-04-09 Thread Thomas Arnhold
/javavm/javavm.cxx| 19 - 5 files changed, 1 insertion(+), 362 deletions(-) New commits: commit 1c86d43ca8bf6f1eac93791068ec016d5637efcd Author: Thomas Arnhold Date: Wed Apr 10 01:25:35 2013 +0200 API CHANGE: cleanup of Math.xcs Remove deprecated items

[Libreoffice-commits] core.git: framework/source sfx2/source

2013-04-09 Thread Thomas Arnhold
insertions(+), 31 deletions(-) New commits: commit 6957d013b49fdb18180f4bf414862c199ea96e26 Author: Thomas Arnhold Date: Wed Apr 10 00:42:02 2013 +0200 equalsAsciiL() -> operator==() some more like 7e06132878a495ffb8ed9d54588e1a3ebbd0e8da Change

Re: cliureversion.mk not found build problem

2013-04-09 Thread Thomas Arnhold
On 09.04.2013 09:35, David Tardon wrote: Hi, On Mon, Apr 08, 2013 at 05:23:05PM +0200, Thomas Arnhold wrote: : ERROR: Include file cliureversion.mk not found! : ADD_INCLUDE_FILES = cliureversion.mk,clioootypesversion.mk at /home/thomas/libo/solenv/bin/modules/installer/worker.pm line 579

[Libreoffice-commits] core.git: 2 commits - officecfg/registry sfx2/source

2013-04-08 Thread Thomas Arnhold
officecfg/registry/schema/org/openoffice/Office/Common.xcs | 353 - sfx2/source/control/dispatch.cxx |2 2 files changed, 1 insertion(+), 354 deletions(-) New commits: commit 4136e6575e6ed55e30c3eb00061f2af0863aa970 Author: Thomas Arnhold Date: Mon

Re: cliureversion.mk not found build problem

2013-04-08 Thread Thomas Arnhold
Hi, I got the issue that "cliureversion.mk" is not found when trying to "make findunusedcode". This is reproducible with ./autogen.sh --enable-dbgutil make && make findunusedcode This fails with: : ERROR: Include file cliureversion.mk not found! : ADD_INCLUDE_FILES = cliureversion.mk,cliooot

[Libreoffice-commits] core.git: README.Code tools/README

2013-04-08 Thread Thomas Arnhold
README.Code |2 +- tools/README |2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit cf9bc834a404d213234f7d9344318ca7342cbcde Author: Thomas Arnhold Date: Mon Apr 8 15:34:25 2013 +0200 update documentation Change-Id

[Libreoffice-commits] core.git: sfx2/source

2013-04-08 Thread Thomas Arnhold
sfx2/source/view/viewsh.cxx | 91 +--- 1 file changed, 44 insertions(+), 47 deletions(-) New commits: commit eeaff77389b43e2e3b30be598d54cfc44dc00e48 Author: Thomas Arnhold Date: Mon Apr 8 11:21:31 2013 +0200 viewsh: correct indentation

Re: officecfg/registry: removal of items

2013-04-08 Thread Thomas Arnhold
E" to them? 55664c9bd2469d3e493e6f1b67fbb2f96500d492 31fedbe9f782976b6aa4615b6fd171ed52137c94 Thomas On 04.04.2013 14:44, Stephan Bergmann wrote: [Thomas, I assume you don't mind moving this to the ML.] On 04/02/2013 09:43 PM, Thomas Arnhold wrote: Is it safe to remove items (which are marked as deprecated) fro

[Libreoffice-commits] core.git: officecfg/registry sfx2/source unotools/inc unotools/Library_utl.mk unotools/Package_inc.mk unotools/source

2013-04-05 Thread Thomas Arnhold
: Thomas Arnhold Date: Tue Apr 2 23:52:27 2013 +0200 unotools: remove some unused items Change-Id: I95bcac6a3ff8cf4644c9d1596c75cac2d9cd94fe Reviewed-on: https://gerrit.libreoffice.org/3191 Reviewed-by: Miklos Vajna Tested-by: Miklos Vajna diff --git a/officecfg

[Libreoffice-commits] core.git: dbaccess/inc dbaccess/source desktop/source framework/source officecfg/registry sfx2/inc sfx2/sdi sfx2/source unotools/inc unotools/Library_utl.mk unotools/Package_inc.

2013-04-05 Thread Thomas Arnhold
/itemholder1.cxx |5 18 files changed, 2 insertions(+), 610 deletions(-) New commits: commit 31fedbe9f782976b6aa4615b6fd171ed52137c94 Author: Thomas Arnhold Date: Tue Apr 2 23:20:15 2013 +0200 Remove SvtInternalOptions * only Get/SetCurrentTempURL were used

<    1   2   3   4   5   6   7   8   9   10   >