[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - basic/source vcl/aqua vcl/headless vcl/inc vcl/Library_vcl.mk vcl/Package_inc.mk vcl/source vcl/unx vcl/win

/salframe.cxx |8 +++ 18 files changed, 132 insertions(+), 3 deletions(-) New commits: commit b2ace6a294e2ce2171e3911a6f8a2ed7d8de4812 Author: Thomas Arnhold Date: Sat Mar 30 14:55:24 2013 +0100 fdo#58807 bring Beep() for basic back The functionality was removed by fdo#48549

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3179 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3179 To unsubscribe

[PATCH] unotools: remove some unused items

** -// private method -//* -Mutex& SvtWorkingSetOptions::GetOwnStaticMutex() -{ - return theW

[PUSHED libreoffice-4-0] Keep semantics, but improve readibility.

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3186 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3186 To unsubscribe

Re: unit test failure in forms module, something do with com.sun.star.form.control.FixedText

Hi Noel, maybe this grepping for "control\.FixedText" helps you: stardiv.vcl.control.FixedText com.sun.star.form.control.FixedText So there is toolkit/source/helper/servicenames.cxx which uses szServiceName_UnoControlFixedText[] = "stardiv.vcl.control.FixedText" Maybe that wasn't converted i

[PATCH libreoffice-4-0] fdo#58807 bring Beep() for basic back

3185 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Thomas Arnhold _

[ABANDONED] fdo#58807 bring Beep() for basic back

Thomas Arnhold has abandoned this change. Change subject: fdo#58807 bring Beep() for basic back .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3184 To unsubscribe, visit https

[PATCH] fdo#58807 bring Beep() for basic back

rit-MessageType: newchange Gerrit-Change-Id: I176dc5a18b8ceec467946f4544418f502880c611 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: basic/source vcl/aqua vcl/headless vcl/inc vcl/Library_vcl.mk vcl/Package_inc.mk vcl/source vcl/unx vcl/win

|8 +++ 18 files changed, 129 insertions(+) New commits: commit 47664d3f2e12649d324b031ca6ffd5589fe3d197 Author: Thomas Arnhold Date: Sat Mar 30 14:55:24 2013 +0100 fdo#58807 bring Beep() for basic back The functionality was removed by fdo#48549. This partially

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

drawinglayer/inc/drawinglayer/geometry/viewinformation3d.hxx |6 drawinglayer/source/geometry/viewinformation3d.cxx | 80 ++- 2 files changed, 20 insertions(+), 66 deletions(-) New commits: commit 78bec2b6f40144277464a64a9851d1dc940ed336 Author: Thomas Arnhold Date

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

drawinglayer/inc/drawinglayer/geometry/viewinformation2d.hxx |6 drawinglayer/source/geometry/viewinformation2d.cxx | 80 ++- 2 files changed, 20 insertions(+), 66 deletions(-) New commits: commit 0c85109e647ab1d1d8d87891b3bba23d90cd7e65 Author: Thomas Arnhold Date

[PATCH] fdo#62525: use cow_wrapper for ViewInformation2D

://gerrit.libreoffice.org/3183 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide3bce3257c9fed7bbda7276dfb55fa179d74fdd Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#39468 Translate German in DBG_ASSERT and OSL_ENSURE in t...

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3163 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3163 To unsubscribe

[PUSHED] fdo#39468: Translated German comments in filter

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3178 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3178 To unsubscribe

[PATCH] Remove SvtInternalOptions

b/unotools/source/config/itemholder1.cxx index 0bac773..8d04245 100644 --- a/unotools/source/config/itemholder1.cxx +++ b/unotools/source/config/itemholder1.cxx @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include @@ -185,10 +184,6 @@ case E_HISTORYOPTION

[Libreoffice-commits] core.git: sfx2/source

sfx2/source/appl/app.hrc |1 - sfx2/source/appl/app.src |5 - sfx2/source/appl/appdata.cxx |1 - sfx2/source/inc/appdata.hxx |1 - 4 files changed, 8 deletions(-) New commits: commit e72072029ad22fdde8310e22667fd8f2f46db28e Author: Thomas Arnhold Date: Tue Apr 2

[PATCH] Remove RTL_CONSTASCII_(U)STRINGPARAM in bridges

Hello LibreOffice gerrit bot, Luboš Luňák, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3139 to look at the new rebased patch set (#2). Change subject: Remove RTL_CONSTASCII_(U)STRINGPARAM in bridges ...

[Libreoffice-commits] core.git: svl/inc svl/source

1416669670de6f93b40d8a2f8f001e92ec0bf101 Author: Thomas Arnhold Date: Tue Apr 2 14:21:42 2013 +0200 Revert "Revert "reduce some uglyness"" The header guard seems to solve the problem. This reverts commit df8c41cceeca27ae49e9fa6b5cd64c65c8feb218

[ABANDONED] API CHANGE: drop rtl::O[U]StringBuffer::{charAt, setCharAt}

Thomas Arnhold has abandoned this change. Change subject: API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt} .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3155 To unsubscribe, visit https

[PUSHED] vcl: convert some fprintf to SAL_INFO

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3143 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3143 To unsubscribe

[Libreoffice-commits] core.git: sal/inc vcl/unx

insertions(+), 53 deletions(-) New commits: commit 60212d610762c262782eaf79bfd1fa3798d8afa7 Author: Thomas Arnhold Date: Sat Mar 30 19:38:29 2013 +0100 vcl: convert some fprintf to SAL_INFO Change-Id: I4b9a20e62e8e137a1bfaa1c654307f15c33e3d3c Reviewed-on: https

[Libreoffice-commits] core.git: 3 commits - drawinglayer/inc drawinglayer/source

Author: Thomas Arnhold Date: Tue Apr 2 14:54:29 2013 +0200 fdo#62525: use cow_wrapper for MaterialAttribute3D Change-Id: I7ee65afe8065525e6af198a4d1b75e1035644983 diff --git a/drawinglayer/inc/drawinglayer/attribute/materialattribute3d.hxx b/drawinglayer/inc/drawinglayer/attribute

[PATCH] Revert "Revert "reduce some uglyness""

p; SfxXRangesItem::Store( SvStream &rStream, sal_uInt16 ) const -{ -NUMTYPE nCount = Count_Impl( _pRanges ); -rStream >> nCount; -for ( NUMTYPE n = 0; _pRanges[n]; ++n ) -rStream >> _pRanges[n]; -return rStream; -} - - -#undef NUMTYPE -#undef SfxXRangeItem

Re: reduce some uglyness

On 02.04.2013 11:51, Michael Stahl wrote: it's a mystery why it works on other compilers, because you have removed the header guard "#define _SFXRNGITEM_HXX" which causes multiple inclusion of the header to define the same types multiple times, which MSVC rightfully complains about. i grant that

[Libreoffice-commits] core.git: sc/source

sc/source/ui/drawfunc/chartsh.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 83810a61bab4fe079de3539dc3489b008e776eaf Author: Thomas Arnhold Date: Tue Apr 2 08:48:28 2013 +0200 fix build css is ::com::sun::star already Change-Id

[Libreoffice-commits] core.git: forms/source

forms/source/inc/frm_strings.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c893d404c6bb90990ea18db70f27647269a6369f Author: Thomas Arnhold Date: Mon Apr 1 22:48:35 2013 +0200 Revert "Remove RTL_CONSTASCII_(U)STRINGPARAM in forms(frm_string

[PATCH] API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt}

al_Unicode* getStr() const { return pData->buffer; } -- To view, visit https://gerrit.libreoffice.org/3155 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ief3a418e2ab0039bdf5100ec6e1505a4887487e7 Gerrit-PatchSet: 1 Gerrit-Proje

unusedcode some step further

Hi, there are several unused methods in the source which callcatcher doesn't catch. Two examples: 08b91c63131b7e625d2a2c489bc537dafe5c5963 and c12ab867f282e783507fcf74ab5c90e784681f65 which had only (virtual) definitions, but no calls. The same applies to inlines like 646daee253b69404591c00

[Libreoffice-commits] core.git: basctl/source reportdesign/inc reportdesign/source sc/inc sc/source

/drwlayer.cxx | 15 --- 6 files changed, 33 deletions(-) New commits: commit 08b91c63131b7e625d2a2c489bc537dafe5c5963 Author: Thomas Arnhold Date: Mon Apr 1 13:19:59 2013 +0200 remove unused GetCurDocViewWin Change-Id: I7fe825cd1fb9e988eb8037e1f5dca7252c192f33

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ (Part 3)

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3144 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3144 To unsubscribe

[PATCH] vcl: convert some fprintf to SAL_INFO

uot; << aVersion ); + sal_Int32 nIndex = 0, nMajor = 0, nMinor = 0; nMajor = aVersion.getToken( 0, '.', nIndex ).toInt32(); if( nIndex > 0 ) @@ -74,16 +73,14 @@ sal_Int32 nMicro = 0; if( nIndex > 0 ) nMicro = aVersion.getToken( 0, '.', nIndex ).toInt32(); -fprintf( stderr, "unsuitable qt version %d.%d.%d\n", nMajor, nMinor, nMicro ); +SAL_INFO( "vcl.kde4", "unsuitable qt version " << nMajor << "." << nMinor << "." << nMicro ); #endif return NULL; } #endif KDESalInstance* pInstance = new KDESalInstance( new SalYieldMutex() ); -#if OSL_DEBUG_LEVEL > 1 -fprintf( stderr, "created KDESalInstance 0x%p\n", pInstance ); -#endif +SAL_INFO( "vcl.kde4", "created KDESalInstance " << &pInstance ); // initialize SalData KDEData *salData = new KDEData( pInstance ); -- To view, visit https://gerrit.libreoffice.org/3143 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4b9a20e62e8e137a1bfaa1c654307f15c33e3d3c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove commented code in odk/examples

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3138 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3138 To unsubscribe

Re: [PATCH] coverity#983561: Arguments in wrong order

On 31.03.2013 15:49, Regina Henschel wrote: Draw a sphere from the set of predefined 3D-objects and set the line style to continues to see the segments. Set "Segments Vertical" to 8 to see, which part of the drawing is affected by "Vertical". In Version 4.0.1.2 (Build ID: 84102822e3d61eb989ddd32

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ PART2

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3129 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3129 To unsubscribe

[PUSHED] Remove commented code in component.cxx (odk)

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3137 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3137 To unsubscribe

[PUSHED] fdo#62096 Replace O(U)String compareTo with ==

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3136 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3136 To unsubscribe

Re: [PATCH] coverity#983561: Arguments in wrong order

Hi Regina, you're right, the other methods are using the order (fVer, fHor), like createUnitSpherePolyPolygon() does. So the definition is correct: inline B3DPoint getPointFromCartesian(double fVer, double fHor) But on the call side it's used like: aNew.append(getPointFromCartesian(fHor, fVe

[PUSHED] Multiple typo fixes, small code changes

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3135 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3135 To unsubscribe

[ABANDONED] drawinglayer depends on o3tl_inc

Thomas Arnhold has abandoned this change. Change subject: drawinglayer depends on o3tl_inc .. Patch Set 1: Abandoned Not needed. Thanks David :) -- To view, visit https://gerrit.libreoffice.org/3125 To unsubscribe, visit

[Libreoffice-commits] core.git: connectivity/source dbaccess/source extensions/source oox/source sal/inc sc/source sdext/source stoc/source sw/source

commits: commit 083092e808ed94325f103a721cc11882c6878b06 Author: Thomas Arnhold Date: Sat Mar 30 04:57:16 2013 +0100 OSL_FAIL -> SAL_WARN Change-Id: I1871e5e3a319b2d5177ae4bd470046c022c14eb7 Reviewed-on: https://gerrit.libreoffice.org/3121 Reviewed-by: David Tar

[PATCH] drawinglayer depends on o3tl_inc

https://gerrit.libreoffice.org/3125 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9dab86e62eb34819be1564b3d7be50cf6acb6f73 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold

[PATCH] fdo#58807 bring Beep() for basic back

- To view, visit https://gerrit.libreoffice.org/3124 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___

[PUSHED] [PATCH] vincent: fix the spell error: change "unkown" to "unknown"

Hello Vincent, they are already pushed on master. https://gerrit.libreoffice.org/#/c/3030/ http://cgit.freedesktop.org/libreoffice/core/commit/?id=002a0d91e4b0d8214656741192ec3260a8764a73 Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesk

[Libreoffice-commits] core.git: sw/source

sw/source/ui/utlui/content.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 6c541cb3168c103f3e13686232fa2e6084570182 Author: Thomas Arnhold Date: Sat Mar 30 05:21:08 2013 +0100 fix build Change-Id: Icb72b18785bb37457f2eaf86e0639cedc119ee92 diff --git a/sw/source

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ (Part1)

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3101 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3101 To unsubscribe

[PATCH] OSL_FAIL -> SAL_WARN

tart << ", object stack: " << OUStringToOString(aTmp, RTL_TEXTENCODING_UTF8).getStr()); +SAL_WARN("sdext.pdfimport.pdfparse", "parse error: " << rError.descriptor << " at buffer pos " << rError.where - file_start <<

[Libreoffice-commits] core.git: cui/source fpicker/source unotools/source uui/source xmlsecurity/inc xmlsecurity/source

/warnings.cxx|2 - 19 files changed, 58 insertions(+), 98 deletions(-) New commits: commit 049ce78144650d92eb6bd73292868f73d37c9010 Author: Thomas Arnhold Date: Sat Mar 30 00:32:52 2013 +0100 remove local css definitions follow-up of

[PUSHED] String::AppendAscii cleanup in dbaccess

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3068 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3068 To unsubscribe

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

drawinglayer/inc/drawinglayer/attribute/fontattribute.hxx |6 drawinglayer/source/attribute/fontattribute.cxx | 89 -- 2 files changed, 32 insertions(+), 63 deletions(-) New commits: commit 32ec7666596b2a0f27c72f9d856e2ec0f0545f6b Author: Thomas Arnhold Date: Wed

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

drawinglayer/inc/drawinglayer/attribute/fillhatchattribute.hxx |6 drawinglayer/source/attribute/fillhatchattribute.cxx | 85 ++ 2 files changed, 27 insertions(+), 64 deletions(-) New commits: commit 63da9d632827e7d08450dfd72bdcdfbed9c73cae Author: Thomas Arnhold Date

[Libreoffice-commits] core.git: desktop/unx

desktop/unx/source/splashx.c | 12 1 file changed, 12 deletions(-) New commits: commit 71907bb06ae6fc3c0ea1485b6ed0efaed196a57a Author: Thomas Arnhold Date: Wed Mar 27 11:49:40 2013 +0100 -Wunused-macros Change-Id: Ia147a72a4bbd5cec45a2a74b721a81ff8c4340c2 diff

[PATCH] fdo#62525: use cow_wrapper for FillHatchAttribute

view, visit https://gerrit.libreoffice.org/3073 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1581b4bca6f14bd27af12ff40a4f4c0fe08af133 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold

[PATCH] fdo#62525: use cow_wrapper for FontAttribute

Gerrit-Change-Id: Ic07da7c7cf225a910e6f0fa4f6d20c4700e7ec7a Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: editeng/source sc/source sw/source vcl/source xmloff/source

/text/txtflde.cxx | 12 12 files changed, 112 deletions(-) New commits: commit 646daee253b69404591c006ec6e717b6660af30b Author: Thomas Arnhold Date: Wed Mar 27 02:57:35 2013 +0100 kill some unused inlines Change-Id: I17160b264b547067c694dd268eb0d3bd1086565d diff

[PUSHED] fdo#39468 Translate German comments - vcl/source/control/

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2966 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2966 To unsubscribe

[PUSHED] Translate German comments, fix some ws

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3063 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3063 To unsubscribe

[Libreoffice-commits] core.git: connectivity/source cppuhelper/inc dbaccess/inc embedserv/source filter/source fpicker/source framework/inc idlc/source lotuswordpro/source rsc/inc rsc/source sal/inc s

488e6875e992e11601611a119476624822fc4635 Author: Thomas Arnhold Date: Mon Mar 25 19:56:20 2013 +0100 remove external include guards Change-Id: If5758e02baa8e019923355b6c97043b306223fdd diff --git a/connectivity/source/inc/hsqldb/HConnection.hxx b/connectivity/source/inc/hsqldb/HConnection.hxx index 42748d9

[PUSHED] Cleanup comments and some translations in style.cxx

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3062 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3062 To unsubscribe

[PATCH] Fix spelling errors and typos: 'unkown' change to 'unknown'

tify()\nUnknown property detected ... I can't handle these!\n" ); #endif } } -- To view, visit https://gerrit.libreoffice.org/3030 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3ff77d2b99c9ef6c4c9b510bb30f349592c0b94 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] vincent: fix the spell error: change "unkown" to "unknown"

Hi Vincent, I uploaded the patch to gerrit, so it gets more attention ;) https://gerrit.libreoffice.org/#/c/3030/ This Get_UnknownTags() method was unused all over the way, so I removed it. Here's an introduction on gerrit and how to use it: https://wiki.documentfoundation.org/Development/ger

[PUSHED] Translate German comments, fix some whitespace

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2916 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2916 To unsubscribe

[Libreoffice-commits] core.git: sd/source sw/source

Author: Thomas Arnhold Date: Mon Mar 25 08:58:06 2013 +0100 random src cleaning Change-Id: I9b246beee646ce1dd68e916ac7fcda138cc9e6f9 diff --git a/sd/source/ui/animations/CustomAnimationDialog.src b/sd/source/ui/animations/CustomAnimationDialog.src index b07f147..ea170a5 100644

[ABANDONED] [draft] use pragma once

Thomas Arnhold has abandoned this change. Change subject: [draft] use pragma once .. Patch Set 3: Abandoned Not as easy as it seems. Clashes with Windows headers at least. Why ever... -- To view, visit https

[Libreoffice-commits] core.git: basic/source

basic/source/runtime/methods.cxx |7 --- basic/source/runtime/rtlproto.hxx |1 - basic/source/runtime/stdobj.cxx |2 -- 3 files changed, 10 deletions(-) New commits: commit 7f4a34e3145673681c0ff3aee8de8c440e790ece Author: Thomas Arnhold Date: Thu Mar 21 19:06:44 2013 +0100

[PUSHED] fdo#39468 Translate German comments - vcl/win/source/gdi/

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2937 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2937 To unsubscribe

[PUSHED] fdo#39468 Translate German Comments - salframe.cxx

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2931 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2931 To unsubscribe

[PATCH] fdo#62525: use cow_wrapper for FillGradientAttribute

onst -- To view, visit https://gerrit.libreoffice.org/2954 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I13aa9817d7abd3753579f6825c166191a836eef3 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhol

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

drawinglayer/inc/drawinglayer/attribute/fillgradientattribute.hxx |6 drawinglayer/source/attribute/fillgradientattribute.cxx | 89 ++ 2 files changed, 30 insertions(+), 65 deletions(-) New commits: commit 75ad992d1801334a2bb39e1b0bdf3ca5f3714625 Author: Thomas Arnhold

[PUSHED] Change duplicate short-cut Alt-I-U

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2943 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2943 To unsubscribe

[PATCH] fdo#62525: use cow_wrapper for FillGradientAttribute

a8ebcc4a7d2c80a3c9d0c13b27 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

drawinglayer/inc/drawinglayer/attribute/fillbitmapattribute.hxx |6 drawinglayer/source/attribute/fillbitmapattribute.cxx | 80 ++ 2 files changed, 24 insertions(+), 62 deletions(-) New commits: commit cafc879f8978ea9f7fca1be9f6aa5057f0a59617 Author: Thomas Arnhold

[PATCH] fdo#62525: use cow_wrapper for FillBitmapAttribute

- To view, visit https://gerrit.libreoffice.org/2948 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f666d4baaf6dc4e9f7ea30a518a8904f01d749f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas A

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source

drawinglayer/inc/drawinglayer/attribute/sdrshadowattribute.hxx |6 drawinglayer/source/attribute/sdrshadowattribute.cxx | 81 ++ 2 files changed, 25 insertions(+), 62 deletions(-) New commits: commit 62fca307fc0fc775234572c79a1237494c2d72a7 Author: Thomas Arnhold Date

[ABANDONED] fdo#62525: use cow_wrapper for SdrShadowAttribute

Thomas Arnhold has abandoned this change. Change subject: fdo#62525: use cow_wrapper for SdrShadowAttribute .. Patch Set 1: Abandoned bla -- To view, visit https://gerrit.libreoffice.org/2945 To unsubscribe, visit https

[PATCH] fdo#62525: use cow_wrapper for SdrShadowAttribute

g/2946 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b5435d2326e9ebf340e88025eeea25ff6388ea2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOf

[ABANDONED] wip

Thomas Arnhold has abandoned this change. Change subject: wip .. Patch Set 1: Abandoned ... -- To view, visit https://gerrit.libreoffice.org/2944 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit

[PATCH] fdo#62525: use cow_wrapper for SdrShadowAttribute

g/2945 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2713bacd10538dfe177cb975a9633dd65285c6fa Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOf

[PATCH] wip

e, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I23427e1e3bfb583ef10123577ebec76af617f917 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOf

[PUSHED] fdo#39468 Translate German comments - vcl/win/source/app

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2938 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2938 To unsubscribe

[PUSHED] Improve size and positions of widgets for CustomAnimationDia...

: merged Gerrit-Change-Id: I38a9cbd533c742657c4af6c83d146706684c1ff6 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Xiaoli Duan Gerrit-Reviewer: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

[PUSHED] General comment cleanup for demo/test vcl apps

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2921 Approvals: Tor Lillqvist: Verified; Looks good to me, approved Thomas Arnhold: -- To view, visit https://gerrit.libreoffice.org/2921

[Libreoffice-commits] core.git: oox/source sal/inc tools/source vcl/source

: commit 5ea8a48a3b26ac326ea5fe4a637a2d9b59cd2b94 Author: Thomas Arnhold Date: Thu Mar 21 10:19:50 2013 +0100 clean up DBG_ERRORn Those were DBG_ERRORn before and were falsely changed to OSL_TRACE by me. See: 1707a350af8a0909ae88c2b11deb714f8b2a93ff

[Libreoffice-commits] core.git: officecfg/registry

/WriterReportWindowState.xcu | 37 -- officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu | 37 -- 8 files changed, 162 deletions(-) New commits: commit 0e49bd05eef97ddd25a5657cdd5fb277a2a86014 Author: Thomas Arnhold Date: Fri Mar 22 03:13:15 2013 +0100

[PUSHED] Comment translation - GER-ENG in sw/source/ui/wrtsh/wrtsh1.c...

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2883 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2883 To unsubscribe

[PUSHED] Comment translation GER-ENG in sw/source/ui/wrtsh/

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2902 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2902 To unsubscribe

[Libreoffice-commits] core.git: sfx2/source svx/source

sfx2/source/appl/newhelp.cxx | 10 +- svx/source/table/tablecontroller.cxx |4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 3dd40efee6ca280ef205c75517621b5f8d5089cd Author: Thomas Arnhold Date: Fri Mar 22 00:48:24 2013 +0100 strg is ctrl

[Libreoffice-commits] core.git: Repository.mk

Repository.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 211a9a9cdcc34316e40c893179d7d3d0c160cfe4 Author: Thomas Arnhold Date: Thu Mar 21 19:46:23 2013 +0100 rscdep is dead 18d37cf9fb21dd809ec79135ce93f9a55512c9b3 Change-Id

Re: [PATCH] remove/add blank lines in sw/source/core

On 21.03.2013 15:06, Michael Meeks wrote: So I'd say that these huge spews of ascii-art don't serve a useful purpose: //- and bulky content-free comments (which we still have plenty of) should clearly take be a higher priority for

[PATCH] clean up DBG_ERRORn

fault: -OSL_TRACE( "ImplWindowFrameProc(): unknown event (%lu)", (sal_uLong)nEvent ); +SAL_WARN( "vcl.layout", "ImplWindowFrameProc(): unknown event (" << nEvent << ")" ); break; #endif } -- To view,

[PATCH] basic: Remove non working AboutStarBasic

gs Gerrit-MessageType: newchange Gerrit-Change-Id: Ia46674f7bdc12e80d61a8142697e875f5c58f482 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: #ifdef vs #if for feature checks [proof of concept]

Hi, https://gerrit.libreoffice.org/#/c/2875/ At least on Linux with --without-java --enable-werror works for me. I only replaced guards like *_HXX_, *_HXX__ and *_HXX_INCLUDED which are not used at any other place. Those are ~8700 matches. Approx. 500 look like guards, but don't match the s

[PATCH] this looks better

master Gerrit-Owner: Thomas Arnhold ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: connectivity/source

3c5b0853944d922e70d7c488712df6780ff2b5f7 Author: Thomas Arnhold Date: Wed Mar 20 13:29:22 2013 +0100 no need for include guard value Change-Id: Ib12b2c975d90cf842381916f3eb98dad3b4b3b4d diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSInit.hxx b/connectivity/source/drivers/mozab

[Libreoffice-commits] core.git: extensions/source ucb/source

extensions/source/update/ui/updatecheckui.cxx |2 +- ucb/source/ucp/webdav/DAVProperties.cxx | 20 +++- 2 files changed, 8 insertions(+), 14 deletions(-) New commits: commit 11878c68c6e22373c95d4b7707aaf2c91e6a1fa1 Author: Thomas Arnhold Date: Wed Mar 20 15:04:03

Re: [SCRIPT] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

On 20.03.2013 12:09, Stephan Bergmann wrote: On 03/19/2013 07:38 PM, Thomas Arnhold wrote: #!/usr/bin/perl # git grep 'RTL_CONSTASCII_USTRINGPARAM' -- '*.[hc]xx' | cut -d':' -f1 | sort -u | xargs perl constascii.pl foreach (@ARGV) { my $file = $_; my $da

Re: #ifdef vs #if for feature checks

Yes, but our internal RSC doesn't support #pragma once ;) On 19.03.2013 07:53, vincent wrote: HI, I found some wiki about "#pragma once" compiler support http://en.wikipedia.org/wiki/Pragma_once#Portability http://en.wikipedia.org/wiki/Pragma_once#Portability Compiler#pragma once Clang <

[Libreoffice-commits] core.git: cppuhelper/inc

cppuhelper/inc/cppuhelper/propertysetmixin.hxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 5e2fd3b3c96362368a516f59555a42450126be85 Author: Thomas Arnhold Date: Wed Mar 20 03:29:03 2013 +0100 this should be enough Change-Id

[SCRIPT] automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted ...

Hi, if someone has problems while rebasing due to this huge change, please use the attached script to do my change on your branch. Thomas On 19.03.2013 10:00, Thomas Arnhold (via Code Review) wrote: Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in

[Libreoffice-commits] core.git: basctl/source basic/qa canvas/source dbaccess/source desktop/source desktop/unx extensions/source filter/source i18npool/source idlc/source io/source io/test odk/exampl

/qa/cppunittests/odiapi/testProperty.cxx |2 - writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 - 46 files changed, 94 insertions(+), 101 deletions(-) New commits: commit 5bb4a2ba1d8a6b98720868786e552aa8fd2a22eb Author: Thomas Arnhold Date: Tue

[PUSHED] removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings ...

Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2835 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2835 To unsubscribe

<    2   3   4   5   6   7   8   9   10   11   >