[PUSHED] Bug # 51154: cppunit warning cleaning

2013-08-15 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5424 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5424 To unsubscribe,

[PUSHED] Remove dead log-area

2013-05-21 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3992 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3992 To unsubscribe,

[PUSHED] sal osl_getGlobalTimer: Don't confuse start and current time...

2013-05-20 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3979 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3979 To unsubscribe,

[PATCH] Let's assume nobody needs the sbase, scalc etc scripts on OS...

2013-05-17 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3930 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/3930/1 Let's assume nobody needs the sbase, scalc etc scripts on OS X It's always possible to run the soffice

[PATCH] No need for the soffice.bin identical copy of soffice on OS ...

2013-05-17 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3931 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/3931/1 No need for the soffice.bin identical copy of soffice on OS X Change-Id:

[PUSHED] Documentation update of README.cross

2013-05-15 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3916 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3916 To unsubscribe,

[PATCH] Get rid of GlobalEditData::GetStdRefDevice()

2013-05-13 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3886 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/3886/1 Get rid of GlobalEditData::GetStdRefDevice() This avoids a crash on exit in a dbgutil build on OS X. The

[PUSHED] dev-install: create the 'install' link in the builddir not i...

2013-05-13 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3887 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3887 To unsubscribe,

[PUSHED] Support IMR_QUERYCHARPOSITION in Writer and Calc.

2013-05-12 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3849 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3849 To unsubscribe,

[PUSHED] [coretext] Fix drawing fallback fonts

2013-05-10 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3846 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3846 To unsubscribe,

[PUSHED] codesign --timestamp=none is not supported on 10.6

2013-05-07 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3806 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3806 To unsubscribe,

[PUSHED] Convert EMFP_DEBUG to SAL_INFO, etc.

2013-05-06 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3782 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3782 To unsubscribe,

[PUSHED] fdo#64003 - added rmi and snd to insert - movie sound lis...

2013-05-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3727 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3727 To unsubscribe,

[PUSHED] Convert from EMFP_DEBUG to SAL_INFO

2013-05-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3726 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3726 To unsubscribe,

[PUSHED] fix fdo#64085 : set proper alignment for justified align tex...

2013-05-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3704 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3704 To unsubscribe,

[PUSHED] Update pch

2013-05-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3736 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3736 To unsubscribe,

[PUSHED] Revert Added Tango colors to palette

2013-05-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3738 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3738 To unsubscribe,

[PUSHED] Clang cleanup, unused mutex variables

2013-04-30 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3678 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3678 To unsubscribe,

[PUSHED libreoffice-4-0] Fix fdo#64062 - can't assume para styles to be there.

2013-04-30 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3694 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3694 To unsubscribe,

[PUSHED] fdo#35785: don't rely on the old apps fallback mechanism to ...

2013-04-30 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3639 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3639 To unsubscribe,

[PUSHED] fdo#35785: LibreOffice is One for now

2013-04-30 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3638 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3638 To unsubscribe,

[PUSHED] fdo#63546: set appropriate alignment when wrt direction of c...

2013-04-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3549 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3549 To unsubscribe,

[PUSHED] UpdateTableShape() is called when we call SetAttrToSelectedC...

2013-04-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3391 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3391 To unsubscribe,

[PUSHED] fdo#61060 - Freezing now marks spreadsheet as unsaved.

2013-04-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3641 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3641 To unsubscribe,

[ABANDONED] Make the Mac installation tree more Mac-like in structure

2013-04-29 Thread Tor Lillqvist (via Code Review)
Tor Lillqvist has abandoned this change. Change subject: Make the Mac installation tree more Mac-like in structure .. Patch Set 2: Abandoned No point keeping this here any longer (even for reference), it just clutters up

[PUSHED] Fixing Indentation RTL bug

2013-04-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3651 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3651 To unsubscribe,

[PUSHED] Clang cleanup, unaligned if statement

2013-04-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3677 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3677 To unsubscribe,

[PUSHED] add fallback for Merge-Modules directory (when not found in ...

2013-04-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3680 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3680 To unsubscribe,

[PUSHED] fdo#33370 Readme file could be easier to follow

2013-04-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3679 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3679 To unsubscribe,

[PUSHED libreoffice-4-0] Fix import of images from pdf.

2013-04-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3690 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3690 To unsubscribe,

[PATCH] Bin CLOOK comments and un-split one large switch statement

2013-04-27 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3640 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3640/1 Bin CLOOK comments and un-split one large switch statement CLOOK = Compiler Limit: Out Of Keys, an error

[PUSHED] Better text for Insert as Link Checkbox

2013-04-26 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3602 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3602 To unsubscribe,

[PUSHED] fdo#56832 Explicitly mention Ogg Audio and Video

2013-04-26 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3609 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3609 To unsubscribe,

[PUSHED] Resolves fdo#62673 Table cells non-editable on cell merge

2013-04-26 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3273 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3273 To unsubscribe,

[PUSHED] Use div instead of multicol when exporting multi-column ...

2013-04-26 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3610 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3610 To unsubscribe,

[PUSHED] gbuild: MSVC: only re-link libraries if exported symbols cha...

2013-04-26 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3612 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3612 To unsubscribe,

[PUSHED] fdo#60625 - Document converter wizard fails to find powerpoi...

2013-04-26 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3617 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3617 To unsubscribe,

[ABANDONED] fdo#61060 - Freeze and unfreeze now mark document as unsaved...

2013-04-26 Thread Tor Lillqvist (via Code Review)
Tor Lillqvist has abandoned this change. Change subject: fdo#61060 - Freeze and unfreeze now mark document as unsaved. .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3620 To unsubscribe, visit

[PUSHED] Fix fdo#35785: recent documents feature of the Windows 7 Sta...

2013-04-26 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3623 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3623 To unsubscribe,

[PUSHED libreoffice-4-0] fix scrolling performance of listboxes with hundreds of entr...

2013-04-25 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3611 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3611 To unsubscribe,

[ABANDONED] Try one approach to compile a class as one compilation unit

2013-04-23 Thread Tor Lillqvist (via Code Review)
Tor Lillqvist has abandoned this change. Change subject: Try one approach to compile a class as one compilation unit .. Patch Set 1: Abandoned OK, the consensus seems to be that trying hard to preserve git log continuity at

[PATCH] Try one approach to compile a class as one compilation unit

2013-04-13 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3373 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/3373/1 Try one approach to compile a class as one compilation unit In many cases the sources for some class have been

[PATCH libreoffice-4-0] Turn on Neon debug output (if enabled in Neon) when building...

2013-04-02 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3166 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3166/1 Turn on Neon debug output (if enabled in Neon) when building for debugging Also add NE_DBG_LOCKS and NE_DBG_SSL

[PUSHED libreoffice-4-0] Adapt code to IllegalArgumentException being a RuntimeExcept...

2013-04-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3174 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3174 To unsubscribe,

[PATCH] SFX_VISIBILITY_PLUGCLIENT and SERVER are unused

2013-04-01 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3147 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3147/1 SFX_VISIBILITY_PLUGCLIENT and SERVER are unused Change-Id: I33926a960d1fba8f68737879a6e58ef38ad1ee62 --- M

[PATCH] SFX_VISIBILITY_PLUGCLIENT, SERVER and RECORDING are unused

2013-04-01 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3148 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3148/1 SFX_VISIBILITY_PLUGCLIENT, SERVER and RECORDING are unused Change-Id: I1fd581c8ca44cfb48184d8a17e6077707f038bd4

[ABANDONED] SFX_VISIBILITY_PLUGCLIENT and SERVER are unused

2013-04-01 Thread Tor Lillqvist (via Code Review)
Tor Lillqvist has abandoned this change. Change subject: SFX_VISIBILITY_PLUGCLIENT and SERVER are unused .. Patch Set 1: Abandoned Re-submitted with different Change-Id for some reason. -- To view, visit

[PATCH] Get rid of the slots.cfg mechanism

2013-03-29 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3118 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/3118/1 Get rid of the slots.cfg mechanism I very much doubt anybody is using it. It has never been documented as far

[PATCH] Make autogen.sh prefer to read an autogen.input file

2013-03-28 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3111 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/3111/1 Make autogen.sh prefer to read an autogen.input file An autogen.lastrun file will still be used if it exists

[ABANDONED] Use an 8bpp virtual device (instead of a 1bpp one) in sw and...

2013-03-26 Thread Tor Lillqvist (via Code Review)
Tor Lillqvist has abandoned this change. Change subject: Use an 8bpp virtual device (instead of a 1bpp one) in sw and sc .. Patch Set 3: Abandoned -- To view, visit https://gerrit.libreoffice.org/2979 To unsubscribe, visit

[PATCH] Use an 8bpp virtual device (instead of a 1bpp one) in sw and...

2013-03-25 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2979 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/2979/1 Use an 8bpp virtual device (instead of a 1bpp one) in sw and sc The reason why a 1bpp virtual device is used is

[PATCH libreoffice-4-0] Allow installation on external storage (SD card)

2013-03-23 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2940 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/2940/1 Allow installation on external storage (SD card) Change-Id: I532f27aee60a2e60110e9edea75e7cbe7d614b1e --- M

[PATCH] Use the system root certificates in Neon's ne_ssl_trust_defa...

2013-03-15 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2741 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/2741/1 Use the system root certificates in Neon's ne_ssl_trust_default_ca() on Win32 Fixes a problem that was noticed

[PUSHED libreoffice-4-0] Resolves: #i119943 Underline can not work with ; in format...

2013-03-13 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2694 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2694 To unsubscribe,

[PUSHED] delete previous uncommented comments in positionhelper.cxx

2013-03-06 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2571 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2571 To unsubscribe,

[PATCH] Remove dead voice command code

2013-02-27 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2452 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/2452/1 Remove dead voice command code I don't see voice input commands being generated anywhere. Nobody seems to know

[PUSHED] [PUSHED] fdo#56886 EMF: Fixes some scaling problems of clipped region...

2013-02-19 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1886 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1886 To unsubscribe,

[PUSHED] remove zenity configure option

2013-02-16 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2174 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2174 To unsubscribe,

[PUSHED] fix build

2013-02-15 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2154 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2154 To unsubscribe,

[PUSHED] MODKEY_BigOrtho is never defined

2013-02-14 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2126 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2126 To unsubscribe,

[PUSHED] Removed several useless macros: UNISTRING, USTR, USTR_ASCII, ...

2013-02-14 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1954 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1954 To unsubscribe,

[PATCH libreoffice-4-0] Let's try to enable compiling the Bluetooth code for Windows

2013-02-13 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2129 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2129/1 Let's try to enable compiling the Bluetooth code for Windows (cherry picked from commit

[PUSHED libreoffice-4-0] remove Basque autotext files, they were in English

2013-02-12 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2116 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2116 To unsubscribe,

[PUSHED] fix cross compiling with icu 50.1.2

2013-02-12 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2112 Approvals: Joren De Cuyper: Looks good to me, but someone else must approve Tor Lillqvist: Verified; Looks good to me, approved -- To

[PUSHED libreoffice-4-0] Fixed SfxDocTplService_Impl::setTitleForURL to keep all stre...

2013-02-12 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2107 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2107 To unsubscribe,

[PUSHED libreoffice-4-0] add more missing adodb constants

2013-02-12 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2106 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2106 To unsubscribe,

[PUSHED] fdo#55430 switches off text mode when clicking an other obje...

2013-02-11 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1344 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1344 To unsubscribe,

[PUSHED] export different first page header/footer to doc/docx

2013-02-11 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2062 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2062 To unsubscribe,

[PUSHED] import different first page header/footer from doc

2013-02-11 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2065 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2065 To unsubscribe,

[PUSHED] fdo#39370 - Fixed RTL/LTR and alignment buttons location on ...

2013-02-11 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2077 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2077 To unsubscribe,

[PUSHED] add unittest for fdo#59240

2013-02-11 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2078 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2078 To unsubscribe,

[PUSHED libreoffice-4-0] fdo#60491: scp2: always package emboleobj library on non-WNT...

2013-02-11 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2095 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2095 To unsubscribe,

[PUSHED] fdo#38838 Some removal/replacement of the String/UniString w...

2013-02-09 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1962 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1962 To unsubscribe,

[PUSHED] Resolves fdo#59889 fault in dragging edge of RTL table

2013-02-09 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1979 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1979 To unsubscribe,

[PATCH libreoffice-4-0] Add support for codesigning on Mac OS X

2013-02-08 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2031 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/2031/1 Add support for codesigning on Mac OS X Only sign the .app. Presumably that's enough here in the 4.0 branch.

[PUSHED libreoffice-4-0] resolve fdo#60379 Impress Remote: Options look disabled

2013-02-07 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2030 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2030 To unsubscribe,

Change in core[libreoffice-4-0]: fdo#46706 Windows 2000 is not supported any more

2013-01-31 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1939 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1939 To unsubscribe,

Change in core[libreoffice-4-0]: Do not call putenv with a temporary string argument

2013-01-29 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1917 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1917 To unsubscribe,

Change in core[libreoffice-4-0]: fdo#51232: i#119987# fix Impress crash when pasting text und...

2013-01-28 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1897 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/1897/1 fdo#51232: i#119987# fix Impress crash when pasting text under Outline view Patch by: Wang Zhe Testing by: Yan

[PUSHED] default to --without-help and --without-myspell-dicts

2013-01-21 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1791 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1791 To unsubscribe,

[PUSHED] disable odk if not explicitly requested and doxygen not in P...

2013-01-21 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1789 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1789 To unsubscribe,

[PATCH] Kill the ancient StarOffice patch concept

2013-01-09 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1605 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1605/1 Kill the ancient StarOffice patch concept For Windows, superseded by Windows Installer patching (i.e., creating

[PATCH] Change in core[libreoffice-4-0]: Make sure that *in this branch* we don't use too new tools

2013-01-08 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1573 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1573/1 Make sure that *in this branch* we don't use too new tools This is the branch for 4.0.x and we want to use the

[PATCH] Change in core[libreoffice-4-0]: Use MSBuild from .NET Framework 4.0

2013-01-08 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1591 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/1591/1 Use MSBuild from .NET Framework 4.0 Otherwise building these external projects fails, at least for me.

Change in core[libreoffice-4-0]: Use MSBuild from .NET Framework 4.0

2013-01-08 Thread Tor Lillqvist (via Code Review)
Tor Lillqvist has abandoned this change. Change subject: Use MSBuild from .NET Framework 4.0 .. Patch Set 1: Abandoned . -- To view, visit https://gerrit.libreoffice.org/1591 To unsubscribe, visit

[PUSHED] Get rid of nsinstall hackery

2013-01-07 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1534 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1534 To unsubscribe,

[PUSHED] fdo#50415: Add Catalan translations of keyboard shortcuts

2013-01-04 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1543 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1543 To unsubscribe,

[PUSHED] Change in core[libreoffice-4-0]: fdo#50415: Add Catalan translations of keyboard shortcuts

2013-01-04 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1544 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1544 To unsubscribe,

[PUSHED] Change in core[libreoffice-3-6]: fix for fdo#57836 throw when attempting to store basicide mo...

2013-01-03 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1538 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1538 To unsubscribe,

[PUSHED] Change in core[libreoffice-4-0]: Minimal fix fdo#58766 Macro Recorder opt not saved

2013-01-03 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1540 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1540 To unsubscribe,

[PUSHED] Paren fix for Ubu 10.04 build (and fdo#58417 ?)

2013-01-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1531 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1531 To unsubscribe,

[PUSHED] fix 'DEBUGCPPUNIT=TRUE make subsequenttest'

2013-01-02 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1532 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1532 To unsubscribe,

[PUSHED] Minimal fix fdo#58766 Macro Recorder opt not saved

2013-01-01 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1523 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1523 To unsubscribe,

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2012-12-31 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1519 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1519 To unsubscribe,

[PUSHED] fdo#57950: remove consecutive append in basctl with StringBu...

2012-12-27 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1486 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1486 To unsubscribe,

[PUSHED] convert icu to gbuild and add to tail_build

2012-12-27 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1488 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1488 To unsubscribe,

Replase GUIBASE checks with equivalent OS checks

2012-12-21 Thread Tor Lillqvist (via Code Review)
Tor Lillqvist has abandoned this change. Change subject: Replase GUIBASE checks with equivalent OS checks .. Patch Set 1: Abandoned Superseded. -- To view, visit https://gerrit.libreoffice.org/1303 To unsubscribe, visit

[PATCH] Change in core[libreoffice-4-0]: fdo#56937 - mac a11y hang related to traversing vast, broken...

2012-12-18 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1401 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/1401/1 fdo#56937 - mac a11y hang related to traversing vast, broken hierarchies. Change-Id:

[PATCH] Replase GUIBASE checks with equivalent OS checks

2012-12-12 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1303 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/1303/1 Replase GUIBASE checks with equivalent OS checks The idea is to get rid of GUIBASE and GUI checks as much as

[PATCH] Get rid of (most uses of) GUI

2012-12-12 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1304 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1304/1 Get rid of (most uses of) GUI GUI only takes values UNX or WNT, so it is fairly pointless. One can check

  1   2   >