Re: libvisio compile on Red Hat Enterprise 6.3 (CentOS 6)

2013-02-07 Thread julien2412
Hello Leon, On pc Debian x86-64 with libvisio retrieved from git://gerrit.libreoffice.org/libvisio, gcc (Debian 4.7.2-5) 4.7.2, boost 1.49, no problem for compiling libvisio (with ./configure --enable-wparanoic) Do you have the same problem with libvisio retrieved from git? Could you give gcc ver

[SOLVED] Re: Cppcheck: ''bSkipBreaks' is assigned a value that is never used (sc)

2013-02-05 Thread julien2412
Thank you Kohei and Caolán for your feedback. I pushed the fix on master (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=444ae4d04adf6c9cdcd1222ef3b8b2e5bf45db0a) Julien -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-bSkipBreaks-is-assigned-a-value

Cppcheck: ''bSkipBreaks' is assigned a value that is never used (sc)

2013-02-05 Thread julien2412
Hello, Cppcheck detected this: sc/source/core/data/table5.cxx 147 unreadVariable style Variable 'bSkipBreaks' is assigned a value that is never used. Here are the lines: 141 if (!bSkipBreaks && pStyleSet->GetItemState(ATTR_PAGE_SCALETO, false, &pItem) == SFX_ITEM_SET) 142

Re: About fdo#53320 MacOs, "unidentified developer" error - GateKeeper

2013-02-05 Thread julien2412
Thorsten, In fact, my initial post on this thread comes from a comment I wanted to add to this bugtracker. After a while, I considered it could be more appropriate to create a new topic on dev mailing list instead of putting a new comment. I thought it could be interesting that several core devs t

Re: Java situation

2013-02-05 Thread julien2412
Stephan Bergmann-2 wrote > I at least am not aware of any such problems that would go away when > downgrading from JRE 7 to 6. 2 examples found with the following query: https://bugs.freedesktop.org/buglist.cgi?query_format=specific&order=relevance%20desc&bug_status=__open__&product=LibreOffice&c

Re: Java situation

2013-02-05 Thread julien2412
julien2412 wrote > - is there a list somewhere of components which use Java? Oups, I should have re read myself another time since there's already the answer in my proper message. (https://wiki.documentfoundation.org/Development/Java) -- View this message in contex

Java situation

2013-02-05 Thread julien2412
Hello, Reading about fdo#60210 and some others, I wonder what's the Java status. I mean there have been issues with Java 1.7 and a lot of them have been fixed, with different origin (Sunjre, OpenJdk, gcj), 32 or 64bits, accessibility JAB (Java Access Bridge) (other issues ?) I know that Base uses

About fdo#53320 MacOs, "unidentified developer" error - GateKeeper

2013-02-04 Thread julien2412
Hello, Concerning fdo#53320 LibreOffice 3.6 will not open on OS X 10.7.5 and Mountain Lion with "unidentified developer" error - GateKeeper https://bugs.freedesktop.org/show_bug.cgi?id=53320 here are some thoughts that I hope not too stupid/naive/... After having leafed through these: http://nab

Cppcheck: "bContainsDate" not read in templateremoteview.cxx (sfx2)

2013-01-27 Thread julien2412
Hello, Cppcheck detected this: sfx2/source/control/templateremoteview.cxx 129 unreadVariable style Variable 'bContainsDate' is assigned a value that is never used. Here are the lines: 124 bool bContainsDate = !xRow->wasNull(); 125 126 i

[SOLVED] Re: Make dev-install fails because of crashrep

2013-01-27 Thread julien2412
Noticing the Michael's commit (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=20773c2bb04631d9bfd60167ed091752f0deecee), I tried a "./g pull -r && make clean && make && make dev-install" I don't know if it was the fix or not, but anyway everything is ok now. Thank you Michael! Julien

Make dev-install fails because of crashrep

2013-01-25 Thread julien2412
Hello, On pc Debian x86-64 with master sources updated today (commit e2250ec113e5534875e7480f5bf508d71fa46f4d), I runned: "make clean && make && make dev-install" I had: : ERROR: Removing file crashrep from file list. : Setting Root Module: gid_Module_Root : Using spellchecker file: /home/j

[SOLVED] Re: Cppcheck: Same expression in testzipimpl.cxx

2013-01-24 Thread julien2412
Thank you Caolán, I pushed the fix (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2f58887eca4b0fce0b56f0763ee5be0d04e671f) -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-Same-expression-in-testzipimpl-cxx-tp4030658p4031526.html Sent from the Dev ma

Re: [Libreoffice-qa] Minutes - QA Call 01/11/2013

2013-01-22 Thread julien2412
I read quickly this thread, so certainly I'll repeat some things from one or another person here but here's what I'm doing: - if "NEW" or "UNCONFIRMED" and need some info (just 1 or several), I put a comment and put State to NEEDINFO - if "NEEDINFO" without feedback for at least 2 months: - eith

Re: Cppcheck: false positive in pptx-text.cxx ?

2013-01-21 Thread julien2412
Thank you for your feedback about this Markus. The problem is, I don't know how to do this, would you have an example? I read again about copy constructor, copy-swap idiom, C++11 standard, etc. so a conversion example to follow could be very useful. I tried to find one in cgit history but didn't f

[SOLVED] Re: Cppcheck : Variable 'nMode' is reassigned in fstat.cxx

2013-01-21 Thread julien2412
Thank you Stephan, I pushed the fix on master (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=87f9d7da00857c649784a7d9eca046bf6e71ae3c) Julien -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-Variable-nMode-is-reassigned-in-fstat-cxx-tp4030405p4030913

Re: About ucbdemo (still used?)

2013-01-21 Thread julien2412
Thank you Stephan for your feedback. Finally, I had pushed a fix about these parenthesis, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e654a9a092682f79d52816d18ad41d2fd6231c3. I don't know if it's unused or rotten but hope I haven't broken it even more :-) Julien -- View this me

[SOLVED] Re: About parenthesis problem in testintrosp.cxx

2013-01-21 Thread julien2412
Thank you Stephan and Lubos. I applied why Lubos indicated, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=bd2302200b7bc8005662b7034346866ae22da38b Julien -- View this message in context: http://nabble.documentfoundation.org/About-parenthesis-problem-in-testintrosp-cxx-tp4030420p

Cppcheck: false positive in pptx-text.cxx ?

2013-01-20 Thread julien2412
Hello, Cppcheck reported this: sd/source/filter/eppt/pptx-text.cxx 1235copyCtorPointerCopying style Value of pointer 'mpImplTextObj', which points to allocated memory, is copied in copy constructor instead of allocating new memory. 1233 TextObj::TextObj( const TextObj& rTextObj ) 123

Cppcheck: Same expression in testzipimpl.cxx

2013-01-20 Thread julien2412
Hello, Cppcheck reported this: shell/qa/zip/testimpl/testzipimpl.cxx 57 duplicateExpression style Same expression on both sides of '=='. 52 bool TestZipImpl::test_directory() 53 { 54 ZipFile::DirectoryPtr_t contents = zipFile.GetDirectory(); 55 vector &strin

About parenthesis problem in testintrosp.cxx

2013-01-19 Thread julien2412
Hello, Here's a problem in stoc/test/testintrosp.cxx, line 182 aRetStr = aRetStr + OUString( OUString(" (Typ: ") ) + xIdlClass->getName() + OUString("")); By taking a look at git history, I found that it was: aRetStr = aRetStr + OUString( OUString(RTL_CONSTASCII_USTRINGPARAM(" (Typ: ")) ) + xIdlC

About ucbdemo (still used?)

2013-01-19 Thread julien2412
Hello, Cppcheck detected this: ucb/workben/ucb/ucbdemo.cxx 1735syntaxError error Invalid number of character (() when these macros are defined: ''. I fixed parenthesis (there was not just one problem) but I don't know how to check this since "make ucbdemo" tells: make: *** No rule to m

Cppcheck : Variable 'nMode' is reassigned in fstat.cxx

2013-01-19 Thread julien2412
Hello, Cppcheck reported this: Indeed, we can see this: 109 if (bRO) 110 { 111 nMode = aBuf.st_mode & ~S_IWUSR; 112 nMode = aBuf.st_mode & ~S_IWGRP; 113 nMode = aBuf.st_mode & ~S_IWOTH; 114 } see http://opengrok.libreoffice.org/xref/

[SOLVED] Re: [BUILD FAILS DEBUG MODE] with test_strings_valuex.cxx

2013-01-19 Thread julien2412
Thank you for the fix Lubos! Building is ok now. Julien -- View this message in context: http://nabble.documentfoundation.org/BUILD-FAILS-DEBUG-MODE-with-test-strings-valuex-cxx-tp4030218p4030308.html Sent from the Dev mailing list archive at Nabble.com. ___

[BUILD FAILS DEBUG MODE] with test_strings_valuex.cxx

2013-01-18 Thread julien2412
Hello, On pc Debian x86-64 with master sources after having runned "make clean", I've got this: /home/julien/compile-libreoffice/libo/sal/qa/rtl/strings/test_strings_valuex.cxx: In instantiation of ‘void testInt() [with T = rtl::OUString]’: /home/julien/compile-libreoffice/libo/sal/qa/rtl/strings/

Cppcheck : Variable 'bRet' is reassigned a value in autoform.cxx

2013-01-17 Thread julien2412
Hello, Cppcheck reported this: sc/source/core/tool/autoform.cxx 1105redundantAssignment style Variable 'bRet' is reassigned a value before the old one has been used. 1102 bRet = (rStream.GetError() == 0); 1103 //

Cppcheck : unused "pUnicodes" variable in pdfwriter_impl.cxx

2013-01-17 Thread julien2412
Hello, Cppcheck reported this: vcl/source/gdi/pdfwriter_impl.cxx 3203unreadVariable style Variable 'pUnicodes' is assigned a value that is never used see http://opengrok.libreoffice.org/xref/core/vcl/source/gdi/pdfwriter_impl.cxx#3182 Can we just remove it or something lacking? Julien

Re: Cppcheck reports

2013-01-16 Thread julien2412
Just for information, I updated the cppcheck reports (LO sources updated today + cppcheck updated today). I also created a first version to explain how to generate all this here: https://wiki.documentfoundation.org/Development/Cppcheck Julien -- View this message in context: http://nabble.docu

About idlc/source/idlccompile.cxx

2013-01-13 Thread julien2412
Hello, Taking a look at this cppcheck report: dlc/source/idlccompile.cxx 198 nullPointer error Possible null pointer dereference: source - otherwise it is redundant to check it against null. I don't understand the function "sal_Bool copyFile(const OString* source, const OString& target

[REVIEW for 4.0 and 3.6] Missing parenthesis in ucb/source/ucp/file/bc.cxx

2013-01-13 Thread julien2412
Hello, Cppcheck detected this: ucb/source/ucp/file/bc.cxx 1175clarifyConditionstyle Boolean result is used in bitwise operation. Clarify expression with parentheses 1173 // Inserts the content, which has the flag m_bIsFresh 1174 1175 if( ! m_nState & NameForInserti

Re: Cppcheck reports

2013-01-11 Thread julien2412
Hi bfo, I don't have access to this ftp but if someone wants to do it, no problem for me :-) About regenerating once a while, since it takes some time to retrieve all these reports, I can propose about once by week. (each time with master sources + cppcheck git updated of course :-)) Julien --

Cppcheck reports

2013-01-11 Thread julien2412
Hello, Since I build master sources and use cppcheck (C/C++ static analyzer) quite regularly, I thought someone could be interested by cppcheck reports. So, I updated today my master sources and launched cppcheck (git updated today) on the sources (except "sal" because of a freeze). Here the resul

Re: [PATCH] Bug 38838 - Removal/Replacement of the String/UniString with OUString once and for all.

2013-01-09 Thread julien2412
Hi Jean-Noël, First thank you for this big patch! Perhaps I missed it but I didn't find a license statement from you. Could you send a post with it? (you can take example from http://nabble.documentfoundation.org/License-Statement-td4027832.html) Thank you in advance. Julien -- View this mess

[RESOLVED/INVALID] Re: [PATCH] Simplify MigrationImpl::subtract in desktop

2013-01-08 Thread julien2412
Hi Stephan The +5 is obviously a kind of type (certainly due to my wrong use of Vi :-)) Above the rest, I didn't think there would be these kinds of problem and must recognize I don't what to answer. So, let's bin all this. Thank you for having taken a look. Julien -- View this message in con

Re: Crash with gnome#627420-1.ods in string related function

2013-01-08 Thread julien2412
Hello Michael, Reading this thread, I took a look at sal/rtl/source/strtmpl.cxx 969 static IMPL_RTL_STRINGDATA* IMPL_RTL_STRINGNAME( ImplAlloc )( sal_Int32 nLen ) 970 { 971 IMPL_RTL_STRINGDATA * pData 972 = (sal::static_int_cast< sal_uInt32 >(nLen) 973<=

Re: No test on the return of pOleObject->Close in embedserv/source/inprocserv/inprocembobj.cxx

2013-01-07 Thread julien2412
Oups, forgot to tell I prefered to submit it since it isn't taken into account during my build. So I don't even know if it builds or not :-( -- View this message in context: http://nabble.documentfoundation.org/No-test-on-the-return-of-pOleObject-Close-in-embedserv-source-inprocserv-inprocembob

Re: No test on the return of pOleObject->Close in embedserv/source/inprocserv/inprocembobj.cxx

2013-01-07 Thread julien2412
Thank you Stephan for your feedback. I submitted a patch to review (see https://gerrit.libreoffice.org/#/c/1567/). Julien -- View this message in context: http://nabble.documentfoundation.org/No-test-on-the-return-of-pOleObject-Close-in-embedserv-source-inprocserv-inprocembobj-cxx-tp4025755p40

Re: Doing massive source changes

2013-01-04 Thread julien2412
Just a simple contributor and C++ beginner of course but I agree for the last solution. About building, it could be interesting to have the maximum of elements enabled in autogen.lastrun (all the extensions + dbgutil). Also, perhaps you won't be able to build on all env (Linux, Win, MacOs...) so we

Re: Wrong indentation which leads to segfault in sc/source/ui/docshell/docfunc.cxx

2013-01-01 Thread julien2412
BTW, it's not cppcheck which had safe iterator since it just allow to scan sources. I rather think it's "--enable-dbgutil" in autogen.lastrun which triggered safe iterator. Julien -- View this message in context: http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in

[REVIEW for 4.0 and 3.6] fdo#47466 FORMATTING: Autoformat empty rows causes app to crash

2013-01-01 Thread julien2412
Hello, I don't reproduce the problem with 4.0 sources (I don't know why) but I can reproduce it with 3.6 sources. Anyway, would it be possible to cherry-pick f843850ee9994653673ef5591aae875d7fb22fed ? (it's just some 2 lacking braces) Julien -- View this message in context: http://nabble.docu

Re: Wrong indentation which leads to segfault in sc/source/ui/docshell/docfunc.cxx

2013-01-01 Thread julien2412
Thank you John for your investigation about all this. In fact, I was leafing through some cppcheck reports. To simplify, I pushed some slight fixes in sc/source/core/tool/autoform.cxx (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=2e1abe1c59b1121ffb5d46afe82ce985cb70c4db). So now w

Wrong indentation which leads to segfault in sc/source/ui/docshell/docfunc.cxx

2012-12-31 Thread julien2412
Hello, 1) Trying to reproduce fdo#47466 with master sources updated this morning, I had this: #0 0x7ff8cd039475 in *__GI_raise (sig=) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 #1 0x7ff8cd03c6f0 in *__GI_abort () at abort.c:92 #2 0x7ff8cd8de31d in __gnu_debug::_Error_formatter:

Question about operator = overloaded in reportdesign module

2012-12-30 Thread julien2412
Hello, Cppcheck reported this: [reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style) 'OXMLComponent::operator=' should return 'OXMLComponent &'. [reportdesign/source/filter/xml/xmlFunction.hxx:41]: (style) 'OXMLFunction::operator=' should return 'OXMLFunction &'. [reportdesign/source/filte

Question about sc/source/core/tool/interpr2.cxx and lcl_GetArabicValue

2012-12-30 Thread julien2412
Hello, Cppcheck reported this: [sc/source/core/tool/interpr2.cxx:2656]: (style) The scope of the variable 'bIsDec2' can be reduced Here are the lines: 2651 while( bValid && (nCharIndex < nCharCount) ) 2652 { 2653 sal_uInt16 nDigit1 = 0; 2654 sal

Questions about function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx

2012-12-29 Thread julien2412
Hello, In function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx, what's the use to process "bHOver" variable in while (bVOver) ? I thought about these too: - declaring nOverlap before the 2 loops, it would avoid to declare it each time in the else of both loops. - bVOver treatment is useles

libreoffice@lists.freedesktop.org

2012-12-29 Thread julien2412
Thank you David, I applied your suggestion, see https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=cf068828d334fcb0998755118e262d16c9db5b3a Julien -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-false-positive-eg-PropEntry-operator-should-return-Prop

[PATCH] Simplify MigrationImpl::subtract in desktop

2012-12-28 Thread julien2412
Hello, By reading the function MigrationImpl::subtract in desktop/source/migration/migration.cxx, see http://opengrok.libreoffice.org/xref/core/desktop/source/migration/migration.cxx#847 I thought about this patch to use "set_difference" desktop_patch.txt

Cppcheck reports an 2 assignments which isn't used in drawinglayer module

2012-12-28 Thread julien2412
Hello, Cppcheck reported these: [drawinglayer/source/primitive2d/sceneprimitive2d.cxx:196]: (style) Variable 'fViewSizeX' is assigned a value that is never used. [drawinglayer/source/primitive2d/sceneprimitive2d.cxx:197]: (style) Variable 'fViewSizeY' is assigned a value that is never used. 1

libreoffice@lists.freedesktop.org

2012-12-27 Thread julien2412
Thank you Lubos for the reference. So I won't change these since it could generate some regressions if badly done. About first report, I meant that = operator is a priori for assignment not for comparison. So even if the one who did this, did it right (and I suppose it's the case), it could be a l

libreoffice@lists.freedesktop.org

2012-12-27 Thread julien2412
Hello, Cppcheck reports this kind of thing: [sd/source/filter/ppt/propread.hxx:116]: (style) 'PropEntry::operator=' should return 'PropEntry &'. 116 const PropEntry& operator=(const PropEntry& rPropEntry); Indeed, I understand this cppcheck report, if you assign a variable, the result can

Cppcheck reports an assignment which isn't used in sd/source/ui/func/fupage.cxx

2012-12-27 Thread julien2412
Hello, Cppcheck reported this: [sd/source/ui/func/fupage.cxx:243]: (style) Variable 'pPtr' is assigned a value that is never used Here are some lines: 236 const sal_uInt16* pPtr = aNewAttr.GetRanges(); 237 sal_uInt16 p1 = pPtr[0], p2 = pPtr[1]; 238 while(pPtr[2] && (pPtr[2

Cppcheck reports Resource leak in setup_native/source/win32/wintools/makecab/parseddf.c

2012-12-27 Thread julien2412
Hello, cppcheck reported this: [setup_native/source/win32/wintools/makecab/parseddf.c:381]: (error) Resource leak: ddf it's in the function ParseDdf fclose function seems to miss. (see http://opengrok.libreoffice.org/xref/core/setup_native/source/win32/wintools/makecab/parseddf.c#356) I'm not ab

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread julien2412
Riccardo Magliocchetti wrote > Il 24/12/2012 15:45, julien2412 ha scritto: >> diff --git a/sal/typesconfig/typesconfig.c >> b/sal/typesconfig/typesconfig.c >> index 473f07a..ef52c5f 100644 >> --- a/sal/typesconfig/typesconfig.c >> +++ b/sal/typesconfig/typescon

Using memset or other way in sal/osl/unx/security.c

2012-12-24 Thread julien2412
Hello, In sal/osl/unx/security.c, I noticed these: 278 sal_Bool SAL_CALL osl_getHomeDir(oslSecurity Security, rtl_uString **pustrDirectory) 279 { 280 sal_Bool bRet=sal_False; 281 sal_Char pszDirectory[PATH_MAX]; 282 283 pszDirectory[0] = '\0'; 373 sal_Bool

[PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread julien2412
Hello, By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a memset to optimize a bit. So here's a straightforward patch: diff --git a/sal/typesconfig/typesconfig.c b/sal/typesconfig/typesconfig.c index 473f07a..ef52c5f

Re: [libreoffice-l10n] [ANN] LibreOffice 4.0.0 Beta2 available

2012-12-23 Thread julien2412
Hi, A tracker about this has been created here: https://bugs.freedesktop.org/show_bug.cgi?id=58052 Julien -- View this message in context: http://nabble.documentfoundation.org/ANN-LibreOffice-4-0-0-Beta2-available-tp4025875p4025939.html Sent from the Dev mailing list archive at Nabble.com. __

About fdo#58451 (Base crash when Execute report with a empty database)

2012-12-23 Thread julien2412
Hello, The cause of this tracker has been found. Since Noel can't intervene before a week (see https://bugs.freedesktop.org/show_bug.cgi?id=58451#c18), would anybody have some time to take a look at this? Julien -- View this message in context: http://nabble.documentfoundation.org/About-fdo-

No test on the return of pOleObject->Close in embedserv/source/inprocserv/inprocembobj.cxx

2012-12-21 Thread julien2412
Hello, Cppcheck reported this: [source/inprocserv/inprocembobj.cxx:783] -> [source/inprocserv/inprocembobj.cxx:784]: (performance) Variable 'hr' is reassigned a value before the old one has been used Here are the lines: 778 HRESULT hr = m_pDefHandler->QueryInterface( IID_IOleObject, (

Re: Cppcheck reports "reassign before using" variable in sw/source/core/doc/tblafmt.cxx

2012-12-20 Thread julien2412
Thank you again Michael for your feedback. I know there are comments like FIXME, TODO in LO and certainly others but I don't know if there has been some formalism (not too much since it could be very quickly unproductive) about this. So, since there are lots of tasks/bugs in LO, perhaps it could

Re: Question about cppcheck report on (SwCrsrShell::GetSmartTagTerm)

2012-12-20 Thread julien2412
Thank you Michael for your answer. I've created a cppcheck ticket about it. (see https://sourceforge.net/apps/trac/cppcheck/ticket/4425) Julien -- View this message in context: http://nabble.documentfoundation.org/Question-about-cppcheck-report-on-SwCrsrShell-GetSmartTagTerm-tp4025236p4025372.

Cppcheck reports "reassign before using" variable in sw/source/core/doc/tblafmt.cxx

2012-12-19 Thread julien2412
Hello, Cppcheck detected this: [sw/source/core/doc/tblafmt.cxx:1227] -> [sw/source/core/doc/tblafmt.cxx:1234]: (performance) Variable 'bRet' is reassigned a value before the old one has been used. 1221 // Attention: We need to save a general Header here 1222 sal_uInt16 nVal =

Question about cppcheck report on (SwCrsrShell::GetSmartTagTerm)

2012-12-19 Thread julien2412
Hello, Cppcheck reported this: [source/core/crsr/crsrsh.cxx:3357] -> [source/core/crsr/crsrsh.cxx:3365]: (performance) Variable 'rContent' is reassigned a value before the old one has been used. Indeed, we have these lines: 3356 SwIndex& rContent = GetCrsr()->GetPoint()->nContent;

Question cppcheck reports on svx/source/svdraw/svdoedge.cxx (Bezier curve)

2012-12-19 Thread julien2412
Hello, Cppcheck detected this into svx/source/svdraw/svdoedge.cxx [svdoedge.cxx:1450]: (style) Variable 'pPt1' is assigned a value that is never used. [svdoedge.cxx:1453]: (style) Variable 'pPt4' is assigned a value that is never used Here are the lines: 1450 pPt1=&aXP1[0]; 1451

About fdo#58026, Localization problem for GoogleDocs extension

2012-12-18 Thread julien2412
Hello, I opened fdo#58026 (https://bugs.freedesktop.org/show_bug.cgi?id=58026), so I'll just quote what I put. With Google docs extension 2a64b8e6f185a7f6c19d00fb8bb4cf64-gdocs_3.0.1_modified.oxt, and with English localization, one of the option isn't translated. In fact, the problem is just her

Question about vcl/source/window/builder.cxx

2012-12-15 Thread julien2412
Hello, Keeping on with cppcheck, I found this on vcl/source/window/builder.cxx 1892 else if (sKey == "pack-type") 1893 { 1894 VclPackType ePackType = (sValue[0] == 'e' || sValue[0] == 'e') ? VCL_PACK_END : VCL_PACK_START; 1895 pCu

Question about sc/source/ui/view/cellsh.cxx

2012-12-15 Thread julien2412
Hello, In sc/source/ui/view/cellsh.cxx, we have these lines: 150 case FID_FILL_TO_RIGHT: // fill to left / right 151 { 152 bDisable = !bSimpleArea || (nCol1 == 0 && nCol2 == 0); 153 bDisable = pDoc->HasSelectedBlockMatrixF

Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread julien2412
Hello, I noticed these lines in file sc/source/core/data/colorscale.cxx (because cppcheck report indicates that bNeedUpdate is reassigned before to be used line 641) 637 void ScDataBarFormat::DataChanged(const ScRange& rRange) 638 { 639 bool bNeedUpdate = false; 640 641

Re: recent git master branch : crash instead of error popup

2012-12-08 Thread julien2412
Hi Olivier, First, you must know that it's the dev mailing list here and not user mailing list. Dev mailing list is for discussing about patches, building process of LO, etc. About the bug, you didn't quote info like Java version, platform for example. Moreover, try to be a little more precise a

[REVIEW for 4.0] Missing breaks in connectivity/source/drivers/odbcbase/OTools.cxx

2012-12-08 Thread julien2412
Hello, Could someone check commit 44b0bf91df1af9920b1c22a2f54bd70c9c44231b for cherry-picking in 4.0? --- connectivity/source/drivers/odbcbase/OTools.cxx --- index a868b0b..290aa61 100644 @@ -682,8 +682,10 @@ SQLSMALLINT OTools::jdbcTypeToOdbc(sal_Int32 jdbcType) // O

Re: intending to join as a developer

2012-12-08 Thread julien2412
Hello, Welcome here! You must know that the main language of LO is C++. These are used too: C, Python, Java (even assembly). SCM is Git and Gerrit is used too. If you want to contribute as a dev, the first thing is to build from sources by following this: http://wiki.documentfoundation.org/Develo

Re: Build failure on master on mysqlc module

2012-12-08 Thread julien2412
Lubos Lunak wrote >> Entering /home/julien/compile-libreoffice/libo/mysqlc/source > ... >> /home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_services.cxx:20: >> /home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/stringutils.h >>xx:34:27: fatal error: config_global.h: No such fil

Build failure on master on mysqlc module

2012-12-08 Thread julien2412
Hello, On pc Debian x86-64 with master sources updated today (commit 6858182d246f21c5b06af09d8ff0e6fd04ef26c3) and following a make clean, I've got this: Entering /home/julien/compile-libreoffice/libo/mysqlc/source Compiling: mysqlc/source/mysqlc_driver.cxx Compiling: mysqlc/source/mysqlc_servic

About numbertext

2012-12-06 Thread julien2412
Hello, By trying to reproduce an fdo, I got a lot of these on console: Python exception: : inconsistent use of tabs and spaces in indentation (__init__.py, line 70), traceback follows /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/uno.py:265 in function _uno_impor

[PATCH for 3.6] Lacking "/" with .icedove prevents to use Icedove addressbook

2012-12-01 Thread julien2412
Hello, Reading https://bugs.freedesktop.org/show_bug.cgi?id=57419, I found there was a missing "/" at the end of ".icedove" in connectivity/source/drivers/mork/MNSFolders.cxx, line 88 It's my fault (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d7e1a6e13008bd7d35896e676796196038f1

Alternative/complementary to Valgrind with MemorySanitizer, ThreadSanitizer (LLVM) ?

2012-11-26 Thread julien2412
Hi, Perhaps you already know these components but just read about this and it seemed very interesting. Here's a quick sumup: http://llvm.org/devmtg/2012-11/#talk4 and a more detailed presentation here: http://llvm.org/devmtg/2012-11/TSan-MSan-LLVM-dev-2012.pdf They're quite fast (more than Valgri

[PATCH] proposed patch for fdo56549 CRASH in menu 'Format → Autocorrect → Apply and Edit Changes'

2012-11-26 Thread julien2412
Hello, I propose a patch for fdo#56549 (see https://bugs.freedesktop.org/show_bug.cgi?id=56549): https://bugs.freedesktop.org/attachment.cgi?id=70538 I think (not sure at all) that the problem was that at the end _GetAutoFmtNameLst(), destructor ~ImpAutoFmtNameListLoader for aTmp is called and mu

Re: [libreoffice-users] - Scalc.java ported to C++ , uses DocumentLoader

2012-11-17 Thread julien2412
Hi, As proposed Enrico, you can use gerrit (see http://wiki.documentfoundation.org/Development/gerrit). You can also send a post here with a patch attached (see http://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines) Julien -- View this message in context: http://nabble.doc

Linux "make dev-install" fails with 3.6

2012-11-10 Thread julien2412
Hello, On pc Debian nx86-64 with 3.6 sources updated today, "make dev-install" fails. : ERROR: Removing file dict-af.oxt from file list. : ERROR: Removing file dict-an.oxt from file list. : ERROR: Removing file dict-ar.oxt from file list. : ERROR: Removing file dict-be.oxt from file list. : ERROR:

Re: Fail to build LO on Windows, MSVCR80.dll: cannot open shared object file

2012-11-09 Thread julien2412
Thank you again Michael :-) Now, I've got "MSVCR80.dll: cannot open shared object file: No such file or directory" I don't understand since I made the external/msvcp80 thing (see http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies#Pre-built_Mozilla_libraries) + I installed "

Fail to build LO on Windows, Cannot link against library/libraries advapi32.lib

2012-11-09 Thread julien2412
Hello, First thank you Michael for your fix about this problem: http://nabble.documentfoundation.org/Fail-to-build-LO-on-Windows-missing-separator-in-sal-tp4015192.html Now I've got this: /home/annie/libreoffice/master/shell/Library_losessioninstall.mk:19: *** Cannot link against library/librarie

Re: Fail to build LO on Windows, missing separator not in sal this time but in accessibility

2012-11-06 Thread julien2412
I updated today my sources and runned make clean && make. In addition, since I still got have a problem to build sources in Windows, I used the command provided by Norbert: make --debug=c,e tail_build logs.zip Any idea? (I removed de

Re: Building failure in connectivity/source/drivers/evoab2

2012-11-06 Thread julien2412
Hi, After having recreated from scratch my master local repo, I've got this now: julien@julienPC:~/compile-libreoffice/libo$ make tail_build make -r -f /home/julien/compile-libreoffice/libo/Makefile.top tail_build make[1]: Entering directory `/home/julien/compile-libreoffice/libo' cd tail_build &

Re: Building failure in connectivity/source/drivers/evoab2

2012-11-05 Thread julien2412
Hi Lionel, I gave a try to your patch. I applied it then "make connectivity", I got this: /home/julien/compile-libreoffice/libo/solenv/gbuild/ComponentTarget.mk:63: *** gb_Deliver_deliver: file does not exist in solver, and cannot be delivered: /home/julien/compile-libreoffice/libo/solver/unxlngx6

Building failure in connectivity/source/drivers/evoab2

2012-11-05 Thread julien2412
Hello, With master sources updated today, I've got this: /home/julien/compile-libreoffice/libo/connectivity/source/drivers/evoab2/NStatement.cxx: In constructor ‘connectivity::evoab::OCommonStatement::OCommonStatement(connectivity::evoab::OEvoabConnection*)’: /home/julien/compile-libreoffice/libo/

About fdo#45911 crash when drag/drop slide between two instances of Impress

2012-11-03 Thread julien2412
Hello, I gave a new try to fdo#45911 (https://bugs.freedesktop.org/show_bug.cgi?id=45911) and had a new bt (see https://bugs.freedesktop.org/attachment.cgi?id=69486) I just put Caolán's on cc of this bugtracker since one of his commit seems to fix the pb on 3.6 (see https://bugs.freedesktop.org/s

About shapeexport.cxx in xmloff

2012-11-01 Thread julien2412
Hi, On xmloff/source/draw/shapeexport.cxx, line 711 seems quite weird: 704 XMLTokenEnum eDisplayToken = XML_TOKEN_INVALID; 705 const unsigned short nDisplay = (bVisible ? 2 : 0) | (bPrintable ? 1 : 0); 706 switch( nDisplay ) 707 {

Re: [PATCH] Resolves: fdo#38193 WRITER, DRAW: Media Player is missing in...

2012-10-28 Thread julien2412
Hi, Idem here too, I wanted to push a simple patch but I forgot "git push" was pushing all the commits :-( Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-Resolves-fdo-38193-WRITER-DRAW-Media-Player-is-missing-in-tp4015624p4015656.html Sent from the Dev ma

Re: [PATCH] Resolves: fdo#56473 IDE: Crash when inserting a simple macro

2012-10-28 Thread julien2412
Hi, Sorry, I wanted to push a simple patch but I forgot "git push" was pushing all the commits :-( Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-Resolves-fdo-56473-IDE-Crash-when-inserting-a-simple-macro-tp4015637p4015655.html Sent from the Dev mailing l

Re: [PATCH] Resolves: fdo#56473 IDE: Crash when inserting a simple macro

2012-10-27 Thread julien2412
+ some other changes (sal_Int32 instead of int for i variable + "!=" to compare current iterator with end iterator instead of "<") Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-Resolves-fdo-56473-IDE-Crash-when-inserting-a-simple-macro-tp4015637p4015639.htm

Re: Error compiling LO on Windows with uwinapi.ilk not found

2012-10-24 Thread julien2412
Seeing the last changes, I had runned "make clean" today, then I stumbled on http://nabble.documentfoundation.org/Fail-to-build-LO-on-Windows-missing-separator-in-sal-td4015192.html (as you already noticed of course:-) ) So I don't know if it's ok now. Just noticed that today, it fails just a mome

Re: Fail to build LO on Windows, missing separator in sal

2012-10-24 Thread julien2412
Sorry Michael, I hadn't copied the whole thing: annie@PC-de-annie ~/libreoffice/master $ /opt/lo/bin/make --version GNU Make 3.82 Built for i686-pc-cygwin Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free so

Fail to build LO on Windows, missing separator in sal

2012-10-24 Thread julien2412
Hello, On Vista SP2 32 bits with master sources updated today (a2e8ac6228f4863eef84ca8a9fca73a3808c1b18) and cleaned. Cygwin 1.7 $ make --version GNU Make 3.82 Built for i686-pc-cygwin I have this: $ make sal make -r -f /home/annie/libreoffice/master/Makefile.top sal make[1]: Entering directory

Re: About Windows Tinderbox error

2012-10-24 Thread julien2412
Stephan Bergmann-2 wrote > I'd assume that if those fdo#46808 related commits introduced one > Windows-only error they probably introduced more, so I started a Windows > build now to hopefully fix them all. However, that build takes a while > for me, so please stay tuned... Hi Stephan, fdo#46

About Windows Tinderbox error

2012-10-24 Thread julien2412
Hello, Following this commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=c988da288ec473a28f61ebb53aa3ff82bab11ef4, shouldn't fpicker/source/win32/filepicker/FPentry.cxx I wonder reading this: http://opengrok.libreoffice.org/xref/core/fpicker/source/win32/filepicker/FPentry.cxx#49 usin

Re: Cppcheck report in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx

2012-10-21 Thread julien2412
Ivan Timofeev wrote > On 20.10.2012 22:23, julien2412 wrote: >> [gdi/salnativewidgets-gtk.cxx:3452] -> >> [gdi/salnativewidgets-gtk.cxx:3462]: >> (performance) Variable 'eState' is reassigned a value before the old one >> has >> been used. >> I

Cppcheck report in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx

2012-10-20 Thread julien2412
Hello, Just noticed this with cppcheck: [gdi/salnativewidgets-gtk.cxx:3452] -> [gdi/salnativewidgets-gtk.cxx:3462]: (performance) Variable 'eState' is reassigned a value before the old one has been used. Here are the lines: 3452 GtkStateType eState = (nState & CTRL_STATE_ENABLED) ? GTK_STAT

Error compiling LO on Windows with uwinapi.ilk not found

2012-10-20 Thread julien2412
Hello, Following the make problem, I've got now this error: $ make sal make -r -f /home/annie/libreoffice/master/Makefile.top sal make[1]: Entering directory `/home/annie/libreoffice/master' cd sal && /opt/lo/bin/make -j 2 -rs gb_PARTIALBUILD=T make[2]: Entering directory `/home/annie/libreoffice

Re: Errors with Makefile.top for building Windows

2012-10-20 Thread julien2412
Found the problem with "make". In fact, I retrieved the specific "make" in /opt/lo/bin but "which make" indicates "/usr/bin/make". So I backup then replace "/usr/bin/make" by "/opt/lo/bin/make" Thank you Matúš and Flavio for your help about this, it was almost ok, just a path problem finally. Hope

Re: Errors with Makefile.top for building Windows

2012-10-19 Thread julien2412
Flavio Moringa wrote > you have to use another "make" for libreoffice. > > Check this: > http://wiki.documentfoundation.org/User:Foral/Build_Win#Cygwin Badfully, I've got exactly the same result as before with this make. Any other idea? Julien. -- View this message in context: http://nabble

Errors with Makefile.top for building Windows

2012-10-18 Thread julien2412
Hello, On Vista SP2 (32 bits) and with Cygwin 1.7 installed some days ago, I've got these errors: /cygdrive/d/compile-libreoffice/libo/Makefile.top:325: target `D' doesn't match the target pattern /cygdrive/d/compile-libreoffice/libo/Makefile.top:329: target `D' doesn't match the target pattern /c

Re: [PATCH] gbuildification of jpeg

2012-10-11 Thread julien2412
??? I don't understand this message, I don't even know how gbuildify a module. Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-gbuildification-of-jpeg-tp4012630p4012631.html Sent from the Dev mailing list archive at Nabble.com. ___

<    2   3   4   5   6   7   8   9   10   11   >