https://bugs.documentfoundation.org/show_bug.cgi?id=39631
Michael Stahl changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.documentfoundation.org/show_bug.cgi?id=39631
Commit Notification changed:
What|Removed |Added
Whiteboard|| target:5.2.0
--
You are r
https://bugs.documentfoundation.org/show_bug.cgi?id=39631
--- Comment #13 from Commit Notification
---
Sheikha AL-Hinai committed a patch related to this issue.
It has been pushed to "master":
http://cgit.freedesktop.org/libreoffice/core/commit/?id=eafb1ebf74c3caf8fbecdc6a4fc7037c3c8f4964
tdf#
https://bugs.documentfoundation.org/show_bug.cgi?id=39631
--- Comment #14 from Commit Notification
---
Michael Meeks committed a patch related to this issue.
It has been pushed to "master":
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e75406e54c57fc3113d4f1983249eb2aec0a3bcd
tdf#396
https://bugs.documentfoundation.org/show_bug.cgi?id=39631
--- Comment #12 from jan iversen ---
you point at the ci build job not the patch.
the patch is
https://gerrit.libreoffice.org/#/c/21070
I have added it to my review list.
--
You are receiving this mail because:
You are on the CC list f
https://bugs.documentfoundation.org/show_bug.cgi?id=39631
--- Comment #11 from sheikha ---
I add SAL_LIKELY, SAL_UNLIKELY ,SAL_HOT, SAL_COLD pair of macro in sal/types.h
,
before that I add
_SAL_BOOLEAN_EXPR which is an alternative way of using __builtin_expect which
is good for implicit conv
https://bugs.freedesktop.org/show_bug.cgi?id=39631
--- Comment #9 from Michael Meeks ---
As you like; we have less and less C these days I guess, and IIRC we compile it
as C++ (?) =)
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=39631
--- Comment #8 from Stephan Bergmann ---
(In reply to comment #7)
> I just dug throught he commit log for glib =) I'd be inclined to simply
> re-use G_LIKELY and G_UNLIKELY with a SAL prefix myself.
That _G_BOOLEAN_EXPR trick would work. An alt
https://bugs.freedesktop.org/show_bug.cgi?id=39631
--- Comment #7 from Michael Meeks ---
I guess it might be worth talking to the glib developers; gmacros.h has a
reasonably workable version - however the _G_BOOLEAN_EXPR stuff is not the
ultimate in beauty =) The implementation in glib is all wri
https://bugs.freedesktop.org/show_bug.cgi?id=39631
--- Comment #6 from Stephan Bergmann ---
also note that GCC __builtin_expect (with its first parameter being of type
long) is plain, simple, and generally does not work as one would naively hope:
> class C {
> private:
> struct S;
> type
https://bugs.freedesktop.org/show_bug.cgi?id=39631
Stephan Bergmann changed:
What|Removed |Added
CC||sberg...@redhat.com
--- Comment #5 fr
https://bugs.freedesktop.org/show_bug.cgi?id=39631
--- Comment #4 from Michal Strnad ---
I am working on this bug.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.o
https://bugs.freedesktop.org/show_bug.cgi?id=39631
Michal Strnad changed:
What|Removed |Added
Assignee|libreoffice-b...@lists.free |high...@gmail.com
|des
https://bugs.freedesktop.org/show_bug.cgi?id=39631
--- Comment #3 from Kohei Yoshida ---
That header sal/inc/sal/macros.h these days lives in include/sal/macros.h.
BTW, there never was sal/inc/sal/macros.hxx. It was always
sal/inc/sal/macros.h.
--
You are receiving this mail because:
You are
https://bugs.freedesktop.org/show_bug.cgi?id=39631
Björn Michaelsen changed:
What|Removed |Added
CC||libreoffice@lists.freedeskt
15 matches
Mail list logo