[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 Hossein changed: What|Removed |Added Whiteboard||reviewed:2023 --- Comment #13 from

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 --- Comment #12 from jan iversen --- Please be aware, that this easyhack is considered an important but large scale cosmetic change as described in

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 jan iversen changed: What|Removed |Added Whiteboard|ToBeReviewed| --

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 jan iversen changed: What|Removed |Added Whiteboard|target:4.4.0

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 jan iversen changed: What|Removed |Added Whiteboard|target:4.4.0

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 --- Comment #7 from Fernando Montes fernandomonte...@me.com --- Well i am going to try to do what is left of this. Hopefully i can get ride of both headers. Though i doubt getting rid of them will improve performance by much. -- You are

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 --- Comment #7 from Fernando Montes fernandomonte...@me.com --- Well i am going to try to do what is left of this. Hopefully i can get ride of both headers. Though i doubt getting rid of them will improve performance by much. -- You are

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 --- Comment #8 from Tor Lillqvist t...@iki.fi --- What made you think this bug has anything to do with performance? -- You are receiving this mail because: You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 --- Comment #9 from Fernando Montes fernandomonte...@me.com --- I don't know. I don't really understand what the bug really is. I understand its about types conflicting with each other. But much like you said I can't think of a clear way

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 --- Comment #9 from Fernando Montes fernandomonte...@me.com --- I don't know. I don't really understand what the bug really is. I understand its about types conflicting with each other. But much like you said I can't think of a clear way

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.documentfoundation.org/show_bug.cgi?id=82579 --- Comment #8 from Tor Lillqvist t...@iki.fi --- What made you think this bug has anything to do with performance? -- You are receiving this mail because: You are the assignee for the bug. ___

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 --- Comment #4 from Tor Lillqvist t...@iki.fi --- Forgot the quartz/hide-osl-timevalue.h, would be something like this. (But the above was just one test approach, not sure at all that it is sane.) #define TimeValue OslTimeValue #include

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC|

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 --- Comment #6 from Tor Lillqvist t...@iki.fi --- Or we could just say that having premac.h/postmac.h is not that bad after all and close this bug as WONTFIX. After all, the above approach at least is hardly any cleaner... -- You are receiving

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 --- Comment #4 from Tor Lillqvist t...@iki.fi --- Forgot the quartz/hide-osl-timevalue.h, would be something like this. (But the above was just one test approach, not sure at all that it is sane.) #define TimeValue OslTimeValue #include

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 --- Comment #6 from Tor Lillqvist t...@iki.fi --- Or we could just say that having premac.h/postmac.h is not that bad after all and close this bug as WONTFIX. After all, the above approach at least is hardly any cleaner... -- You are receiving

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 --- Comment #3 from Tor Lillqvist t...@iki.fi --- I guess handling TimeValue will be problematic here, as it is defined in a stable API header, osl/time.h. OK to break API (and ABI?) by renaming TimeValue there to OslTimeValue? Or is something

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 --- Comment #3 from Tor Lillqvist t...@iki.fi --- I guess handling TimeValue will be problematic here, as it is defined in a stable API header, osl/time.h. OK to break API (and ABI?) by renaming TimeValue there to OslTimeValue? Or is something

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 --- Comment #2 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Tor Lillqvist committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 --- Comment #2 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Tor Lillqvist committed a patch related to this issue. It has been pushed to master:

[Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 Michael Stahl mst...@redhat.com changed: What|Removed |Added Whiteboard||EasyHack

[Libreoffice-bugs] [Bug 82579] get rid of premac.h / postmac.h wrapper headers

https://bugs.freedesktop.org/show_bug.cgi?id=82579 Michael Stahl mst...@redhat.com changed: What|Removed |Added Whiteboard||EasyHack