[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 Chris Sherlock changed: What|Removed |Added Whiteboard|ToBeReviewed|target:5.1.0 ToBeReviewed --- Co

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 jan iversen changed: What|Removed |Added Whiteboard|target:5.1.0|ToBeReviewed -- You are receiving

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #30 from Ian Gilham --- Okay, I've naïvely changed all the vector instances to vector. New Changes: https://gerrit.libreoffice.org/17914 Changed vector to vector https://gerrit.libreoffice.org/17915 alter vector* to vector

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #29 from Ian Gilham --- Good point. I'll try to get that change in soonish. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #28 from David Tardon --- Yes, the intial objective has been achieved. There is one small possible improvement yet, though: the remaining list classes typically hold a vector of pointers and the elements are dynamically allocat

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #27 from Ian Gilham --- We might be hitting the point of diminished returns on this ticket now. Most of the offending code has been removed. Is there any desire to keep going and continue making small removals in this area? -

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #26 from Commit Notification --- Ian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4498c5e1d0e0c98055d6ce6ad22c840e89b401cc tdf#90222: Remove

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #25 from Ian Gilham --- And on a different branch (isolated code changes) New Changes: https://gerrit.libreoffice.org/17680 Removed another FuncDataList collection -- You are receiving this mail because: You are on the CC l

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #24 from Ian Gilham --- New Changes: https://gerrit.libreoffice.org/17678 tdf#90222: Removed ScaList and cleaned up usages https://gerrit.libreoffice.org/17679 migrated some raw pointers to unique_ptr's -- You are receiving

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #23 from Commit Notification --- Ian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2e23b6b9fc31de8177d72028f4d9441c76015903 tdf#90222: Remove

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #22 from Commit Notification --- Ian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5cebd1bfc15eed5cc2018a88a7b0cd5a841f6bc tdf#90222: Remove

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #21 from Ian Gilham --- New Changes: https://gerrit.libreoffice.org/17651 tdf#90222: Removed ScaFuncDataList type https://gerrit.libreoffice.org/17652 tdf#90222: Removed ScaList from pricing scaddin -- You are receiving this

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 Ian Gilham changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |ian.gil...@gmail.com

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #19 from Commit Notification --- Ian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=46ae639272baac0fda61b456a44d5d1307d7b230 tdf#90222: Remove

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #18 from tux3 --- I started working on this bug yesterday too, oops! I was about to send a patch that removes ScaList from datefunc, but I see I'm a bit late to take on this bug. So here it is anyways, rebased it on top of Ia

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #17 from Ian Gilham --- Another: https://gerrit.libreoffice.org/#/c/17579/ -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list L

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #16 from Commit Notification --- Ian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=25534a62b2ba398c6298c6b9e521f20de1087540 tdf#90222: Remove

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #15 from Ian Gilham --- Another small one: https://gerrit.libreoffice.org/17573 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing l

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #14 from Commit Notification --- Ian committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=09a9234c021ad98c5adeb493b5814e97b92ee912 tdf#90222: Remove

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 Commit Notification changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #13 from Ian Gilham --- Hi there. It's my first time so please be gentle. First, a caveat: my antivirus keeps complaining about a trojan while trying to run CppunitTest_filter_tiff_test. The test currently fails on master, but

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #12 from David Tardon --- @tml: Nope, it hasn't. The submitted patch has been rejected. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice m

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #11 from Tor Lillqvist --- (Which you didn't, but just in case;) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #10 from Tor Lillqvist --- Start by readin the previous comments? Based on them, it seems to me that this has already been done? Don't start by assigning it to yourself before you have any idea what to do... -- You are receiv

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 ashutosh75 changed: What|Removed |Added CC||ashutoshnaran...@gmail.com --- Comme

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 David Tardon changed: What|Removed |Added Assignee|pieter...@gmail.com |libreoffice-b...@lists.free

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 Matthew Francis changed: What|Removed |Added CC||fdb...@neosheffield.co.uk

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #8 from Pieter Adriaensen --- Thanks for the help. Here is the patch to get rid of the ScaList. https://gerrit.libreoffice.org/#/c/15177/ -- You are receiving this mail because: You are on the CC list for the bug. __

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #7 from Michael Meeks --- Hi Pieter - there is no need to add a new class to the makefiles, but assuming you mean a new source module try: scaddins/Library_*.mk eg. $(eval $(call gb_Library_add_exception_objects,analysis,\

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #6 from Pieter Adriaensen --- I fixed the issue and I'm now fixing the code replication of pricing and datefunc by making a base class that they will inherit from. But I can't find where to put the new class in the makefiles. A

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #5 from David Tardon --- (In reply to Pieter Adriaensen from comment #4) > I still have a question though: The ScaList is always used to put data of > the same class in. So isn't it better to change it to vector instead of > be

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #4 from Pieter Adriaensen --- I pushed a patch to gerrit https://gerrit.libreoffice.org/#/c/15012/ tdf#90222: replace ScaList in scaddins with a std container I still have a question though: The ScaList is always used to put

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #3 from Pieter Adriaensen --- (In reply to Tor Lillqvist from comment #2) > OK, if you promise to assign back to the default if you don't do this > within, say, two weeks... Ok, but I'm planning on fixing it though :) -- You

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #2 from Tor Lillqvist --- OK, if you promise to assign back to the default if you don't do this within, say, two weeks... -- You are receiving this mail because: You are on the CC list for the bug. ___

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 Pieter Adriaensen changed: What|Removed |Added CC||pieter...@gmail.com

[Bug 90222] replace ScaList in scaddins with a std container

https://bugs.documentfoundation.org/show_bug.cgi?id=90222 David Tardon changed: What|Removed |Added Status|UNCONFIRMED |NEW CC|