https://bugs.documentfoundation.org/show_bug.cgi?id=94306
jan iversen changed:
What|Removed |Added
Whiteboard||ToBeReviewed
--
You are receiving
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
Robinson Tryon (qubit) changed:
What|Removed |Added
Whiteboard|EasyHack DifficultyBeginner |
|Skil
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
Robinson Tryon (qubit) changed:
What|Removed |Added
Keywords||difficultyBeginner,
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #19 from Siddharth Khabia ---
i have replace uses of boost::noncopyable in a module
but when i do boost/noncopyable , it shows its use as a header file.
will only commenting out/deleteing those headere files work ?
--
You are
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #18 from Siddharth Khabia ---
(In reply to Kohei Yoshida from comment #15)
> (In reply to Stephan Bergmann from comment #14)
> > (In reply to Siddharth Khabia from comment #10)
> > > my apology for the earlier comment that was
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #17 from Siddharth Khabia ---
I will be glad to do that !
have you completed sw , i changed a few files of that ?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #16 from Umang Jain ---
(In reply to Siddharth Khabia from comment #12)
> i find this bug great to start off with so can i also join in with umang and
> do the sw module to get hang of this ?
>
> once i am done with with sw ho
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #15 from Kohei Yoshida ---
(In reply to Stephan Bergmann from comment #14)
> (In reply to Siddharth Khabia from comment #10)
> > my apology for the earlier comment that was posted by mistake.
> > i want to ask is that are we su
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #14 from Stephan Bergmann ---
(In reply to Siddharth Khabia from comment #10)
> my apology for the earlier comment that was posted by mistake.
> i want to ask is that are we supposed to remove boost::noncopyable and add
> the c
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
Stephan Bergmann changed:
What|Removed |Added
CC||sberg...@redhat.com
--- Commen
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #12 from Siddharth Khabia ---
i find this bug great to start off with so can i also join in with umang and do
the sw module to get hang of this ?
once i am done with with sw how do i submit it ?
--
You are receiving this mai
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #11 from Siddharth Khabia ---
i find this bug great to start off with so can i also join in with umang and do
the sw module to get hang of this ?
once i am done with with sw how do i submit it ?
--
You are receiving this mai
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #10 from Siddharth Khabia ---
my apology for the earlier comment that was posted by mistake.
i want to ask is that are we supposed to remove boost::noncopyable and add the
code provided bu BJORN in the public part of the class
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #9 from Siddharth Khabia ---
Like umang this is my first bug too. i have a working build .
in a file in sw :
inc/breakit.hxx :
should this :
class SW_DLLPUBLIC SwBreakIt : private ::boost::noncopyable
{
com::sun::star::uno
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #8 from Daniel L Robertson ---
I just took a look at it, and if I'm correct this is due to the fact that there
is no default constructor in IBluetoothSocket. boost::noncopyable defines a
default constructor. As a result, you mi
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #7 from Umang Jain ---
ok regarding the sd/ module, I am not able to make changes in:
sd/source/ui/remotecontrol/IBluetoothSocket.hxx : (line) struct
IBluetoothSocket : private boost::noncopyable
If I change with :
class No
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #6 from Daniel L Robertson ---
The only real difference between structs and classes is the default access.
class NonCopyable {
public:
NonCopyable(const NonCopyable&) = delete;
const NonCopyable& operator=(const NonCopyabl
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #5 from Umang Jain ---
There are some structures using boost noncopyable template, how to remove that
? Does it(i.e. structs) even required to be removed or just only the classes.
Like in :
core/undoanim.cxx:struct UndoAnimat
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #4 from Miklos Vajna ---
Let's say you pick "sd". Do your changes in "sd", then build the changed code
with "make sd.build", and iterate it till you're done with your changes and the
code builds. Then run "make check" to run al
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #3 from Umang Jain ---
ok. So correct me if I am wrong. Have to make changes module by module, then
run "make" for that particular module and examine if some error pops up ?
--
You are receiving this mail because:
You are on
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #2 from Noel Grandin ---
Umang, you should make changes in at most one module at a time.
Where a module is all of the code under a top-level directory like vcl/ or sd/
--
You are receiving this mail because:
You are on the CC
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
--- Comment #1 from Umang Jain ---
Hi, This is my first bug fix and I am a new contributor with very little
experience. I successfully build libreoffice and tried
git grep boost::noncopyable
git grep boost/noncopyable
I see that there h
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
Umang Jain changed:
What|Removed |Added
Assignee|libreoffice-b...@lists.free |mailumangj...@gmail.com
https://bugs.documentfoundation.org/show_bug.cgi?id=94306
Björn Michaelsen changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
CC|
24 matches
Mail list logo
