Re: [Libreoffice][PATCH] Prevent print settings dialog to show help button when it's called from help window

2012-06-25 Thread Maxime de Roucy
The patch 0003 introduce a bug : -if ( SID_PRINTER_NAME == nId ) -{ -// just set a recorded printer name -if ( pPrinter ) -SetPrinter( pPrinter, SFX_PRINTER_PRINTER ); -break; -} please wait be

[Libreoffice][PATCH] Prevent print settings dialog to show help button when it's called from help window

2012-06-19 Thread Maxime de Roucy
Hello, Here is some patchs : 0001 : one line, code simplification. 0002 : explicite NULL or 0 comparison in if. I don't know if LibreOffice have a coding standard about that type of comparison ? 0003 : some rewriting of SfxViewShell::ExecPrint_Impl ; add some comments, prevent a segfault (NULL poi