Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-07-05 Thread Caolán McNamara
On Sat, 2011-07-02 at 22:51 +0200, Chr. Rossmanith wrote: Attached you find the patch cleaning httprequest.{ch}xx from ByteString, tools/string.hxx has been replaced by rtl/string.hxx. Could someone please review the complete patch? looks good to me, push it. C.

Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-07-02 Thread Chr. Rossmanith
Hi, Caolan, thank you for your hints. Now I've finished httprequest.{hc}xx but have two commits for one cleanup because I've committed the partial cleanup some days ago. I know that git amend should be my friend in such a situation but the last time it wasn't. If someone could describe in

Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-07-02 Thread Andras Timar
Hi, 2011/7/2 Chr. Rossmanith chrrossman...@gmx.de: Hi, Caolan, thank you for your hints. Now I've finished httprequest.{hc}xx but have two commits for one cleanup because I've committed the partial cleanup some days ago. I know that git amend should be my friend in such a situation but the

Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-07-02 Thread Chr. Rossmanith
Hi, git addfiles you've just modified git commit --amend I hope this helps. Andras That's really easy - can't remember what went wrong the last time. Attached you find the patch cleaning httprequest.{ch}xx from ByteString, tools/string.hxx has been replaced by rtl/string.hxx. Could someone

Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-06-30 Thread Caolán McNamara
On Wed, 2011-06-29 at 23:00 +0200, Chr. Rossmanith wrote: Hi, I've started to replace ByteString with rtl::OString. You find what I did so far in the attached patches. It would be nice if someone could review the patches and give feedback. Then I'll continue and push. Patch 2 is good, we

Re: [Libreoffice] [PATCH][REVIEW] Replacing ByteString with rtl::OString

2011-06-29 Thread Chr. Rossmanith
Hi, I've started to replace ByteString with rtl::OString. You find what I did so far in the attached patches. It would be nice if someone could review the patches and give feedback. Then I'll continue and push. Christina From b090093772d7011b7508f32d749eca69e01adbd4 Mon Sep 17 00:00:00 2001