Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-22 Thread Noel Power
On 20/08/11 17:32, Lionel Elie Mamane wrote: I'd rather we fix*that* separate bug cleanly; after all, other exceptions may by thrown during a save. That commit is only in master (not libreoffice-3-4) anyway, so we have breathing space. it appears the exception here isn't really handled, I

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-20 Thread Lionel Elie Mamane
On Thu, Aug 18, 2011 at 12:52:55PM +0100, Noel Power wrote: On 17/08/11 19:02, Lionel Elie Mamane wrote: On Wed, Aug 17, 2011 at 09:48:04AM +0100, Noel Power wrote: On 16/08/11 17:32, Lionel Elie Mamane wrote: I notice that calc and writer have the good sense of displaying an error message

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-18 Thread Noel Power
Hi Lionel On 17/08/11 19:02, Lionel Elie Mamane wrote: On Wed, Aug 17, 2011 at 09:48:04AM +0100, Noel Power wrote: On 16/08/11 17:32, Lionel Elie Mamane wrote: I did now. Reproduced there, but someone (you?) pushed my patch so *now* one cannot reproduce it anymore. I also took the liberty of

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-18 Thread Noel Power
On 17/08/11 19:02, Lionel Elie Mamane wrote: Which leads me to another bug: If I remove the librarie's only dialog and save, I restart LO, I reopen the file again, the dialog is back. probably worth opening another bug for that then, anyway, lets look at one thing at a time ( otherwise I will

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-17 Thread Noel Power
Hi Lionel On 16/08/11 17:32, Lionel Elie Mamane wrote: Two questions, a) did you try this on master No, not yet. no problem ( I did and it appeared to work as expected ) but I am pretty 'base' disabled so I fear I may have missed something in trying to recreate it You have to be very

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-17 Thread Noel Power
On 16/08/11 17:32, Lionel Elie Mamane wrote: I disabled the export out any embedded image object code by adding a return; before it, and it does not loose the embedded images, even after restarting LO and re-opening the document. ( after refamiliarising myself with this code ) this behaviour is

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-16 Thread Noel Power
Hello Lionel On 15/08/11 13:10, Lionel Elie Mamane wrote: When the Standard Basic Macro Library for the document is loaded (which happens implicitly as soon as a macro is executed), but not the Standard Dialog Library, the File / Save action (or the equivalent toolbar button) does nothing,

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-16 Thread Noel Power
probably I should have read further before replying ;-) ( sorry excuse for a mind is elsewhere at the moment ) On 15/08/11 13:10, Lionel Elie Mamane wrote: So probably what happened is that the // Can we simply copy the storage? optimisation / fast path was added and suddenly

Re: [Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-16 Thread Lionel Elie Mamane
On Tue, Aug 16, 2011 at 09:41:43AM +0100, Noel Power wrote: On 15/08/11 13:10, Lionel Elie Mamane wrote: When the Standard Basic Macro Library for the document is loaded (which happens implicitly as soon as a macro is executed), but not the Standard Dialog Library, the File / Save action (or

[Libreoffice] [PATCH] Base fdo#40079 file / save (as) inoperant

2011-08-15 Thread Lionel Elie Mamane
When the Standard Basic Macro Library for the document is loaded (which happens implicitly as soon as a macro is executed), but not the Standard Dialog Library, the File / Save action (or the equivalent toolbar button) does nothing, without error message. The attached patch (against