Re: [Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

2012-01-02 Thread Stephan Bergmann
On 12/21/2011 05:23 PM, Norbert Thiebaud wrote: On Wed, Dec 21, 2011 at 9:58 AM, Eike Rathkeer...@redhat.com wrote: Still, there should be a way to have non-dbgutil and dbgutil builds (or builds with different switches, whatever) in parallel. So we'd need _some_ mechanism to differentiate

Re: [Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

2012-01-02 Thread Stephan Bergmann
On 12/20/2011 09:52 AM, Victor Lee wrote: 1) Statements setting $CPU=U (looks like it should be SPARC64) could not be found in set_soenv.in or related files, but $(CPU)==U is checked in some makefiles. I left those lines untouched in this patch. Historically, there was a SPARC64 port done at

Re: [Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

2011-12-21 Thread Eike Rathke
Hi, On Tuesday, 2011-12-20 17:46:22 -0600, Norbert Thiebaud wrote: IMHO (other might disagree), we should get rid of these opaque names in the long run anyway. INPATH and OUTPATH should only be build or host. Sure, but then stuff like rm -fr */$INPATH may end-up having unexpected

Re: [Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

2011-12-21 Thread Norbert Thiebaud
On Wed, Dec 21, 2011 at 9:58 AM, Eike Rathke er...@redhat.com wrote: Hi, On Tuesday, 2011-12-20 17:46:22 -0600, Norbert Thiebaud wrote: IMHO (other might disagree), we should get rid of these opaque names in the long run anyway. INPATH and OUTPATH should only be build or host. Sure,

Re: [Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

2011-12-20 Thread Norbert Thiebaud
On Tue, Dec 20, 2011 at 2:52 AM, Victor Lee konya@gmail.com wrote: First welcome to LibreOffice... This patch substituts $CPU to $CPUNAME in makfiles and has been successfully built on my Linux/x86 machine.  However, there are two questions remain: 1) Statements setting $CPU=U (looks

Re: [Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

2011-12-20 Thread Bjoern Michaelsen
On Tue, Dec 20, 2011 at 04:43:41AM -0600, Norbert Thiebaud wrote: a/ if ( @WITH_MOZILLA@ eq YES and @BUILD_MOZAB@ ne TRUE and @SYSTEM_MOZILLA@ ne YES ) { print(Checking for prebuilt Mozilla libraries ...); my $mozbinfile = $SRC_ROOT./moz/zipped/; - $mozbinfile .= $OS.$COM.$CPU;

Re: [Libreoffice] [PATCH] Fix fdo#42783 get rid of CPU define/build system variable

2011-12-20 Thread Norbert Thiebaud
On Tue, Dec 20, 2011 at 10:45 AM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: IMHO (other might disagree), we should get rid of these opaque names in the long run anyway. INPATH and OUTPATH should only be build or host. Sure, but then stuff like rm -fr */$INPATH may end-up having