[Libreoffice] [PATCH] Fix replacement of $filename$ in GTK SaveAs dialogs

2011-02-24 Thread Kevin Hunter
Hullo List, A patch that fixes a display issue with the GTK SaveAs dialog box that asks for confirmation before overwriting a file. For reference, OO fixes this by removing the string replacement altogether, while this patch keeps in line with the native-to-LO dialogs. As this is my first

Re: [Libreoffice] [PATCH] Fix replacement of $filename$ in GTK SaveAs dialogs

2011-02-24 Thread Caolán McNamara
On Thu, 2011-02-24 at 09:57 -0500, Kevin Hunter wrote: please do spit it back to me with, you should implement it this way instead OString baseName = OString(OUStringToOString( aFileObj.getName(INetURLObject::LAST_SEGMENT, true, INetURLObject::DECODE_WITH_CHARSET),

Re: [Libreoffice] [PATCH] Fix replacement of $filename$ in GTK SaveAs dialogs

2011-02-24 Thread Kevin Hunter
At 11:30am -0500 Thu, 24 Feb 2011, Caolán Mcnamara wrote: On Thu, 2011-02-24 at 09:57 -0500, Kevin Hunter wrote: please do spit it back to me with, you should implement it this way instead c) I wouldn't bother with the aFileObj.HasError() and return 0, i.e. I'd prefer to get some