Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Stephan Bergmann
On Sep 1, 2011, at 2:19 AM, Mohammad Elahi wrote: Changed function lcl_formatPersianWord to be more generic, and added support for some more numbering types: English word: one, two, three, ... English cardinal: first, second, third, ... English cardinal semi-word: 1st, 2nd, 3rd, ... Persian

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Mohammad Elahi
Hi Stephan First, I think extending this from Persian to English already shows the biggest flaw of this approach: Do you want to extend in in this way for all languages supported by LibO? Yes, I was trying to make it more generic so can be used by more languages. But maybe I should not, I

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Stephan Bergmann
On Sep 1, 2011, at 11:00 AM, Mohammad Elahi wrote: Here, however, someone doing localization would need to add new constants to NumberingType.idl and would need to add code to defaultnumberingprovider.cxx. That does not feel right. OK, I'm just started to work with libreoffice code ;) Just

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Eike Rathke
Hi, On Thursday, 2011-09-01 09:35:09 +0200, Stephan Bergmann wrote: First, I think extending this from Persian to English already shows the biggest flaw of this approach: Do you want to extend in in this way for all languages supported by LibO? I would consider such extension to additional

[Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Mohammad Elahi
Hi Eike String resources wouldn't be sufficient as different locales have different rules for how to form a number string, especially when it comes to ordinals. However, this looks more like spell-out than level numbering and as such misses the point of the numbering provider. If we wanted to

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Stephan Bergmann
On Sep 1, 2011, at 1:01 PM, Eike Rathke wrote: On Thursday, 2011-09-01 09:35:09 +0200, Stephan Bergmann wrote: First, I think extending this from Persian to English already shows the biggest flaw of this approach: Do you want to extend in in this way for all languages supported by LibO? I

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Eike Rathke
Hi Mohammad, On Thursday, 2011-09-01 16:04:53 +0430, Mohammad Elahi wrote: However, this looks more like spell-out than level numbering and as such misses the point of the numbering provider. If we wanted to implement spell-out I'd rather go for ICU's methods than implementing yet

Re: [Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-09-01 Thread Mohammad Elahi
Hi Eike I thought the persian word numbers were meant to be used in numbering, isn't that the case? Well, I wanted to use it for a few page numbers in start of my document. Instead of roman numbers which is customary in some English books. Please don't confuse numbering used for paragraphs

[Libreoffice] [PATCH] More numbering types: one, two, three, ...

2011-08-31 Thread Mohammad Elahi
Hi Changed function lcl_formatPersianWord to be more generic, and added support for some more numbering types: English word: one, two, three, ... English cardinal: first, second, third, ... English cardinal semi-word: 1st, 2nd, 3rd, ... Persian cardinal word. I used C++ macros, but do not know