Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-04 Thread Stephan Bergmann
On 10/03/2011 04:48 PM, Chr. Rossmanith wrote: One improvement suggested by Norbert on IRC: using OUString instead of ::rtl::OUString. What is the preferred syntax using ::rtl::OUString at the beginning of the file and OUString throughout the remaining source code or ::rtl::OUString

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-03 Thread Michael Meeks
Hi Christina, On Sun, 2011-10-02 at 20:52 +0200, Chr. Rossmanith wrote: could someone please review this small patch. I'll extend the replacement (and push on my own) but want to be sure that there are no mistakes. At least it seems to build :-) Looks great to me :-)

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-03 Thread Caolán McNamara
On Mon, 2011-10-03 at 10:07 +0100, Michael Meeks wrote: Hi Christina, On Sun, 2011-10-02 at 20:52 +0200, Chr. Rossmanith wrote: could someone please review this small patch. I'll extend the replacement (and push on my own) but want to be sure that there are no mistakes. At least it

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-03 Thread Chr. Rossmanith
One improvement suggested by Norbert on IRC: using OUString instead of ::rtl::OUString. What is the preferred syntax using ::rtl::OUString at the beginning of the file and OUString throughout the remaining source code or ::rtl::OUString everywhere in the source code. Christina Am

Re: [Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-03 Thread Norbert Thiebaud
On Mon, Oct 3, 2011 at 9:48 AM, Chr. Rossmanith chrrossman...@gmx.de wrote: One improvement suggested by Norbert on IRC: using OUString instead of ::rtl::OUString. What is the preferred syntax Note: I don't know what is the 'preferred' way, I just noticed that there was a mix of the 2 notations

[Libreoffice] [PATCH] Replace (Byte)String with O(U)String in sw

2011-10-02 Thread Chr. Rossmanith
Hi, could someone please review this small patch. I'll extend the replacement (and push on my own) but want to be sure that there are no mistakes. At least it seems to build :-) Thank you, Christina From 4598efcf63b30b673794c8d8aaf99797ada3117c Mon Sep 17 00:00:00 2001 From: Christina