Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-23 Thread Muthu Subramanian K
Hello Marcel, Thank you for the nice patch. Before pushing, it would be great to understand the reason behind replacing the macro with regular code. I believe the macro would help in improving code readability (and of course the code size) - in my understanding. Any particular reason, please?

Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-23 Thread Marcel Metz
Hello Muthu, On 23.01.2012 09:19, Muthu Subramanian K wrote: Before pushing, it would be great to understand the reason behind replacing the macro with regular code. Sure thing. The reason why I replaced the ENSURE_OR_* macros with regular code was the replacement of the OSL_ENSURE macro with

Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-23 Thread Muthu Subramanian K
Hi, I am somehow not yet convinced. I would want to wait for a second opinion. Thanks! Muthu Subramanian On 01/23/2012 03:38 PM, Marcel Metz wrote: Hello Muthu, On 23.01.2012 09:19, Muthu Subramanian K wrote: Before pushing, it would be great to understand the reason behind replacing the

[Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-22 Thread Marcel Metz
Hello lo-devs, the attached patches replace some of the ENSURE_OR_* macros, with regular code. I can't see any advantage in these macros aside from save some typing. regards Marcel Metz From 1d0aeb0f7266646da553ea7d120afcc9065118e5 Mon Sep 17 00:00:00 2001 Message-Id: