Hello all, This patch fixes building on windows / cygwin.
IMHO, the problem is caused by part of the commit [1] Seems msvc doesn't allow us to have SAL_DLLPUBLIC_EXPORT in both class and functions definition. It throws compiler error C2487 [2] So, I tried to fix with 2 methods: 1. Remove dll interface from functions definition, now the whole class has dll interface 2. Remove dll interface from class definition, and only some functions has dll interface which I attached both patches. Anyway, since both methods build and program started fine, I don't know which one is better / more correct. And the manual test shouldn't work, since we don't have any new version to check for update, right? [1] http://cgit.freedesktop.org/libreoffice/core/diff/extensions/source/update/check/updatecheck.hxx?id=9d79b12871522cb9daebf4f6c850e07edcdce08a [2] http://msdn.microsoft.com/en-us/library/t72ahzw1%28v=VS.90%29.aspx Please feel free to comment :-) Best Regards, -- Korrawit Pruegsanusak
update-1.patch
Description: Binary data
update-2.patch
Description: Binary data
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
