Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-23 Thread Caolán McNamara
On Tue, 2012-01-17 at 11:40 -0800, julien2412 wrote: There was an extra semicolon after the while on the patch. Even if i re read several times the code, I just missed it too and needed gdb to see it ! Now it works better :-) *groan*, that was dumb of me. Do you want to commit/push it

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-17 Thread julien2412
There was an extra semicolon after the while on the patch. Even if i re read several times the code, I just missed it too and needed gdb to see it ! Now it works better :-) Do you want to commit/push it yourself on master or do you want me to do it (of course I put you as the author) ? Would it

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread Caolán McNamara
On Sat, 2012-01-14 at 11:17 -0800, julien2412 wrote: Hello, I propose the attached patch for fdo#44040 (see https://bugs.freedesktop.org/attachment.cgi?id=55580) Since I could have missed something, I would like your opinion about this. Does this work ? I worry (maybe I'm out of date on

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread Stephan Bergmann
On 01/16/2012 06:12 PM, Caolán McNamara wrote: Does this work ? I worry (maybe I'm out of date on this one?) that std::map::erase only returns an iterator in C++11x not C++98 which we still support. Its a C++11 extension. Stephan ___ LibreOffice

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread julien2412
You're right Caolan, I checked there : http://en.cppreference.com/w/cpp/container/map/erase I didn't know that it was a recent feature, just thought it was useful, so I didn't think about checking it existed :-) I'm trying right now to find a solution another way. Julien PS : I use gcc (Debian

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread Caolán McNamara
On Mon, 2012-01-16 at 12:33 -0800, julien2412 wrote: You're right Caolan, I checked there : http://en.cppreference.com/w/cpp/container/map/erase I didn't know that it was a recent feature, just thought it was useful, so I didn't think about checking it existed :-) I'm trying right now to

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-16 Thread julien2412
I just finished to compile. There's no errors in console but when I clicked on Preview, I've got no response as if there was a infinite loop (I've just waited 20 seconds not minutes so perhaps I'm wrong :-)). I must go to my job so I don't have time for the moment to gdb this part. Julien. --

[Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-14 Thread julien2412
Hello, I propose the attached patch for fdo#44040 (see https://bugs.freedesktop.org/attachment.cgi?id=55580) Since I could have missed something, I would like your opinion about this. Julien (I can commit and push it on master if it's ok) -- View this message in context: