On Wed, 2011-09-21 at 21:13 +0400, Ivan Timofeev wrote:
2011/9/21 Caolán McNamara caol...@redhat.com
Did I just break this, or were they always so broken ?
No, I had tested on OOo 3.3 just now - same devilry.
Ah good :-)
And do you want to fix it ? :-)
Yeah, I want. But since I'm
On Tue, 2011-09-20 at 22:10 +0400, Ivan Timofeev wrote:
2011/9/20 Caolán McNamara caol...@redhat.com:
Hmm, if in normal mode I type in 3-4 I get that range previewed, change
it to foobar and it stays previewing 3-4, which isn't great either
really.
In normal layout in Writer and in any
2011/9/21 Caolán McNamara caol...@redhat.com:
So I reckon we might be better off modifying
StringRangeEnumerator::getRangesFromString to always clear its page
vector argument, and then its probably worth being more forgiving and
output what valid ranges in the text can be extracted before the
On Wed, 2011-09-21 at 14:53 +0400, Ivan Timofeev wrote:
Ok! Problems with incorrect pasting eliminated. But one problem still
exists...
If in brochure mode we input range, that is incorrect at all (e.g.
foo) or starts with illegal characters (e.g. foo1-4), previous
range will be lost.
Isn't
2011/9/21 Caolán McNamara caol...@redhat.com:
Isn't it a good thing that the previous range isn't the one selected
anymore when an invalid range has been entered ?
Maybe it is. But other apps have different behavior on processing invalid
range.
See results of my small test (in normal mode)
On Wed, 2011-09-21 at 16:56 +0400, Ivan Timofeev wrote:
See results of my small test (in normal mode) for docs with 20 pages:
Range DrawImpress CalcWriter
emptyNo pages (!) 1-201-20
1-51-51-5 1-5
q1-5 1-5 (!)
2011/9/21 Caolán McNamara caol...@redhat.com
Did I just break this, or were they always so broken ?
No, I had tested on OOo 3.3 just now - same devilry.
And do you want to fix it ? :-)
Yeah, I want. But since I'm newbie to source code, I'm working slowly.
However, if this is not
On Sat, 2011-09-17 at 03:33 -0700, Ivan Timofeev wrote:
This patch fixes crash when you input incorrect range of pages in Print
dialog, General tab, Pages textfield and layout is set to Brochure.
http://nabble.documentfoundation.org/file/n3344034/Fix-for-fdo-35513.patch
I'm glad to see my patches in master! :-) Thanks!
2011/9/20 Caolán McNamara caol...@redhat.com:
I don't *think* we need to move the code around, the check for empty is
sufficient so I shrank it down to that bit.
Hmm, when in brochure layout, try to input incorrect range and you
will see No
I think this lines should (?) be moved below the newly introduced check.
*This* lines:
rPagePairs.clear();
rValidPagesSet.clear();
rValidStartFrms.clear();
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On Tue, 2011-09-20 at 14:25 +0400, Ivan Timofeev wrote:
I'm glad to see my patches in master! :-) Thanks!
2011/9/20 Caolán McNamara caol...@redhat.com:
I don't *think* we need to move the code around, the check for empty is
sufficient so I shrank it down to that bit.
Hmm, when in
2011/9/20 Caolán McNamara caol...@redhat.com:
Hmm, if in normal mode I type in 3-4 I get that range previewed, change
it to foobar and it stays previewing 3-4, which isn't great either
really.
In normal layout in Writer and in any modes in other apps, i.e.
brochure layout in Writer is the only
12 matches
Mail list logo
