Hello Jonas, Michael, list,
Sorry for not replying sooner.
On Tue, 2011-02-01 at 19:32 +0100, Jonas Finnemann Jensen wrote:
I don't think it's critial... None of the commits that removes
brackets and improves SmNodeToTextVisitor have been applied to
libreoffice-3-3... The SmNodeToTextVisitor
I don't think it's critial... None of the commits that removes brackets and
improves SmNodeToTextVisitor have been applied to libreoffice-3-3... The
SmNodeToTextVisitor there uses a lot of brackets, so there's hopefully no
major issues with it...
In fact I've kept all the changes to the visual
Hi Luke,
Really sorry for not giving this any attention for so long.
No worry... I've been busy with exams for the most of January...
Though, I hope I had a break through with the newline-? bug, yesterday...
Removing the brackets from the SmOperNodes was a pretty bad, so they can
just go
Hi Jonas,
I'm very sorry for not responding very quickly. And I'm very sorry for
sending pretty much the same message twice, I forgot to CC the list.
That's not all true... I added all the brackets initially because I
had some problems with a few isolated things...
Try writing binom a b + c
Hi Luke,
Yep, I'm very sorry for breaking things.
I'm not sure you broke this... I'm not even sure it ever worked properly...
I've attached a patch for this particular problem (with a test).
Nice, I've pushed it... Really great idea to have tests for it too :)
I've noticed other stuff I've
On Wed, 2010-11-24 at 20:34 +, Caolán McNamara wrote:
I've been struggling a little bit with converting tests from
testautomation/math/required/includes/m_002_.inc e.g. tmEditMarker into
a build-time cppunit test
Figured this out now. Can test SmEditWindow standalone now.
C.
Hi Luke,
Just, pushed the two patches... Sorry, that it took a while to get
back to you...
By the way, is the SmNodeToTextVisitor as good as it gets now?
Or is it possible to do more improvements ? and if so, should we leave
as an easy hack we or someone can pickup later? (if not lets remove it
Hi Luke,
Nice work! I didn't know there was bugs in SmNodeToTextVisitor, but
somehow it doesn't surprise me...
The format is slightly obscure and the visitor was in need of some love...
By the way, I really like to unit tests... That is a brilliant idea,
unit tests are perfect for this kind of
Hello Jonas,
Thanks for accepting these patches.
Nice work! I didn't know there was bugs in SmNodeToTextVisitor, but
somehow it doesn't surprise me...
The format is slightly obscure and the visitor was in need of some love...
Sometimes the smallest bugs are the hardest to believe. There are
On Wed, 2010-11-24 at 17:25 +, Luke Dixon wrote:
Ever since I saw that other test added there a couple of weeks ago, I've
been feeling guilty about it and kept wondering if it was put there as a
hint.
Heh, success, build it and they will come :-) Thanks a lot for adding
extra tests into
10 matches
Mail list logo
