On 21/04/11 21:34, Markus Mohrhard wrote:
Hello,
here a short patch that reworks the
ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
I see Kohei has pushed it :-)
P.S. Noel did you push the last patch?
yes ( done now ), thanks for reminding me :-)
thanks again
Noel
On Thu, 2011-04-21 at 22:34 +0200, Markus Mohrhard wrote:
Hello,
here a short patch that reworks the
ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
Hi Markus,
Just a minor thing. In ScVbaWorksheet::setAutoFilterMode(), you do
+if (bAutoFilterMode pDoc)
but you've
Hello Kohei,
yes you're right. This part was copied from another method and I didn't
notice it. But I don't think that you must check for ScDocShell, because the
whole class is build without any check for it.
Should I send a reworked patch? There are just the two occurences of this
check. Only
Hi Markus,
On Fri, 2011-04-22 at 19:29 +0200, Markus Mohrhard wrote:
Hello Kohei,
yes you're right. This part was copied from another method and I
didn't notice it. But I don't think that you must check for
ScDocShell, because the whole class is build without any check for it.
Agreed. The
Hello,
here a short patch that reworks the
ScVbaWorksheet::getAutoFilterMode/setAutoFilterMode methods.
It now works with the new sheet local DB ranges, which are no longer
available through UNO API. Additionally I changed those methods that they my
no longer manipulate named DB ranges because
