Re: [Libreoffice] [REVIEW] patch for fdo#38455

2011-06-21 Thread Markus Mohrhard
Hello, after I talked to Michael on IRC we agreed that the following patch is much better. http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4defbffb7654402cf6bbd4b8c3cb0d897ce88126 It fixes an additional potential crash. Regards, Markus 2011/6/20 Michael Meeks michael.me...@novell.com

Re: [Libreoffice] [REVIEW] patch for fdo#38455

2011-06-21 Thread Petr Mladek
Michael Meeks píše v Po 20. 06. 2011 v 21:06 +0100: On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote: The rest of that method seems to assume in several places that pActiveViewSh can be NULL and checks for that: Markus is committing an updated patch to master, that I'd love

Re: [Libreoffice] [REVIEW] patch for fdo#38455

2011-06-21 Thread Noel Power
On 21/06/11 09:08, Petr Mladek wrote: Michael Meeks píše v Po 20. 06. 2011 v 21:06 +0100: On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote: The rest of that method seems to assume in several places that pActiveViewSh can be NULL and checks for that: Markus is committing

[Libreoffice] [REVIEW] patch for fdo#38455

2011-06-20 Thread Markus Mohrhard
Hello, I have here a quick patch for fdo#38455. Calc crahs if you go to Data-Define range and type some text to a cell because pActiveViewSh isn't set in the InputHandler. http://cgit.freedesktop.org/libreoffice/calc/commit/?id=165ccab687d976d06afa0b02582065045132ee6d This fix only checks that

Re: [Libreoffice] [REVIEW] patch for fdo#38455

2011-06-20 Thread Michael Meeks
Hi Markus, On Mon, 2011-06-20 at 21:04 +0200, Markus Mohrhard wrote: I have here a quick patch for fdo#38455. Calc crahs if you go to Data-Define range and type some text to a cell because pActiveViewSh isn't set in the InputHandler. Hokay ? This fix only checks that pActiveViewSh

Re: [Libreoffice] [REVIEW] patch for fdo#38455

2011-06-20 Thread Michael Meeks
On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote: The rest of that method seems to assume in several places that pActiveViewSh can be NULL and checks for that: Markus is committing an updated patch to master, that I'd love to see on -3-4 and also in -3-4-1 it potentially