Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-26 Thread Stephan Bergmann
On 09/25/2011 01:48 PM, Mathias Bauer wrote: The differentiation between hard and soft refererences would require a solid understanding of the relationships of all objects. With this understanding you could most probably fix the existing code without refcounting also: a weak reference always

Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-26 Thread Bjoern Michaelsen
On Sun, 25 Sep 2011 13:48:26 +0200 Mathias Bauer nospamfor...@gmx.de wrote: The biggest part of the work is getting the right picture: which objects control the life time of others and which just need to know if some other objects are present or not. ^- That is the hard part. And the one with

Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-25 Thread Mathias Bauer
Am 24.09.2011 09:57, schrieb Michael Meeks: On Sat, 2011-09-24 at 00:36 +0200, Mathias Bauer wrote: Really, the layout is a complete mess, at least from an architectural POV. There is no clear relationship and ownership between objects. That might work better in a world with garbage

Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-24 Thread Michael Meeks
On Sat, 2011-09-24 at 00:36 +0200, Mathias Bauer wrote: Really, the layout is a complete mess, at least from an architectural POV. There is no clear relationship and ownership between objects. That might work better in a world with garbage collection, but in the ugly world of pointers this is

Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-23 Thread Mathias Bauer
Am 22.09.2011 19:12, schrieb Michael Stahl: On 22.09.2011 18:51, Bjoern Michaelsen wrote: Hi Cedric, Hi Caolan, could you please review: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac1912ecb13709082026428d2b2a56c4915b939f for backporting to -3-4? It kills the footnotes

[Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-22 Thread Bjoern Michaelsen
Hi Cedric, Hi Caolan, could you please review: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac1912ecb13709082026428d2b2a56c4915b939f for backporting to -3-4? It kills the footnotes before killing the rest of the layout saving us from the trouble later. It seems to fix the problem

Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-22 Thread Michael Stahl
On 22.09.2011 18:51, Bjoern Michaelsen wrote: Hi Cedric, Hi Caolan, could you please review: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac1912ecb13709082026428d2b2a56c4915b939f for backporting to -3-4? It kills the footnotes before killing the rest of the layout saving us

Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2011-09-22 Thread Bjoern Michaelsen
On Thu, 22 Sep 2011 19:12:38 +0200 Michael Stahl m...@openoffice.org wrote: is this the kind of crash that was introduced by mba's layout refactoring (moving the layout from the model to the view) that went into one of the last DEV300 milestones? Likely. i think the workaround for OOo 3.4