Re: [Libreoffice] I need some advice to fix fdo#40363

2011-12-01 Thread Eike Rathke
Hi Michael, On Wednesday, 2011-11-30 18:45:31 +0100, Michael Stahl wrote: On 30/11/11 12:10, Eike Rathke wrote: Also fixed the misrepresentation of years1000 with less than 4 digits we did that? oops. i didn't know that... Yup.. which made we wonder why we have two implementations for

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-12-01 Thread Michael Stahl
On 01/12/11 20:04, Eike Rathke wrote: Hi Michael, On Wednesday, 2011-11-30 18:45:31 +0100, Michael Stahl wrote: On 30/11/11 12:10, Eike Rathke wrote: Also fixed the misrepresentation of years1000 with less than 4 digits we did that? oops. i didn't know that... Yup.. which made we

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-12-01 Thread Eike Rathke
Hi Michael, On Thursday, 2011-12-01 21:12:48 +0100, Michael Stahl wrote: I don't insist on keeping the ^+ thing in, maybe it's better to remove that part and check for W3C compliance. I'm unbiased there. hmm... even ODF 1.0 referred to XMLSchema; i've taken a quick look at the OOoXML

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-30 Thread Eike Rathke
Hi Jean-Baptiste, On Tuesday, 2011-11-29 00:35:46 +0100, Eike Rathke wrote: I do not understand why every dates before 1582-10-15 should not be valid when only dates from 1582-10-05 to 1582-10-14 do not exist due to the switch from julian calendar to gregorian calendar. Well, the Date

[Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Jean-Baptiste Faure
Hi all, The bug described in fdo#40363 may occur if you make a typo when type some dates in Calc. For example 1011-11-28 instead of 2011-11-28. In such a case, chart2 loops infinitely in master and LibO 3.4. The loop occurs in GetDateSomeYearsAway method in DateHelper.cxx :

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Kohei Yoshida
On Mon, 2011-11-28 at 13:43 +0100, Jean-Baptiste Faure wrote: Now, my question is what to do? Is it a good idea to modify Date::IsValid in tdate.cxx without knowing why it works in LibO 3.3 ? I can sense that you already know the answer to this question. :-) But I wouldn't modify IsValid()

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Regina Henschel
Hi Kohei, Kohei Yoshida schrieb: [..] My conclusion? No idea what advice I should give you to get it fixed just yet. Maybe someone else knows the work that Oracle has done to the chart2 module after 3.3 give us some background? From the release notes [1] I guess, that it is the feature to

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Kohei Yoshida
On Mon, 2011-11-28 at 21:56 +0100, Regina Henschel wrote: Hi Kohei, Kohei Yoshida schrieb: [..] My conclusion? No idea what advice I should give you to get it fixed just yet. Maybe someone else knows the work that Oracle has done to the chart2 module after 3.3 give us some

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Regina Henschel
Hi Kohei, Kohei Yoshida schrieb: On Mon, 2011-11-28 at 21:56 +0100, Regina Henschel wrote: Hi Kohei, Kohei Yoshida schrieb: [..] My conclusion? No idea what advice I should give you to get it fixed just yet. Maybe someone else knows the work that Oracle has done to the chart2 module after

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Eike Rathke
Hi Jean-Baptiste, On Monday, 2011-11-28 13:43:51 +0100, Jean-Baptiste Faure wrote: The bug described in fdo#40363 may occur if you make a typo when type some dates in Calc. Thanks for investigating, I'll dig into that. If I modify Date::IsValid so that only dates strictly between 1582-10-05

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Jean-Baptiste Faure
Hi Eike, Le 29/11/2011 00:35, Eike Rathke a écrit : Hi Jean-Baptiste, On Monday, 2011-11-28 13:43:51 +0100, Jean-Baptiste Faure wrote: The bug described in fdo#40363 may occur if you make a typo when type some dates in Calc. Thanks for investigating, I'll dig into that. Thank you.

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Jean-Baptiste Faure
Hi Regina, Kohei, Le 28/11/2011 22:00, Regina Henschel a écrit : Hi Kohei, Kohei Yoshida schrieb: [..] My conclusion? No idea what advice I should give you to get it fixed just yet. Maybe someone else knows the work that Oracle has done to the chart2 module after 3.3 give us some