Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-14 Thread Kohei Yoshida
On Tue, 2010-12-14 at 15:52 +, Michael Meeks wrote: > Hi there, > > On Mon, 2010-12-13 at 16:28 -0500, Kohei Yoshida wrote: > > I'd like to port a patch to the libreoffice-3-3 branch to ignore > > preceding and trailing spaces in cells during csv import. > > I just wrote a set of unit t

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-14 Thread Michael Meeks
Hi there, On Mon, 2010-12-13 at 16:28 -0500, Kohei Yoshida wrote: > I'd like to port a patch to the libreoffice-3-3 branch to ignore > preceding and trailing spaces in cells during csv import. I just wrote a set of unit tests for this; in sc/qa/unit/ something like: struct {

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-14 Thread Kohei Yoshida
On Tue, 2010-12-14 at 07:43 -0600, Norbert Thiebaud wrote: > On Tue, Dec 14, 2010 at 7:18 AM, Kohei Yoshida wrote: > > Hi Takeshi, > > > > On Tue, 2010-12-14 at 18:36 +0900, Takeshi Abe wrote: > >> Hi Kohei, > >> > >> On Mon, 13 Dec 2010 16:28:34 -0500, Kohei Yoshida > >> wrote: > >> > I'd like

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-14 Thread Norbert Thiebaud
On Tue, Dec 14, 2010 at 7:18 AM, Kohei Yoshida wrote: > Hi Takeshi, > > On Tue, 2010-12-14 at 18:36 +0900, Takeshi Abe wrote: >> Hi Kohei, >> >> On Mon, 13 Dec 2010 16:28:34 -0500, Kohei Yoshida >> wrote: >> > I'd like to port a patch to the libreoffice-3-3 branch to ignore >> > preceding and tr

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-14 Thread Kohei Yoshida
On Tue, 2010-12-14 at 15:19 +0530, Muthu Subramanian K wrote: > Hi Kohei, > > Is there a specific reason why functions like: > rStr.EraseLeadingAndTrailingChars() weren't used on the string? > [ then something like n=rStr.getLength() if(!n) return false; ] If we do that we'd be parsing the same c

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-14 Thread Kohei Yoshida
Hi Takeshi, On Tue, 2010-12-14 at 18:36 +0900, Takeshi Abe wrote: > Hi Kohei, > > On Mon, 13 Dec 2010 16:28:34 -0500, Kohei Yoshida wrote: > > I'd like to port a patch to the libreoffice-3-3 branch to ignore > > preceding and trailing spaces in cells during csv import. The change is > > already

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-14 Thread Muthu Subramanian K
Hi Kohei, Is there a specific reason why functions like: rStr.EraseLeadingAndTrailingChars() weren't used on the string? [ then something like n=rStr.getLength() if(!n) return false; ] Regards, Muthu Subramanian On Mon, 2010-12-13 at 16:28 -0500, Kohei Yoshida wrote: > Hi there, > > I'd like to

Re: [Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-14 Thread Takeshi Abe
Hi Kohei, On Mon, 13 Dec 2010 16:28:34 -0500, Kohei Yoshida wrote: > I'd like to port a patch to the libreoffice-3-3 branch to ignore > preceding and trailing spaces in cells during csv import. The change is > already committed on master, and the attached is the total difference > against the cu

[Libreoffice] Patch for ignoring preceding and trailing spaces in cell during csv import

2010-12-13 Thread Kohei Yoshida
Hi there, I'd like to port a patch to the libreoffice-3-3 branch to ignore preceding and trailing spaces in cells during csv import. The change is already committed on master, and the attached is the total difference against the current libreoffice-3-3 branch. The change on master consists of se