Re: [Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-10-05 Thread Stephan Bergmann
On 09/27/2011 09:00 PM, Stephan Bergmann wrote: Hi all, As has recently been discussed on #libreoffice-dev, its probably a good idea to remove the rather unhelpful conversion operators rtl::OString::operator sal_Char const * () rtl::OStringBuffer::operator sal_Char const * ()

[Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-09-27 Thread Stephan Bergmann
Hi all, As has recently been discussed on #libreoffice-dev, its probably a good idea to remove the rather unhelpful conversion operators rtl::OString::operator sal_Char const * () rtl::OStringBuffer::operator sal_Char const * () rtl::OUString::operator sal_Unicode const * ()

Re: [Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-09-27 Thread Caolán McNamara
On Tue, 2011-09-27 at 21:00 +0200, Stephan Bergmann wrote: introduce the operator [] replacements. Any reason, we make operator[] const ?, i.e. unassignable. plenty of code out there using operator[] to get a given index, and setCharAt to set it, which is kind of clumsy. C.

Re: [Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 09:07 PM, Caolán McNamara wrote: On Tue, 2011-09-27 at 21:00 +0200, Stephan Bergmann wrote: introduce the operator [] replacements. Any reason, we make operator[] const ?, i.e. unassignable. plenty of code out there using operator[] to get a given index, and setCharAt to set it,

Re: [Libreoffice] Removal of rtl::O[U]String[Buffer]::operator sal_{char|Unicode} const *()

2011-09-27 Thread Stephan Bergmann
On 09/27/2011 09:21 PM, Stephan Bergmann wrote: (Note that my commits just broke various tinderboxes due to some GCCs apparently complaining about alleged ambiguities in a+=b when a is a tools String and b an rtl::OUString; fixing it right now.) Hopefully fixed now with