Re: [Libreoffice] Request for review: bug 32427

2010-12-29 Thread Jan Holesovsky
Hi Norbert, all, On 2010-12-21 at 10:18 +0100, Jan Holesovsky wrote: Good point - actually, the easiest / best might be to enclose the entire call into '(' and ')', and add '' to that? Ie. it'd result into '( firefox something ) '. Any objections? Updated patch attached to

Re: [Libreoffice] Request for review: bug 32427

2010-12-21 Thread Jan Holesovsky
Hi Norbert, On 2010-12-21 at 03:01 -0600, Norbert Thiebaud wrote: but maybe you should check if there is not a '' already on the command line (a caller of this function may already have a '' appended to his command line and may have used the 'magic number 42' as a flags that prevented the

[Libreoffice] Request for review: bug 32427

2010-12-20 Thread Jan Holesovsky
Hi, Can you please review the patch from https://bugs.freedesktop.org/show_bug.cgi?id=32427 and apply if OK? When Firefox is not running, and an URL is launched from LibreOffice, it blocks until Firefox is closed again. Apparently the conditions to see it must be a bit special, but still, I