Re: [Libreoffice] comprehensive binfilter tests?

2011-10-21 Thread Caolán McNamara
On Wed, 2011-09-28 at 21:58 +0200, Andras Timar wrote: In rsc/doku/feinkonz.43 there are 3 sdw files, LibreOffice 3.4.x crashes on all of them under Linux/Windows. I did not try master. 3.3 is OK. master crashes for me alright,

Re: [Libreoffice] comprehensive binfilter tests?

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 02:38 PM, Caolán McNamara wrote: On Wed, 2011-09-28 at 21:58 +0200, Andras Timar wrote: In rsc/doku/feinkonz.43 there are 3 sdw files, LibreOffice 3.4.x crashes on all of them under Linux/Windows. I did not try master. 3.3 is OK. master crashes for me alright,

Re: [Libreoffice] comprehensive binfilter tests?

2011-09-28 Thread Andras Timar
2011/9/26 Caolán McNamara caol...@redhat.com: On Mon, 2011-09-26 at 10:23 +0200, Stephan Bergmann wrote: With the apparently somewhat semi-automatic code clean-up/removal in binfilter (removing dead code, noticing compiler warnings about thus newly unused variables, thus removing more dead

Re: [Libreoffice] comprehensive binfilter tests?

2011-09-27 Thread Stephan Bergmann
On 09/26/2011 09:58 PM, Michael Meeks wrote: (And the cost of analysing the regressions, if they are eventually found, will also be rather high, given the aggressive pruning of allegedly dead code in the meantime). Surely git bisect is pretty impervious to the size or number of changes

[Libreoffice] comprehensive binfilter tests?

2011-09-26 Thread Stephan Bergmann
With the apparently somewhat semi-automatic code clean-up/removal in binfilter (removing dead code, noticing compiler warnings about thus newly unused variables, thus removing more dead code, ...), I wonder whether this does not introduce regressions. Do we have some comprehensive test suite

Re: [Libreoffice] comprehensive binfilter tests?

2011-09-26 Thread Michael Meeks
On Mon, 2011-09-26 at 10:23 +0200, Stephan Bergmann wrote: With the apparently somewhat semi-automatic code clean-up/removal in binfilter (removing dead code, noticing compiler warnings about thus newly unused variables, thus removing more dead code, ...), I wonder whether this does not

Re: [Libreoffice] comprehensive binfilter tests?

2011-09-26 Thread Caolán McNamara
On Mon, 2011-09-26 at 10:23 +0200, Stephan Bergmann wrote: With the apparently somewhat semi-automatic code clean-up/removal in binfilter (removing dead code, noticing compiler warnings about thus newly unused variables, thus removing more dead code, ...), I wonder whether this does not

Re: [Libreoffice] comprehensive binfilter tests?

2011-09-26 Thread Stephan Bergmann
On 09/26/2011 11:45 AM, Michael Meeks wrote: On Mon, 2011-09-26 at 10:23 +0200, Stephan Bergmann wrote: With the apparently somewhat semi-automatic code clean-up/removal in binfilter (removing dead code, noticing compiler warnings about thus newly unused variables, thus removing more dead code,

Re: [Libreoffice] comprehensive binfilter tests?

2011-09-26 Thread Michael Meeks
On Mon, 2011-09-26 at 20:37 +0200, Stephan Bergmann wrote: So the chance of regressions remaining undetected for quite a while is IMO higher here than for other typical code changes. Made more so by the fact that almost no-one uses the filter ;-) (And the cost of analysing the