Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

2011-12-23 Thread Ivan Timofeev
Having fresh look into this problem, I think we should come to nothing more than: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=746cde4adb386e26ec3368198b4d893db16ee2cc I realize that it's a dirty hack and you can blame me for negligence here, but if we want to follo

Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

2011-12-14 Thread Ivan Timofeev
14.12.2011 17:01, Michael Meeks пишет: On Wed, 2011-12-14 at 15:32 +0400, Ivan Timofeev wrote: If I understood you right, the MENU_FLAG_SHOWCHECKIMAGES flag was introduced to control whether a simple check mark [x] or an image should be painted with a checkable menu item; if it is so, it don't w

Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

2011-12-14 Thread Michael Meeks
Hi Ivan, On Wed, 2011-12-14 at 15:32 +0400, Ivan Timofeev wrote: > I see no feature here... When icons in menus are disabled - there is no > problem, but when they are enabled - nothing is painted at the left of a > checkable menu item, neither a check mark [x] nor an image (see the > attached

Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

2011-12-13 Thread Pedro
Michael Meeks-2 wrote > > That - is/was a feature. In the gtk+ world when a menu item is a radio > or option button, it has a [ ] or [x] checked - which is in the same > column as an icon would be for a normal item. > > In various other toolkits and suites things can be done differen

Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

2011-12-13 Thread Michael Meeks
Hi Ivan, On Mon, 2011-12-12 at 23:54 +0400, Ivan Timofeev wrote: > the bug: https://bugs.freedesktop.org/show_bug.cgi?id=41264 > > briefly: in the context menus (except the toolbar's ones) icons are not > shown for radio menu items and for checked menu items. That - is/was a feature. In

[Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

2011-12-12 Thread Ivan Timofeev
Hi all, the bug: https://bugs.freedesktop.org/show_bug.cgi?id=41264 briefly: in the context menus (except the toolbar's ones) icons are not shown for radio menu items and for checked menu items. Rainer assigned it to me, so... :) looking at the drawing code (vcl/source/window/menu.cxx):