Re: [Libreoffice] inconsistency between rtl::OString/rtl::OUString and optimization opportunities ?

2011-09-01 Thread Caolán McNamara
On Wed, 2011-08-31 at 15:41 +0200, Stephan Bergmann wrote: On Aug 31, 2011, at 12:04 PM, Caolán McNamara wrote: ... I'm vaguely thinking of ... i18nutil x_rtl stuff ... hard-coding its refcount argument to 0 or 1 and fixing up its uses to consistently use one or the other public OUString

[Libreoffice] inconsistency between rtl::OString/rtl::OUString and optimization opportunities ?

2011-08-31 Thread Caolán McNamara
So, playing around with the sal string classes I see that... rtl_string_new_WithLength/rtl_uString_new_WithLength create an rtl/String/rtl_uString of the given length, but set the full buffer contents to 0s[1] meanwhile I see that we have x_rtl_uString_new_WithLength in

Re: [Libreoffice] inconsistency between rtl::OString/rtl::OUString and optimization opportunities ?

2011-08-31 Thread Stephan Bergmann
On Aug 31, 2011, at 12:04 PM, Caolán McNamara wrote: rtl_string_new_WithLength/rtl_uString_new_WithLength create an rtl/String/rtl_uString of the given length, but set the full buffer contents to 0s[1] No idea whether specifying that the values of all characters are set to 0 was meant to be