Re: [Libreoffice] minor idl fixes

2012-04-20 Thread Stephan Bergmann
On 04/20/2012 12:42 AM, Tomas Hlavaty wrote: 1) Exceptions have message and context fields and there should be a constructor with arguments (java.lang.String m, java.lang.Object c) for those fields. However, this doesn't seem to be applied consistently. Where is this not applied

[Libreoffice] minor idl fixes

2012-04-19 Thread Tomas Hlavaty
Hi all, bellow are some patches fixing minor issues with idl files. Also I would like to ask: 1) Exceptions have message and context fields and there should be a constructor with arguments (java.lang.String m, java.lang.Object c) for those fields. However, this doesn't seem to be applied

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Stephan Bergmann
On 01/04/2012 11:09 PM, Tomas Hlavaty wrote: diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl b/offapi/com/sun/star/chart/XAxisSupplier.idl index f87d245..cfb42b6 100644 --- a/offapi/com/sun/star/chart/XAxisSupplier.idl +++ b/offapi/com/sun/star/chart/XAxisSupplier.idl @@ -27,7 +27,7

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Tomas Hlavaty
Hi Stephan, Stephan Bergmann sberg...@redhat.com writes: On 01/04/2012 11:09 PM, Tomas Hlavaty wrote: diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl b/offapi/com/sun/star/chart/XAxisSupplier.idl ... Are you sure that this is right, using chart2 entities from within chart? I

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Stephan Bergmann
On 01/05/2012 09:38 AM, Tomas Hlavaty wrote: Stephan Bergmannsberg...@redhat.com writes: On 01/04/2012 11:09 PM, Tomas Hlavaty wrote: diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl b/offapi/com/sun/star/chart/XAxisSupplier.idl ... Are you sure that this is right, using chart2

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Michael Meeks
Hi Tomas, On Wed, 2012-01-04 at 23:09 +0100, Tomas Hlavaty wrote: sorry for inconvenience, I have sent the License statement email to the mailing list so please feel free to reapply the patch. Thanks ! - I pushed it to master; it also seems to be in the 3.5 branch, so hopefully it

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Michael Stahl
On 05/01/12 09:38, Tomas Hlavaty wrote: Hi Stephan, Stephan Bergmann sberg...@redhat.com writes: On 01/04/2012 11:09 PM, Tomas Hlavaty wrote: diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl b/offapi/com/sun/star/chart/XAxisSupplier.idl ... Are you sure that this is right,

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Tomas Hlavaty
Hi Stephan, Stephan Bergmann sberg...@redhat.com writes: On 01/05/2012 09:38 AM, Tomas Hlavaty wrote: Stephan Bergmannsberg...@redhat.com writes: On 01/04/2012 11:09 PM, Tomas Hlavaty wrote: diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl What exactly is broken? as Michael Stahl

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Tomas Hlavaty
Hi Michael, Michael Meeks michael.me...@suse.com writes: Thanks ! - I pushed it to master; it also seems to be in the 3.5 branch, so hopefully it should be there too for you in the release :-) Thank you! Tomas ___ LibreOffice mailing list

Re: [Libreoffice] minor idl fixes

2012-01-04 Thread Tomas Hlavaty
Hi Michael, Until then I'll reverting the patch, in case I forget later; we wouldn't like to accidentally license your code against your wishes. sorry for inconvenience, I have sent the License statement email to the mailing list so please feel free to reapply the patch. Also, I attach a few

Re: [Libreoffice] minor idl fixes

2011-12-13 Thread Stephan Bergmann
On 12/13/2011 01:21 AM, Tomas Hlavaty wrote: Stephan Bergmannsberg...@redhat.com writes: At runtime, the C++ UNO binding queries the types.rdb for certain data (e.g., when (un-)packing data as ANY). OK. Does it need to go through the rdb file? It could as well be already compiled into a

Re: [Libreoffice] minor idl fixes

2011-12-13 Thread Michael Meeks
Hi Tomas, On Tue, 2011-12-13 at 00:52 +0100, Tomas Hlavaty wrote: that they are tiny, What does tiny mean? Well - you're going to find it hard to make it bigger than the existing rdb files ;-) but by tiny I really mean fast to read from disk and fast to parse. Currently, rdb files

Re: [Libreoffice] minor idl fixes

2011-12-13 Thread Stephan Bergmann
On 12/13/2011 11:15 AM, Michael Meeks wrote: On Tue, 2011-12-13 at 00:52 +0100, Tomas Hlavaty wrote: If 200ms is slow, we could split the allpp,idl file into something smaller required at startup and the rest loaded lazily. Possibly; or we could invent yet another format for this type

Re: [Libreoffice] minor idl fixes

2011-12-12 Thread Michael Meeks
Hi Thomas, On Sat, 2011-12-10 at 14:57 +0100, Tomas Hlavaty wrote: I would be happy with LGPLv3+ but I haven't found much on why was MPL added and/or preffered for new contributions. Could you please point me to some discussions so I can make up my mind on this matter? Sure; so - the

Re: [Libreoffice] minor idl fixes

2011-12-12 Thread Stephan Bergmann
On 12/10/2011 02:57 PM, Tomas Hlavaty wrote: There seems to be agreement that the RDB type database should go away. There are several LO projects that would be affected by this and they seem rather complex with dependencies. Also, for example the conversion from uno idl to java and cli goes

Re: [Libreoffice] minor idl fixes

2011-12-12 Thread Tomas Hlavaty
Hi Michael, This would allow us to get rid of the RDB files (although I need to familiarise myself with current use-cases to understand the impact of such change, e.g. merging in custom plugins). So, there are rather a number of hidden criteria for RDB files: that they are tiny,

Re: [Libreoffice] minor idl fixes

2011-12-12 Thread Tomas Hlavaty
Hi Stephan, Stephan Bergmann sberg...@redhat.com writes: Historically, the situation is as follows: thanks a lot! At runtime, the C++ UNO binding queries the types.rdb for certain data (e.g., when (un-)packing data as ANY). OK. Does it need to go through the rdb file? It could as well be

Re: [Libreoffice] minor idl fixes

2011-12-10 Thread Tomas Hlavaty
Hi Michael, Nice work - thanks :-) It'd be great if you could give an explicit licensing statement for your contributions; something like: All my contributions to LibreOffice are licensed under the MPL/LGPLv3+ dual license or somesuch :-) then we can add you to:

Re: [Libreoffice] minor idl fixes

2011-12-07 Thread Michael Meeks
Hi Thomas, On Wed, 2011-12-07 at 00:02 +0100, Tomas Hlavaty wrote: attached is a patch to fix some broken IDL files. Nice work - thanks :-) It'd be great if you could give an explicit licensing statement for your contributions; something like: All my contributions to

[Libreoffice] minor idl fixes

2011-12-06 Thread Tomas Hlavaty
Hi all, attached is a patch to fix some broken IDL files. Thank you, Tomas From d66bf0eea556f71b25c526e7916d7aaea739c8a8 Mon Sep 17 00:00:00 2001 From: Tomas Hlavaty t...@logand.com Date: Tue, 6 Dec 2011 23:52:56 +0100 Subject: [PATCH] minor idl fixes ---