[Libreoffice-commits] core.git: 2 commits - cui/source helpcompiler/source

[Caolán McNamara (via logerrit)]

 cui/source/dialogs/scriptdlg.cxx   |    3 +--
 helpcompiler/source/HelpLinker.cxx |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit de788d603dd763ed3c69a4e0fea98a571301c0ca
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Dec 3 19:47:18 2023 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Dec 4 10:47:55 2023 +0100

    cid#1546483 COPY_INSTEAD_OF_MOVE
    
    Change-Id: I41c2d42e64d25c7333f66b21bf294862bb04483a
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160275
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index 2c2e40a8e708..890034317c2a 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -1030,8 +1030,7 @@ void SvxScriptOrgDialog::StoreCurrentSelection()
             aDescription = ";" + aDescription;
     }
     while (bEntry);
-    OUString sDesc( aDescription );
-    m_lastSelection[ m_sLanguage ] = sDesc;
+    m_lastSelection[m_sLanguage] = aDescription;
 }
 
 void SvxScriptOrgDialog::RestorePreviousSelection()
commit 7f713779949a2d971da3f1c327429cdd3cbe2a95
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Dec 3 19:46:33 2023 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Mon Dec 4 10:47:42 2023 +0100

    cid#1546485 COPY_INSTEAD_OF_MOVE
    
    Change-Id: Id8ef4ab026e00a34f4ac2280becef35faa98a0e1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160274
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/helpcompiler/source/HelpLinker.cxx 
b/helpcompiler/source/HelpLinker.cxx
index 898a8b26392a..f585a4d33d6a 100644
--- a/helpcompiler/source/HelpLinker.cxx
+++ b/helpcompiler/source/HelpLinker.cxx
@@ -826,8 +826,7 @@ static void StructuredXMLErrorFunction(SAL_UNUSED_PARAMETER 
void *, xmlErrorPtr
     if( error->file != nullptr )
         aXMLParsingFile = error->file;
     int nXMLParsingLine = error->line;
-    HelpProcessingException* pException = new HelpProcessingException( 
aErrorMsg, aXMLParsingFile, nXMLParsingLine );
-    GpXMLParsingException = pException;
+    GpXMLParsingException = new HelpProcessingException( aErrorMsg, 
aXMLParsingFile, nXMLParsingLine );
 
     // Reset error handler
     xmlSetStructuredErrorFunc( nullptr, nullptr );