framework/source/uiconfiguration/moduleuicfgsupplier.cxx | 6 -
framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx | 4
framework/source/uiconfiguration/uiconfigurationmanager.cxx | 4
offapi/UnoApi_offapi.mk | 2
offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl | 2
offapi/com/sun/star/ui/UIConfigurationManager.idl | 2
offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl | 8 +
offapi/com/sun/star/ui/XModuleUIConfigurationManager3.idl | 41
----------
offapi/com/sun/star/ui/XUIConfigurationManager2.idl | 8 +
offapi/com/sun/star/ui/XUIConfigurationManager3.idl | 39
---------
svtools/source/misc/acceleratorexecute.cxx | 6 -
11 files changed, 28 insertions(+), 94 deletions(-)
New commits:
commit 98a87f015800cd2e81e43732d7effe723b61e02a
Author: Miklos Vajna <vmik...@collabora.com>
AuthorDate: Thu May 25 08:15:10 2023 +0200
Commit: Miklos Vajna <vmik...@collabora.com>
CommitDate: Thu May 25 10:35:41 2023 +0200
[API CHANGE] remove XModuleUIConfigurationManager3 and
XUIConfigurationManager3
The motivation was to not modify XModuleUIConfigurationManager /
XUIConfigurationManager, but as pointed out at
<https://gerrit.libreoffice.org/c/core/+/151798/10#message-31d00a775989b981a5f50639623cc773d6ea930d>,
it may be fine to modify XModuleUIConfigurationManager2 and
XUIConfigurationManager2 instead of adding
XModuleUIConfigurationManager3 and XUIConfigurationManager3.
Indeed, searching for usage in <https://github.com/libreoffice/wollmux>,
only the published interfaces are used, so let's fold
XModuleUIConfigurationManager3 into XModuleUIConfigurationManager2 and
XUIConfigurationManager3 into XUIConfigurationManager2.
This is a reasonable middle ground between 0 API change and breaking
known users of the public API.
Change-Id: I2dedee7e255f9dda9c9057961e6c829f83b2b709
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152254
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmik...@collabora.com>
diff --git a/framework/source/uiconfiguration/moduleuicfgsupplier.cxx
b/framework/source/uiconfiguration/moduleuicfgsupplier.cxx
index f127c81d7fb9..cdbd647c3108 100644
--- a/framework/source/uiconfiguration/moduleuicfgsupplier.cxx
+++ b/framework/source/uiconfiguration/moduleuicfgsupplier.cxx
@@ -28,7 +28,7 @@
#include <com/sun/star/lang/XServiceInfo.hpp>
#include <com/sun/star/ui/XModuleUIConfigurationManagerSupplier.hpp>
#include <com/sun/star/ui/XUIConfigurationManager.hpp>
-#include <com/sun/star/ui/XModuleUIConfigurationManager3.hpp>
+#include <com/sun/star/ui/XModuleUIConfigurationManager2.hpp>
#include <com/sun/star/frame/XModuleManager2.hpp>
#include <comphelper/compbase.hxx>
@@ -80,7 +80,7 @@ public:
private:
virtual void disposing(std::unique_lock<std::mutex>&) final override;
- typedef std::unordered_map< OUString, css::uno::Reference<
css::ui::XModuleUIConfigurationManager3 > > ModuleToModuleCfgMgr;
+ typedef std::unordered_map< OUString, css::uno::Reference<
css::ui::XModuleUIConfigurationManager2 > > ModuleToModuleCfgMgr;
//TODO_AS void impl_initStorages();
@@ -99,7 +99,7 @@
ModuleUIConfigurationManagerSupplier::ModuleUIConfigurationManagerSupplier( cons
Reference< XNameAccess > xNameAccess( m_xModuleMgr, UNO_QUERY_THROW );
const Sequence< OUString > aNameSeq =
xNameAccess->getElementNames();
for ( const OUString& rName : aNameSeq )
- m_aModuleToModuleUICfgMgrMap.emplace( rName, Reference<
XModuleUIConfigurationManager3 >() );
+ m_aModuleToModuleUICfgMgrMap.emplace( rName, Reference<
XModuleUIConfigurationManager2 >() );
}
catch(...)
{
diff --git a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
index dfa73e9bd39a..7427cd925956 100644
--- a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
+++ b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
@@ -30,7 +30,7 @@
#include <com/sun/star/ui/UIElementType.hpp>
#include <com/sun/star/ui/ConfigurationEvent.hpp>
#include <com/sun/star/ui/ModuleAcceleratorConfiguration.hpp>
-#include <com/sun/star/ui/XModuleUIConfigurationManager3.hpp>
+#include <com/sun/star/ui/XModuleUIConfigurationManager2.hpp>
#include <com/sun/star/lang/DisposedException.hpp>
#include <com/sun/star/lang/IllegalAccessException.hpp>
#include <com/sun/star/lang/WrappedTargetRuntimeException.hpp>
@@ -83,7 +83,7 @@ namespace {
class ModuleUIConfigurationManager : public cppu::WeakImplHelper<
css::lang::XServiceInfo,
css::lang::XComponent,
- css::ui::XModuleUIConfigurationManager3
>
+ css::ui::XModuleUIConfigurationManager2
>
{
public:
ModuleUIConfigurationManager(
diff --git a/framework/source/uiconfiguration/uiconfigurationmanager.cxx
b/framework/source/uiconfiguration/uiconfigurationmanager.cxx
index c3e2bc7ca9e1..0140d17866d1 100644
--- a/framework/source/uiconfiguration/uiconfigurationmanager.cxx
+++ b/framework/source/uiconfiguration/uiconfigurationmanager.cxx
@@ -40,7 +40,7 @@
#include <com/sun/star/ui/ConfigurationEvent.hpp>
#include <com/sun/star/ui/DocumentAcceleratorConfiguration.hpp>
#include <com/sun/star/ui/XAcceleratorConfiguration.hpp>
-#include <com/sun/star/ui/XUIConfigurationManager3.hpp>
+#include <com/sun/star/ui/XUIConfigurationManager2.hpp>
#include <com/sun/star/lang/XComponent.hpp>
#include <com/sun/star/lang/XServiceInfo.hpp>
@@ -73,7 +73,7 @@ namespace {
class UIConfigurationManager : public ::cppu::WeakImplHelper<
css::lang::XServiceInfo ,
- css::ui::XUIConfigurationManager3 >
+ css::ui::XUIConfigurationManager2 >
{
public:
virtual OUString SAL_CALL getImplementationName() override
diff --git a/offapi/UnoApi_offapi.mk b/offapi/UnoApi_offapi.mk
index 4a42279b2c54..7ee71bb984c1 100644
--- a/offapi/UnoApi_offapi.mk
+++ b/offapi/UnoApi_offapi.mk
@@ -4058,7 +4058,6 @@ $(eval $(call
gb_UnoApi_add_idlfiles,offapi,com/sun/star/ui,\
XImageManager \
XModuleUIConfigurationManager \
XModuleUIConfigurationManager2 \
- XModuleUIConfigurationManager3 \
XModuleUIConfigurationManagerSupplier \
XPanel \
XPanels \
@@ -4071,7 +4070,6 @@ $(eval $(call
gb_UnoApi_add_idlfiles,offapi,com/sun/star/ui,\
XUIConfigurationListener \
XUIConfigurationManager \
XUIConfigurationManager2 \
- XUIConfigurationManager3 \
XUIConfigurationManagerSupplier \
XUIConfigurationPersistence \
XUIConfigurationStorage \
diff --git a/offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl
b/offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl
index 56fd37bcbfef..6fe18b254fc6 100644
--- a/offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl
+++ b/offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl
@@ -36,7 +36,7 @@ module com { module sun { module star { module ui {
@since OOo 2.0
*/
-service ModuleUIConfigurationManager : XModuleUIConfigurationManager3
+service ModuleUIConfigurationManager : XModuleUIConfigurationManager2
{
/** provides a function to initialize a module user interface
configuration manager instance.
diff --git a/offapi/com/sun/star/ui/UIConfigurationManager.idl
b/offapi/com/sun/star/ui/UIConfigurationManager.idl
index c0ae1683f106..bff584dcdb83 100644
--- a/offapi/com/sun/star/ui/UIConfigurationManager.idl
+++ b/offapi/com/sun/star/ui/UIConfigurationManager.idl
@@ -25,7 +25,7 @@ module com { module sun { module star { module ui {
@since OOo 2.0
*/
-service UIConfigurationManager : XUIConfigurationManager3;
+service UIConfigurationManager : XUIConfigurationManager2;
}; }; }; };
diff --git a/offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl
b/offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl
index 301304aa4901..c97c05738e09 100644
--- a/offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl
+++ b/offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl
@@ -45,6 +45,14 @@ interface XModuleUIConfigurationManager2
interface configuration manager.
*/
interface com::sun::star::ui::XUIConfiguration;
+
+ /**
+ Creates a new configuration manager in case there are different views
with different languages.
+ This function enables those views to have short cut keys specific to
the languages.
+
+ @since LibreOffice 7.6
+ */
+ com::sun::star::ui::XAcceleratorConfiguration createShortCutManager();
};
diff --git a/offapi/com/sun/star/ui/XModuleUIConfigurationManager3.idl
b/offapi/com/sun/star/ui/XModuleUIConfigurationManager3.idl
deleted file mode 100644
index 494de200b2e9..000000000000
--- a/offapi/com/sun/star/ui/XModuleUIConfigurationManager3.idl
+++ /dev/null
@@ -1,41 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-module com { module sun { module star { module ui {
-
-/**
- Provides a unified interface for the ModuleUIConfigurationManager service.
-
- @since LibreOffice 7.6
-*/
-interface XModuleUIConfigurationManager3
-{
- interface com::sun::star::ui::XModuleUIConfigurationManager2;
-
- /**
- Creates a new configuration manager in case there are different views
with different languages.
- This function enables those views to have short cut keys specific to
the languages.
- */
- com::sun::star::ui::XAcceleratorConfiguration createShortCutManager();
-};
-
-
-}; }; }; };
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/offapi/com/sun/star/ui/XUIConfigurationManager2.idl
b/offapi/com/sun/star/ui/XUIConfigurationManager2.idl
index fd165b3422be..f9bcf8c57d5f 100644
--- a/offapi/com/sun/star/ui/XUIConfigurationManager2.idl
+++ b/offapi/com/sun/star/ui/XUIConfigurationManager2.idl
@@ -52,6 +52,14 @@ interface XUIConfigurationManager2
</p>
*/
interface ::com::sun::star::lang::XComponent;
+
+ /**
+ Creates a new configuration manager in case there are different views
with different languages.
+ This function enables those views to have short cut keys specific to
the languages.
+
+ @since LibreOffice 7.6
+ */
+ com::sun::star::ui::XAcceleratorConfiguration createShortCutManager();
};
diff --git a/offapi/com/sun/star/ui/XUIConfigurationManager3.idl
b/offapi/com/sun/star/ui/XUIConfigurationManager3.idl
deleted file mode 100644
index 73652fc6c8ef..000000000000
--- a/offapi/com/sun/star/ui/XUIConfigurationManager3.idl
+++ /dev/null
@@ -1,39 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-module com { module sun { module star { module ui {
-
-/**
- @since LibreOffice 7.6
-*/
-interface XUIConfigurationManager3
-{
- interface com::sun::star::ui::XUIConfigurationManager2;
-
- /**
- Creates a new configuration manager in case there are different views
with different languages.
- This function enables those views to have short cut keys specific to
the languages.
- */
- com::sun::star::ui::XAcceleratorConfiguration createShortCutManager();
-};
-
-
-}; }; }; };
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svtools/source/misc/acceleratorexecute.cxx
b/svtools/source/misc/acceleratorexecute.cxx
index 134db44efc1d..70e1bc6c6b8a 100644
--- a/svtools/source/misc/acceleratorexecute.cxx
+++ b/svtools/source/misc/acceleratorexecute.cxx
@@ -24,8 +24,8 @@
#include <com/sun/star/frame/Desktop.hpp>
#include <com/sun/star/ui/GlobalAcceleratorConfiguration.hpp>
#include <com/sun/star/ui/XUIConfigurationManager.hpp>
-#include <com/sun/star/ui/XUIConfigurationManager3.hpp>
-#include <com/sun/star/ui/XModuleUIConfigurationManager3.hpp>
+#include <com/sun/star/ui/XUIConfigurationManager2.hpp>
+#include <com/sun/star/ui/XModuleUIConfigurationManager2.hpp>
#include <com/sun/star/ui/theModuleUIConfigurationManagerSupplier.hpp>
#include <com/sun/star/ui/XUIConfigurationManagerSupplier.hpp>
#include <com/sun/star/awt/KeyModifier.hpp>
@@ -418,7 +418,7 @@ css::uno::Reference<css::ui::XAcceleratorConfiguration>
AcceleratorExecute::lok_
{
css::uno::Reference<css::ui::XUIConfigurationManager> xUIManager =
xUISupplier->getUIConfigurationManager(sModule);
- css::ui::XModuleUIConfigurationManager3* t =
static_cast<css::ui::XModuleUIConfigurationManager3*>(xUIManager.get());
+ css::ui::XModuleUIConfigurationManager2* t =
static_cast<css::ui::XModuleUIConfigurationManager2*>(xUIManager.get());
// Return new short cut manager in case current view's language is
different from previous ones.
return t->createShortCutManager();
