Re: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine

2016-11-28 Thread Stephan Bergmann
On 11/04/2016 03:09 PM, Khaled Hosny wrote: It can be dropped just after 5.3 is branched off. seen done with "Revert 'tdf#89870: Add config option for layout engine'"; thanks

Re: Cleaning up configuration (was: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine)

2016-11-04 Thread Khaled Hosny
On Fri, Nov 04, 2016 at 12:12:21PM +0100, Stephan Bergmann wrote: > On 11/04/2016 11:20 AM, Tor Lillqvist wrote: > > Also, would going through officecfg and looking for deprecated and > > actually no-op configuration thingies be a good Easy Hack? > > At least in principle, the tree of available

Re: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine

2016-11-04 Thread Khaled Hosny
On Fri, Nov 04, 2016 at 02:51:26PM +0100, Stephan Bergmann wrote: > On 11/04/2016 01:11 PM, Khaled Hosny wrote: > > On Fri, Nov 04, 2016 at 11:12:59AM +0100, Stephan Bergmann wrote: > > > * How long will we keep supporting the old code? "Forever", or do we > > > have a > > > clear idea when to

Re: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine

2016-11-04 Thread Stephan Bergmann
On 11/04/2016 01:11 PM, Khaled Hosny wrote: On Fri, Nov 04, 2016 at 11:12:59AM +0100, Stephan Bergmann wrote: * How long will we keep supporting the old code? "Forever", or do we have a clear idea when to drop it? It should go away sometime after 5.3 is released. Would it be an issue to just

Re: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine

2016-11-04 Thread Khaled Hosny
On Fri, Nov 04, 2016 at 11:12:59AM +0100, Stephan Bergmann wrote: > On 11/03/2016 06:23 PM, Khaled Hosny wrote: > > commit 6324efd70dfa8c6be84cba1fa29658e3373cbbe3 > > Author: Khaled Hosny > > Date: Thu Nov 3 19:21:01 2016 +0200 > > > > tdf#89870: Add config option

Cleaning up configuration (was: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine)

2016-11-04 Thread Stephan Bergmann
On 11/04/2016 11:20 AM, Tor Lillqvist wrote: Also, would going through officecfg and looking for deprecated and actually no-op configuration thingies be a good Easy Hack? At least in principle, the tree of available configuration items is part of the stable interface, accessible from 3rd

Re: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine

2016-11-04 Thread Tor Lillqvist
> We shouldn't light-heartedly fill the configuration with unnecessary > entries. Agree. Or, as they would say in that other project, +1. Also, would going through officecfg and looking for deprecated and actually no-op configuration thingies be a good Easy Hack? For instance, some days ago I

Re: [Libreoffice-commits] core.git: tdf#89870: Add config option for layout engine

2016-11-04 Thread Stephan Bergmann
On 11/03/2016 06:23 PM, Khaled Hosny wrote: commit 6324efd70dfa8c6be84cba1fa29658e3373cbbe3 Author: Khaled Hosny Date: Thu Nov 3 19:21:01 2016 +0200 tdf#89870: Add config option for layout engine The env variable takes precedence. Do we really need this?