On Wed, 2012-05-30 at 21:29 +0200, Philipp Riemer wrote:
Hmm... I have to admit that Tor's last mail bothered me. Thus, I spent
my evening at home in front of the PC fixing/ re-applying the changes
after fetching the newest files. The results of my work are in the
three patches attached to
Hi Tor,
On Wednesday, 2012-05-30 23:49:48 +0300, Tor Lillqvist wrote:
Thanks! Pushed all three. I onlychanged the commit comments to be in
present tense, as I think is better. (Instead of cleaned up
comments, Clean up comments.)
I think that past tense actually makes more sense, given that
Hi Eike,
On Thu, May 31, 2012 at 05:18:53PM +0200, Eike Rathke er...@redhat.com wrote:
Thanks! Pushed all three. I onlychanged the commit comments to be in
present tense, as I think is better. (Instead of cleaned up
comments, Clean up comments.)
I think that past tense actually makes
Thanks. I pushed the first one, but the second one did not apply,
severa patch hunks failed. Could you please check that?
Probably your source code is out of sync and you need to do a git
pull. You might run into merge conflicts when you do that because of
slight changes needed to your patch(es)
Thank you. I will try that tomorrow and than re-send the patch.
Philipp
2012/5/30 Tor Lillqvist t...@iki.fi:
Thanks. I pushed the first one, but the second one did not apply,
severa patch hunks failed. Could you please check that?
Probably your source code is out of sync and you need to do a
Thanks! Pushed all three. I onlychanged the commit comments to be in
present tense, as I think is better. (Instead of cleaned up
comments, Clean up comments.)
BTW, please start a new thread for each message with one or several
patches attached. Otherwise our convention of finalizing the thread
Thank you very much! Pushed. Welcome as a LibreOffice contributor!
A couple of minor requests for you future patches: Please do combine
changes to several files into one patch, easier to handle them that
way... For translation patches, something like half a dozen files per
patch perhaps is ideal?
