Re: [PATCH] Fix for Bug 43895: Never let users save in /tmp by default

2012-03-26 Thread Kohei Yoshida
On Mon, 2012-03-19 at 00:17 +, Andrzej J. R. Hunt wrote: Hi, Here is a my first attempt at a patch, fixing Bug 43895 (Never let users save in /tmp by default). I was debating adding a warning for anyone saving to /tmp, however I doubt anyone would do this accidentally except in the

Re: [PATCH] Fix for Bug 43895: Never let users save in /tmp by default

2012-03-26 Thread Stephan Bergmann
Just looking at the below function itself (so no idea about the larger context), I noted a few things: On 03/19/2012 01:17 AM, Andrzej J. R. Hunt wrote: +void FileDialogHelper_Impl::verifyPath() +{ +struct stat aFileStat; +const char* pFullPath = OUStringToOString( ( maPath.copy(7) +

Re: [PATCH] Fix for Bug 43895: Never let users save in /tmp by default

2012-03-26 Thread Bjoern Michaelsen
On Mon, Mar 26, 2012 at 10:28:09AM -0400, Kohei Yoshida wrote: The owner of this easy hack appears to be Bjoern. I'm CC'ing him to get his attention. Got it, checking back with original reporter at lp#905355. Best, Bjoern ___ LibreOffice mailing

[PATCH] Fix for Bug 43895: Never let users save in /tmp by default

2012-03-18 Thread Andrzej J. R. Hunt
Hi, Here is a my first attempt at a patch, fixing Bug 43895 (Never let users save in /tmp by default). I was debating adding a warning for anyone saving to /tmp, however I doubt anyone would do this accidentally except in the case of downloading through firefox, which is now fixed.