Hi Tor,
I looked at the miscopt.*xx. When searching for other alike classes I
did find several, for example:
- /core/unotools/source/config/misccfg.cxx
- /core/unotools/source/config/printwarningoptions.cxx
- /core/svtools/source/config/optionsdrawinglayer.cxx
-
I am sorry but I still have some critique of the patch... Please don't
take this too harshly.
Is this use of IsDisposing state variable really necessary? Or is
that band-aid protection against some bug (mismanagement of
dynamically allocated objects) elsewhere?
The use of the GetPropertyNames()
Rob pointed out to me that much of his additions is in fact based on
existing code, svtools/inc/svtools/miscopt.hxx etc. Which uses a
similar oddly phrased comments, weird _Impl class with reference
counting that is not a Pimpl, and other potential signs of
micro-optimization for dubious gain. So
Hi,
I have changed a lot of the things Tor wrote about in the earlier email.
Except the issue below and the issue about IsDisposing.
I also saw another little bug in the patch and solved that.
--
Greetings,
Rob Snelders
Op 28-05-12 16:55, Tor Lillqvist schreef:
Rob pointed out to me that
On Mon, 2012-05-28 at 17:55 +0300, Tor Lillqvist wrote:
Rob pointed out to me that much of his additions is in fact based on
existing code, svtools/inc/svtools/miscopt.hxx etc.
In which case the original LGPL licensing header sounds correct.
Which uses a similar oddly phrased
A hard one; I'd not hold a volunteer's feature up for a cleanup, but
clearly having the code made beautiful is in the end a good goal OTOH -
this is some UNO using code so - our ability to make it succinct and
sweet is somewhat constrained anyway - cf. the property verbosity.
Sure, but
It will take a while for me to digest and approve the patch (others
are welcome to do it quicker, of course), but just a few stylistic
questions at a start:
- You use the old Oracle LGPL-only header in a couple of new files the
patch introduces. Is this because the files in question are largely
Hi Tor,
I have updated the license/header, I forgot to change them when I copied
them from the miscopt-class. Also removed some comments with especially
the art, seems usefull to me.
--
Greetings,
Rob Snelders
Op 25-05-12 12:39, Tor Lillqvist schreef:
It will take a while for me to digest
Hi All,
This patch makes the SlideSorter-toolbar in Impress and Draw remember if
it was visible or not for each view.
When this patch is accepted then I'll create a similar patch for the
ToolPanel-toolbar.
--
Greetings,
Rob Snelders
From d0152a068a92019131032a03bf39f00fb2fc7bf5 Mon Sep 17
